----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/2/ -----------------------------------------------------------
Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner.
Repository: rolekit
Description -------
Add placeholders for Domain Controller and Database roles
Diffs -----
config/Makefile.am 88f68818c877eeadf05e3c6bccea77e6693d428c config/roles/databaseserver/role.py PRE-CREATION config/roles/domaincontroller/role.py PRE-CREATION
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/2/diff/
Testing -------
Started up rolekit and examined with d-feet that the new roles were available and functioned equivalently to the testrole.
Thanks,
Stephen Gallagher
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/2/#review1 -----------------------------------------------------------
config/roles/databaseserver/role.py http://reviewboard-fedoraserver.rhcloud.com/r/2/#comment1
backup_path was in the testrole by accident before. The methods to handle backup_path and also the property is disabled at the moment. Should it just be enabled?
- Thomas Woerner
On July 14, 2014, 11:42 a.m., Stephen Gallagher wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/2/
(Updated July 14, 2014, 11:42 a.m.)
Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner.
Repository: rolekit
Description
Add placeholders for Domain Controller and Database roles
Diffs
config/Makefile.am 88f68818c877eeadf05e3c6bccea77e6693d428c config/roles/databaseserver/role.py PRE-CREATION config/roles/domaincontroller/role.py PRE-CREATION
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/2/diff/
Testing
Started up rolekit and examined with d-feet that the new roles were available and functioned equivalently to the testrole.
Thanks,
Stephen Gallagher
On July 14, 2014, 1:24 p.m., Thomas Woerner wrote:
config/roles/databaseserver/role.py, line 38 http://reviewboard-fedoraserver.rhcloud.com/r/2/diff/1/?file=39#file39line38
backup_path was in the testrole by accident before. The methods to handle backup_path and also the property is disabled at the moment. Should it just be enabled?
No, we're not likely to have it implemented properly in time for F21. I'll remove this.
- Stephen
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/2/#review1 -----------------------------------------------------------
On July 14, 2014, 11:42 a.m., Stephen Gallagher wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/2/
(Updated July 14, 2014, 11:42 a.m.)
Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner.
Repository: rolekit
Description
Add placeholders for Domain Controller and Database roles
Diffs
config/Makefile.am 88f68818c877eeadf05e3c6bccea77e6693d428c config/roles/databaseserver/role.py PRE-CREATION config/roles/domaincontroller/role.py PRE-CREATION
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/2/diff/
Testing
Started up rolekit and examined with d-feet that the new roles were available and functioned equivalently to the testrole.
Thanks,
Stephen Gallagher
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/2/#review2 -----------------------------------------------------------
config/roles/databaseserver/role.py http://reviewboard-fedoraserver.rhcloud.com/r/2/#comment2
Maybe it would be good to also have get_dbus_property in the roles for now with the comments to make the use of additional properties simple.
- Thomas Woerner
On July 14, 2014, 11:42 a.m., Stephen Gallagher wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/2/
(Updated July 14, 2014, 11:42 a.m.)
Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner.
Repository: rolekit
Description
Add placeholders for Domain Controller and Database roles
Diffs
config/Makefile.am 88f68818c877eeadf05e3c6bccea77e6693d428c config/roles/databaseserver/role.py PRE-CREATION config/roles/domaincontroller/role.py PRE-CREATION
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/2/diff/
Testing
Started up rolekit and examined with d-feet that the new roles were available and functioned equivalently to the testrole.
Thanks,
Stephen Gallagher
On July 14, 2014, 1:26 p.m., Thomas Woerner wrote:
config/roles/databaseserver/role.py, line 65 http://reviewboard-fedoraserver.rhcloud.com/r/2/diff/1/?file=39#file39line65
Maybe it would be good to also have get_dbus_property in the roles for now with the comments to make the use of additional properties simple.
Sorry, could you give an example of what you mean? I'm not sure what properties have to do with decomission()
- Stephen
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/2/#review2 -----------------------------------------------------------
On July 14, 2014, 11:42 a.m., Stephen Gallagher wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/2/
(Updated July 14, 2014, 11:42 a.m.)
Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner.
Repository: rolekit
Description
Add placeholders for Domain Controller and Database roles
Diffs
config/Makefile.am 88f68818c877eeadf05e3c6bccea77e6693d428c config/roles/databaseserver/role.py PRE-CREATION config/roles/domaincontroller/role.py PRE-CREATION
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/2/diff/
Testing
Started up rolekit and examined with d-feet that the new roles were available and functioned equivalently to the testrole.
Thanks,
Stephen Gallagher
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/2/ -----------------------------------------------------------
(Updated July 14, 2014, 3:34 p.m.)
Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner.
Changes -------
Updated the copied testrole. It was accidentally copied from an old version.
Repository: rolekit
Description -------
Add placeholders for Domain Controller and Database roles
Diffs (updated) -----
config/Makefile.am 88f68818c877eeadf05e3c6bccea77e6693d428c config/roles/databaseserver/role.py PRE-CREATION config/roles/domaincontroller/role.py PRE-CREATION
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/2/diff/
Testing -------
Started up rolekit and examined with d-feet that the new roles were available and functioned equivalently to the testrole.
Thanks,
Stephen Gallagher
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/2/#review8 -----------------------------------------------------------
Ship it!
Ship It!
- Thomas Woerner
On July 14, 2014, 3:34 p.m., Stephen Gallagher wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/2/
(Updated July 14, 2014, 3:34 p.m.)
Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner.
Repository: rolekit
Description
Add placeholders for Domain Controller and Database roles
Diffs
config/Makefile.am 88f68818c877eeadf05e3c6bccea77e6693d428c config/roles/databaseserver/role.py PRE-CREATION config/roles/domaincontroller/role.py PRE-CREATION
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/2/diff/
Testing
Started up rolekit and examined with d-feet that the new roles were available and functioned equivalently to the testrole.
Thanks,
Stephen Gallagher
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/2/ -----------------------------------------------------------
(Updated July 14, 2014, 5:32 p.m.)
Status ------
This change has been marked as submitted.
Review request for RoleKit Mailing List, Stephen Gallagher and Thomas Woerner.
Repository: rolekit
Description -------
Add placeholders for Domain Controller and Database roles
Diffs -----
config/Makefile.am 88f68818c877eeadf05e3c6bccea77e6693d428c config/roles/databaseserver/role.py PRE-CREATION config/roles/domaincontroller/role.py PRE-CREATION
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/2/diff/
Testing -------
Started up rolekit and examined with d-feet that the new roles were available and functioned equivalently to the testrole.
Thanks,
Stephen Gallagher
rolekit-commits@lists.stg.fedorahosted.org
-
Stephen Gallagher