----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/65/#review227 -----------------------------------------------------------

src/rolekit/async.py http://reviewboard-fedoraserver.rhcloud.com/r/65/#comment133

I disagree. Let's not define a convention and ignore it in the same patch, please :)

Rename this to async.call_future(), please (as discussed on #fedora-server).

- Stephen Gallagher

On Aug. 19, 2014, 12:30 p.m., Miloslav Trmac wrote:

---

This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/65/

---

(Updated Aug. 19, 2014, 12:30 p.m.)

Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.

Repository: rolekit

Description

This uses the GLib mainloop infrastructure for polling.

Also establishes a _future naming suffix for functions that return futures.

Diffs

src/rolekit/async.py 1e2b82eab5a4e6862594672f738c1935a83c2be5 tests/async_test.py 47a54ed408657e67e797d50d7c73d9a7982bcfc3

Diff: http://reviewboard-fedoraserver.rhcloud.com/r/65/diff/

Testing

Thanks,

Miloslav Trmac

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/65/ -----------------------------------------------------------

(Updated Srp. 19, 2014, 9:30 odp.)

Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.

Repository: rolekit

Description -------

This uses the GLib mainloop infrastructure for polling.

Also establishes a _future naming suffix for functions that return futures.

Diffs -----

src/rolekit/async.py 0a820c383d89fd6e8a6df22968cf7bae06228b14 tests/async_test.py 47a54ed408657e67e797d50d7c73d9a7982bcfc3

Diff: http://reviewboard-fedoraserver.rhcloud.com/r/65/diff/

Testing -------

Thanks,

Miloslav Trmac

On Srp. 19, 2014, 9:34 odp., Stephen Gallagher wrote:

...

Ship It!

https://git.fedorahosted.org/cgit/rolekit.git/commit/?id=288560d3da79e297fe2...

- Miloslav

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/65/#review232 -----------------------------------------------------------

On Srp. 19, 2014, 9:36 odp., Miloslav Trmac wrote:

---

This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/65/

---

(Updated Srp. 19, 2014, 9:36 odp.)

Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.

Repository: rolekit

Description

This uses the GLib mainloop infrastructure for polling.

Also establishes a _future naming suffix for functions that return futures.

Diffs

src/rolekit/async.py 0a820c383d89fd6e8a6df22968cf7bae06228b14 tests/async_test.py 47a54ed408657e67e797d50d7c73d9a7982bcfc3

Diff: http://reviewboard-fedoraserver.rhcloud.com/r/65/diff/

Testing

Thanks,

Miloslav Trmac