Review Request 79: rolectl (re)deploy: New option --settings-file, dropped --set option, fixed redeploy call
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/79/ -----------------------------------------------------------
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description -------
- New option --settings-file: store all settings in a json file. - Dropped --set option for --settings-file. Values like arrays or dicts have been very user unfriedly with the --set option. - The redeploy option was additionally not functional
Fixes https://fedorahosted.org/rolekit/ticket/8 Fixes https://fedorahosted.org/rolekit/ticket/9
Diffs -----
src/rolectl e686b8858e3ea3b96c82bcf6d1a16e5bd27314a6
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/79/diff/
Testing -------
Thanks,
Thomas Woerner
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/79/#review275 -----------------------------------------------------------
Ship it!
Ship It!
- Stephen Gallagher
On Sept. 10, 2014, 6:02 p.m., Thomas Woerner wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/79/
(Updated Sept. 10, 2014, 6:02 p.m.)
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
- New option --settings-file: store all settings in a json file.
- Dropped --set option for --settings-file. Values like arrays or dicts have been very user unfriedly with the --set option.
- The redeploy option was additionally not functional
Fixes https://fedorahosted.org/rolekit/ticket/8 Fixes https://fedorahosted.org/rolekit/ticket/9
Diffs
src/rolectl e686b8858e3ea3b96c82bcf6d1a16e5bd27314a6
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/79/diff/
Testing
Thanks,
Thomas Woerner
On Oct. 1, 2014, 9:06 p.m., Stephen Gallagher wrote:
Ship It!
Pushed: https://git.fedorahosted.org/cgit/rolekit.git/commit/?id=9a0d76fd1b93c764ec4...
- Thomas
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/79/#review275 -----------------------------------------------------------
On Sept. 10, 2014, 6:02 p.m., Thomas Woerner wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/79/
(Updated Sept. 10, 2014, 6:02 p.m.)
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
- New option --settings-file: store all settings in a json file.
- Dropped --set option for --settings-file. Values like arrays or dicts have been very user unfriedly with the --set option.
- The redeploy option was additionally not functional
Fixes https://fedorahosted.org/rolekit/ticket/8 Fixes https://fedorahosted.org/rolekit/ticket/9
Diffs
src/rolectl e686b8858e3ea3b96c82bcf6d1a16e5bd27314a6
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/79/diff/
Testing
Thanks,
Thomas Woerner
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/79/ -----------------------------------------------------------
(Updated Oct. 2, 2014, 1:50 p.m.)
Status ------
This change has been marked as submitted.
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description -------
- New option --settings-file: store all settings in a json file. - Dropped --set option for --settings-file. Values like arrays or dicts have been very user unfriedly with the --set option. - The redeploy option was additionally not functional
Fixes https://fedorahosted.org/rolekit/ticket/8 Fixes https://fedorahosted.org/rolekit/ticket/9
Diffs -----
src/rolectl e686b8858e3ea3b96c82bcf6d1a16e5bd27314a6
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/79/diff/
Testing -------
Thanks,
Thomas Woerner
rolekit-commits@lists.stg.fedorahosted.org
-
Stephen Gallagher