----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/107/ -----------------------------------------------------------
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description -------
With the force option it is possible to force a instance decommission even in the error case.
Diffs -----
src/rolectl ec11929bea45e60486a4d9000f0b30e66db665de src/rolekit/client.py 5b117c4fe0a4af89cfe4cdb3898b5be29ae3e7ab src/rolekit/server/rolebase.py e90414f57c896fff31f5264cb75c53f1c4be0f9e
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/107/diff/
Testing -------
Thanks,
Thomas Woerner
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/107/#review331 -----------------------------------------------------------
src/rolectl http://reviewboard-fedoraserver.rhcloud.com/r/107/#comment177
Please add this to the manpage for rolectl as well.
src/rolekit/server/rolebase.py http://reviewboard-fedoraserver.rhcloud.com/r/107/#comment178
Let's make the prototype be:
__decommission_async(self, sender, force=False)
and do the same for do_decommission_async().
There may be cases where the role plugin itself may want to do something special on a force-decommission.
- Stephen Gallagher
On Oct. 24, 2014, 12:39 p.m., Thomas Woerner wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/107/
(Updated Oct. 24, 2014, 12:39 p.m.)
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
With the force option it is possible to force a instance decommission even in the error case.
Diffs
src/rolectl ec11929bea45e60486a4d9000f0b30e66db665de src/rolekit/client.py 5b117c4fe0a4af89cfe4cdb3898b5be29ae3e7ab src/rolekit/server/rolebase.py e90414f57c896fff31f5264cb75c53f1c4be0f9e
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/107/diff/
Testing
Thanks,
Thomas Woerner
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/107/ -----------------------------------------------------------
(Updated Oct. 29, 2014, 1:01 p.m.)
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description -------
With the force option it is possible to force a instance decommission even in the error case.
Diffs (updated) -----
config/roles/databaseserver/role.py 346906b16f09474c2a51a6767a3e59df862fdb2d config/roles/domaincontroller/role.py 29777b41d56fb68541b7807adbb4e9ea4e3594bb config/roles/testrole/role.py 08ffd195c8907f88c874e2ee0a771081649bb81e doc/xml/rolectl.xml 261a263f05840cf2b864a14686999c8d1eb1f922 src/rolectl ec11929bea45e60486a4d9000f0b30e66db665de src/rolekit/client.py 5b117c4fe0a4af89cfe4cdb3898b5be29ae3e7ab src/rolekit/server/rolebase.py e90414f57c896fff31f5264cb75c53f1c4be0f9e
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/107/diff/
Testing -------
Thanks,
Thomas Woerner
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/107/#review333 -----------------------------------------------------------
Ship it!
Ship It!
- Stephen Gallagher
On Oct. 29, 2014, 1:01 p.m., Thomas Woerner wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/107/
(Updated Oct. 29, 2014, 1:01 p.m.)
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
With the force option it is possible to force a instance decommission even in the error case.
Diffs
config/roles/databaseserver/role.py 346906b16f09474c2a51a6767a3e59df862fdb2d config/roles/domaincontroller/role.py 29777b41d56fb68541b7807adbb4e9ea4e3594bb config/roles/testrole/role.py 08ffd195c8907f88c874e2ee0a771081649bb81e doc/xml/rolectl.xml 261a263f05840cf2b864a14686999c8d1eb1f922 src/rolectl ec11929bea45e60486a4d9000f0b30e66db665de src/rolekit/client.py 5b117c4fe0a4af89cfe4cdb3898b5be29ae3e7ab src/rolekit/server/rolebase.py e90414f57c896fff31f5264cb75c53f1c4be0f9e
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/107/diff/
Testing
Thanks,
Thomas Woerner
On Oct. 29, 2014, 1:08 p.m., Stephen Gallagher wrote:
Ship It!
Pushed: https://git.fedorahosted.org/cgit/rolekit.git/commit/?id=eae4e203c180a1f5f18...
- Thomas
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/107/#review333 -----------------------------------------------------------
On Oct. 29, 2014, 1:01 p.m., Thomas Woerner wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/107/
(Updated Oct. 29, 2014, 1:01 p.m.)
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description
With the force option it is possible to force a instance decommission even in the error case.
Diffs
config/roles/databaseserver/role.py 346906b16f09474c2a51a6767a3e59df862fdb2d config/roles/domaincontroller/role.py 29777b41d56fb68541b7807adbb4e9ea4e3594bb config/roles/testrole/role.py 08ffd195c8907f88c874e2ee0a771081649bb81e doc/xml/rolectl.xml 261a263f05840cf2b864a14686999c8d1eb1f922 src/rolectl ec11929bea45e60486a4d9000f0b30e66db665de src/rolekit/client.py 5b117c4fe0a4af89cfe4cdb3898b5be29ae3e7ab src/rolekit/server/rolebase.py e90414f57c896fff31f5264cb75c53f1c4be0f9e
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/107/diff/
Testing
Thanks,
Thomas Woerner
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-fedoraserver.rhcloud.com/r/107/ -----------------------------------------------------------
(Updated Oct. 29, 2014, 2:34 p.m.)
Status ------
This change has been marked as submitted.
Review request for RoleKit Mailing List, Miloslav Trmac, Stephen Gallagher, and Thomas Woerner.
Repository: rolekit
Description -------
With the force option it is possible to force a instance decommission even in the error case.
Diffs -----
config/roles/databaseserver/role.py 346906b16f09474c2a51a6767a3e59df862fdb2d config/roles/domaincontroller/role.py 29777b41d56fb68541b7807adbb4e9ea4e3594bb config/roles/testrole/role.py 08ffd195c8907f88c874e2ee0a771081649bb81e doc/xml/rolectl.xml 261a263f05840cf2b864a14686999c8d1eb1f922 src/rolectl ec11929bea45e60486a4d9000f0b30e66db665de src/rolekit/client.py 5b117c4fe0a4af89cfe4cdb3898b5be29ae3e7ab src/rolekit/server/rolebase.py e90414f57c896fff31f5264cb75c53f1c4be0f9e
Diff: http://reviewboard-fedoraserver.rhcloud.com/r/107/diff/
Testing -------
Thanks,
Thomas Woerner
rolekit-commits@lists.stg.fedorahosted.org
-
Stephen Gallagher