--------------------------------------------------------------------- Fedora Test Update Notification FEDORA-2004-058 2004-01-30 ---------------------------------------------------------------------
Name : mc Version : 4.6.0 Release : 8.3 Summary : User-friendly text console file manager and visual shell. Description : Midnight Commander is a visual shell much like a file manager, only with many more features. It is a text mode application, but it also includes mouse support if you are running GPM. Midnight Commander's best features are its ability to FTP, view tar and zip files, and to poke into RPMs for specific files.
--------------------------------------------------------------------- Update Information:
This is an update to the previous testing update, 4.6.0-8.1. New changes listed below. --------------------------------------------------------------------- * Fri Jan 30 2004 Jakub Jelinek jakub@redhat.com 4.6.0-8.3
- update php.syntax file (#112645) - fix crash with large syntax file (#112644)
--------------------------------------------------------------------- This update can be downloaded from: http://download.fedora.redhat.com/pub/fedora/linux/core/updates/testing/1/
69692aaa0d1eb263a2a8625ad5bdaac1 SRPMS/mc-4.6.0-8.3.src.rpm 60ebb4dd088eeee193c9259998136c6f i386/mc-4.6.0-8.3.i386.rpm 0c27127b10ee9cb0c99a07f3f54f7845 i386/debug/mc-debuginfo-4.6.0-8.3.i386.rpm
This update can also be installed with the Update Agent; you can launch the Update Agent with the 'up2date' command. You may need to edit your up2date channels configuration. Within /etc/sysconfig/rhn/sources enable the following line: yum updates-testing http://fedora.redhat.com/updates/testing/fedora-core-1 ---------------------------------------------------------------------
Hello Bill, Jakub,
This is an update to the previous testing update, 4.6.0-8.1. New changes listed below.
Note that 8.1 is a SECURITY fix but was never announced. You should upgrade to 8.1!
- update php.syntax file (#112645)
- fix crash with large syntax file (#112644)
I am very glad you included the php.syntax file, but the patch I uploaded for #112644 is buggy, as I found out and stated in that bug report.
When running this version (8.3) I do still see a segfault when editing php files.
Although just increasing MAX_WORDS_PER_CONTEXT to 4096 doesn't really solve the cause of the segfault, at least it makes mc usable with most large syntax files, like this one included in 8.3.
--- mc-4.6.0/edit/syntax.c.000 2002-12-15 19:55:53.000000000 +0100 +++ mc-4.6.0/edit/syntax.c 2003-12-26 01:06:51.000000000 +0100 @@ -42,7 +42,7 @@
#define UNKNOWN_FORMAT "unknown"
-#define MAX_WORDS_PER_CONTEXT 1024 +#define MAX_WORDS_PER_CONTEXT 4096 #define MAX_CONTEXTS 128
#define RULE_ON_LEFT_BORDER 1
has worked for me for over a month with this > 128K php.syntax file. The included patch does not.
Either this patch should be fixed/redone or MAX_WORDS_PER_CONTEXT increased to 4096. And everyone should upgrade to 8.1 now!
Bye, Leonard.
On Sat, Jan 31, 2004 at 03:49:18AM +0100, Leonard den Ottolander wrote:
Hello Bill, Jakub,
This is an update to the previous testing update, 4.6.0-8.1. New changes listed below.
Note that 8.1 is a SECURITY fix but was never announced. You should upgrade to 8.1!
- update php.syntax file (#112645)
- fix crash with large syntax file (#112644)
I am very glad you included the php.syntax file, but the patch I uploaded for #112644 is buggy, as I found out and stated in that bug report.
But mc-4.6.0-8.3 doesn't use the patch yoo uploaded, there is an important difference in bounds checking.
When running this version (8.3) I do still see a segfault when editing php files.
Are you really sure? Don't you have some other mc binary floating around or something? It works for me just fine, with your > 128K php.syntax (which is included in the rpm as well), even under LD_PRELOAD=libefence.so.0.
Jakub
On Sat, Jan 31, 2004 at 03:49:18AM +0100, Leonard den Ottolander wrote:
I am very glad you included the php.syntax file, but the patch I uploaded for #112644 is buggy, as I found out and stated in that bug report.
Actually, I found another bug in that patch (and that the original code is very crappy). It always calloced the arrays to make sure they are in the end NULL terminated, of course realloc without any memset would not keep the rest cleared and so if you're unlucky it would segfault. Triggered with explicit memset (, 0xaa, ). Rewritten so that it terminates both the keywords and contexts explicitely and no longer misuses calloc.
Bill, mc-4.6.0-8.4 is in updates-candidate, can you please repush? Thanks. Now I'm really away...
Jakub
Hello Jakub,
Actually, I found another bug in that patch (and that the original code is very crappy).
Tell me about it ;-) . But it is a good indication of where and how to solve the issue.
The fact that 8.3 still segfaulted on me made me assume you were using the original patch. As it was getting quite late (so it has on your end I see :) I didn't look any closer yet.
It always calloced the arrays to make sure they are in the end NULL terminated, of course realloc without any memset would not keep the rest cleared and so if you're unlucky it would segfault. Triggered with explicit memset (, 0xaa, ). Rewritten so that it terminates both the keywords and contexts explicitely and no longer misuses calloc.
Can you make the patch available anywhere before the push?
Bill, mc-4.6.0-8.4 is in updates-candidate, can you please repush? Thanks.
And please be so kind to announce 8.1 and push it to the main tree in the mean time. I am a bit surprised (to use an understatement) a security patch lies around in testing for over 10 days but never got announced. Not everybody is using testing on a regular basis, and even I missed this update as it was not announced. And I was monitoring, as announcements for RHEL and RH9 have already been made.
Now I'm really away...
Thanks and hope you have a good night.
Bye, Leonard.
Speaking of this...
any ideas on why fedora (tested on 3 fedora boxes, including 1 i never installed) wont let you set the info on left hand side, you can set it on right no hassles, and when we ctl -u or whatever it is to swap em boom locks up again.. (yep deleted ~/.mc several times in case of corruption somewhere)
Cheers
On Fri, 30 Jan 2004, Bill Nottingham wrote:
Fedora Test Update Notification FEDORA-2004-058 2004-01-30
Name : mc Version : 4.6.0 Release : 8.3 Summary : User-friendly text console file manager and visual shell. Description : Midnight Commander is a visual shell much like a file manager, only with many more features. It is a text mode application, but it also includes mouse support if you are running GPM. Midnight Commander's best features are its ability to FTP, view tar and zip files, and to poke into RPMs for specific files.
Update Information:
This is an update to the previous testing update, 4.6.0-8.1. New changes listed below.
- Fri Jan 30 2004 Jakub Jelinek jakub@redhat.com 4.6.0-8.3
- update php.syntax file (#112645)
- fix crash with large syntax file (#112644)
This update can be downloaded from: http://download.fedora.redhat.com/pub/fedora/linux/core/updates/testing/1/
69692aaa0d1eb263a2a8625ad5bdaac1 SRPMS/mc-4.6.0-8.3.src.rpm 60ebb4dd088eeee193c9259998136c6f i386/mc-4.6.0-8.3.i386.rpm 0c27127b10ee9cb0c99a07f3f54f7845 i386/debug/mc-debuginfo-4.6.0-8.3.i386.rpm
This update can also be installed with the Update Agent; you can launch the Update Agent with the 'up2date' command. You may need to edit your up2date channels configuration. Within /etc/sysconfig/rhn/sources enable the following line: yum updates-testing http://fedora.redhat.com/updates/testing/fedora-core-1
On Sun, 1 Feb 2004 09:54:04 +1000 (EST), Res wrote:
Speaking of this...
any ideas on why fedora (tested on 3 fedora boxes, including 1 i never installed) wont let you set the info on left hand side, you can set it on right no hassles, and when we ctl -u or whatever it is to swap em boom locks up again.. (yep deleted ~/.mc several times in case of corruption somewhere)
Reproducible here. gdb output suggests it's an UTF-8 bug in S-Lang. With "env LANG=en_GB mc" it's not reproducible.
--
-
Bill Nottingham -
Jakub Jelinek -
Leonard den Ottolander -
Michael Schwendt -
Res