The following Fedora 29 Security updates need testing: Age URL 105 https://bodhi.fedoraproject.org/updates/FEDORA-2019-49f80a78bc mingw-sqlite-3.26.0.0-1.fc29 85 https://bodhi.fedoraproject.org/updates/FEDORA-2019-fa5843e0e1 asterisk-16.2.1-1.fc29 71 https://bodhi.fedoraproject.org/updates/FEDORA-2019-c84f291592 WALinuxAgent-2.2.38-1.fc29 66 https://bodhi.fedoraproject.org/updates/FEDORA-2019-7528388823 chicken-5.0.0-2.fc29 26 https://bodhi.fedoraproject.org/updates/FEDORA-2019-9839aded3f python-gnupg-0.4.4-1.fc29 24 https://bodhi.fedoraproject.org/updates/FEDORA-2019-6a8a9efc40 community-mysql-8.0.16-1.fc29 22 https://bodhi.fedoraproject.org/updates/FEDORA-2019-35cb5a4785 kubernetes-1.13.5-1.fc29 18 https://bodhi.fedoraproject.org/updates/FEDORA-2019-0370ad8310 bind-9.11.6-2.P1.fc29 bind-dyndb-ldap-11.1-15.fc29 dhcp-4.3.6-31.fc29 dnsperf-2.2.1-4.fc29 16 https://bodhi.fedoraproject.org/updates/FEDORA-2019-9454ce61b2 freeradius-3.0.19-3.fc29 14 https://bodhi.fedoraproject.org/updates/FEDORA-2019-ec26883852 python3-3.7.3-3.fc29 11 https://bodhi.fedoraproject.org/updates/FEDORA-2019-1f5832fc0e xen-4.11.1-5.fc29 9 https://bodhi.fedoraproject.org/updates/FEDORA-2019-a01751837d sqlite-3.26.0-3.fc29 8 https://bodhi.fedoraproject.org/updates/FEDORA-2019-0cf869d6d6 safelease-1.0.1-1.fc29 8 https://bodhi.fedoraproject.org/updates/FEDORA-2019-b8a704ff4b wavpack-5.1.0-13.fc29 7 https://bodhi.fedoraproject.org/updates/FEDORA-2019-a0d15f5e40 webkit2gtk3-2.24.2-1.fc29 6 https://bodhi.fedoraproject.org/updates/FEDORA-2019-d57de29e94 drupal7-entity-1.9-1.fc29 5 https://bodhi.fedoraproject.org/updates/FEDORA-2019-e2f5e10754 nss-3.44.0-2.fc29 5 https://bodhi.fedoraproject.org/updates/FEDORA-2019-063672154a c3p0-0.9.5.4-1.fc29 3 https://bodhi.fedoraproject.org/updates/FEDORA-2019-96badf645f thunderbird-60.7.0-1.fc29 1 https://bodhi.fedoraproject.org/updates/FEDORA-2019-e5910c3ef2 libvirt-4.7.0-4.fc29 1 https://bodhi.fedoraproject.org/updates/FEDORA-2019-697de0501f curl-7.61.1-11.fc29 1 https://bodhi.fedoraproject.org/updates/FEDORA-2019-f180df9791 mod_http2-1.15.0-1.fc29 1 https://bodhi.fedoraproject.org/updates/FEDORA-2019-61b6dae771 sleuthkit-4.6.6-1.fc29 1 https://bodhi.fedoraproject.org/updates/FEDORA-2019-5258ea8ae2 drupal7-ds-2.16-1.fc29 1 https://bodhi.fedoraproject.org/updates/FEDORA-2019-2aa9f5f5d6 drupal7-uuid-1.2-1.fc29 1 https://bodhi.fedoraproject.org/updates/FEDORA-2019-f219dbb548 drupal7-xmlsitemap-2.6-1.fc29 1 https://bodhi.fedoraproject.org/updates/FEDORA-2019-62eba285ee drupal7-context-3.10-1.fc29 1 https://bodhi.fedoraproject.org/updates/FEDORA-2019-c12c2f0c22 drupal7-path_breadcrumbs-3.4-1.fc29 1 https://bodhi.fedoraproject.org/updates/FEDORA-2019-0e10310204 drupal7-module_filter-2.2-1.fc29 1 https://bodhi.fedoraproject.org/updates/FEDORA-2019-f08c17b5cc drupal7-views-3.23-1.fc29
The following Fedora 29 Critical Path updates have yet to be approved: Age URL 74 https://bodhi.fedoraproject.org/updates/FEDORA-2019-5329292fc2 fedfind-4.2.2-1.fc29 python-productmd-1.20-1.fc29 66 https://bodhi.fedoraproject.org/updates/FEDORA-2019-f4b2308023 iproute-5.0.0-2.fc29 31 https://bodhi.fedoraproject.org/updates/FEDORA-2019-4a24d6089e pungi-4.1.36-1.fc29 31 https://bodhi.fedoraproject.org/updates/FEDORA-2019-201c9dce0a libXt-1.1.5-11.20190424gitba4ec9376.fc29 26 https://bodhi.fedoraproject.org/updates/FEDORA-2019-d762a7ad70 kexec-tools-2.0.19-1.fc29 26 https://bodhi.fedoraproject.org/updates/FEDORA-2019-ca38b20492 libbytesize-2.0-1.fc29 25 https://bodhi.fedoraproject.org/updates/FEDORA-2019-e6d2bef148 python2-2.7.16-2.fc29 22 https://bodhi.fedoraproject.org/updates/FEDORA-2019-3b403286dc fuse-2.9.9-7.fc29 18 https://bodhi.fedoraproject.org/updates/FEDORA-2019-0370ad8310 bind-9.11.6-2.P1.fc29 bind-dyndb-ldap-11.1-15.fc29 dhcp-4.3.6-31.fc29 dnsperf-2.2.1-4.fc29 17 https://bodhi.fedoraproject.org/updates/FEDORA-2019-e513e057d5 python-blivet-3.1.2-5.fc29 16 https://bodhi.fedoraproject.org/updates/FEDORA-2019-719c8264ca lorax-29.29-1.fc29 15 https://bodhi.fedoraproject.org/updates/FEDORA-2019-3b38d20c4a alsa-utils-1.1.9-1.fc29 alsa-lib-1.1.9-1.fc29 alsa-plugins-1.1.9-1.fc29 14 https://bodhi.fedoraproject.org/updates/FEDORA-2019-ec26883852 python3-3.7.3-3.fc29 11 https://bodhi.fedoraproject.org/updates/FEDORA-2019-1f5832fc0e xen-4.11.1-5.fc29 10 https://bodhi.fedoraproject.org/updates/FEDORA-2019-0c8a3052ac breeze-icon-theme-5.58.0-1.fc29 extra-cmake-modules-5.58.0-1.fc29 kf5-5.58.0-1.fc29 kf5-attica-5.58.0-1.fc29 kf5-baloo-5.58.0-1.fc29 kf5-bluez-qt-5.58.0-1.fc29 kf5-frameworkintegration-5.58.0-2.fc29 kf5-kactivities-5.58.0-1.fc29 kf5-kactivities-stats-5.58.0-1.fc29 kf5-kapidox-5.58.0-1.fc29 kf5-karchive-5.58.0-1.fc29 kf5-kauth-5.58.0-1.fc29 kf5-kbookmarks-5.58.0-1.fc29 kf5-kcmutils-5.58.0-1.fc29 kf5-kcodecs-5.58.0-1.fc29 kf5-kcompletion-5.58.0-1.fc29 kf5-kconfig-5.58.0-1.fc29 kf5-kconfigwidgets-5.58.0-1.fc29 kf5-kcoreaddons-5.58.0-2.fc29 kf5-kcrash-5.58.0-1.fc29 kf5-kdbusaddons-5.58.0-1.fc29 kf5-kdeclarative-5.58.0-1.fc29 kf5-kded-5.58.0-1.fc29 kf5-kdelibs4support-5.58.0-1.fc29 kf5-kdesignerplugin-5.58.0-1.fc29 kf5-kdesu-5.58.0-1.fc29 kf5-kdewebkit-5.58.0-1.fc29 kf5-kdnssd-5.58.0-1.fc29 kf5-kdoctools-5.58.0-1.fc29 kf5-kemoticons-5.58.0-1.fc29 kf5-kfilemetadata-5.58.0-1.fc29 kf5-kglobalaccel-5.58.0-1.fc29 kf5-kguiad dons-5.58.0-1.fc29 kf5-kholidays-5.58.0-1.fc29 kf5-khtml-5.58.0-1.fc29 kf5-ki18n-5.58.0-1.fc29 kf5-kiconthemes-5.58.0-1.fc29 kf5-kidletime-5.58.0-1.fc29 kf5-kimageformats-5.58.0-1.fc29 kf5-kinit-5.58.0-1.fc29 kf5-kio-5.58.0-1.fc29 kf5-kirigami2-5.58.0-1.fc29 kf5-kitemmodels-5.58.0-1.fc29 kf5-kitemviews-5.58.0-1.fc29 kf5-kjobwidgets-5.58.0-1.fc29 kf5-kjs-5.58.0-1.fc29 kf5-kjsembed-5.58.0-1.fc29 kf5-kmediaplayer-5.58.0-1.fc29 kf5-knewstuff-5.58.0-1.fc29 kf5-knotifications-5.58.0-1.fc29 kf5-knotifyconfig-5.58.0-1.fc29 kf5-kpackage-5.58.0-1.fc29 kf5-kparts-5.58.0-2.fc29 kf5-kpeople-5.58.0-1.fc29 kf5-kplotting-5.58.0-1.fc29 kf5-kpty-5.58.0-1.fc29 kf5-kross-5.58.0-1.fc29 kf5-krunner-5.58.0-1.fc29 kf5-kservice-5.58.0-1.fc29 kf5-ktexteditor-5.58.0-1.fc29 kf5-ktextwidgets-5.58.0-1.fc29 kf5-kunitconversion-5.58.0-1.fc29 kf5-kwallet-5.58.0-1.fc29 kf5-kwayland-5.58.0-1.fc29 kf5-kwidgetsaddons-5.58.0-1.fc29 kf5-kwindowsystem-5.58.0-1.fc29 kf5-kxmlgui-5.58.0-1.fc29 kf5-kxmlrpcclient-5.58.0-1.fc29 kf5-modemmanager-qt-5.58.0-1.fc29 kf5-networkmanager-qt-5.58.0-2.fc29 kf5-plasma-5.58.0-1.fc29 kf5-prison-5.58.0-1.fc29 kf5-purpose-5.58.0-1.fc29 kf5-solid-5.58.0-1.fc29 kf5-sonnet-5.58.0-1.fc29 kf5-syndication-5.58.0-1.fc29 kf5-syntax-highlighting-5.58.0-1.fc29 kf5-threadweaver-5.58.0-1.fc29 oxygen-icon-theme-5.58.0-1.fc29 qqc2-desktop-style-5.58.0-1.fc29 9 https://bodhi.fedoraproject.org/updates/FEDORA-2019-a01751837d sqlite-3.26.0-3.fc29 8 https://bodhi.fedoraproject.org/updates/FEDORA-2019-b8a704ff4b wavpack-5.1.0-13.fc29 5 https://bodhi.fedoraproject.org/updates/FEDORA-2019-e2f5e10754 nss-3.44.0-2.fc29 5 https://bodhi.fedoraproject.org/updates/FEDORA-2019-28516f8c38 librepo-1.10.2-1.fc29 5 https://bodhi.fedoraproject.org/updates/FEDORA-2019-d2df59c6df vim-8.1.1359-1.fc29 5 https://bodhi.fedoraproject.org/updates/FEDORA-2019-c1840c618b createrepo_c-0.13.2-2.fc29 3 https://bodhi.fedoraproject.org/updates/FEDORA-2019-691a70723b fwupd-1.2.9-1.fc29 3 https://bodhi.fedoraproject.org/updates/FEDORA-2019-9be1aa31d1 dnf-plugins-core-4.0.7-1.fc29 3 https://bodhi.fedoraproject.org/updates/FEDORA-2019-96badf645f thunderbird-60.7.0-1.fc29 3 https://bodhi.fedoraproject.org/updates/FEDORA-2019-852102b3ba squashfs-tools-4.3-20.fc29 1 https://bodhi.fedoraproject.org/updates/FEDORA-2019-f5bac824d8 firefox-67.0-4.fc29 1 https://bodhi.fedoraproject.org/updates/FEDORA-2019-8ab4452eca pcre-8.43-2.fc29 1 https://bodhi.fedoraproject.org/updates/FEDORA-2019-5ecb2e38c3 libidn2-2.2.0-1.fc29 1 https://bodhi.fedoraproject.org/updates/FEDORA-2019-4cefd3161a nfs-utils-2.3.3-2.rc2.fc29 1 https://bodhi.fedoraproject.org/updates/FEDORA-2019-b1f02f9ed4 p11-kit-0.23.16.1-1.fc29 1 https://bodhi.fedoraproject.org/updates/FEDORA-2019-697de0501f curl-7.61.1-11.fc29 1 https://bodhi.fedoraproject.org/updates/FEDORA-2019-e5910c3ef2 libvirt-4.7.0-4.fc29
The following builds have been pushed to Fedora 29 updates-testing
homebank-5.2.6-1.fc29 lshw-B.02.18-20.fc29 php-masterminds-html5-2.6.0-1.fc29 python-acoustid-1.1.7-1.fc29 python-audioread-2.1.7-1.fc29 python-regex-2019.05.25-1.fc29 recoll-1.25.16-1.fc29 rust-1.35.0-1.fc29 terminology-1.4.1-1.fc29 waf-2.0.16-1.fc29
Details about builds:
================================================================================ homebank-5.2.6-1.fc29 (FEDORA-2019-2cd29dfa69) Free easy personal accounting for all -------------------------------------------------------------------------------- Update Information:
- Update to 5.2.6 fixes rhbz #1711554 and rhbz #1713860 -------------------------------------------------------------------------------- ChangeLog:
* Sat May 25 2019 Filipe Rosset rosset.filipe@gmail.com - 5.2.6-1 - Update to 5.2.6 fixes rhbz #1711554 and rhbz #1713860 -------------------------------------------------------------------------------- References:
[ 1 ] Bug #1711554 - [abrt] homebank: _cairo_arc_in_direction(): homebank killed by SIGABRT https://bugzilla.redhat.com/show_bug.cgi?id=1711554 [ 2 ] Bug #1709028 - homebank-5.2.5 is available https://bugzilla.redhat.com/show_bug.cgi?id=1709028 [ 3 ] Bug #1713860 - homebank-5.2.6 is available https://bugzilla.redhat.com/show_bug.cgi?id=1713860 --------------------------------------------------------------------------------
================================================================================ lshw-B.02.18-20.fc29 (FEDORA-2019-45236a5fc1) Hardware lister -------------------------------------------------------------------------------- Update Information:
Add manual page for command lshw-gui. -------------------------------------------------------------------------------- ChangeLog:
* Sat May 25 2019 Terje Rosten terje.rosten@ntnu.no - B.02.18-20 - Add lshw-gui man page (from Debian, thanks!) * Fri Feb 1 2019 Fedora Release Engineering releng@fedoraproject.org - B.02.18-19 - Rebuilt for https://fedoraproject.org/wiki/Fedora_30_Mass_Rebuild -------------------------------------------------------------------------------- References:
[ 1 ] Bug #1611502 - Man page scan results for lshw https://bugzilla.redhat.com/show_bug.cgi?id=1611502 --------------------------------------------------------------------------------
================================================================================ php-masterminds-html5-2.6.0-1.fc29 (FEDORA-2019-9e61f18a62) An HTML5 parser and serializer -------------------------------------------------------------------------------- Update Information:
### 2.6.0 * #163: Allow to pass a charset to the Scanner ### 2.5.0 This release brings again big performance improvements (thanks @stof for the excellent work). `v2.5` is 3.5 times faster than `v2.4` and 11 times faster than `v2.3`! Here a list of the changes: * #162, #161, #155, #154, #153, #151: performance improvements * #156: fixed typos * #160: adopt and enforce code style * #159: remove deprecated php unit base test case * #150: backport changes from old master bran ### 2.4.0 This release brings big performance improvements (thanks @tgalopin for the excellent work). Based on the `test/benchmark/run.php` benchmark, 2.4.0 is 2x faster than 2.3.1 when parsing HTML5 documents. Here a list of the changes: * #148: Improve performance by moving sequence matching * #147: Improve the Tokenizer performance * #146: Improve performance by relying on a native string instead of InputStream * #144: Add DOM extension in composer.json * #145: Add more extensions on composer.json, improve phpdocs and remove dead code * #143: Remove experimental comment -------------------------------------------------------------------------------- ChangeLog:
* Sat May 25 2019 Shawn Iwinski shawn.iwinski@gmail.com - 2.6.0-1 - Update to 2.6.0 (RHBZ #1687215) * Sat Feb 2 2019 Fedora Release Engineering releng@fedoraproject.org - 2.3.0-4 - Rebuilt for https://fedoraproject.org/wiki/Fedora_30_Mass_Rebuild -------------------------------------------------------------------------------- References:
[ 1 ] Bug #1687215 - php-masterminds-html5-2.6.0 is available https://bugzilla.redhat.com/show_bug.cgi?id=1687215 --------------------------------------------------------------------------------
================================================================================ python-acoustid-1.1.7-1.fc29 (FEDORA-2019-e9f49e54a6) Python bindings for Chromaprint acoustic fingerprinting and the Acoustid API -------------------------------------------------------------------------------- Update Information:
Update to latest upstream release pyacoustid 1.1.7. -------------------------------------------------------------------------------- ChangeLog:
* Sat May 25 2019 Terje Rosten terje.rosten@ntnu.no - 1.1.7-1 - 1.1.7 * Sat Feb 2 2019 Fedora Release Engineering releng@fedoraproject.org - 1.1.5-8 - Rebuilt for https://fedoraproject.org/wiki/Fedora_30_Mass_Rebuild * Sun Nov 18 2018 Zbigniew J��drzejewski-Szmek zbyszek@in.waw.pl - 1.1.5-7 - Drop explicit locale setting See https://fedoraproject.org/wiki/Changes/Remove_glibc-langpacks-all_from_build... -------------------------------------------------------------------------------- References:
[ 1 ] Bug #1711103 - python-acoustid-1.1.7 is available https://bugzilla.redhat.com/show_bug.cgi?id=1711103 --------------------------------------------------------------------------------
================================================================================ python-audioread-2.1.7-1.fc29 (FEDORA-2019-8c56aa54df) Multi-library, cross-platform audio decoding in Python -------------------------------------------------------------------------------- Update Information:
Update to latest upstream release audioread 2.1.7. -------------------------------------------------------------------------------- ChangeLog:
* Sat May 25 2019 Terje Rosten terje.rosten@ntnu.no - 2.1.7-1 - 2.1.7 * Sat Feb 2 2019 Fedora Release Engineering releng@fedoraproject.org - 2.1.6-4 - Rebuilt for https://fedoraproject.org/wiki/Fedora_30_Mass_Rebuild -------------------------------------------------------------------------------- References:
[ 1 ] Bug #1711102 - python-audioread-2.1.7 is available https://bugzilla.redhat.com/show_bug.cgi?id=1711102 --------------------------------------------------------------------------------
================================================================================ python-regex-2019.05.25-1.fc29 (FEDORA-2019-9e476b9600) Alternative regular expression module, to replace re -------------------------------------------------------------------------------- Update Information:
Update to the latest released version. -------------------------------------------------------------------------------- ChangeLog:
* Sat May 25 2019 Thomas Moschny thomas.moschny@gmx.de - 2019.05.25-1 - Update to 2019.05.25. --------------------------------------------------------------------------------
================================================================================ recoll-1.25.16-1.fc29 (FEDORA-2019-6b52ce8a86) Desktop full text search tool with Qt GUI -------------------------------------------------------------------------------- Update Information:
Update to latest upstream release recoll 1.25.16. -------------------------------------------------------------------------------- ChangeLog:
* Sat May 25 2019 Terje Rosten terje.rosten@ntnu.no - 1.25.16-1 - 1.25.16 -------------------------------------------------------------------------------- References:
[ 1 ] Bug #1691955 - [abrt] recoll: parse(): ole.py:216:parse:OverflowError: integer division result too large for a float https://bugzilla.redhat.com/show_bug.cgi?id=1691955 [ 2 ] Bug #1712957 - recoll-1.25.16 is available https://bugzilla.redhat.com/show_bug.cgi?id=1712957 --------------------------------------------------------------------------------
================================================================================ rust-1.35.0-1.fc29 (FEDORA-2019-77b71d75a3) The Rust Programming Language -------------------------------------------------------------------------------- Update Information:
Update to Rust 1.35.0: - `Fn*` closure traits implemented for `Box<dyn Fn*>` - Coercing closures to `unsafe fn` pointers - Calling `dbg!()` with no argument - Library stabilizations - Clippy `drop_bounds` See the [blog post](https://blog.rust-lang.org/2019/05/23/Rust-1.35.0.html) and [release notes](https://github.com/rust- lang/rust/blob/master/RELEASES.md#version-1350-2019-05-23) for more details. -------------------------------------------------------------------------------- ChangeLog:
* Thu May 23 2019 Josh Stone jistone@redhat.com - 1.35.0-1 - Update to 1.35.0. --------------------------------------------------------------------------------
================================================================================ terminology-1.4.1-1.fc29 (FEDORA-2019-7894dbb527) EFL based terminal emulator -------------------------------------------------------------------------------- Update Information:
Changes since 1.4.0: -------------------- Fixes: * Decode pasted string as UTF-8, fixing some characters being skipped * Fix theme to ensure default size is 80x24 * Fix focus disappearing after going to Settings and back Changes since 1.3.2: -------------------- Additions: * Add Continuous Integration on every push to the git repository * Add a test framework on escape code parsing and interpreting * Add more than 120 test files * Add support, along with tests, for the following escape codes: DSR-DIR, DSR-KBD, DSR-MSR, DSR-DECCKSR, DSR-OS, DSR-PP, DSR-UDK, DECSCLM, DECBI, DECFI, DECSACE, DECRARA, DECCRARA, DECIC, DECDC, DECCRA, DECST8C, DA3, DECSWBV * Add finer configuration on whether to activate links * Set environment variable WINDOWID Improvements: * Selections only disappear if the underlaying content changes * When pasting a buffer, skip control characters as a security measure Fixes: * Fixes, along with tests, on handling the following escape codes: VPR, DECERA, DECFRA, DSR-CPR, DCH, DECALN, DECAWM, IL, DL * Fixes, along with tests, on mouse reporting * Fixes on issues spotted by Coverity -------------------------------------------------------------------------------- ChangeLog:
* Sat May 25 2019 Conrad Meyer cemeyer@uw.edu - 1.4.1-1 - Update to latest upstream 1.4.1 - Fix rhbz# 1713806 * Tue Apr 16 2019 Adam Williamson awilliam@redhat.com - 1.4.0-2 - Rebuild with Meson fix for #1699099 * Mon Apr 8 2019 Conrad Meyer cemeyer@uw.edu - 1.4.0-1 - Update to latest upstream - Fix rhbz# 1694425 * Sun Feb 3 2019 Fedora Release Engineering releng@fedoraproject.org - 1.3.2-2 - Rebuilt for https://fedoraproject.org/wiki/Fedora_30_Mass_Rebuild -------------------------------------------------------------------------------- References:
[ 1 ] Bug #1713806 - terminology-1.4.1 is available https://bugzilla.redhat.com/show_bug.cgi?id=1713806 --------------------------------------------------------------------------------
================================================================================ waf-2.0.16-1.fc29 (FEDORA-2019-784d950fcc) A Python-based build system -------------------------------------------------------------------------------- Update Information:
#### NEW IN WAF 2.0.16 #### * Fix task semaphore errors on stateful tasks #2232 * Fix encoding errors with UTF-8 paths on Python 2 #2230 * Fix encoding errors in waf_unit_test #2220 * Improve dependency between javac task and use-d generated jars nodes * Install pdb files with /debug:* flags #2224 * Make javadoc detection optional #2225 * Improve md5_tstamp documentation #2221 * Add extras/color_msvc to colorizes MSVC outputs #2221 * Fix symbol regex on mac-o binaries in extras/syms #2222 * Maintain order of lines in doxyfile in extras/doxygen #2223 * Improve extras/msvcdeps path handling * Add extras/clang_cross for cross-compilation using clang -------------------------------------------------------------------------------- ChangeLog:
* Sun May 19 2019 Thomas Moschny thomas.moschny@gmx.de - 2.0.16-1 - Update to 2.0.16. * Wed May 15 2019 Thomas Moschny thomas.moschny@gmx.de - 2.0.15-1 - Update to 2.0.15. * Sun Feb 3 2019 Fedora Release Engineering releng@fedoraproject.org - 2.0.14-2 - Rebuilt for https://fedoraproject.org/wiki/Fedora_30_Mass_Rebuild --------------------------------------------------------------------------------