Hi all,
I have submitted a draft patch about Features/NUMA and Virtual NUMAhttp://www.ovirt.org/Features/NUMA_and_Virtual_NUMA. Here is the gerrit request: http://gerrit.ovirt.org/#/c/23703/ Please help me to review the codes.
Thanks & Best Regards Shi, Xiao-Lei (Bruce)
Hewlett-Packard Co., Ltd. HP Servers Core Platform Software China Telephone +86 23 65683093 Mobile +86 18696583447 Email xiao-lei.shi@hp.commailto:shiguo.li@hp.com
On Sun, Jan 26, 2014 at 06:51:50AM +0000, Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ) wrote:
Hi all,
I have submitted a draft patch about Features/NUMA and Virtual NUMAhttp://www.ovirt.org/Features/NUMA_and_Virtual_NUMA. Here is the gerrit request: http://gerrit.ovirt.org/#/c/23703/ Please help me to review the codes.
Thanks for your contrinution!
I see that Francesco gave it a preliminary review. Since this patch borders virt and sla, I think that Martin could be of help, too.
When you introduce new API functionality, you most usually need to document it in vdsm_api/vdsmapi-schema.json and explain in the commit message, how would the new response to this verb would look like. Unit tests serve as a good example of how to use the new code.
Dan.
----- Original Message -----
From: "Dan Kenigsberg" danken@redhat.com To: "Xiao-Lei Shi (Bruce, HP Servers-PSC-CQ)" xiao-lei.shi@hp.com, fromani@redhat.com, msivak@redhat.com Cc: vdsm-devel@lists.fedorahosted.org, "Gilad Chaplik gchaplik@redhat.com (gchaplik@redhat.com)" gchaplik@redhat.com Sent: Monday, January 27, 2014 6:40:35 PM Subject: Re: [vdsm] Find reviewers for codes of Numa feature
On Sun, Jan 26, 2014 at 06:51:50AM +0000, Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ) wrote:
Hi all,
I have submitted a draft patch about Features/NUMA and Virtual NUMAhttp://www.ovirt.org/Features/NUMA_and_Virtual_NUMA. Here is the gerrit request: http://gerrit.ovirt.org/#/c/23703/ Please help me to review the codes.
Thanks for your contrinution!
I see that Francesco gave it a preliminary review. Since this patch borders virt and sla, I think that Martin could be of help, too.
Yep! Bruce, thanks for the patch, feel free to ask if you need more informations.
Best regards,
vdsm-devel@lists.stg.fedorahosted.org