From: Fedora Kernel Team kernel-team@fedoraproject.org
Hi,
As part of the ongoing rebase effort, the following configuration options need to be reviewed.
As a reminder, the ARK configuration flow involves moving unreviewed configuration options from the pending directory to the ark directory. In the diff below, options are removed from the pending directory and added to the ark hierarchy. The final options that need to be ACKed are the files that are being added to the ark hierarchy.
If the value for a file that is added should be changed, please reply with a better option.
CONFIG_KGDB_HONOUR_BLOCKLIST:
If set to Y the debug core will use the kprobe blocklist to identify symbols where it is unsafe to set breakpoints. In particular this disallows instrumentation of functions called during debug trap handling and thus makes it very difficult to inadvertently provoke recursive trap handling.
If unsure, say Y.
Symbol: KGDB_HONOUR_BLOCKLIST [=y] Type : bool Defined at lib/Kconfig.kgdb:27 Prompt: KGDB: use kprobe blocklist to prohibit unsafe breakpoints Depends on: KGDB [=y] && HAVE_KPROBES [=y] && MODULES [=y] Location: -> Kernel hacking -> Generic Kernel Debugging Instruments -> KGDB: kernel debugger (KGDB [=y]) Selects: KPROBES [=y]
---
Cc: Prarit Bhargava prarit@redhat.com Signed-off-by: Fedora Kernel Team kernel-team@fedoraproject.org --- .../generic/CONFIG_KGDB_HONOUR_BLOCKLIST | 1 + .../generic/CONFIG_KGDB_HONOUR_BLOCKLIST | 24 ------------------- 2 files changed, 1 insertion(+), 24 deletions(-) create mode 100644 redhat/configs/common/generic/CONFIG_KGDB_HONOUR_BLOCKLIST delete mode 100644 redhat/configs/pending-common/generic/CONFIG_KGDB_HONOUR_BLOCKLIST
diff --git a/redhat/configs/common/generic/CONFIG_KGDB_HONOUR_BLOCKLIST b/redhat/configs/common/generic/CONFIG_KGDB_HONOUR_BLOCKLIST new file mode 100644 index 000000000000..7da79f661883 --- /dev/null +++ b/redhat/configs/common/generic/CONFIG_KGDB_HONOUR_BLOCKLIST @@ -0,0 +1 @@ +CONFIG_KGDB_HONOUR_BLOCKLIST=y diff --git a/redhat/configs/pending-common/generic/CONFIG_KGDB_HONOUR_BLOCKLIST b/redhat/configs/pending-common/generic/CONFIG_KGDB_HONOUR_BLOCKLIST deleted file mode 100644 index 224aca014283..000000000000 --- a/redhat/configs/pending-common/generic/CONFIG_KGDB_HONOUR_BLOCKLIST +++ /dev/null @@ -1,24 +0,0 @@ -# CONFIG_KGDB_HONOUR_BLOCKLIST: -# -# If set to Y the debug core will use the kprobe blocklist to -# identify symbols where it is unsafe to set breakpoints. -# In particular this disallows instrumentation of functions -# called during debug trap handling and thus makes it very -# difficult to inadvertently provoke recursive trap handling. -# -# If unsure, say Y. -# -# Symbol: KGDB_HONOUR_BLOCKLIST [=y] -# Type : bool -# Defined at lib/Kconfig.kgdb:27 -# Prompt: KGDB: use kprobe blocklist to prohibit unsafe breakpoints -# Depends on: KGDB [=y] && HAVE_KPROBES [=y] && MODULES [=y] -# Location: -# -> Kernel hacking -# -> Generic Kernel Debugging Instruments -# -> KGDB: kernel debugger (KGDB [=y]) -# Selects: KPROBES [=y] -# -# -# -CONFIG_KGDB_HONOUR_BLOCKLIST=y
From: Patrick Talbert on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/733#note_48897250...
This merge request has not been updated in over 30 days. Please review this MR's current changes regarding the following configuration option(s):
CONFIG_KGDB_HONOUR_BLOCKLIST
From: Joe Lawrence on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/733#note_53885037...
Seems fairly safe and reasonable, no crazy bug fixes or problems reported in the git log for enabling this option.
kernel@lists.fedoraproject.org