From: Fedora Kernel Team kernel-team@fedoraproject.org
Hi,
As part of the ongoing rebase effort, the following configuration options need to be reviewed.
As a reminder, the ARK configuration flow involves moving unreviewed configuration options from the pending directory to the ark directory. In the diff below, options are removed from the pending directory and added to the ark hierarchy. The final options that need to be ACKed are the files that are being added to the ark hierarchy.
If the value for a file that is added should be changed, please reply with a better option.
CONFIG_CSD_LOCK_WAIT_DEBUG:
This option enables debug prints when CPUs are slow to respond to the smp_call_function*() IPI wrappers. These debug prints include the IPI handler function currently executing (if any) and relevant stack traces.
Symbol: CSD_LOCK_WAIT_DEBUG [=n] Type : bool Defined at lib/Kconfig.debug:1380 Prompt: Debugging for csd_lock_wait(), called from smp_call_function*() Depends on: DEBUG_KERNEL [=y] && 64BIT [=y] Location: -> Kernel hacking -> Lock Debugging (spinlocks, mutexes, etc...)
---
CONFIG_SCF_TORTURE_TEST:
This option provides a kernel module that runs torture tests on the smp_call_function() family of primitives. The kernel module may be built after the fact on the running kernel to be tested, if desired.
Symbol: SCF_TORTURE_TEST [=n] Type : tristate Defined at lib/Kconfig.debug:1370 Prompt: torture tests for smp_call_function*() Depends on: DEBUG_KERNEL [=y] Location: -> Kernel hacking -> Lock Debugging (spinlocks, mutexes, etc...) Selects: TORTURE_TEST [=n]
---
Cc: Prarit Bhargava prarit@redhat.com Signed-off-by: Fedora Kernel Team kernel-team@fedoraproject.org --- .../common/generic/CONFIG_CSD_LOCK_WAIT_DEBUG | 1 + .../common/generic/CONFIG_SCF_TORTURE_TEST | 1 + .../generic/CONFIG_CSD_LOCK_WAIT_DEBUG | 19 ------------------ .../generic/CONFIG_SCF_TORTURE_TEST | 20 ------------------- 4 files changed, 2 insertions(+), 39 deletions(-) create mode 100644 redhat/configs/common/generic/CONFIG_CSD_LOCK_WAIT_DEBUG create mode 100644 redhat/configs/common/generic/CONFIG_SCF_TORTURE_TEST delete mode 100644 redhat/configs/pending-common/generic/CONFIG_CSD_LOCK_WAIT_DEBUG delete mode 100644 redhat/configs/pending-common/generic/CONFIG_SCF_TORTURE_TEST
diff --git a/redhat/configs/common/generic/CONFIG_CSD_LOCK_WAIT_DEBUG b/redhat/configs/common/generic/CONFIG_CSD_LOCK_WAIT_DEBUG new file mode 100644 index 000000000000..086e41bbfcf8 --- /dev/null +++ b/redhat/configs/common/generic/CONFIG_CSD_LOCK_WAIT_DEBUG @@ -0,0 +1 @@ +# CONFIG_CSD_LOCK_WAIT_DEBUG is not set diff --git a/redhat/configs/common/generic/CONFIG_SCF_TORTURE_TEST b/redhat/configs/common/generic/CONFIG_SCF_TORTURE_TEST new file mode 100644 index 000000000000..53ebe3b18974 --- /dev/null +++ b/redhat/configs/common/generic/CONFIG_SCF_TORTURE_TEST @@ -0,0 +1 @@ +# CONFIG_SCF_TORTURE_TEST is not set diff --git a/redhat/configs/pending-common/generic/CONFIG_CSD_LOCK_WAIT_DEBUG b/redhat/configs/pending-common/generic/CONFIG_CSD_LOCK_WAIT_DEBUG deleted file mode 100644 index d2e1af1bda65..000000000000 --- a/redhat/configs/pending-common/generic/CONFIG_CSD_LOCK_WAIT_DEBUG +++ /dev/null @@ -1,19 +0,0 @@ -# CONFIG_CSD_LOCK_WAIT_DEBUG: -# -# This option enables debug prints when CPUs are slow to respond -# to the smp_call_function*() IPI wrappers. These debug prints -# include the IPI handler function currently executing (if any) -# and relevant stack traces. -# -# Symbol: CSD_LOCK_WAIT_DEBUG [=n] -# Type : bool -# Defined at lib/Kconfig.debug:1380 -# Prompt: Debugging for csd_lock_wait(), called from smp_call_function*() -# Depends on: DEBUG_KERNEL [=y] && 64BIT [=y] -# Location: -# -> Kernel hacking -# -> Lock Debugging (spinlocks, mutexes, etc...) -# -# -# -# CONFIG_CSD_LOCK_WAIT_DEBUG is not set diff --git a/redhat/configs/pending-common/generic/CONFIG_SCF_TORTURE_TEST b/redhat/configs/pending-common/generic/CONFIG_SCF_TORTURE_TEST deleted file mode 100644 index d22be82b0415..000000000000 --- a/redhat/configs/pending-common/generic/CONFIG_SCF_TORTURE_TEST +++ /dev/null @@ -1,20 +0,0 @@ -# CONFIG_SCF_TORTURE_TEST: -# -# This option provides a kernel module that runs torture tests -# on the smp_call_function() family of primitives. The kernel -# module may be built after the fact on the running kernel to -# be tested, if desired. -# -# Symbol: SCF_TORTURE_TEST [=n] -# Type : tristate -# Defined at lib/Kconfig.debug:1370 -# Prompt: torture tests for smp_call_function*() -# Depends on: DEBUG_KERNEL [=y] -# Location: -# -> Kernel hacking -# -> Lock Debugging (spinlocks, mutexes, etc...) -# Selects: TORTURE_TEST [=n] -# -# -# -# CONFIG_SCF_TORTURE_TEST is not set
On 10/21/20 1:27 PM, GitLab Bridge on behalf of jeremycline wrote:
From: Fedora Kernel Team kernel-team@fedoraproject.org
Hi,
As part of the ongoing rebase effort, the following configuration options need to be reviewed.
As a reminder, the ARK configuration flow involves moving unreviewed configuration options from the pending directory to the ark directory. In the diff below, options are removed from the pending directory and added to the ark hierarchy. The final options that need to be ACKed are the files that are being added to the ark hierarchy.
If the value for a file that is added should be changed, please reply with a better option.
CONFIG_CSD_LOCK_WAIT_DEBUG:
This option enables debug prints when CPUs are slow to respond to the smp_call_function*() IPI wrappers. These debug prints include the IPI handler function currently executing (if any) and relevant stack traces.
Symbol: CSD_LOCK_WAIT_DEBUG [=n] Type : bool Defined at lib/Kconfig.debug:1380 Prompt: Debugging for csd_lock_wait(), called from smp_call_function*() Depends on: DEBUG_KERNEL [=y] && 64BIT [=y] Location: -> Kernel hacking -> Lock Debugging (spinlocks, mutexes, etc...)
longman, should we turn this on in the base kernel?
CONFIG_SCF_TORTURE_TEST:
This option provides a kernel module that runs torture tests on the smp_call_function() family of primitives. The kernel module may be built after the fact on the running kernel to be tested, if desired.
Symbol: SCF_TORTURE_TEST [=n] Type : tristate Defined at lib/Kconfig.debug:1370 Prompt: torture tests for smp_call_function*() Depends on: DEBUG_KERNEL [=y] Location: -> Kernel hacking -> Lock Debugging (spinlocks, mutexes, etc...) Selects: TORTURE_TEST [=n]
This can be Y for debug kernels.
P.
Cc: Prarit Bhargava prarit@redhat.com Signed-off-by: Fedora Kernel Team kernel-team@fedoraproject.org
.../common/generic/CONFIG_CSD_LOCK_WAIT_DEBUG | 1 + .../common/generic/CONFIG_SCF_TORTURE_TEST | 1 + .../generic/CONFIG_CSD_LOCK_WAIT_DEBUG | 19 ------------------ .../generic/CONFIG_SCF_TORTURE_TEST | 20 ------------------- 4 files changed, 2 insertions(+), 39 deletions(-) create mode 100644 redhat/configs/common/generic/CONFIG_CSD_LOCK_WAIT_DEBUG create mode 100644 redhat/configs/common/generic/CONFIG_SCF_TORTURE_TEST delete mode 100644 redhat/configs/pending-common/generic/CONFIG_CSD_LOCK_WAIT_DEBUG delete mode 100644 redhat/configs/pending-common/generic/CONFIG_SCF_TORTURE_TEST
diff --git a/redhat/configs/common/generic/CONFIG_CSD_LOCK_WAIT_DEBUG b/redhat/configs/common/generic/CONFIG_CSD_LOCK_WAIT_DEBUG new file mode 100644 index 000000000000..086e41bbfcf8 --- /dev/null +++ b/redhat/configs/common/generic/CONFIG_CSD_LOCK_WAIT_DEBUG @@ -0,0 +1 @@ +# CONFIG_CSD_LOCK_WAIT_DEBUG is not set diff --git a/redhat/configs/common/generic/CONFIG_SCF_TORTURE_TEST b/redhat/configs/common/generic/CONFIG_SCF_TORTURE_TEST new file mode 100644 index 000000000000..53ebe3b18974 --- /dev/null +++ b/redhat/configs/common/generic/CONFIG_SCF_TORTURE_TEST @@ -0,0 +1 @@ +# CONFIG_SCF_TORTURE_TEST is not set diff --git a/redhat/configs/pending-common/generic/CONFIG_CSD_LOCK_WAIT_DEBUG b/redhat/configs/pending-common/generic/CONFIG_CSD_LOCK_WAIT_DEBUG deleted file mode 100644 index d2e1af1bda65..000000000000 --- a/redhat/configs/pending-common/generic/CONFIG_CSD_LOCK_WAIT_DEBUG +++ /dev/null @@ -1,19 +0,0 @@ -# CONFIG_CSD_LOCK_WAIT_DEBUG: -# -# This option enables debug prints when CPUs are slow to respond -# to the smp_call_function*() IPI wrappers. These debug prints -# include the IPI handler function currently executing (if any) -# and relevant stack traces. -# -# Symbol: CSD_LOCK_WAIT_DEBUG [=n] -# Type : bool -# Defined at lib/Kconfig.debug:1380 -# Prompt: Debugging for csd_lock_wait(), called from smp_call_function*() -# Depends on: DEBUG_KERNEL [=y] && 64BIT [=y] -# Location: -# -> Kernel hacking -# -> Lock Debugging (spinlocks, mutexes, etc...) -# -# -# -# CONFIG_CSD_LOCK_WAIT_DEBUG is not set diff --git a/redhat/configs/pending-common/generic/CONFIG_SCF_TORTURE_TEST b/redhat/configs/pending-common/generic/CONFIG_SCF_TORTURE_TEST deleted file mode 100644 index d22be82b0415..000000000000 --- a/redhat/configs/pending-common/generic/CONFIG_SCF_TORTURE_TEST +++ /dev/null @@ -1,20 +0,0 @@ -# CONFIG_SCF_TORTURE_TEST: -# -# This option provides a kernel module that runs torture tests -# on the smp_call_function() family of primitives. The kernel -# module may be built after the fact on the running kernel to -# be tested, if desired. -# -# Symbol: SCF_TORTURE_TEST [=n] -# Type : tristate -# Defined at lib/Kconfig.debug:1370 -# Prompt: torture tests for smp_call_function*() -# Depends on: DEBUG_KERNEL [=y] -# Location: -# -> Kernel hacking -# -> Lock Debugging (spinlocks, mutexes, etc...) -# Selects: TORTURE_TEST [=n] -# -# -# -# CONFIG_SCF_TORTURE_TEST is not set
On 10/22/20 8:21 AM, Prarit Bhargava wrote:
On 10/21/20 1:27 PM, GitLab Bridge on behalf of jeremycline wrote:
From: Fedora Kernel Team kernel-team@fedoraproject.org
Hi,
As part of the ongoing rebase effort, the following configuration options need to be reviewed.
As a reminder, the ARK configuration flow involves moving unreviewed configuration options from the pending directory to the ark directory. In the diff below, options are removed from the pending directory and added to the ark hierarchy. The final options that need to be ACKed are the files that are being added to the ark hierarchy.
If the value for a file that is added should be changed, please reply with a better option.
CONFIG_CSD_LOCK_WAIT_DEBUG:
This option enables debug prints when CPUs are slow to respond to the smp_call_function*() IPI wrappers. These debug prints include the IPI handler function currently executing (if any) and relevant stack traces.
Symbol: CSD_LOCK_WAIT_DEBUG [=n] Type : bool Defined at lib/Kconfig.debug:1380 Prompt: Debugging for csd_lock_wait(), called from smp_call_function*() Depends on: DEBUG_KERNEL [=y] && 64BIT [=y] Location: -> Kernel hacking -> Lock Debugging (spinlocks, mutexes, etc...)
longman, should we turn this on in the base kernel?
This option looks useful. However, it depends on what performance impact it has. We probably need to run some test to find out. Let enable only in the debug kernel for now.
CONFIG_SCF_TORTURE_TEST:
This option provides a kernel module that runs torture tests on the smp_call_function() family of primitives. The kernel module may be built after the fact on the running kernel to be tested, if desired.
Symbol: SCF_TORTURE_TEST [=n] Type : tristate Defined at lib/Kconfig.debug:1370 Prompt: torture tests for smp_call_function*() Depends on: DEBUG_KERNEL [=y] Location: -> Kernel hacking -> Lock Debugging (spinlocks, mutexes, etc...) Selects: TORTURE_TEST [=n]
This can be Y for debug kernels.
This can be enabled for both debug and non-debug kernel as long as it is packaged in an internal rpm.
-Longman
From: Fedora Kernel Team kernel-team@fedoraproject.org
[redhat] New configs in lib/Kconfig.debug
Hi,
As part of the ongoing rebase effort, the following configuration options need to be reviewed.
As a reminder, the ARK configuration flow involves moving unreviewed configuration options from the pending directory to the ark directory. In the diff below, options are removed from the pending directory and added to the ark hierarchy. The final options that need to be ACKed are the files that are being added to the ark hierarchy.
If the value for a file that is added should be changed, please reply with a better option.
CONFIG_CSD_LOCK_WAIT_DEBUG:
This option enables debug prints when CPUs are slow to respond to the smp_call_function*() IPI wrappers. These debug prints include the IPI handler function currently executing (if any) and relevant stack traces.
Symbol: CSD_LOCK_WAIT_DEBUG [=n] Type : bool Defined at lib/Kconfig.debug:1380 Prompt: Debugging for csd_lock_wait(), called from smp_call_function*() Depends on: DEBUG_KERNEL [=y] && 64BIT [=y] Location: -> Kernel hacking -> Lock Debugging (spinlocks, mutexes, etc...)
---
CONFIG_SCF_TORTURE_TEST:
This option provides a kernel module that runs torture tests on the smp_call_function() family of primitives. The kernel module may be built after the fact on the running kernel to be tested, if desired.
Symbol: SCF_TORTURE_TEST [=n] Type : tristate Defined at lib/Kconfig.debug:1370 Prompt: torture tests for smp_call_function*() Depends on: DEBUG_KERNEL [=y] Location: -> Kernel hacking -> Lock Debugging (spinlocks, mutexes, etc...) Selects: TORTURE_TEST [=n]
---
Cc: Prarit Bhargava prarit@redhat.com Signed-off-by: Fedora Kernel Team kernel-team@fedoraproject.org
diff a/redhat/configs/common/debug/CONFIG_CSD_LOCK_WAIT_DEBUG b/redhat/configs/common/debug/CONFIG_CSD_LOCK_WAIT_DEBUG --- /dev/null +++ b/redhat/configs/common/debug/CONFIG_CSD_LOCK_WAIT_DEBUG @@ -0,0 +1 @@ +CONFIG_CSD_LOCK_WAIT_DEBUG=y diff a/redhat/configs/common/debug/CONFIG_SCF_TORTURE_TEST b/redhat/configs/common/debug/CONFIG_SCF_TORTURE_TEST --- /dev/null +++ b/redhat/configs/common/debug/CONFIG_SCF_TORTURE_TEST @@ -0,0 +1 @@ +CONFIG_SCF_TORTURE_TEST=y diff a/redhat/configs/pending-common/generic/CONFIG_CSD_LOCK_WAIT_DEBUG b/redhat/configs/pending-common/generic/CONFIG_CSD_LOCK_WAIT_DEBUG --- a/redhat/configs/pending-common/generic/CONFIG_CSD_LOCK_WAIT_DEBUG +++ /dev/null @@ -1,19 +0,0 @@ -# CONFIG_CSD_LOCK_WAIT_DEBUG: -# -# This option enables debug prints when CPUs are slow to respond -# to the smp_call_function*() IPI wrappers. These debug prints -# include the IPI handler function currently executing (if any) -# and relevant stack traces. -# -# Symbol: CSD_LOCK_WAIT_DEBUG [=n] -# Type : bool -# Defined at lib/Kconfig.debug:1380 -# Prompt: Debugging for csd_lock_wait(), called from smp_call_function*() -# Depends on: DEBUG_KERNEL [=y] && 64BIT [=y] -# Location: -# -> Kernel hacking -# -> Lock Debugging (spinlocks, mutexes, etc...) -# -# -# -# CONFIG_CSD_LOCK_WAIT_DEBUG is not set diff a/redhat/configs/pending-common/generic/CONFIG_SCF_TORTURE_TEST b/redhat/configs/pending-common/generic/CONFIG_SCF_TORTURE_TEST --- a/redhat/configs/pending-common/generic/CONFIG_SCF_TORTURE_TEST +++ /dev/null @@ -1,20 +0,0 @@ -# CONFIG_SCF_TORTURE_TEST: -# -# This option provides a kernel module that runs torture tests -# on the smp_call_function() family of primitives. The kernel -# module may be built after the fact on the running kernel to -# be tested, if desired. -# -# Symbol: SCF_TORTURE_TEST [=n] -# Type : tristate -# Defined at lib/Kconfig.debug:1370 -# Prompt: torture tests for smp_call_function*() -# Depends on: DEBUG_KERNEL [=y] -# Location: -# -> Kernel hacking -# -> Lock Debugging (spinlocks, mutexes, etc...) -# Selects: TORTURE_TEST [=n] -# -# -# -# CONFIG_SCF_TORTURE_TEST is not set
-- https://gitlab.com/cki-project/kernel-ark/-/merge_requests/740
From: CKI Bot on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/740#note_49156718...
Hi! This is the friendly CKI test bot.
It appears that you are not a member of redhat/red-hat-ci- tools/kernel/cki-runs/trusted-pipelines. This means that the CI pipeline on your MR will fail. As getting testing is important, I'll be responsible for testing your changes. After every MR change, I'll start a small testing pipeline and link it here so you can follow the results. I'll also create and link a pipeline for hardware testing that the reviewers can start to get extra test coverage.
From: CKI Bot on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/740#note_49156729...
Testing pipeline status: Basic testing pipeline:
https://gitlab.com/redhat/red-hat-ci-tools/kernel/cki- runs/external-pipelines/-/pipelines/245418759 - created :hourglass_flowing_sand:
From: Patrick Talbert on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/740#note_49156863...
Hi Prarit, Longman,
I've updated the MR to enable both these options for debug builds. Please rereview.
Thank you,
Patrick
From: Patrick Talbert on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/740#note_53984786...
Hey Prarit,
This does not build for the debug variant of aarch64 if CONFIG_SCF_TORTURE_TEST=y is set. This is because having CONFIG_SCF_TORTURE_TEST=y enables CONFIG_TORTURE_TEST as a built in while our the existing aarch64 debug config specify it as a module:
``` kernel-ark (configs/2020-10-21/lib/Kconfig.debug)$ make dist-configs make -C redhat dist-configs make[1]: Entering directory '/home/ptalbert/git/gitlab/kernel- ark/redhat' BUILDID is ".test". cd /home/ptalbert/git/gitlab/kernel-ark/redhat/configs; rm -f kernel-*.config \ kernel-*.config.orig \ kernel-*.config.tmp Gathering new log entries since 74937d92fe7907fb2ffbed20493cefb05b231bed MARKER is v5.12-rc4 cd /home/ptalbert/git/gitlab/kernel-ark/redhat/configs; ./build_configs.sh "kernel" "" "" Building /home/ptalbert/git/gitlab/kernel- ark/redhat/configs/kernel-x86_64-rhel.config ... done Building /home/ptalbert/git/gitlab/kernel- ark/redhat/configs/kernel-x86_64-debug-rhel.config ... done Building /home/ptalbert/git/gitlab/kernel-ark/redhat/configs/kernel- ppc64le-rhel.config ... done Building /home/ptalbert/git/gitlab/kernel-ark/redhat/configs/kernel- ppc64le-debug-rhel.config ... done Building /home/ptalbert/git/gitlab/kernel- ark/redhat/configs/kernel-s390x-rhel.config ... done Building /home/ptalbert/git/gitlab/kernel- ark/redhat/configs/kernel-s390x-debug-rhel.config ... done Building /home/ptalbert/git/gitlab/kernel- ark/redhat/configs/kernel-s390x-zfcpdump-rhel.config ... done Building /home/ptalbert/git/gitlab/kernel-ark/redhat/configs/kernel- aarch64-rhel.config ... done Building /home/ptalbert/git/gitlab/kernel-ark/redhat/configs/kernel- aarch64-debug-rhel.config ... done Building /home/ptalbert/git/gitlab/kernel- ark/redhat/configs/kernel-x86_64-fedora.config ... done Building /home/ptalbert/git/gitlab/kernel- ark/redhat/configs/kernel-x86_64-debug-fedora.config ... done Building /home/ptalbert/git/gitlab/kernel- ark/redhat/configs/kernel-i686-fedora.config ... done Building /home/ptalbert/git/gitlab/kernel- ark/redhat/configs/kernel-i686-debug-fedora.config ... done Building /home/ptalbert/git/gitlab/kernel-ark/redhat/configs/kernel- ppc64le-fedora.config ... done Building /home/ptalbert/git/gitlab/kernel-ark/redhat/configs/kernel- ppc64le-debug-fedora.config ... done Building /home/ptalbert/git/gitlab/kernel- ark/redhat/configs/kernel-s390x-fedora.config ... done Building /home/ptalbert/git/gitlab/kernel- ark/redhat/configs/kernel-s390x-debug-fedora.config ... done Building /home/ptalbert/git/gitlab/kernel-ark/redhat/configs/kernel- aarch64-fedora.config ... done Building /home/ptalbert/git/gitlab/kernel-ark/redhat/configs/kernel- aarch64-debug-fedora.config ... done Building /home/ptalbert/git/gitlab/kernel-ark/redhat/configs/kernel- armv7hl-fedora.config ... done Building /home/ptalbert/git/gitlab/kernel-ark/redhat/configs/kernel- armv7hl-debug-fedora.config ... done Building /home/ptalbert/git/gitlab/kernel-ark/redhat/configs/kernel- armv7hl-lpae-fedora.config ... done Building /home/ptalbert/git/gitlab/kernel-ark/redhat/configs/kernel- armv7hl-lpae-debug-fedora.config ... done Processing /home/ptalbert/git/gitlab/kernel- ark/redhat/configs/kernel-5.12.0-aarch64-debug.config ... Error: Mismatches found in configuration files Found CONFIG_TORTURE_TEST=y after generation, had CONFIG_TORTURE_TEST=m in Source tree make[1]: *** [Makefile:135: dist-configs] Error 1 make[1]: Leaving directory '/home/ptalbert/git/gitlab/kernel-ark/redhat' make: *** [makefile:12: dist-configs] Error 2
kernel-ark (configs/2020-10-21/lib/Kconfig.debug)$ grep -nr CONFIG_TORTURE_TEST redhat/configs/ redhat/configs/ark/debug/arm/aarch64/CONFIG_TORTURE_TEST:1:CONFIG_TORTUR E_TEST=m ```
The simple solution to me is to instead set CONFIG_SCF_TORTURE_TEST=m.
Also, I added generic files to turn both options off for the non-debug variants.
Let me know what you think.
Thank you,
Patrick
kernel@lists.fedoraproject.org
-
cki-gitlab＠redhat.com -
GitLab Bridge on behalf of jeremycline
-
Jeremy Cline (via Email Bridge)
-
Patrick Talbert (via Email Bridge)
-
Prarit Bhargava -
Waiman Long