get_option_value() is used to get the value of $1 configured in /etc/kdump.conf. But when we use "get_option_value ssh", it can get the value of "sshkey" instead of "ssh".
Fix the regexp pattern to get an exact match.
Signed-off-by: WANG Chao chaowang@redhat.com --- kdump-lib.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kdump-lib.sh b/kdump-lib.sh index a20c6e8..b9dec21 100755 --- a/kdump-lib.sh +++ b/kdump-lib.sh @@ -109,7 +109,7 @@ get_mntpoint_from_target() # get_option_value <option_name> # retrieves value of option defined in kdump.conf get_option_value() { - echo $(strip_comments `grep ^$1 /etc/kdump.conf | tail -1 | cut -d\ -f2-`) + echo $(strip_comments `grep "^$1[[:space:]]+" /etc/kdump.conf | tail -1 | cut -d\ -f2-`) }
#This function compose a absolute path with the mount
On 10/28/14 at 03:47pm, WANG Chao wrote:
get_option_value() is used to get the value of $1 configured in /etc/kdump.conf. But when we use "get_option_value ssh", it can get the value of "sshkey" instead of "ssh".
Fix the regexp pattern to get an exact match.
Signed-off-by: WANG Chao chaowang@redhat.com
kdump-lib.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kdump-lib.sh b/kdump-lib.sh index a20c6e8..b9dec21 100755 --- a/kdump-lib.sh +++ b/kdump-lib.sh @@ -109,7 +109,7 @@ get_mntpoint_from_target() # get_option_value <option_name> # retrieves value of option defined in kdump.conf get_option_value() {
- echo $(strip_comments `grep ^$1 /etc/kdump.conf | tail -1 | cut -d\ -f2-`)
- echo $(strip_comments `grep "^$1[[:space:]]+" /etc/kdump.conf | tail -1 | cut -d\ -f2-`)
Looks good to me.
Acked-by: Baoquan He bhe@redhat.com
}
#This function compose a absolute path with the mount
1.9.3
kexec mailing list kexec@lists.fedoraproject.org https://lists.fedoraproject.org/mailman/listinfo/kexec