The old name of function get_kdump_conf is confusing. When I took the first glance at if, I thought it's about con fs handling. Especially it's nearby a pile of functions like dump_fs, dump_ro_rotofs.
So make this minor change to remove the confusion.
Signed-off-by: Baoquan He bhe@redaht.com --- kdump-lib-initramfs.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kdump-lib-initramfs.sh b/kdump-lib-initramfs.sh index 57b8304..186da74 100755 --- a/kdump-lib-initramfs.sh +++ b/kdump-lib-initramfs.sh @@ -19,7 +19,7 @@ KDUMP_PRE="" KDUMP_POST="" NEWROOT="/sysroot"
-get_kdump_confs() +get_kdump_conf() { local config_opt config_val
On 12/12/14 at 03:52pm, Baoquan He wrote:
The old name of function get_kdump_conf is confusing. When I took the first glance at if, I thought it's about con fs handling. Especially it's nearby a pile of functions like dump_fs, dump_ro_rotofs.
So make this minor change to remove the confusion.
get_kdump_confs() is used in multiple places. Please also update its callers.
Thanks WANG Chao
Signed-off-by: Baoquan He bhe@redaht.com
kdump-lib-initramfs.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kdump-lib-initramfs.sh b/kdump-lib-initramfs.sh index 57b8304..186da74 100755 --- a/kdump-lib-initramfs.sh +++ b/kdump-lib-initramfs.sh @@ -19,7 +19,7 @@ KDUMP_PRE="" KDUMP_POST="" NEWROOT="/sysroot"
-get_kdump_confs() +get_kdump_conf() { local config_opt config_val
-- 1.9.0
kexec mailing list kexec@lists.fedoraproject.org https://lists.fedoraproject.org/mailman/listinfo/kexec
On 12/15/14 at 02:42pm, WANG Chao wrote:
On 12/12/14 at 03:52pm, Baoquan He wrote:
The old name of function get_kdump_conf is confusing. When I took the first glance at if, I thought it's about con fs handling. Especially it's nearby a pile of functions like dump_fs, dump_ro_rotofs.
So make this minor change to remove the confusion.
get_kdump_confs() is used in multiple places. Please also update its callers.
Yes, exactly. Nack this patch self.
Thanks WANG Chao
Signed-off-by: Baoquan He bhe@redaht.com
kdump-lib-initramfs.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kdump-lib-initramfs.sh b/kdump-lib-initramfs.sh index 57b8304..186da74 100755 --- a/kdump-lib-initramfs.sh +++ b/kdump-lib-initramfs.sh @@ -19,7 +19,7 @@ KDUMP_PRE="" KDUMP_POST="" NEWROOT="/sysroot"
-get_kdump_confs() +get_kdump_conf() { local config_opt config_val
-- 1.9.0
kexec mailing list kexec@lists.fedoraproject.org https://lists.fedoraproject.org/mailman/listinfo/kexec
-
Baoquan He -
WANG Chao