Since user can use ipaddr of a node instead of its hostname, so we need to protect from this case.
Signed-off-by: Pingfan Liu piliu@redhat.com --- kdump.conf | 4 ++-- kdumpctl | 7 +++++++ 2 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/kdump.conf b/kdump.conf index 1e24e1b..cfdaec7 100644 --- a/kdump.conf +++ b/kdump.conf @@ -137,8 +137,8 @@ # # fence_kdump_nodes <node(s)> # - List of cluster node(s), separated by spaces, to send -# fence_kdump notifications to (this option is mandatory to -# enable fence_kdump). +# fence_kdump notifications to. The list should exclude this node itself! +# (this option is mandatory to enable fence_kdump). #
#raw /dev/vg/lv_kdump diff --git a/kdumpctl b/kdumpctl index d43f46b..638c6b6 100755 --- a/kdumpctl +++ b/kdumpctl @@ -1118,6 +1118,7 @@ check_kdump_feasibility() check_fence_kdump_config() { local hostname=`hostname` + local ipaddrs=`hostname -i` local nodes=$(get_option_value "fence_kdump_nodes")
for node in $nodes; do @@ -1125,6 +1126,12 @@ check_fence_kdump_config() echo "Option fence_kdump_nodes cannot contain $hostname" return 1 fi + # node can be ipaddr + echo $ipaddrs | grep $node + if [ $? -eq 0 ]; then + echo "Option fence_kdump_nodes cannot contain $node" + return 1 + fi done
return 0