Resolves: bz1294877
When 'default' is set to 'halt', system will halt if and ONLY if dump fails.
Signed-off-by: Freeman Zhang zhezhang@redhat.com Reported-by: Donald Berry dberry@redhat.com --- kdump.conf | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/kdump.conf b/kdump.conf index 54b581d..1195b38 100644 --- a/kdump.conf +++ b/kdump.conf @@ -98,15 +98,14 @@ # dependent modules will automatically be included. # # default <reboot | halt | poweroff | shell | dump_to_rootfs> -# - Action to preform in case dumping to intended target +# - Action to perform in case dumping to intended target # fails. If no default action is specified, "reboot" # is assumed default. # reboot: If the default action is reboot simply reboot # the system and loose the core that you are # trying to retrieve. # halt: If the default action is halt, then simply -# halt the system after attempting to capture -# a vmcore, regardless of success or failure. +# halt the system after dump failure. # poweroff: The system will be powered down # shell: If the default action is shell, then drop to # an shell session inside the initramfs from
On 2016/05/17 at 16:19, Freeman Zhang wrote:
Resolves: bz1294877
It's not a fedora bug, is that proper if we put it in the fedora patch?
When 'default' is set to 'halt', system will halt if and ONLY if dump fails.
According to the Bugzilla, there are also other typos, like "an shell", "Configures", "preformed", etc. I think it would be nice if we handle them all in one patch.
Regards, Xunlei
Signed-off-by: Freeman Zhang zhezhang@redhat.com Reported-by: Donald Berry dberry@redhat.com
kdump.conf | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/kdump.conf b/kdump.conf index 54b581d..1195b38 100644 --- a/kdump.conf +++ b/kdump.conf @@ -98,15 +98,14 @@ # dependent modules will automatically be included. # # default <reboot | halt | poweroff | shell | dump_to_rootfs> -# - Action to preform in case dumping to intended target +# - Action to perform in case dumping to intended target # fails. If no default action is specified, "reboot" # is assumed default. # reboot: If the default action is reboot simply reboot # the system and loose the core that you are # trying to retrieve. # halt: If the default action is halt, then simply -# halt the system after attempting to capture -# a vmcore, regardless of success or failure. +# halt the system after dump failure. # poweroff: The system will be powered down # shell: If the default action is shell, then drop to # an shell session inside the initramfs from
On 05/19/2016 10:41 AM, Xunlei Pang wrote:
On 2016/05/17 at 16:19, Freeman Zhang wrote:
Resolves: bz1294877
It's not a fedora bug, is that proper if we put it in the fedora patch?
Yeah, my mistake :(
According to the Bugzilla, there are also other typos, like "an shell", "Configures", "preformed", etc. I think it would be nice if we handle them all in one patch.
It's a good idea. I just didn't figure out how should I name the compound patch. And I am told 'each patch should focus on one thing'. My understanding of this might be wrong.
I will remove the 'Resolves' and fix typos, and send again right away.
Thanks Freeman