Hi,
The first patch is a fix to set device down when cleaning it instead of up. The second patch is adding support to set addresses on the bridge interface.
Thanks, Roi
Roi Dayan (2): NetConfigDeviceOvsBridge: set interface down in address cleanup NetConfigDeviceOvsBridge: support set addresses on the bridge interface
lnst/Slave/NetConfigDevice.py | 4 +++- schema-recipe.rng | 3 +++ 2 files changed, 6 insertions(+), 1 deletions(-)
Fixes: 82f606fb169e ("{Net, Nm}ConfigDevice: split up() into up+address_setup") Signed-off-by: Roi Dayan roid@mellanox.com --- lnst/Slave/NetConfigDevice.py | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lnst/Slave/NetConfigDevice.py b/lnst/Slave/NetConfigDevice.py index a668e32..9ffa5e8 100644 --- a/lnst/Slave/NetConfigDevice.py +++ b/lnst/Slave/NetConfigDevice.py @@ -479,7 +479,7 @@ class NetConfigDeviceOvsBridge(NetConfigDeviceGeneric): exec_cmd("ip addr add %s dev %s" % (address, iport["name"]))
def address_cleanup(self): - super(NetConfigDeviceOvsBridge, self).up() + super(NetConfigDeviceOvsBridge, self).down()
int_ports = self._dev_config["ovs_conf"]["internals"] br_name = self._dev_config["name"]
This will allow a type of setup that is being used widely where there is a bridge with uplink port and the local VXLAN tunnel ip is set on the bridge interface instead of directly on the uplink interface. i.e. OpenStack users do this.
Signed-off-by: Roi Dayan roid@mellanox.com --- lnst/Slave/NetConfigDevice.py | 2 ++ schema-recipe.rng | 3 +++ 2 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/lnst/Slave/NetConfigDevice.py b/lnst/Slave/NetConfigDevice.py index 9ffa5e8..cadce06 100644 --- a/lnst/Slave/NetConfigDevice.py +++ b/lnst/Slave/NetConfigDevice.py @@ -470,6 +470,7 @@ class NetConfigDeviceOvsBridge(NetConfigDeviceGeneric):
def address_setup(self): super(NetConfigDeviceOvsBridge, self).up() + super(NetConfigDeviceOvsBridge, self).address_setup()
int_ports = self._dev_config["ovs_conf"]["internals"] br_name = self._dev_config["name"] @@ -480,6 +481,7 @@ class NetConfigDeviceOvsBridge(NetConfigDeviceGeneric):
def address_cleanup(self): super(NetConfigDeviceOvsBridge, self).down() + super(NetConfigDeviceOvsBridge, self).address_cleanup()
int_ports = self._dev_config["ovs_conf"]["internals"] br_name = self._dev_config["name"] diff --git a/schema-recipe.rng b/schema-recipe.rng index ca06eb8..1a40a02 100644 --- a/schema-recipe.rng +++ b/schema-recipe.rng @@ -194,6 +194,9 @@ <optional> <attribute name="netns"/> </optional> + <optional> + <ref name="addresses"/> + </optional>
<interleave> <optional>
On 27/04/2017 14:27, Roi Dayan wrote:
Hi,
The first patch is a fix to set device down when cleaning it instead of up. The second patch is adding support to set addresses on the bridge interface.
Thanks, Roi
Roi Dayan (2): NetConfigDeviceOvsBridge: set interface down in address cleanup NetConfigDeviceOvsBridge: support set addresses on the bridge interface
lnst/Slave/NetConfigDevice.py | 4 +++- schema-recipe.rng | 3 +++ 2 files changed, 6 insertions(+), 1 deletions(-)
Hi,
Any comments about the patches?
Thanks, Roi
On Mon, May 08, 2017 at 01:54:05PM +0300, Roi Dayan wrote:
On 27/04/2017 14:27, Roi Dayan wrote:
Hi,
The first patch is a fix to set device down when cleaning it instead of up. The second patch is adding support to set addresses on the bridge interface.
Thanks, Roi
Roi Dayan (2): NetConfigDeviceOvsBridge: set interface down in address cleanup NetConfigDeviceOvsBridge: support set addresses on the bridge interface
lnst/Slave/NetConfigDevice.py | 4 +++- schema-recipe.rng | 3 +++ 2 files changed, 6 insertions(+), 1 deletions(-)
Hi,
Any comments about the patches?
Thanks, Roi
Again, apologies for the silence.
The patches are simple enough and look ok to me.
Only, we didn't really want to push any more changes to the XML schema AFAIK.
But considering it's a small enough change I can push this if there's no complaints from anyone else...
@Jiri Pirko any comments on this from your side?
-Ondrej
Tue, May 09, 2017 at 09:54:40AM CEST, olichtne@redhat.com wrote:
On Mon, May 08, 2017 at 01:54:05PM +0300, Roi Dayan wrote:
On 27/04/2017 14:27, Roi Dayan wrote:
Hi,
The first patch is a fix to set device down when cleaning it instead of up. The second patch is adding support to set addresses on the bridge interface.
Thanks, Roi
Roi Dayan (2): NetConfigDeviceOvsBridge: set interface down in address cleanup NetConfigDeviceOvsBridge: support set addresses on the bridge interface
lnst/Slave/NetConfigDevice.py | 4 +++- schema-recipe.rng | 3 +++ 2 files changed, 6 insertions(+), 1 deletions(-)
Hi,
Any comments about the patches?
Thanks, Roi
Again, apologies for the silence.
The patches are simple enough and look ok to me.
Only, we didn't really want to push any more changes to the XML schema AFAIK.
But considering it's a small enough change I can push this if there's no complaints from anyone else...
@Jiri Pirko any comments on this from your side?
No, please push this. Thanks.
On 09/05/2017 10:54, Ondrej Lichtner wrote:
On Mon, May 08, 2017 at 01:54:05PM +0300, Roi Dayan wrote:
On 27/04/2017 14:27, Roi Dayan wrote:
Hi,
The first patch is a fix to set device down when cleaning it instead of up. The second patch is adding support to set addresses on the bridge interface.
Thanks, Roi
Roi Dayan (2): NetConfigDeviceOvsBridge: set interface down in address cleanup NetConfigDeviceOvsBridge: support set addresses on the bridge interface
lnst/Slave/NetConfigDevice.py | 4 +++- schema-recipe.rng | 3 +++ 2 files changed, 6 insertions(+), 1 deletions(-)
Hi,
Any comments about the patches?
Thanks, Roi
Again, apologies for the silence.
The patches are simple enough and look ok to me.
Only, we didn't really want to push any more changes to the XML schema AFAIK.
But considering it's a small enough change I can push this if there's no complaints from anyone else...
@Jiri Pirko any comments on this from your side?
-Ondrej
thanks! I'll start checking the python recipes as well to stay in sync.
On Mon, May 08, 2017 at 01:54:05PM +0300, Roi Dayan wrote:
On 27/04/2017 14:27, Roi Dayan wrote:
Hi,
The first patch is a fix to set device down when cleaning it instead of up. The second patch is adding support to set addresses on the bridge interface.
Thanks, Roi
Roi Dayan (2): NetConfigDeviceOvsBridge: set interface down in address cleanup NetConfigDeviceOvsBridge: support set addresses on the bridge interface
lnst/Slave/NetConfigDevice.py | 4 +++- schema-recipe.rng | 3 +++ 2 files changed, 6 insertions(+), 1 deletions(-)
Hi,
Any comments about the patches?
Thanks, Roi
pushed, thanks
-Ondrej
lnst-developers@lists.fedorahosted.org
-
Jiri Pirko -
Ondrej Lichtner -
Roi Dayan