[PATCH] SimpleMacsecRecipe.py: Fixed issue with not hw_config not being defined - Added parent method call in apply_sub_configurations/remove_sub_configurations - Also removed check for perf_reverse params that was causing an error and isnt needed anymore.
From: Perry Gagne pgagne@redhat.com
Signed-off-by: Perry Gagne pgagne@redhat.com --- lnst/Recipes/ENRT/SimpleMacsecRecipe.py | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/lnst/Recipes/ENRT/SimpleMacsecRecipe.py b/lnst/Recipes/ENRT/SimpleMacsecRecipe.py index 92926b0..fded0e6 100644 --- a/lnst/Recipes/ENRT/SimpleMacsecRecipe.py +++ b/lnst/Recipes/ENRT/SimpleMacsecRecipe.py @@ -39,12 +39,6 @@ class SimpleMacsecRecipe(CommonHWSubConfigMixin, BaseEnrtRecipe):
self.wait_tentative_ips(configuration.test_wide_devices)
- if (self.params.ping_parallel or self.params.ping_bidirect or - self.params.perf_reverse): - logging.debug("Parallel pings or reverse perf tests are " - "not supported for this recipe, ping_parallel" - "/ping_bidirect/perf_reverse will be ignored.") - configuration.endpoint1 = host1.eth0 configuration.endpoint2 = host2.eth0 configuration.host1 = host1 @@ -80,6 +74,7 @@ class SimpleMacsecRecipe(CommonHWSubConfigMixin, BaseEnrtRecipe): yield new_config
def apply_sub_configuration(self, config): + super().apply_sub_configuration(config) if not config.encrypt: config.endpoint1.up() config.endpoint2.up() @@ -119,6 +114,7 @@ class SimpleMacsecRecipe(CommonHWSubConfigMixin, BaseEnrtRecipe): del host.msec0 config.endpoint1.down() config.endpoint2.down() + super().remove_sub_configuration(config)
def generate_ping_configurations(self, config): if not config.encrypt:
Hmm seems i forgot to add an extra line break here, let me try to resubmit
On Thu, Jun 18, 2020 at 12:01 PM pgagne@redhat.com wrote:
From: Perry Gagne pgagne@redhat.com
Signed-off-by: Perry Gagne pgagne@redhat.com
lnst/Recipes/ENRT/SimpleMacsecRecipe.py | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/lnst/Recipes/ENRT/SimpleMacsecRecipe.py b/lnst/Recipes/ENRT/SimpleMacsecRecipe.py index 92926b0..fded0e6 100644 --- a/lnst/Recipes/ENRT/SimpleMacsecRecipe.py +++ b/lnst/Recipes/ENRT/SimpleMacsecRecipe.py @@ -39,12 +39,6 @@ class SimpleMacsecRecipe(CommonHWSubConfigMixin, BaseEnrtRecipe):
self.wait_tentative_ips(configuration.test_wide_devices)
if (self.params.ping_parallel or self.params.ping_bidirect orself.params.perf_reverse):logging.debug("Parallel pings or reverse perf tests are ""not supported for this recipe, ping_parallel""/ping_bidirect/perf_reverse will be ignored.")configuration.endpoint1 = host1.eth0 configuration.endpoint2 = host2.eth0 configuration.host1 = host1@@ -80,6 +74,7 @@ class SimpleMacsecRecipe(CommonHWSubConfigMixin, BaseEnrtRecipe): yield new_config
def apply_sub_configuration(self, config):
super().apply_sub_configuration(config) if not config.encrypt: config.endpoint1.up() config.endpoint2.up()@@ -119,6 +114,7 @@ class SimpleMacsecRecipe(CommonHWSubConfigMixin, BaseEnrtRecipe): del host.msec0 config.endpoint1.down() config.endpoint2.down()
super().remove_sub_configuration(config)def generate_ping_configurations(self, config): if not config.encrypt:
-- 2.26.2
The patch is fine, but fix your subject - you put in the entire commit message into the header again...
-Ondrej
On Thu, Jun 18, 2020 at 12:01:45PM -0400, pgagne@redhat.com wrote:
From: Perry Gagne pgagne@redhat.com
Signed-off-by: Perry Gagne pgagne@redhat.com
lnst/Recipes/ENRT/SimpleMacsecRecipe.py | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/lnst/Recipes/ENRT/SimpleMacsecRecipe.py b/lnst/Recipes/ENRT/SimpleMacsecRecipe.py index 92926b0..fded0e6 100644 --- a/lnst/Recipes/ENRT/SimpleMacsecRecipe.py +++ b/lnst/Recipes/ENRT/SimpleMacsecRecipe.py @@ -39,12 +39,6 @@ class SimpleMacsecRecipe(CommonHWSubConfigMixin, BaseEnrtRecipe):
self.wait_tentative_ips(configuration.test_wide_devices)
if (self.params.ping_parallel or self.params.ping_bidirect orself.params.perf_reverse):logging.debug("Parallel pings or reverse perf tests are ""not supported for this recipe, ping_parallel""/ping_bidirect/perf_reverse will be ignored.")configuration.endpoint1 = host1.eth0 configuration.endpoint2 = host2.eth0 configuration.host1 = host1@@ -80,6 +74,7 @@ class SimpleMacsecRecipe(CommonHWSubConfigMixin, BaseEnrtRecipe): yield new_config
def apply_sub_configuration(self, config):
super().apply_sub_configuration(config) if not config.encrypt: config.endpoint1.up() config.endpoint2.up()@@ -119,6 +114,7 @@ class SimpleMacsecRecipe(CommonHWSubConfigMixin, BaseEnrtRecipe): del host.msec0 config.endpoint1.down() config.endpoint2.down()
super().remove_sub_configuration(config)def generate_ping_configurations(self, config): if not config.encrypt:
-- 2.26.2 _______________________________________________ LNST-developers mailing list -- lnst-developers@lists.fedorahosted.org To unsubscribe send an email to lnst-developers-leave@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/lnst-developers@lists.fedorahos...
Yeah thats what i meant, i forgot to add a second line break after the first. Resent as "[PATCH] SimpleMacsecRecipe.py: Fixed issue causing undefined hw_config"
On Thu, Jun 18, 2020 at 12:31 PM Ondrej Lichtner olichtne@redhat.com wrote:
The patch is fine, but fix your subject - you put in the entire commit message into the header again...
-Ondrej
On Thu, Jun 18, 2020 at 12:01:45PM -0400, pgagne@redhat.com wrote:
From: Perry Gagne pgagne@redhat.com
Signed-off-by: Perry Gagne pgagne@redhat.com
lnst/Recipes/ENRT/SimpleMacsecRecipe.py | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/lnst/Recipes/ENRT/SimpleMacsecRecipe.py
b/lnst/Recipes/ENRT/SimpleMacsecRecipe.py
index 92926b0..fded0e6 100644 --- a/lnst/Recipes/ENRT/SimpleMacsecRecipe.py +++ b/lnst/Recipes/ENRT/SimpleMacsecRecipe.py @@ -39,12 +39,6 @@ class SimpleMacsecRecipe(CommonHWSubConfigMixin,
BaseEnrtRecipe):
self.wait_tentative_ips(configuration.test_wide_devices)
if (self.params.ping_parallel or self.params.ping_bidirect orself.params.perf_reverse):logging.debug("Parallel pings or reverse perf tests are ""not supported for this recipe, ping_parallel""/ping_bidirect/perf_reverse will beignored.")
configuration.endpoint1 = host1.eth0 configuration.endpoint2 = host2.eth0 configuration.host1 = host1@@ -80,6 +74,7 @@ class SimpleMacsecRecipe(CommonHWSubConfigMixin,
BaseEnrtRecipe):
yield new_config def apply_sub_configuration(self, config):
super().apply_sub_configuration(config) if not config.encrypt: config.endpoint1.up() config.endpoint2.up()@@ -119,6 +114,7 @@ class SimpleMacsecRecipe(CommonHWSubConfigMixin,
BaseEnrtRecipe):
del host.msec0 config.endpoint1.down() config.endpoint2.down()
super().remove_sub_configuration(config)def generate_ping_configurations(self, config): if not config.encrypt:
-- 2.26.2 _______________________________________________ LNST-developers mailing list -- lnst-developers@lists.fedorahosted.org To unsubscribe send an email to
lnst-developers-leave@lists.fedorahosted.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives:
https://lists.fedorahosted.org/archives/list/lnst-developers@lists.fedorahos...
lnst-developers@lists.fedorahosted.org
-
Ondrej Lichtner -
Perry Gagne -
pgagne＠redhat.com