[PATCH] Recipes.ENRT.ConfigMixins.BaseHWConfigMixin: do not initialize config if dev_list is empty - LNST-developers - Fedora mailing-lists

12 Oct 2020

If a specific config mixin's dev_list property is left unset, the mixin's description
would be silently discarded. In such cases the mixin should report that configuration
of the feature has been skipped. That should be similar to the case when the parameter
controlling the mixin is not specified.
Fixes issue 199
Signed-off-by: Jan Tluka jtluka@redhat.com
---
 lnst/Recipes/ENRT/ConfigMixins/BaseHWConfigMixin.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/lnst/Recipes/ENRT/ConfigMixins/BaseHWConfigMixin.py b/lnst/Recipes/ENRT/ConfigMixins/BaseHWConfigMixin.py
index c860291c..6fce028d 100644
--- a/lnst/Recipes/ENRT/ConfigMixins/BaseHWConfigMixin.py
+++ b/lnst/Recipes/ENRT/ConfigMixins/BaseHWConfigMixin.py
@@ -10,7 +10,9 @@ class BaseHWConfigMixin(object):
def _configure_dev_attribute(self, config, dev_list, attr_name, value):
         hw_config = config.hw_config
-        attr_cfg = hw_config[attr_name + "_configuration"] = {}
+        if len(dev_list) > 0:
+            attr_cfg = hw_config[attr_name + "_configuration"] = {}
+
         for dev in dev_list:
             attr_cfg[dev] = {}
             attr_cfg[dev]["original"] = getattr(dev, attr_name)
-- 
2.21.3

    