Few recipes had incorrect devices selected for IRQ pinning.
Recipe vxlan_multicast included some of the tap devices. As these do not have any IRQ assigned it does not make sense to do the pinning on them.
Recipe novirt_ovs_vxlan selected ovs internal devices instead of physical devices. This impacts the performance testing.
v2: use get_interface instead of get_device method
Signed-off-by: Jan Tluka jtluka@redhat.com --- recipes/regression_tests/phase3/novirt_ovs_vxlan.py | 5 ++++- recipes/regression_tests/phase3/vxlan_multicast.py | 4 +--- 2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/recipes/regression_tests/phase3/novirt_ovs_vxlan.py b/recipes/regression_tests/phase3/novirt_ovs_vxlan.py index 7b4d1ec..02e5dcc 100644 --- a/recipes/regression_tests/phase3/novirt_ovs_vxlan.py +++ b/recipes/regression_tests/phase3/novirt_ovs_vxlan.py @@ -53,8 +53,11 @@ if nperf_cpupin: h1.run("service irqbalance stop") h2.run("service irqbalance stop")
+ h1_phy = h1.get_interface("if1") + h2_phy = h2.get_interface("if1") + # this will pin devices irqs to cpu #0 - for m, d in [(h1, h1_nic), (h2, h2_nic)]: + for m, d in [(h1, h1_phy), (h2, h2_phy)]: pin_dev_irqs(m, d, 0)
nperf_opts = "" diff --git a/recipes/regression_tests/phase3/vxlan_multicast.py b/recipes/regression_tests/phase3/vxlan_multicast.py index d4c18ee..e31bd6b 100644 --- a/recipes/regression_tests/phase3/vxlan_multicast.py +++ b/recipes/regression_tests/phase3/vxlan_multicast.py @@ -57,10 +57,8 @@ if nperf_cpupin: g1.run("service irqbalance stop")
m1_phy1 = m1.get_interface("eth1") - m1_phy2 = m1.get_interface("tap1") m2_phy1 = m2.get_interface("eth1") - g1_phy1 = g1.get_interface("eth1") - dev_list = [(m1, m1_phy1), (m1, m1_phy2), (m2, m2_phy1), (g1, g1_phy1)] + dev_list = [(m1, m1_phy1), (m2, m2_phy1)]
# this will pin devices irqs to cpu #0 for m, d in dev_list:
Wed, Apr 19, 2017 at 02:59:11PM CEST, jtluka@redhat.com wrote:
Few recipes had incorrect devices selected for IRQ pinning.
Recipe vxlan_multicast included some of the tap devices. As these do not have any IRQ assigned it does not make sense to do the pinning on them.
Recipe novirt_ovs_vxlan selected ovs internal devices instead of physical devices. This impacts the performance testing.
v2: use get_interface instead of get_device method
Signed-off-by: Jan Tluka jtluka@redhat.com
I pushed this patch.
-Jan
lnst-developers@lists.fedorahosted.org