Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2024
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
List overview
Download
lvm2-commits
December 2012
----- 2024 -----
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
lvm2-commits@lists.fedorahosted.org
5 participants
64 discussions
Start a n
N
ew thread
master - thin: add detach_pool_metadata_lv
by Zdenek Kabelac
02 Dec '12
02 Dec '12
Gitweb:
http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=6987a353de9476c5…
Commit: 6987a353de9476c57831fdcf9cccb5d80e4f505b Parent: c5e2f08cf9134ebf2d377ad050a707c0268d1444 Author: Zdenek Kabelac <zkabelac(a)redhat.com> AuthorDate: Sun Dec 2 01:28:51 2012 +0100 Committer: Zdenek Kabelac <zkabelac(a)redhat.com> CommitterDate: Sun Dec 2 17:56:29 2012 +0100 thin: add detach_pool_metadata_lv Add internal function detach_pool_metadata_lv(). --- WHATS_NEW | 1 + lib/metadata/metadata.h | 2 ++ lib/metadata/thin_manip.c | 18 ++++++++++++++++++ 3 files changed, 21 insertions(+), 0 deletions(-) diff --git a/WHATS_NEW b/WHATS_NEW index 43bdb0e..be2ebea 100644 --- a/WHATS_NEW +++ b/WHATS_NEW @@ -1,5 +1,6 @@ Version 2.02.99 - =================================== + Implement internal function detach_pool_metadata_lv(). Fix lvm2app to return all property sizes in bytes. Recognize DM_DISABLE_UDEV environment variable for a complete fallback. Do not verify udev operations if --noudevsync command option is used. diff --git a/lib/metadata/metadata.h b/lib/metadata/metadata.h index 7bc7eaf..19bf742 100644 --- a/lib/metadata/metadata.h +++ b/lib/metadata/metadata.h @@ -460,6 +460,8 @@ int fixup_imported_mirrors(struct volume_group *vg); */ int attach_pool_metadata_lv(struct lv_segment *pool_seg, struct logical_volume *pool_metadata_lv); +int detach_pool_metadata_lv(struct lv_segment *pool_seg, + struct logical_volume **pool_metadata_lv); int attach_pool_data_lv(struct lv_segment *pool_seg, struct logical_volume *pool_data_lv); int attach_pool_lv(struct lv_segment *seg, struct logical_volume *pool_lv, diff --git a/lib/metadata/thin_manip.c b/lib/metadata/thin_manip.c index e7e96df..e2762a0 100644 --- a/lib/metadata/thin_manip.c +++ b/lib/metadata/thin_manip.c @@ -30,6 +30,24 @@ int attach_pool_metadata_lv(struct lv_segment *pool_seg, struct logical_volume * return add_seg_to_segs_using_this_lv(metadata_lv, pool_seg); } +int detach_pool_metadata_lv(struct lv_segment *pool_seg, struct logical_volume **metadata_lv) +{ + struct logical_volume *lv = pool_seg->metadata_lv; + + if (!lv || !lv_is_thin_pool_metadata(lv) || + !remove_seg_from_segs_using_this_lv(lv, pool_seg)) { + log_error(INTERNAL_ERROR "LV %s is invalid thin pool.", pool_seg->lv->name); + return 0; + } + + lv_set_visible(lv); + lv->status &= ~THIN_POOL_METADATA; + *metadata_lv = lv; + pool_seg->metadata_lv = NULL; + + return 1; +} + int attach_pool_data_lv(struct lv_segment *pool_seg, struct logical_volume *pool_data_lv) { if (!set_lv_segment_area_lv(pool_seg, 0, pool_data_lv, 0, THIN_POOL_DATA))
1
0
0
0
master - tests: add error_dev aux
by Zdenek Kabelac
02 Dec '12
02 Dec '12
Gitweb:
http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=c5e2f08cf9134ebf…
Commit: c5e2f08cf9134ebf2d377ad050a707c0268d1444 Parent: 0dc6ba8309300b576f56e28dc71fba760b3e52df Author: Zdenek Kabelac <zkabelac(a)redhat.com> AuthorDate: Sat Dec 1 17:09:18 2012 +0100 Committer: Zdenek Kabelac <zkabelac(a)redhat.com> CommitterDate: Sun Dec 2 17:55:49 2012 +0100 tests: add error_dev aux Aux function to replace PV with specifically damaged device. Usage: aux error_dev "$dev1" 8:32 96:8 Replaces from 8 sector 32 error 512b sectors and from 96 sector next 8 sectors will fail on rw. Rest of device is preserved. For testing: dd if="$dev1" of=x bs=512 count=104 conv=sync,noerror iflag=direct --- test/lib/aux.sh | 47 +++++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 47 insertions(+), 0 deletions(-) diff --git a/test/lib/aux.sh b/test/lib/aux.sh index e3dfdd9..d500b37 100644 --- a/test/lib/aux.sh +++ b/test/lib/aux.sh @@ -371,6 +371,53 @@ enable_dev() { finish_udev_transaction } +# +# Convert device to device with errors +# Takes the list of pairs of error segment from:len +# Original device table is replace with multiple lines +# i.e. error_dev "$dev1" 8:32 96:8 +error_dev() { + local dev=$1 + local name=$(echo "$dev" | sed -e 's,.*/,,') + local fromlen + local pos + local size + local type + local pvdev + local offset + + read pos size type pvdev offset < $name.table + + shift + rm -f $name.errtable + for fromlen in "$@"; do + from=${fromlen%%:*} + len=${fromlen##*:} + diff=$(($from - $pos)) + if test $diff -gt 0 ; then + echo "$pos $diff $type $pvdev $(($pos + $offset))" >>$name.errtable + pos=$(($pos + $diff)) + elif test $diff -lt 0 ; then + die "Position error" + fi + echo "$from $len error" >>$name.errtable + pos=$(($pos + $len)) + done + diff=$(($size - $pos)) + test $diff -gt 0 && echo "$pos $diff $type $pvdev $(($pos + $offset))" >>$name.errtable + + init_udev_transaction + if dmsetup table $name ; then + dmsetup load "$name" "$name.errtable" + else + dmsetup create -u "TEST-$name" "$name" "$name.errtable" + fi + # using device name (since device path does not exists yet with udev) + notify_lvmetad "$dev" + dmsetup resume "$name" + finish_udev_transaction +} + backup_dev() { local dev
1
0
0
0
master - tests: resume devices on background
by Zdenek Kabelac
02 Dec '12
02 Dec '12
Gitweb:
http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=0dc6ba8309300b57…
Commit: 0dc6ba8309300b576f56e28dc71fba760b3e52df Parent: 9ec474f38aac948a3fb2cb572af9a756b0ac585d Author: Zdenek Kabelac <zkabelac(a)redhat.com> AuthorDate: Thu Nov 29 17:39:36 2012 +0100 Committer: Zdenek Kabelac <zkabelac(a)redhat.com> CommitterDate: Sun Dec 2 17:55:49 2012 +0100 tests: resume devices on background Since some devices may need correct order of their resuming, resume then all on background and wait for finish. --- test/lib/aux.sh | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/test/lib/aux.sh b/test/lib/aux.sh index 7c0c189..e3dfdd9 100644 --- a/test/lib/aux.sh +++ b/test/lib/aux.sh @@ -98,9 +98,11 @@ teardown_devs_prefixed() { # Resume suspended devices first for dm in $(dm_info suspended,name | grep "^Suspended:.*$prefix"); do echo "dmsetup resume \"${dm#Suspended:}\"" - dmsetup resume "${dm#Suspended:}" || true + dmsetup resume "${dm#Suspended:}" & done + wait + local mounts=( $(grep "$prefix" /proc/mounts | cut -d' ' -f1) ) if test ${#mounts[@]} -gt 0; then test "$stray" -eq 0 || echo "Removing stray mounted devices containing $prefix: ${mounts[@]}"
1
0
0
0
master - lvm2api: fix size reporting
by Zdenek Kabelac
02 Dec '12
02 Dec '12
Gitweb:
http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=9ec474f38aac948a…
Commit: 9ec474f38aac948a3fb2cb572af9a756b0ac585d Parent: 83978cdec8aa6f6b6af2cb8937d64cc16b88cf18 Author: Zdenek Kabelac <zkabelac(a)redhat.com> AuthorDate: Thu Nov 29 10:29:03 2012 +0100 Committer: Zdenek Kabelac <zkabelac(a)redhat.com> CommitterDate: Sun Dec 2 17:55:08 2012 +0100 lvm2api: fix size reporting API is reporting all sizes as 64bit integers in bytes. Fix at those places, where sectors were returned to remain consistent. --- WHATS_NEW | 3 ++- lib/report/properties.c | 20 ++++++++++---------- 2 files changed, 12 insertions(+), 11 deletions(-) diff --git a/WHATS_NEW b/WHATS_NEW index ca1b539..43bdb0e 100644 --- a/WHATS_NEW +++ b/WHATS_NEW @@ -1,8 +1,9 @@ Version 2.02.99 - =================================== + Fix lvm2app to return all property sizes in bytes. Recognize DM_DISABLE_UDEV environment variable for a complete fallback. Do not verify udev operations if --noudevsync command option is used. - Fix lvm2api and return lvseg discards property as string. + Fix lvm2app and return lvseg discards property as string. Allow forced vgcfgrestore of lvm2 metadata with thin volumes. Recognise STEC skd devices in filter. Recognise Violin Memory vtms devices in filter. diff --git a/lib/report/properties.c b/lib/report/properties.c index 0cd39ba..6a4d960 100644 --- a/lib/report/properties.c +++ b/lib/report/properties.c @@ -183,7 +183,7 @@ GET_LV_NUM_PROPERTY_FN(seg_count, dm_list_size(&lv->segments)) #define _seg_count_set _not_implemented_set GET_LV_STR_PROPERTY_FN(origin, lv_origin_dup(lv->vg->vgmem, lv)) #define _origin_set _not_implemented_set -GET_LV_NUM_PROPERTY_FN(origin_size, lv_origin_size(lv)) +GET_LV_NUM_PROPERTY_FN(origin_size, (SECTOR_SIZE * lv_origin_size(lv))) #define _origin_size_set _not_implemented_set GET_LV_NUM_PROPERTY_FN(snap_percent, _snap_percent(lv)) #define _snap_percent_set _not_implemented_set @@ -233,7 +233,7 @@ GET_VG_NUM_PROPERTY_FN(vg_free, (SECTOR_SIZE * vg_free(vg))) #define _vg_free_set _not_implemented_set GET_VG_STR_PROPERTY_FN(vg_sysid, vg_system_id_dup(vg)) #define _vg_sysid_set _not_implemented_set -GET_VG_NUM_PROPERTY_FN(vg_extent_size, vg->extent_size) +GET_VG_NUM_PROPERTY_FN(vg_extent_size, (SECTOR_SIZE * vg->extent_size)) #define _vg_extent_size_set _not_implemented_set GET_VG_NUM_PROPERTY_FN(vg_extent_count, vg->extent_count) #define _vg_extent_count_set _not_implemented_set @@ -269,17 +269,17 @@ GET_LVSEG_STR_PROPERTY_FN(segtype, lvseg_segtype_dup(lvseg->lv->vg->vgmem, lvseg #define _segtype_set _not_implemented_set GET_LVSEG_NUM_PROPERTY_FN(stripes, lvseg->area_count) #define _stripes_set _not_implemented_set -GET_LVSEG_NUM_PROPERTY_FN(stripesize, lvseg->stripe_size) +GET_LVSEG_NUM_PROPERTY_FN(stripesize, (SECTOR_SIZE * lvseg->stripe_size)) #define _stripesize_set _not_implemented_set -GET_LVSEG_NUM_PROPERTY_FN(stripe_size, lvseg->stripe_size) +GET_LVSEG_NUM_PROPERTY_FN(stripe_size, (SECTOR_SIZE * lvseg->stripe_size)) #define _stripe_size_set _not_implemented_set -GET_LVSEG_NUM_PROPERTY_FN(regionsize, lvseg->region_size) +GET_LVSEG_NUM_PROPERTY_FN(regionsize, (SECTOR_SIZE * lvseg->region_size)) #define _regionsize_set _not_implemented_set -GET_LVSEG_NUM_PROPERTY_FN(region_size, lvseg->region_size) +GET_LVSEG_NUM_PROPERTY_FN(region_size, (SECTOR_SIZE * lvseg->region_size)) #define _region_size_set _not_implemented_set -GET_LVSEG_NUM_PROPERTY_FN(chunksize, lvseg_chunksize(lvseg)) +GET_LVSEG_NUM_PROPERTY_FN(chunksize, (SECTOR_SIZE * lvseg_chunksize(lvseg))) #define _chunksize_set _not_implemented_set -GET_LVSEG_NUM_PROPERTY_FN(chunk_size, lvseg_chunksize(lvseg)) +GET_LVSEG_NUM_PROPERTY_FN(chunk_size, (SECTOR_SIZE * lvseg_chunksize(lvseg))) #define _chunk_size_set _not_implemented_set GET_LVSEG_NUM_PROPERTY_FN(thin_count, dm_list_size(&lvseg->lv->segs_using_this_lv)) #define _thin_count_set _not_implemented_set @@ -289,7 +289,7 @@ GET_LVSEG_NUM_PROPERTY_FN(transaction_id, lvseg->transaction_id) #define _transaction_id_set _not_implemented_set GET_LVSEG_STR_PROPERTY_FN(discards, lvseg_discards_dup(lvseg->lv->vg->vgmem, lvseg)) #define _discards_set _not_implemented_set -GET_LVSEG_NUM_PROPERTY_FN(seg_start, lvseg_start(lvseg)) +GET_LVSEG_NUM_PROPERTY_FN(seg_start, (SECTOR_SIZE * lvseg_start(lvseg))) #define _seg_start_set _not_implemented_set GET_LVSEG_NUM_PROPERTY_FN(seg_start_pe, lvseg->le) #define _seg_start_pe_set _not_implemented_set @@ -307,7 +307,7 @@ GET_LVSEG_STR_PROPERTY_FN(devices, lvseg_devices(lvseg->lv->vg->vgmem, lvseg)) /* PVSEG */ GET_PVSEG_NUM_PROPERTY_FN(pvseg_start, pvseg->pe) #define _pvseg_start_set _not_implemented_set -GET_PVSEG_NUM_PROPERTY_FN(pvseg_size, pvseg->len) +GET_PVSEG_NUM_PROPERTY_FN(pvseg_size, (SECTOR_SIZE * pvseg->len)) #define _pvseg_size_set _not_implemented_set
1
0
0
0
← Newer
1
2
3
4
5
6
7
Older →
Jump to page:
1
2
3
4
5
6
7
Results per page:
10
25
50
100
200