lvm2-commits July 2012

lvm2-commits@lists.fedorahosted.org

5 participants
42 discussions

master - TEST (lvconvert-raid): localize a function variable
by Jonathan Brassow 03 Jul '12

03 Jul '12

Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=7168880caa5f09da… Commit: 7168880caa5f09da254e930313c2d59547643bb2 Parent: 149ab6921e9029e12899c280f290656b1b60742f Author: Jonathan Brassow <jbrassow(a)redhat.com> AuthorDate: Mon Jun 25 22:25:46 2012 -0500 Committer: Jonathan Brassow <jbrassow(a)redhat.com> CommitterDate: Mon Jun 25 22:25:46 2012 -0500 TEST (lvconvert-raid): localize a function variable Function was overwriting a global variable because it used a variable of the same name without first declaring it with 'local'. --- test/shell/lvconvert-raid.sh | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/test/shell/lvconvert-raid.sh b/test/shell/lvconvert-raid.sh index e7df164..6c289a8 100644 --- a/test/shell/lvconvert-raid.sh +++ b/test/shell/lvconvert-raid.sh @@ -60,6 +60,7 @@ is_in_sync_() { # wait_for_sync <VG/LV> wait_for_sync_() { + local i for i in {1..100} ; do is_in_sync_ $1 && return sleep 1

1 0

master - TEST (lvcreate-raid): Allow more time for RAID arrays to sync
by Jonathan Brassow 03 Jul '12

03 Jul '12

Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=149ab6921e9029e1… Commit: 149ab6921e9029e12899c280f290656b1b60742f Parent: 1d0a2b919fe173e3a25e5f19d535588bb5b214e2 Author: Jonathan Brassow <jbrassow(a)redhat.com> AuthorDate: Mon Jun 25 22:20:24 2012 -0500 Committer: Jonathan Brassow <jbrassow(a)redhat.com> CommitterDate: Mon Jun 25 22:20:24 2012 -0500 TEST (lvcreate-raid): Allow more time for RAID arrays to sync My machines can run very slow sometimes causing this test to fail when it would otherwise have succeeded given more time. --- test/shell/lvcreate-raid.sh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/test/shell/lvcreate-raid.sh b/test/shell/lvcreate-raid.sh index 21ab9a1..b6792c5 100644 --- a/test/shell/lvcreate-raid.sh +++ b/test/shell/lvcreate-raid.sh @@ -41,7 +41,7 @@ function wait_for_raid_sync() local i=0 while ! is_raid_in_sync $1; do - sleep .2 + sleep 1 i=$(($i + 1)) if [ $i -gt 500 ]; then echo "Sync is taking too long - assume stuck"

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

lvm2-commits July 2012