lvm2-commits August 2012

lvm2-commits@lists.fedorahosted.org

6 participants
73 discussions

master - lvmetad: do not deref NULL pointer
by Zdenek Kabelac 23 Aug '12

23 Aug '12

Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=ed53b4b674097341… Commit: ed53b4b6740973411acee52a31fca9c48c585dab Parent: 3685701529e0d25a17a7fd7874e276fc441cad7c Author: Zdenek Kabelac <zkabelac(a)redhat.com> AuthorDate: Thu Aug 23 11:01:00 2012 +0200 Committer: Zdenek Kabelac <zkabelac(a)redhat.com> CommitterDate: Thu Aug 23 14:34:54 2012 +0200 lvmetad: do not deref NULL pointer Call log only for req.cft != NULL. --- WHATS_NEW | 1 + libdaemon/server/daemon-server.c | 4 +++- 2 files changed, 4 insertions(+), 1 deletions(-) diff --git a/WHATS_NEW b/WHATS_NEW index dc3b29e..1dcc5c2 100644 --- a/WHATS_NEW +++ b/WHATS_NEW @@ -1,5 +1,6 @@ Version 2.02.98 ================================= + Fix dereference of NULL in lvmetad error path logging. Fix buffer memory leak in lvmetad logging. Use 'ignore' discards for thin metadata created with older versions. Use proper condition to check for unsupported discards settings. diff --git a/libdaemon/server/daemon-server.c b/libdaemon/server/daemon-server.c index 27a3a05..df75ac7 100644 --- a/libdaemon/server/daemon-server.c +++ b/libdaemon/server/daemon-server.c @@ -389,10 +389,12 @@ static void *client_thread(void *baton) goto fail; req.cft = dm_config_from_string(req.buffer); + if (!req.cft) fprintf(stderr, "error parsing request:\n %s\n", req.buffer); + else + daemon_log_cft(b->s.log, DAEMON_LOG_WIRE, "<- ", req.cft->root); - daemon_log_cft(b->s.log, DAEMON_LOG_WIRE, "<- ", req.cft->root); res = builtin_handler(b->s, b->client, req); if (res.error == EPROTO) /* Not a builtin, delegate to the custom handler. */

1 0

master - lvmetad: fix memleak on error path
by Zdenek Kabelac 23 Aug '12

23 Aug '12

Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=3685701529e0d25a… Commit: 3685701529e0d25a17a7fd7874e276fc441cad7c Parent: 8edc0e450da2c0959c44da4811901782cc399649 Author: Zdenek Kabelac <zkabelac(a)redhat.com> AuthorDate: Thu Aug 23 11:00:02 2012 +0200 Committer: Zdenek Kabelac <zkabelac(a)redhat.com> CommitterDate: Thu Aug 23 14:33:27 2012 +0200 lvmetad: fix memleak on error path Release allocated buffer on error path. --- libdaemon/server/daemon-server.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/libdaemon/server/daemon-server.c b/libdaemon/server/daemon-server.c index c69da36..27a3a05 100644 --- a/libdaemon/server/daemon-server.c +++ b/libdaemon/server/daemon-server.c @@ -400,8 +400,10 @@ static void *client_thread(void *baton) if (!res.buffer) { dm_config_write_node(res.cft->root, buffer_line, &res); - if (!buffer_rewrite(&res.buffer, "%s\n\n", NULL)) + if (!buffer_rewrite(&res.buffer, "%s\n\n", NULL)) { + dm_free(req.buffer); goto fail; + } dm_config_destroy(res.cft); }

1 0

master - lvmetad: fix memleaks
by Zdenek Kabelac 23 Aug '12

23 Aug '12

Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=8edc0e450da2c095… Commit: 8edc0e450da2c0959c44da4811901782cc399649 Parent: 00877fe47b99458e22f6e1c928505fc75aad0752 Author: Zdenek Kabelac <zkabelac(a)redhat.com> AuthorDate: Thu Aug 16 20:10:35 2012 +0200 Committer: Zdenek Kabelac <zkabelac(a)redhat.com> CommitterDate: Thu Aug 23 14:33:23 2012 +0200 lvmetad: fix memleaks Release allocated buffers in daemon_logf, daemon_log_parse --- WHATS_NEW | 1 + libdaemon/server/daemon-log.c | 7 ++++++- 2 files changed, 7 insertions(+), 1 deletions(-) diff --git a/WHATS_NEW b/WHATS_NEW index dcd51ff..dc3b29e 100644 --- a/WHATS_NEW +++ b/WHATS_NEW @@ -1,5 +1,6 @@ Version 2.02.98 ================================= + Fix buffer memory leak in lvmetad logging. Use 'ignore' discards for thin metadata created with older versions. Use proper condition to check for unsupported discards settings. Update lvs manpage with discards (2.02.97). diff --git a/libdaemon/server/daemon-log.c b/libdaemon/server/daemon-log.c index caa40cb..21068bc 100644 --- a/libdaemon/server/daemon-log.c +++ b/libdaemon/server/daemon-log.c @@ -59,6 +59,7 @@ void daemon_logf(log_state *s, int type, const char *fmt, ...) { if (dm_vasprintf(&buf, fmt, ap) < 0) return; /* _0 */ daemon_log(s, type, buf); + dm_free(buf); } struct log_line_baton { @@ -134,10 +135,14 @@ int daemon_log_parse(log_state *s, int outlet, const char *types, int enable) char *next = strchr(pos, ','); if (next) *next = 0; - if (!_parse_one(s, outlet, pos, enable)) + if (!_parse_one(s, outlet, pos, enable)) { + dm_free(buf); return 0; + } pos = next ? next + 1 : 0; } + dm_free(buf); + return 1; }

1 0

master - mirror: reconfigure_mirror_images not used
by Peter Rajnoha 15 Aug '12

15 Aug '12

Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=00877fe47b99458e… Commit: 00877fe47b99458e22f6e1c928505fc75aad0752 Parent: 54c24193f535660478e88af76340eef40dc3223c Author: Peter Rajnoha <prajnoha(a)redhat.com> AuthorDate: Wed Aug 15 10:44:19 2012 +0200 Committer: Peter Rajnoha <prajnoha(a)redhat.com> CommitterDate: Wed Aug 15 10:44:19 2012 +0200 mirror: reconfigure_mirror_images not used --- lib/metadata/metadata-exported.h | 3 +++ lib/metadata/mirror.c | 3 +++ 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/lib/metadata/metadata-exported.h b/lib/metadata/metadata-exported.h index f46fccc..f39f968 100644 --- a/lib/metadata/metadata-exported.h +++ b/lib/metadata/metadata-exported.h @@ -761,8 +761,11 @@ int add_mirror_log(struct cmd_context *cmd, struct logical_volume *lv, uint32_t log_count, uint32_t region_size, struct dm_list *allocatable_pvs, alloc_policy_t alloc); +#if 0 +/* FIXME: reconfigure_mirror_images: remove this code? */ int reconfigure_mirror_images(struct lv_segment *mirrored_seg, uint32_t num_mirrors, struct dm_list *removable_pvs, unsigned remove_log); +#endif int collapse_mirrored_lv(struct logical_volume *lv); int shift_mirror_images(struct lv_segment *mirrored_seg, unsigned mimage); diff --git a/lib/metadata/mirror.c b/lib/metadata/mirror.c index 61e4b47..0997c58 100644 --- a/lib/metadata/mirror.c +++ b/lib/metadata/mirror.c @@ -1219,6 +1219,8 @@ int collapse_mirrored_lv(struct logical_volume *lv) return 1; } +#if 0 +/* FIXME: reconfigure_mirror_images: remove this code? */ static int _get_mirror_fault_policy(struct cmd_context *cmd __attribute__((unused)), int log_policy) { @@ -1375,6 +1377,7 @@ int reconfigure_mirror_images(struct lv_segment *mirrored_seg, uint32_t num_mirr */ return 1; } +#endif static int _create_mimage_lvs(struct alloc_handle *ah, uint32_t num_mirrors,

1 0

master - thin: lvcreate --discards
by Zdenek Kabelac 09 Aug '12

09 Aug '12

Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=54c24193f5356604… Commit: 54c24193f535660478e88af76340eef40dc3223c Parent: 80bf4eb03546903d88affbb866c9c3750bfa08e5 Author: Zdenek Kabelac <zkabelac(a)redhat.com> AuthorDate: Thu Aug 9 12:20:47 2012 +0200 Committer: Zdenek Kabelac <zkabelac(a)redhat.com> CommitterDate: Thu Aug 9 16:25:52 2012 +0200 thin: lvcreate --discards --- WHATS_NEW | 1 + lib/metadata/lv_manip.c | 1 + lib/metadata/metadata-exported.h | 1 + tools/commands.h | 6 +++++- tools/lvcreate.c | 7 +++++++ 5 files changed, 15 insertions(+), 1 deletions(-) diff --git a/WHATS_NEW b/WHATS_NEW index a2a9285..dcd51ff 100644 --- a/WHATS_NEW +++ b/WHATS_NEW @@ -3,6 +3,7 @@ Version 2.02.98 Use 'ignore' discards for thin metadata created with older versions. Use proper condition to check for unsupported discards settings. Update lvs manpage with discards (2.02.97). + Add support for lvcreate --discards. Version 2.02.97 - 7th August 2012 ================================= diff --git a/lib/metadata/lv_manip.c b/lib/metadata/lv_manip.c index daa90da..70b984e 100644 --- a/lib/metadata/lv_manip.c +++ b/lib/metadata/lv_manip.c @@ -4423,6 +4423,7 @@ static struct logical_volume *_lv_create_an_lv(struct volume_group *vg, struct l if (seg_is_thin_pool(lp)) { first_seg(lv)->zero_new_blocks = lp->zero ? 1 : 0; first_seg(lv)->chunk_size = lp->chunk_size; + first_seg(lv)->discards = lp->discards; /* FIXME: use lowwatermark via lvm.conf global for all thinpools ? */ first_seg(lv)->low_water_mark = 0; } else if (seg_is_thin_volume(lp)) { diff --git a/lib/metadata/metadata-exported.h b/lib/metadata/metadata-exported.h index 74edb58..f46fccc 100644 --- a/lib/metadata/metadata-exported.h +++ b/lib/metadata/metadata-exported.h @@ -592,6 +592,7 @@ struct lvcreate_params { int log_count; /* mirror */ int nosync; /* mirror */ activation_change_t activate; /* non-snapshot, non-mirror */ + thin_discards_t discards; /* thin */ const char *origin; /* snap */ const char *pool; /* thin */ diff --git a/tools/commands.h b/tools/commands.h index 2a4404e..602fe81 100644 --- a/tools/commands.h +++ b/tools/commands.h @@ -1,6 +1,6 @@ /* * Copyright (C) 2001-2004 Sistina Software, Inc. All rights reserved. - * Copyright (C) 2004-2007 Red Hat, Inc. All rights reserved. + * Copyright (C) 2004-2012 Red Hat, Inc. All rights reserved. * * This file is part of LVM2. * @@ -180,6 +180,10 @@ xx(lvcreate, "\t[-p|--permission {r|rw}]\n" "\t[-r|--readahead ReadAheadSectors|auto|none]\n" "\t[-R|--regionsize MirrorLogRegionSize]\n" + "\t[-T|--thin [-c|--chunksize ChunkSize]\n" + "\t [--discards {ignore|nopassdown|passdown}]\n" + "\t [--poolmetadatasize MetadataSize[bBsSkKmMgG]]]\n" + "\t[--thinpool ThinPoolLogicalVolume{Name|Path}]\n" "\t[-t|--test]\n" "\t[--type VolumeType]\n" "\t[-v|--verbose]\n" diff --git a/tools/lvcreate.c b/tools/lvcreate.c index da2b925..6aecf1d 100644 --- a/tools/lvcreate.c +++ b/tools/lvcreate.c @@ -797,6 +797,13 @@ static int _lvcreate_params(struct lvcreate_params *lp, !_read_raid_params(lp, cmd)) return_0; + if (lp->create_thin_pool) { + lp->discards = arg_uint_value(cmd, discards_ARG, THIN_DISCARDS_PASSDOWN); + } else if (arg_count(cmd, discards_ARG)) { + log_error("--discards is only available for thin pool creation."); + return 0; + } + if (lp->snapshot && lp->thin && arg_count(cmd, chunksize_ARG)) log_warn("WARNING: Ignoring --chunksize with thin snapshots."); else if (lp->thin && !lp->create_thin_pool) {

1 0

master - thin: fix man page for lvs
by Zdenek Kabelac 09 Aug '12

09 Aug '12

Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=80bf4eb03546903d… Commit: 80bf4eb03546903d88affbb866c9c3750bfa08e5 Parent: b8a6efbcc03dd21cfc765176c3e406075bfa1e02 Author: Zdenek Kabelac <zkabelac(a)redhat.com> AuthorDate: Thu Aug 9 11:27:14 2012 +0200 Committer: Zdenek Kabelac <zkabelac(a)redhat.com> CommitterDate: Thu Aug 9 16:25:25 2012 +0200 thin: fix man page for lvs Renamed discard -> discards --- WHATS_NEW | 1 + man/lvs.8.in | 2 +- 2 files changed, 2 insertions(+), 1 deletions(-) diff --git a/WHATS_NEW b/WHATS_NEW index b0fa32f..a2a9285 100644 --- a/WHATS_NEW +++ b/WHATS_NEW @@ -2,6 +2,7 @@ Version 2.02.98 ================================= Use 'ignore' discards for thin metadata created with older versions. Use proper condition to check for unsupported discards settings. + Update lvs manpage with discards (2.02.97). Version 2.02.97 - 7th August 2012 ================================= diff --git a/man/lvs.8.in b/man/lvs.8.in index f492835..97e1879 100644 --- a/man/lvs.8.in +++ b/man/lvs.8.in @@ -80,7 +80,7 @@ convert_lv, copy_percent, data_lv, devices, -discard, +discards, lv_attr, lv_host, lv_kernel_major,

1 0

master - thin: fix condition for kernels without discards
by Zdenek Kabelac 09 Aug '12

09 Aug '12

Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=b8a6efbcc03dd21c… Commit: b8a6efbcc03dd21cfc765176c3e406075bfa1e02 Parent: 1f1c664b78d5f8464e0bbee5a00402cad93c7029 Author: Zdenek Kabelac <zkabelac(a)redhat.com> AuthorDate: Thu Aug 9 11:25:41 2012 +0200 Committer: Zdenek Kabelac <zkabelac(a)redhat.com> CommitterDate: Thu Aug 9 16:24:42 2012 +0200 thin: fix condition for kernels without discards Report warning if the kernel is not support given discards settings. (In this case the behavior is equal to IGNORE.) --- WHATS_NEW | 1 + lib/thin/thin.c | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/WHATS_NEW b/WHATS_NEW index c7d3a2d..b0fa32f 100644 --- a/WHATS_NEW +++ b/WHATS_NEW @@ -1,6 +1,7 @@ Version 2.02.98 ================================= Use 'ignore' discards for thin metadata created with older versions. + Use proper condition to check for unsupported discards settings. Version 2.02.97 - 7th August 2012 ================================= diff --git a/lib/thin/thin.c b/lib/thin/thin.c index 25c1947..d95b68e 100644 --- a/lib/thin/thin.c +++ b/lib/thin/thin.c @@ -276,13 +276,13 @@ static int _thin_pool_add_target_line(struct dev_manager *dm, seg->zero_new_blocks ? 0 : 1)) return_0; - if ((seg->discards != THIN_DISCARDS_PASSDOWN) && (attr & THIN_FEATURE_DISCARDS)) { + if (attr & THIN_FEATURE_DISCARDS) { /* FIXME: Check whether underlying dev supports discards */ if (!dm_tree_node_set_thin_pool_discard(node, seg->discards == THIN_DISCARDS_IGNORE, seg->discards == THIN_DISCARDS_NO_PASSDOWN)) return_0; - } else + } else if (seg->discards != THIN_DISCARDS_IGNORE) log_warn_suppress(_no_discards++, "WARNING: Thin pool target does " "not support discards (needs kernel >= 3.4).");

1 0

master - thin: default discards for old mda is IGNORE
by Zdenek Kabelac 09 Aug '12

09 Aug '12

Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=1f1c664b78d5f846… Commit: 1f1c664b78d5f8464e0bbee5a00402cad93c7029 Parent: de3b1c4506ff502f00a360a83800f35a31e1b42e Author: Zdenek Kabelac <zkabelac(a)redhat.com> AuthorDate: Thu Aug 9 11:24:37 2012 +0200 Committer: Zdenek Kabelac <zkabelac(a)redhat.com> CommitterDate: Thu Aug 9 16:23:32 2012 +0200 thin: default discards for old mda is IGNORE If the discard was not set in metadata, use IGNORE, as this is the equivalent behavior for this case. --- WHATS_NEW | 4 ++++ lib/thin/thin.c | 2 +- 2 files changed, 5 insertions(+), 1 deletions(-) diff --git a/WHATS_NEW b/WHATS_NEW index fd741bb..c7d3a2d 100644 --- a/WHATS_NEW +++ b/WHATS_NEW @@ -1,3 +1,7 @@ +Version 2.02.98 +================================= + Use 'ignore' discards for thin metadata created with older versions. + Version 2.02.97 - 7th August 2012 ================================= Issue error message when arguments do not match specified RAID type. diff --git a/lib/thin/thin.c b/lib/thin/thin.c index cfd50ad..25c1947 100644 --- a/lib/thin/thin.c +++ b/lib/thin/thin.c @@ -119,7 +119,7 @@ static int _thin_pool_text_import(struct lv_segment *seg, return SEG_LOG_ERROR("Could not read discards for"); if (!discards_str) - seg->discards = THIN_DISCARDS_PASSDOWN; + seg->discards = THIN_DISCARDS_IGNORE; else if (!get_pool_discards(discards_str, &seg->discards)) return SEG_LOG_ERROR("Discards option unsupported for");

1 0

master - RAID: Improve RAID argument handling.
by Jonathan Brassow 08 Aug '12

08 Aug '12

Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=de3b1c4506ff502f… Commit: de3b1c4506ff502f00a360a83800f35a31e1b42e Parent: b61be643701d05bb12e0b2e32085f312a1f121bf Author: Jonathan Brassow <jbrassow(a)redhat.com> AuthorDate: Wed Aug 8 12:32:27 2012 -0500 Committer: Jonathan Brassow <jbrassow(a)redhat.com> CommitterDate: Wed Aug 8 12:32:27 2012 -0500 RAID: Improve RAID argument handling. Disallow '-m' for RAID types that have no mirror component and disallow '-i' argument for RAID types that have no stripe component. --- WHATS_NEW | 1 + tools/lvcreate.c | 21 +++++++++++++++++++++ 2 files changed, 22 insertions(+), 0 deletions(-) diff --git a/WHATS_NEW b/WHATS_NEW index 25f4a9c..fd741bb 100644 --- a/WHATS_NEW +++ b/WHATS_NEW @@ -1,5 +1,6 @@ Version 2.02.97 - 7th August 2012 ================================= + Issue error message when arguments do not match specified RAID type. Improve documention of allocation policies in lvm.8. Increase limit for major:minor to 4095:1048575 when using -My option. Add make install_systemd_generators. diff --git a/tools/lvcreate.c b/tools/lvcreate.c index 48977d7..da2b925 100644 --- a/tools/lvcreate.c +++ b/tools/lvcreate.c @@ -539,6 +539,27 @@ static int _read_raid_params(struct lvcreate_params *lp, } /* + * RAID types without a mirror component do not take '-m' arg + */ + if (!segtype_is_mirrored(lp->segtype) && + arg_count(cmd, mirrors_ARG)) { + log_error("Mirror argument cannot be used with segment type, %s", + lp->segtype->name); + return 0; + } + + /* + * RAID1 does not take a stripe arg + */ + if ((lp->stripes > 1) && + segtype_is_mirrored(lp->segtype) && + strcmp(lp->segtype->name, "raid10")) { + log_error("Stripe argument cannot be used with segment type, %s", + lp->segtype->name); + return 0; + } + + /* * _read_mirror_params is called before _read_raid_params * and already sets: * lp->nosync

1 0

master - libdaemon: Draft logging infrastructure.
by Petr Rockai 08 Aug '12

08 Aug '12

Gitweb: http://git.fedorahosted.org/git/?p=lvm2.git;a=commitdiff;h=b61be643701d05bb… Commit: b61be643701d05bb12e0b2e32085f312a1f121bf Parent: 7ecccc3099c854bd9a993b360974a9f52a746131 Author: Petr Rockai <prockai(a)redhat.com> AuthorDate: Wed Aug 8 09:41:01 2012 +0200 Committer: Petr Rockai <prockai(a)redhat.com> CommitterDate: Wed Aug 8 09:44:19 2012 +0200 libdaemon: Draft logging infrastructure. - logging is not controlled by "levels" but by "types"; types are independent of each other... implementation of the usual "log level" user-level semantics can be simply done on top; the immediate application is enabling/disabling wire traffic logging independently of other debug data, since the former is rather bulky and can easily obscure almost everything else - all logs go to "outlets", of which we currently have 2: syslog and stderr; which "types" go to which "outlets" is entirely configurable --- daemons/lvmetad/lvmetad-core.c | 79 +++++++++------------ libdaemon/server/Makefile.in | 2 +- libdaemon/server/daemon-log.c | 143 ++++++++++++++++++++++++++++++++++++++ libdaemon/server/daemon-log.h | 14 ++++ libdaemon/server/daemon-server.c | 23 ++++-- libdaemon/server/daemon-server.h | 38 ++++++++++- test/lib/aux.sh | 2 +- 7 files changed, 245 insertions(+), 56 deletions(-) diff --git a/daemons/lvmetad/lvmetad-core.c b/daemons/lvmetad/lvmetad-core.c index 0b0ec73..d06ff46 100644 --- a/daemons/lvmetad/lvmetad-core.c +++ b/daemons/lvmetad/lvmetad-core.c @@ -17,6 +17,7 @@ #include "configure.h" #include "daemon-shared.h" #include "daemon-server.h" +#include "daemon-log.h" #include <assert.h> #include <pthread.h> @@ -25,6 +26,9 @@ #include <unistd.h> typedef struct { + log_state *log; /* convenience */ + const char *debug_config; + struct dm_hash_table *pvid_to_pvmeta; struct dm_hash_table *device_to_pvid; /* shares locks with above */ @@ -40,26 +44,6 @@ typedef struct { } lock; } lvmetad_state; -__attribute__ ((format(printf, 1, 2))) -static void debug(const char *fmt, ...) { - va_list ap; - va_start(ap, fmt); - fprintf(stderr, "[D %lu] ", pthread_self()); - vfprintf(stderr, fmt, ap); - va_end(ap); - fflush(stderr); -} - -static int debug_cft_line(const char *line, void *baton) { - fprintf(stderr, "| %s\n", line); - return 0; -} - -static void debug_cft(const char *id, struct dm_config_node *n) { - debug("%s\n", id); - dm_config_write_node(n, &debug_cft_line, NULL); -} - static void lock_pvid_to_pvmeta(lvmetad_state *s) { pthread_mutex_lock(&s->lock.pvid_to_pvmeta); } static void unlock_pvid_to_pvmeta(lvmetad_state *s) { @@ -98,7 +82,7 @@ static struct dm_config_tree *lock_vg(lvmetad_state *s, const char *id) { return NULL; } } - // debug("lock VG %s\n", id); + DEBUG(s, "locking VG %s", id); pthread_mutex_lock(vg); cft = dm_hash_lookup(s->vgid_to_metadata, id); unlock_vgid_to_metadata(s); @@ -108,7 +92,7 @@ static struct dm_config_tree *lock_vg(lvmetad_state *s, const char *id) { static void unlock_vg(lvmetad_state *s, const char *id) { pthread_mutex_t *vg; - // debug("unlock VG %s\n", id); + DEBUG(s, "unlocking VG %s", id); lock_vgid_to_metadata(s); /* someone might be changing the s->lock.vg structure right * now, so avoid stepping on each other's toes */ if ((vg = dm_hash_lookup(s->lock.vg, id))) @@ -410,7 +394,7 @@ static response pv_lookup(lvmetad_state *s, request r) pvid = dm_hash_lookup_binary(s->device_to_pvid, &devt, sizeof(devt)); if (!pvid) { - debug("pv_lookup: could not find device %" PRIu64 "\n", devt); + WARN(s, "pv_lookup: could not find device %" PRIu64, devt); unlock_pvid_to_pvmeta(s); dm_config_destroy(res.cft); return daemon_reply_simple("unknown", "reason = %s", "device not found", NULL); @@ -507,7 +491,7 @@ static response vg_lookup(lvmetad_state *s, request r) const char *uuid = daemon_request_str(r, "uuid", NULL); const char *name = daemon_request_str(r, "name", NULL); - debug("vg_lookup: uuid = %s, name = %s\n", uuid, name); + DEBUG(s, "vg_lookup: uuid = %s, name = %s", uuid, name); if (!uuid || !name) { lock_vgid_to_metadata(s); @@ -518,7 +502,7 @@ static response vg_lookup(lvmetad_state *s, request r) unlock_vgid_to_metadata(s); } - debug("vg_lookup: updated uuid = %s, name = %s\n", uuid, name); + DEBUG(s, "vg_lookup: updated uuid = %s, name = %s", uuid, name); if (!uuid) return daemon_reply_simple("unknown", "reason = %s", "VG not found", NULL); @@ -596,7 +580,7 @@ static int compare_config(struct dm_config_node *a, struct dm_config_node *b) result = compare_config(a->child, b->child); if (result) { - debug("config inequality at %s / %s\n", a->key, b->key); + // DEBUG("config inequality at %s / %s", a->key, b->key); return result; } @@ -642,7 +626,7 @@ static int update_pvid_to_vgid(lvmetad_state *s, struct dm_config_tree *vg, if (!dm_hash_insert(s->pvid_to_vgid, pvid, (void*) vgid)) goto out; - debug("remap PV %s to VG %s\n", pvid, vgid); + DEBUG(s, "moving PV %s to VG %s", pvid, vgid); } for (n = dm_hash_get_first(to_check); n; @@ -712,7 +696,7 @@ static int vg_remove_if_missing(lvmetad_state *s, const char *vgid) } if (missing) { - debug("nuking VG %s\n", vgid); + DEBUG(s, "removing empty VG %s", vgid); remove_metadata(s, vgid, 0); } @@ -758,17 +742,17 @@ static int update_metadata(lvmetad_state *s, const char *name, const char *_vgid retval = 1; if (compare_config(metadata, old->root)) retval = 0; - debug("Not updating metadata for %s at %d (%s)\n", _vgid, haveseq, + DEBUG(s, "Not updating metadata for %s at %d (%s)", _vgid, haveseq, retval ? "ok" : "MISMATCH"); if (!retval) { - debug_cft("OLD: ", old->root); - debug_cft("NEW: ", metadata); + DEBUG_cft(s, "OLD: ", old->root); + DEBUG_cft(s, "NEW: ", metadata); } goto out; } if (seq < haveseq) { - debug("Refusing to update metadata for %s at %d to %d\n", _vgid, haveseq, seq); + DEBUG(s, "Refusing to update metadata for %s (at %d) to %d", _vgid, haveseq, seq); /* TODO: notify the client that their metadata is out of date? */ retval = 1; goto out; @@ -776,27 +760,27 @@ static int update_metadata(lvmetad_state *s, const char *name, const char *_vgid if (!(cft = dm_config_create()) || !(cft->root = dm_config_clone_node(cft, metadata, 0))) { - debug("Out of memory\n"); + ERROR(s, "Out of memory"); goto out; } vgid = dm_config_find_str(cft->root, "metadata/id", NULL); if (!vgid || !name) { - debug("Name '%s' or uuid '%s' missing!\n", name, vgid); + DEBUG(s, "Name '%s' or uuid '%s' missing!", name, vgid); goto out; } lock_pvid_to_vgid(s); if (haveseq >= 0 && haveseq < seq) { - debug("Updating metadata for %s at %d to %d\n", _vgid, haveseq, seq); + INFO(s, "Updating metadata for %s at %d to %d", _vgid, haveseq, seq); /* temporarily orphan all of our PVs */ remove_metadata(s, vgid, 1); } lock_vgid_to_metadata(s); - debug("Mapping %s to %s\n", vgid, name); + DEBUG(s, "Mapping %s to %s", vgid, name); retval = ((cfgname = dm_pool_strdup(dm_config_memory(cft), name)) && dm_hash_insert(s->vgid_to_metadata, vgid, cft) && @@ -820,7 +804,7 @@ static response pv_gone(lvmetad_state *s, request r) int64_t device = daemon_request_int(r, "device", 0); struct dm_config_tree *pvmeta; - debug("pv_gone: %s / %" PRIu64 "\n", pvid, device); + DEBUG(s, "pv_gone: %s / %" PRIu64, pvid, device); lock_pvid_to_pvmeta(s); if (!pvid && device > 0) @@ -830,7 +814,7 @@ static response pv_gone(lvmetad_state *s, request r) return daemon_reply_simple("unknown", "reason = %s", "device not in cache", NULL); } - debug("pv_gone (updated): %s / %" PRIu64 "\n", pvid, device); + DEBUG(s, "pv_gone (updated): %s / %" PRIu64, pvid, device); pvmeta = dm_hash_lookup(s->pvid_to_pvmeta, pvid); dm_hash_remove_binary(s->device_to_pvid, &device, sizeof(device)); @@ -866,7 +850,7 @@ static response pv_found(lvmetad_state *s, request r) if (!dm_config_get_uint64(pvmeta, "pvmeta/device", &device)) return daemon_reply_simple("failed", "reason = %s", "need PV device number", NULL); - debug("pv_found %s, vgid = %s, device = %" PRIu64 "\n", pvid, vgid, device); + DEBUG(s, "pv_found %s, vgid = %s, device = %" PRIu64, pvid, vgid, device); lock_pvid_to_pvmeta(s); @@ -895,7 +879,7 @@ static response pv_found(lvmetad_state *s, request r) if (metadata) { if (!vgid) return daemon_reply_simple("failed", "reason = %s", "need VG UUID", NULL); - debug("obtained vgid = %s, vgname = %s\n", vgid, vgname); + DEBUG(s, "obtained vgid = %s, vgname = %s", vgid, vgname); if (!vgname) return daemon_reply_simple("failed", "reason = %s", "need VG name", NULL); if (daemon_request_int(r, "metadata/seqno", -1) < 0) @@ -959,7 +943,7 @@ static response vg_remove(lvmetad_state *s, request r) if (!vgid) return daemon_reply_simple("failed", "reason = %s", "need VG UUID", NULL); - fprintf(stderr, "vg_remove: %s\n", vgid); + DEBUG(s, "vg_remove: %s", vgid); lock_pvid_to_vgid(s); remove_metadata(s, vgid, 1); @@ -1009,6 +993,7 @@ static int init(daemon_state *s) { pthread_mutexattr_t rec; lvmetad_state *ls = s->private; + ls->log = s->log; ls->pvid_to_pvmeta = dm_hash_create(32); ls->device_to_pvid = dm_hash_create(32); @@ -1023,7 +1008,10 @@ static int init(daemon_state *s) pthread_mutex_init(&ls->lock.vgid_to_metadata, &rec); pthread_mutex_init(&ls->lock.pvid_to_vgid, NULL); - debug("initialised state: vgid_to_metadata = %p\n", ls->vgid_to_metadata); + /* Set up stderr logging depending on the -d option. */ + daemon_log_parse(ls->log, DAEMON_LOG_OUTLET_STDERR, ls->debug_config, 1); + + DEBUG(s, "initialised state: vgid_to_metadata = %p", ls->vgid_to_metadata); if (!ls->pvid_to_vgid || !ls->vgid_to_metadata) return 0; @@ -1038,7 +1026,7 @@ static int fini(daemon_state *s) lvmetad_state *ls = s->private; struct dm_hash_node *n = dm_hash_get_first(ls->vgid_to_metadata); - debug("fini\n"); + DEBUG(s, "fini"); while (n) { dm_config_destroy(dm_hash_get_data(ls->vgid_to_metadata, n)); n = dm_hash_get_next(ls->vgid_to_metadata, n); @@ -1094,12 +1082,11 @@ int main(int argc, char *argv[]) if (!s.socket_path) s.socket_path = DEFAULT_RUN_DIR "/lvmetad.socket"; s.pidfile = LVMETAD_PIDFILE; - s.log_level = 0; s.protocol = "lvmetad"; s.protocol_version = 1; // use getopt_long - while ((opt = getopt(argc, argv, "?fhVdRs:")) != EOF) { + while ((opt = getopt(argc, argv, "?fhVd:Rs:")) != EOF) { switch (opt) { case 'h': usage(argv[0], stdout); @@ -1114,7 +1101,7 @@ int main(int argc, char *argv[]) s.foreground = 1; break; case 'd': - s.log_level++; + ls.debug_config = optarg; break; case 's': // --socket s.socket_path = optarg; diff --git a/libdaemon/server/Makefile.in b/libdaemon/server/Makefile.in index 245a19d..1c4a38e 100644 --- a/libdaemon/server/Makefile.in +++ b/libdaemon/server/Makefile.in @@ -15,7 +15,7 @@ top_srcdir = @top_srcdir@ top_builddir = @top_builddir@ LIB_STATIC = libdaemonserver.a -SOURCES = daemon-server.c +SOURCES = daemon-server.c daemon-log.c include $(top_builddir)/make.tmpl diff --git a/libdaemon/server/daemon-log.c b/libdaemon/server/daemon-log.c new file mode 100644 index 0000000..caa40cb --- /dev/null +++ b/libdaemon/server/daemon-log.c @@ -0,0 +1,143 @@ +#include "daemon-server.h" +#include "daemon-log.h" +#include <syslog.h> +#include "assert.h" + +struct backend { + int id; + void (*log)(log_state *s, void **state, int type, const char *message); +}; + +static void log_syslog(log_state *s, void **state, int type, const char *message) +{ + if (!*state) { /* initialize */ + *state = (void *)1; + openlog(s->name, LOG_PID, LOG_DAEMON); + } + int prio = LOG_DEBUG; + switch (type) { + case DAEMON_LOG_INFO: prio = LOG_INFO; break; + case DAEMON_LOG_WARN: prio = LOG_WARNING; break; + case DAEMON_LOG_FATAL: prio = LOG_CRIT; break; + } + + syslog(prio, "%s", message); +} + +static void log_stderr(log_state *s, void **state, int type, const char *message) +{ + const char *prefix = ""; + switch (type) { + case DAEMON_LOG_INFO: prefix = "I: "; break; + case DAEMON_LOG_WARN: prefix = "W: " ; break; + case DAEMON_LOG_ERROR: + case DAEMON_LOG_FATAL: prefix = "E: " ; break; + } + + fprintf(stderr, "%s%s\n", prefix, message); +} + +struct backend backend[] = { + { DAEMON_LOG_OUTLET_SYSLOG, log_syslog }, + { DAEMON_LOG_OUTLET_STDERR, log_stderr }, + { 0, 0 } +}; + +void daemon_log(log_state *s, int type, const char *message) { + int i = 0; + while ( backend[i].id ) { + if ( (s->log_config[type] & backend[i].id) == backend[i].id ) + backend[i].log( s, &s->backend_state[i], type, message ); + ++ i; + } +} + +void daemon_logf(log_state *s, int type, const char *fmt, ...) { + va_list ap; + va_start(ap, fmt); + char *buf; + if (dm_vasprintf(&buf, fmt, ap) < 0) + return; /* _0 */ + daemon_log(s, type, buf); +} + +struct log_line_baton { + log_state *s; + int type; + const char *prefix; +}; + +static int _log_line(const char *line, void *baton) { + struct log_line_baton *b = baton; + daemon_logf(b->s, b->type, "%s%s", b->prefix, line); + return 0; +} + +void daemon_log_cft(log_state *s, int type, const char *prefix, const struct dm_config_node *n) +{ + struct log_line_baton b = { .s = s, .type = type, .prefix = prefix }; + dm_config_write_node(n, &_log_line, &b); +} + +void daemon_log_multi(log_state *s, int type, const char *prefix, const char *msg) +{ + struct log_line_baton b = { .s = s, .type = type, .prefix = prefix }; + char *buf = dm_strdup(msg); + char *pos = buf; + + if (!buf) + return; /* _0 */ + + while (pos) { + char *next = strchr(pos, '\n'); + if (next) + *next = 0; + _log_line(pos, &b); + pos = next ? next + 1 : 0; + } +} + +void daemon_log_enable(log_state *s, int outlet, int type, int enable) +{ + assert(type < 32); + if (enable) + s->log_config[type] |= outlet; + else + s->log_config[type] &= ~outlet; +} + +static int _parse_one(log_state *s, int outlet, const char *type, int enable) +{ + int i; + if (!strcmp(type, "all")) + for (i = 0; i < 32; ++i) + daemon_log_enable(s, outlet, i, enable); + else if (!strcmp(type, "wire")) + daemon_log_enable(s, outlet, DAEMON_LOG_WIRE, enable); + else if (!strcmp(type, "debug")) + daemon_log_enable(s, outlet, DAEMON_LOG_DEBUG, enable); + else + return 0; + + return 1; +} + +int daemon_log_parse(log_state *s, int outlet, const char *types, int enable) +{ + char *buf = dm_strdup(types); + char *pos = buf; + + if (!buf) + return 0; + + while (pos) { + char *next = strchr(pos, ','); + if (next) + *next = 0; + if (!_parse_one(s, outlet, pos, enable)) + return 0; + pos = next ? next + 1 : 0; + } + + return 1; +} diff --git a/libdaemon/server/daemon-log.h b/libdaemon/server/daemon-log.h new file mode 100644 index 0000000..17d8007 --- /dev/null +++ b/libdaemon/server/daemon-log.h @@ -0,0 +1,14 @@ +enum { DAEMON_LOG_FATAL = 0 /* usually preceding daemon death */ + , DAEMON_LOG_ERROR = 1 /* something serious has happened */ + , DAEMON_LOG_WARN = 2 /* something unusual has happened */ + , DAEMON_LOG_INFO = 3 /* thought you might be interested */ + , DAEMON_LOG_WIRE = 4 /* dump traffic on client sockets */ + , DAEMON_LOG_DEBUG = 5 /* unsorted debug stuff */ + }; + +#define DEBUG(s, x...) daemon_logf((s)->log, DAEMON_LOG_DEBUG, x) +#define DEBUG_cft(s, i, n) daemon_log_cft((s)->log, DAEMON_LOG_DEBUG, i, n) +#define WARN(s, x...) daemon_logf((s)->log, DAEMON_LOG_WARN, x) +#define INFO(s, x...) daemon_logf((s)->log, DAEMON_LOG_INFO, x) +#define ERROR(s, x...) daemon_logf((s)->log, DAEMON_LOG_ERROR, x) +#define FATAL(s, x...) daemon_logf((s)->log, DAEMON_LOG_FATAL, x) diff --git a/libdaemon/server/daemon-server.c b/libdaemon/server/daemon-server.c index 5ca9231..c69da36 100644 --- a/libdaemon/server/daemon-server.c +++ b/libdaemon/server/daemon-server.c @@ -12,6 +12,7 @@ #include "daemon-shared.h" #include "daemon-server.h" +#include "daemon-log.h" #include <dlfcn.h> #include <errno.h> @@ -26,7 +27,7 @@ #include <unistd.h> #include <signal.h> -#include <syslog.h> +#include <syslog.h> /* FIXME. For the global closelog(). */ #if 0 /* Create a device monitoring thread. */ @@ -391,6 +392,7 @@ static void *client_thread(void *baton) if (!req.cft) fprintf(stderr, "error parsing request:\n %s\n", req.buffer); + daemon_log_cft(b->s.log, DAEMON_LOG_WIRE, "<- ", req.cft->root); res = builtin_handler(b->s, b->client, req); if (res.error == EPROTO) /* Not a builtin, delegate to the custom handler. */ @@ -407,6 +409,7 @@ static void *client_thread(void *baton) dm_config_destroy(req.cft); dm_free(req.buffer); + daemon_log_multi(b->s.log, DAEMON_LOG_WIRE, "-> ", res.buffer); write_buffer(b->client.socket_fd, res.buffer, strlen(res.buffer)); free(res.buffer); @@ -462,8 +465,13 @@ void daemon_start(daemon_state s) if (!s.foreground) _daemonise(); - /* TODO logging interface should be somewhat more elaborate */ - openlog(s.name, LOG_PID, LOG_DAEMON); + log_state _log = { { 0 } }; + s.log = &_log; + s.log->name = s.name; + + /* Log important things to syslog by default. */ + daemon_log_enable(s.log, DAEMON_LOG_OUTLET_SYSLOG, DAEMON_LOG_FATAL, 1); + daemon_log_enable(s.log, DAEMON_LOG_OUTLET_SYSLOG, DAEMON_LOG_ERROR, 1); (void) dm_prepare_selinux_context(s.pidfile, S_IFREG); @@ -487,7 +495,7 @@ void daemon_start(daemon_state s) #ifdef linux /* Systemd has adjusted oom killer for us already */ if (s.avoid_oom && !_systemd_activation && !_protect_against_oom_killer()) - syslog(LOG_ERR, "Failed to protect against OOM killer"); + ERROR(&s, "Failed to protect against OOM killer"); #endif if (!_systemd_activation && s.socket_path) { @@ -511,7 +519,7 @@ void daemon_start(daemon_state s) perror("select error"); if (FD_ISSET(s.socket_fd, &in)) if (!_shutdown_requested && !handle_connect(s)) - syslog(LOG_ERR, "Failed to handle a client connection."); + ERROR(&s, "Failed to handle a client connection."); } /* If activated by systemd, do not unlink the socket - systemd takes care of that! */ @@ -522,8 +530,9 @@ void daemon_start(daemon_state s) if (s.daemon_fini) s.daemon_fini(&s); - syslog(LOG_NOTICE, "%s shutting down", s.name); - closelog(); + INFO(&s, "%s shutting down", s.name); + + closelog(); /* FIXME */ remove_lockfile(s.pidfile); if (failed) exit(1); diff --git a/libdaemon/server/daemon-server.h b/libdaemon/server/daemon-server.h index 104dac1..df7ed8e 100644 --- a/libdaemon/server/daemon-server.h +++ b/libdaemon/server/daemon-server.h @@ -64,6 +64,12 @@ static inline const char *daemon_request_str(request r, const char *path, const */ typedef response (*handle_request)(struct daemon_state s, client_handle h, request r); +typedef struct { + uint32_t log_config[32]; + void *backend_state[32]; + const char *name; +} log_state; + typedef struct daemon_state { /* * The maximal stack size for individual daemon threads. This is @@ -81,7 +87,6 @@ typedef struct daemon_state { const char *protocol; int protocol_version; - int log_level; handle_request handler; int (*daemon_init)(struct daemon_state *st); int (*daemon_fini)(struct daemon_state *st); @@ -89,6 +94,7 @@ typedef struct daemon_state { /* Global runtime info maintained by the framework. */ int socket_fd; + log_state *log; void *private; /* the global daemon state */ } daemon_state; @@ -119,4 +125,34 @@ daemon_reply daemon_takeover(daemon_info i, daemon_request r); /* Call this to request a clean shutdown of the daemon. Async safe. */ void daemon_stop(void); +enum { DAEMON_LOG_OUTLET_SYSLOG = 1, + DAEMON_LOG_OUTLET_STDERR = 2, + DAEMON_LOG_OUTLET_SOCKET = 4 }; + +/* Log a message of a given type. */ +void daemon_log(log_state *s, int type, const char *message); + +/* Log a config (sub)tree, using a given message type, each line prefixed with "prefix". */ +void daemon_log_cft(log_state *s, int type, const char *prefix, + const struct dm_config_node *n); + +/* Log a multi-line block, prefixing each line with "prefix". */ +void daemon_log_multi(log_state *s, int type, const char *prefix, const char *message); + +/* Log a formatted message as "type". See also daemon-log.h. */ +void daemon_logf(log_state *s, int type, const char *format, ...); + +/* + * Configure log_state to send messages of type "type" to the log outlet + * "outlet", iff "enable" is true. + */ +void daemon_log_enable(log_state *s, int outlet, int type, int enable); + +/* + * Set up logging on a given outlet using a list of message types (comma + * separated) to log using that outlet. The list is expected to look like this, + * "info,wire,debug". Returns 0 upon encountering an unknown message type. + */ +int daemon_log_parse(log_state *s, int outlet, const char *types, int enable); + #endif diff --git a/test/lib/aux.sh b/test/lib/aux.sh index 4128f30..26508cf 100644 --- a/test/lib/aux.sh +++ b/test/lib/aux.sh @@ -74,7 +74,7 @@ prepare_lvmetad() { lvmconf "devices/md_component_detection = 0" echo "preparing lvmetad..." - lvmetad -f "$@" -s "$TESTDIR/lvmetad.socket" & + lvmetad -f "$@" -s "$TESTDIR/lvmetad.socket" -d wire,debug & echo $! > LOCAL_LVMETAD sleep .3

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

lvm2-commits August 2012