On Mon, Aug 31, 2020 at 04:37:24PM +0000, Ruben Torrero Marijnissen wrote:
> Hi,
>
> I'm looking into the possibility of adding support for an additional
> backend (wicked) inside nmstate. What would be a good starting point?
> what things should I keep in mind when doing so? What would be the
> requirements that would have to be met to send a PR with chances of it
> being accepted?
Hi Ruben Torrero Marijnissen,
Nmstate now provides plugin support, you may refer to
`libnmstate/plugins/nmstate_plugin_ovsdb.py` as an example plugin.
Currently, we are moving to nispor(via netlink) for querying kernel
network state, so your plugin will only have to apply the config and
some user space only state(e.g. OVS, DHCP status).
For accepting a PR, these are required besides maintainer approval:
* License LGPL 2.1+
* CI pass.
* New code has test cases covered.
Besides that, we can discuss the detail in github PR.
> Any suggestion is appreciated as well as pointing me in the right
> direction to find more documentation is appreciated (I'm already going
> through the contents of nmstate.io)
I will draft out an document for `Nmstate Plugin Developer Guide`
for this use case before end of this week.
I am in freenode IRC #nmstate channel as Gris, ping me if you need any
help on this.
Best regards!
--
Gris Ge