Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: libkipi - Common plugin infrastructure for KDE image applications
https://bugzilla.redhat.com/show_bug.cgi?id=719323
Summary: Review Request: libkipi - Common plugin infrastructure for KDE image applications Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: rdieter@math.unl.edu QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: ---
Spec URL: http://rdieter.fedorapeople.org/rpms/kdegraphics/libkipi.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/kdegraphics/libkipi-4.6.90-1.fc16.src.r... Description: Common plugin infrastructure for KDE image applications
https://bugzilla.redhat.com/show_bug.cgi?id=719323
Marcus Harrison marcus@harrisonland.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |marcus@harrisonland.co.uk
--- Comment #17 from Marcus Harrison marcus@harrisonland.co.uk --- Not sure if this is where I should report this, but on my Fedora 22 system, running "dnf remove libkipi" results in the error, "The operation would result in removing the following protected packages: systemd."
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719323
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |656997(kde-reviews) Alias| |libkipi
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719323
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |719328(gwenview)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719323
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |719342(okular)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719323
nucleo alekcejk@googlemail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |alekcejk@googlemail.com
--- Comment #1 from nucleo alekcejk@googlemail.com 2011-07-06 12:53:03 EDT --- Almost all sources in libkipi GPLv2+ and only libkipi_export.h have LGPLv2+ license so resulting license maybe is GPLv2+?
scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3182848
rpmlint output:
libkipi.i686: W: spelling-error %description -l en_US Kipi -> Kip, Ki pi, Ki-pi libkipi.i686: E: zero-length /usr/share/doc/libkipi-4.6.90/TODO libkipi.src: W: spelling-error %description -l en_US Kipi -> Kip, Ki pi, Ki-pi libkipi.src: W: invalid-url Source0: ftp://ftp.kde.org/pub/kde/stable/4.6.90/src/libkipi-4.6.90.tar.bz2 <urlopen error ftp error: 550 Failed to change directory.> libkipi.x86_64: W: spelling-error %description -l en_US Kipi -> Kip, Ki pi, Ki-pi libkipi.x86_64: E: zero-length /usr/share/doc/libkipi-4.6.90/TODO libkipi-devel.i686: W: no-documentation libkipi-devel.x86_64: W: no-documentation 7 packages and 0 specfiles checked; 2 errors, 6 warnings.
TODO file is empty (NEWS can be added instead it).
invalid-url error because 4.6.90 is in unstable dir.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719323
--- Comment #2 from nucleo alekcejk@googlemail.com 2011-07-06 13:39:34 EDT --- Is update-desktop-database really needed? kipiplugin.desktop installed in /usr/share/kde4/servicetypes but update-desktop-database searches files in /usr/share/applications.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719323
--- Comment #3 from Rex Dieter rdieter@math.unl.edu 2011-07-06 13:45:01 EDT --- nope, it's not needed, thanks. I'll fix up those issues, and upload a new one here shortly.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719323
--- Comment #4 from Rex Dieter rdieter@math.unl.edu 2011-07-06 13:48:12 EDT --- Spec URL: http://rdieter.fedorapeople.org/rpms/kdegraphics/libkipi.spec SRPM URL: http://rdieter.fedorapeople.org/rpms/kdegraphics/libkipi-4.6.90-2.fc15.src.r...
%changelog * Wed Jul 06 2011 Rex Dieter rdieter@fedoraproject.org 4.6.90-2 - License: GPLv2+ - fix scriptlets - %%doc: +NEWS, -TODO
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719323
--- Comment #5 from Rex Dieter rdieter@math.unl.edu 2011-07-06 13:48:43 EDT --- and %changelog - fix URL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719323
nucleo alekcejk@googlemail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |alekcejk@googlemail.com Flag| |fedora-review?
--- Comment #6 from nucleo alekcejk@googlemail.com 2011-07-09 10:11:59 EDT --- rpmlint output for libkipi-4.6.90-3* rpms and -debuginfo: libkipi.i686: W: spelling-error %description -l en_US Kipi -> Kip, Ki pi, Ki-pi libkipi.src: W: spelling-error %description -l en_US Kipi -> Kip, Ki pi, Ki-pi libkipi.x86_64: W: spelling-error %description -l en_US Kipi -> Kip, Ki pi, Ki-pi libkipi-devel.i686: W: no-documentation libkipi-devel.x86_64: W: no-documentation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719323
nucleo alekcejk@googlemail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #7 from nucleo alekcejk@googlemail.com 2011-07-09 10:26:23 EDT --- So all issues fixed now. Package and spec names are fine, license GPLv2+ is actual license used in libkipi sources, Requires in devel packages is %{name}%{?_isa} = %{version}-%{release}, scriptlets are fine.
Package APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719323
--- Comment #8 from nucleo alekcejk@googlemail.com 2011-07-09 10:38:21 EDT --- Is this package will be built after all other packages from kdegraphics will be ready?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719323
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution| |RAWHIDE Last Closed| |2011-07-10 10:58:03
--- Comment #9 from Rex Dieter rdieter@math.unl.edu 2011-07-10 10:58:03 EDT --- Wrt when to build this, we'll probably wait until the stack up through okular is reviewed first.
Imported (using prior/old libkipi module from kde3 era...)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719323
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |ASSIGNED Resolution|RAWHIDE | Flag| |fedora-cvs? Keywords| |Reopened
--- Comment #10 from Rex Dieter rdieter@math.unl.edu 2011-07-10 11:04:42 EDT --- Looks like this is deprecated in pkgdb, we'll need intervention.
Package Change Request ====================== Package Name: libkipi Owners: than rdieter jreznik kkofler ltinkl rnovacek rrix
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719323
--- Comment #11 from nucleo alekcejk@googlemail.com 2011-07-10 21:22:20 EDT --- It is will be better to change URL to https://projects.kde.org/projects/kde/kdegraphics/libs/libkipi Sorry that I not noticed this before.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719323
--- Comment #12 from Jon Ciesla limb@jcomserv.net 2011-07-11 11:10:33 EDT --- Misformed request, what sort of intervention are you referring to?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719323
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #13 from Rex Dieter rdieter@math.unl.edu 2011-07-11 12:54:29 EDT ---
Package Change Request ====================== Package Name: libkipi Short Description: Common plugin infrastructure for KDE image applications Owners: than rdieter jreznik kkofler ltinkl rnovacek rrix Branches: f15
3 things needed: 1. updated owners 2. f15 branch 3. mark package not deprecated in pkgdb
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719323
--- Comment #14 from Jon Ciesla limb@jcomserv.net 2011-07-11 13:12:34 EDT --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719323
Jon Ciesla limb@jcomserv.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |limb@jcomserv.net
--- Comment #15 from Jon Ciesla limb@jcomserv.net 2011-07-11 13:13:57 EDT --- Created f15 branch, I can't do 1 or 3, you'll need to file a rel-eng trac.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719323
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE Last Closed|2011-07-10 10:58:03 |2011-07-11 13:43:24
--- Comment #16 from Rex Dieter rdieter@math.unl.edu 2011-07-11 13:43:24 EDT --- Ok, thanks!
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=719323
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|656997(kde-reviews) |
package-review@lists.fedoraproject.org