https://bugzilla.redhat.com/show_bug.cgi?id=1183169
Bug ID: 1183169 Summary: Review Request: ykfde - opening LUKS with yubikey Product: Fedora Version: rawhide Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: benjamin.pereto@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://git.nj0y.ch/rpms/ykfde/ykfde.spec SRPM URL: https://git.nj0y.ch/rpms/ykfde/ykfde-0.5.1-2.el7.centos.src.rpm Description: The Package provides the ability to open a LUKS encrypted drive with the Yubikey in challenge response mode (HMAC-SHA1) Fedora Account System Username: nj0y
Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=8645842 (F21)
https://bugzilla.redhat.com/show_bug.cgi?id=1183169
Benjamin Pereto benjamin.pereto@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841 (FE-NEEDSPONSOR)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=1183169
Michael Scherer misc@zarb.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |misc@zarb.org
--- Comment #1 from Michael Scherer misc@zarb.org --- Hi,
A few notes : - you should use macro for various path ( /usr/lib/systemd/system for example ) - i would recommand having 1 buildRequires per line, since that's easier to review on git when there is a change ( ie, in the diff )
- if it install a service, it should run some scriplet for systemd, no ?
https://bugzilla.redhat.com/show_bug.cgi?id=1183169
--- Comment #2 from Benjamin Pereto benjamin.pereto@gmail.com --- Hi,
Thank you for your notes. I updated the spec file.
you should use macro for various path ( /usr/lib/systemd/system for example )
I have the problem, that ex. _libdir is translated to /usr/lib64 on x86_64 systems. no I have changed it to %{_usr}/lib. Is there another way?
i would recommand having 1 buildRequires per line, since that's easier to review on git when there is a change ( ie, in the diff )
I changed it that way.
i would recommand having 1 buildRequires per line, since that's easier to review on git when there is a change ( ie, in the diff )
this case the systemd-service is not required. if you want to change the challenges, then you should.
https://bugzilla.redhat.com/show_bug.cgi?id=1183169
--- Comment #3 from Benjamin Pereto benjamin.pereto@gmail.com ---
if it install a service, it should run some scriplet for systemd, no ?
this case the systemd-service is not required. if you want to change the challenges, then you should.
https://bugzilla.redhat.com/show_bug.cgi?id=1183169
Florian "der-flo" Lehner dev@der-flo.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dev@der-flo.net
--- Comment #4 from Florian "der-flo" Lehner dev@der-flo.net --- hi!
Why don't you use the base source?
URL: https://github.com/nj0y/ykfde Source: https://git.nj0y.ch/download/ykfde-%%7Bversion%7D.tar.gz
%{URL} is a fork from https://github.com/eworm-de/mkinitcpio-ykfde without advantages as far as I can say now. There is also no advantage in using %{Source} from an private git server, which seems like another fork from https://github.com/eworm-de/mkinitcpio-ykfde .
Cheers, Flo
https://bugzilla.redhat.com/show_bug.cgi?id=1183169
--- Comment #5 from Benjamin Pereto benjamin.pereto@gmail.com --- Hi!
Why don't you use the base source?
No problem with that. it's a fork, just to implement the fedora things, which were merged into upstream. Changed it.
https://bugzilla.redhat.com/show_bug.cgi?id=1183169
--- Comment #6 from Benjamin Pereto benjamin.pereto@gmail.com --- I added a Copr Repository for that:
https://copr.fedoraproject.org/coprs/nj0y/ykfde/
https://bugzilla.redhat.com/show_bug.cgi?id=1183169
Orion Poplawski orion@nwra.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |bpereto@fedoraproject.org, | |orion@nwra.com Flags| |needinfo?(bpereto@fedorapro | |ject.org)
--- Comment #7 from Orion Poplawski orion@nwra.com --- Benjamin - Are you still interested in packaging this?
package-review@lists.fedoraproject.org