[Bug 1880721] New: Review Request: hydroxide - A third-party, open-source ProtonMail bridge
https://bugzilla.redhat.com/show_bug.cgi?id=1880721
Bug ID: 1880721 Summary: Review Request: hydroxide - A third-party, open-source ProtonMail bridge Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: proletarius101@protonmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
There are so many dependencies that are not already in Fedora. So I packaged them together (as independent packages).
See the Copr for their spec and src.rpm: https://copr.fedorainfracloud.org/coprs/proletarius101/hydroxide/packages/
It's strange that when I rebuild the same spec from git they failed today (was successful before): https://copr.fedorainfracloud.org/coprs/proletarius101/hydroxide/build/16777.... But fortunately I upload src.rpm from my computer and all of them succeed.
Description:
Hydroxide is a third-party, open-source ProtonMail bridge. For power users only, designed to run on a server.
hydroxide supports CardDAV, IMAP and SMTP.
Fedora Account System Username: proletarius101
It's my first package so it would be nice to have someone as my sponsor. I'm a contributor of hydroxide and it's related packages. We hope to make it into Fedora: https://github.com/emersion/hydroxide/issues/118
https://bugzilla.redhat.com/show_bug.cgi?id=1880721
proletarius101@protonmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841 (FE-NEEDSPONSOR)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=1880721
Fabian Affolter mail@fabian-affolter.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mail@fabian-affolter.ch Doc Type|--- |If docs needed, set a value
--- Comment #1 from Fabian Affolter mail@fabian-affolter.ch --- You need to submit a review request for every package. And please use the template as a lot of reviewers are using fedora-review.
All reviews should block hydroxide.
https://bugzilla.redhat.com/show_bug.cgi?id=1880721
proletarius101@protonmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1881789
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1881789 [Bug 1881789] Review Request: golang-github-emersion-bcrypt - bcrypt from golang.org/x/crypto/bcrypt
https://bugzilla.redhat.com/show_bug.cgi?id=1880721
proletarius101@protonmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1881793
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1881793 [Bug 1881793] Review Request: golang-github-emersion-ical - An iCalendar library for Go.
https://bugzilla.redhat.com/show_bug.cgi?id=1880721
proletarius101@protonmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1881794
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1881794 [Bug 1881794] Review Request: golang-github-emersion-imap - An IMAP library for clients and servers.
https://bugzilla.redhat.com/show_bug.cgi?id=1880721
proletarius101@protonmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1881796
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1881796 [Bug 1881796] Review Request: golang-github-emersion-imap-move - MOVE extension for go-imap.
https://bugzilla.redhat.com/show_bug.cgi?id=1880721
proletarius101@protonmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1881797
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1881797 [Bug 1881797] Review Request: golang-github-emersion-imap-specialuse - Special-Use Mailboxes extension for go-imap.
https://bugzilla.redhat.com/show_bug.cgi?id=1880721
proletarius101@protonmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1881798
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1881798 [Bug 1881798] Review Request: golang-github-emersion-mbox - Package mbox parses the mbox file format into messages and formats messages into mbox files.
https://bugzilla.redhat.com/show_bug.cgi?id=1880721
proletarius101@protonmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1881799
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1881799 [Bug 1881799] Review Request: golang-github-emersion-message - A streaming Go library for the Internet Message Format and mail messages.
https://bugzilla.redhat.com/show_bug.cgi?id=1880721
proletarius101@protonmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1881800
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1881800 [Bug 1881800] Review Request: golang-github-emersion-sasl - A SASL library written in Go.
https://bugzilla.redhat.com/show_bug.cgi?id=1880721
proletarius101@protonmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1881801
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1881801 [Bug 1881801] Review Request: golang-github-emersion-smtp - An SMTP client & server library written in Go.
https://bugzilla.redhat.com/show_bug.cgi?id=1880721
proletarius101@protonmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1881802
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1881802 [Bug 1881802] Review Request: golang-github-emersion-textwrapper - A writer that wraps long text lines to a specified length.
https://bugzilla.redhat.com/show_bug.cgi?id=1880721
proletarius101@protonmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1881803
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1881803 [Bug 1881803] Review Request: golang-github-emersion-vcard - A Go library to parse and format vCard.
https://bugzilla.redhat.com/show_bug.cgi?id=1880721
proletarius101@protonmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1881804
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1881804 [Bug 1881804] Review Request: golang-github-emersion-webdav - A Go library for WebDAV, CalDAV and CardDAV.
https://bugzilla.redhat.com/show_bug.cgi?id=1880721
proletarius101@protonmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1881806
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1881806 [Bug 1881806] Review Request: golang-github-martinlindhe-base36 - Base36 implementation in golang.
https://bugzilla.redhat.com/show_bug.cgi?id=1880721
proletarius101@protonmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1881808
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1881808 [Bug 1881808] Review Request: golang-github-protonmail-crypto - Go supplementary cryptography libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1880721
--- Comment #2 from proletarius101@protonmail.com ---
You need to submit a review request for every package.
Thanks for your instruction!
Those packages are submitted. Please take a look.
https://bugzilla.redhat.com/show_bug.cgi?id=1880721
proletarius101@protonmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Comment|0 |updated
--- Comment #0 has been edited ---
There are so many dependencies that are not already in Fedora. So I packaged them together (as independent packages).
See the Copr for their spec and src.rpm: https://copr.fedorainfracloud.org/coprs/proletarius101/hydroxide/packages/
It's strange that when I rebuild the same spec from git they failed today (was successful before): https://copr.fedorainfracloud.org/coprs/proletarius101/hydroxide/build/16777.... But fortunately I upload src.rpm from my computer and all of them succeed.
Description:
Hydroxide is a third-party, open-source ProtonMail bridge. For power users only, designed to run on a server.
hydroxide supports CardDAV, IMAP and SMTP.
Fedora Account System Username: proletarius101
It's my first package so it would be nice to have someone as my sponsor. I'm a contributor of hydroxide and it's related packages. We hope to make it into Fedora: https://github.com/emersion/hydroxide/issues/118
https://bugzilla.redhat.com/show_bug.cgi?id=1880721
proletarius101@protonmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Comment|0 |updated
--- Comment #0 has been edited ---
Spec URL: https://download.copr.fedorainfracloud.org/results/proletarius101/hydroxide/... SRPM URL: https://download.copr.fedorainfracloud.org/results/proletarius101/hydroxide/...
Description:
Hydroxide is a third-party, open-source ProtonMail bridge. For power users only, designed to run on a server.
hydroxide supports CardDAV, IMAP and SMTP.
Fedora Account System Username: proletarius101
It's my first package so it would be nice to have someone as my sponsor. I'm a contributor of hydroxide and it's related packages. We hope to make it into Fedora: https://github.com/emersion/hydroxide/issues/118
https://bugzilla.redhat.com/show_bug.cgi?id=1880721
Robert-André Mauchin 🐧 zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zebob.m@gmail.com Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review?
--- Comment #3 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- - I prefer:
sed -i 's|golang.org/x/crypto|github.com/ProtonMail/crypto|' $(find . -name *.go)
to match the rest of Go packages.
- the spec file name must match the name of the spec: hydroxide.spec
- Build fails:
# github.com/emersion/hydroxide/protonmail _build/src/github.com/emersion/hydroxide/protonmail/contacts.go:167:66: too many arguments in call to openpgp.CheckArmoredDetachedSignature have (openpgp.KeyRing, *bytes.Buffer, io.Reader, nil) want (openpgp.KeyRing, io.Reader, io.Reader) _build/src/github.com/emersion/hydroxide/protonmail/contacts.go:193:55: too many arguments in call to openpgp.CheckArmoredDetachedSignature have (openpgp.KeyRing, *strings.Reader, *strings.Reader, nil) want (openpgp.KeyRing, io.Reader, io.Reader) _build/src/github.com/emersion/hydroxide/protonmail/crypto.go:39:21: subkey.PublicKey.KeyExpired undefined (type *packet.PublicKey has no field or method KeyExpired) _build/src/github.com/emersion/hydroxide/protonmail/crypto.go:56:137: i.SelfSignature.SigExpired undefined (type *packet.Signature has no field or method SigExpired) _build/src/github.com/emersion/hydroxide/protonmail/crypto.go:73:21: subkey.PublicKey.KeyExpired undefined (type *packet.PublicKey has no field or method KeyExpired) _build/src/github.com/emersion/hydroxide/protonmail/crypto.go:87:80: i.SelfSignature.SigExpired undefined (type *packet.Signature has no field or method SigExpired) _build/src/github.com/emersion/hydroxide/protonmail/srp.go:45:41: too many arguments in call to openpgp.CheckDetachedSignature have (openpgp.EntityList, *bytes.Reader, io.Reader, nil) want (openpgp.KeyRing, io.Reader, io.Reader)
Seems the commit you packaged for ProtonMail/crypto https://github.com/ProtonMail/crypto/commit/5c72a883971a4325f8c62bf07b6d38c2... has been yanked from any branch.
Build is successful after building the latest git commit for ProtonMail/crypto
- License ok - Latest version packaged - Builds in mock - No rpmlint errors - Conforms to Packaging Guidelines
Please fix the aforementioned issue.
https://bugzilla.redhat.com/show_bug.cgi?id=1880721 Bug 1880721 depends on bug 1881794, which changed state.
Bug 1881794 Summary: Review Request: golang-github-emersion-imap - An IMAP library for clients and servers. https://bugzilla.redhat.com/show_bug.cgi?id=1881794
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |CURRENTRELEASE
https://bugzilla.redhat.com/show_bug.cgi?id=1880721 Bug 1880721 depends on bug 1881799, which changed state.
Bug 1881799 Summary: Review Request: golang-github-emersion-message - A streaming Go library for the Internet Message Format and mail messages. https://bugzilla.redhat.com/show_bug.cgi?id=1881799
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |CURRENTRELEASE
https://bugzilla.redhat.com/show_bug.cgi?id=1880721 Bug 1880721 depends on bug 1881802, which changed state.
Bug 1881802 Summary: Review Request: golang-github-emersion-textwrapper - A writer that wraps long text lines to a specified length. https://bugzilla.redhat.com/show_bug.cgi?id=1881802
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |CURRENTRELEASE
https://bugzilla.redhat.com/show_bug.cgi?id=1880721 Bug 1880721 depends on bug 1881800, which changed state.
Bug 1881800 Summary: Review Request: golang-github-emersion-sasl - A SASL library written in Go. https://bugzilla.redhat.com/show_bug.cgi?id=1881800
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |CURRENTRELEASE
https://bugzilla.redhat.com/show_bug.cgi?id=1880721 Bug 1880721 depends on bug 1881801, which changed state.
Bug 1881801 Summary: Review Request: golang-github-emersion-smtp - An SMTP client & server library written in Go. https://bugzilla.redhat.com/show_bug.cgi?id=1881801
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |CURRENTRELEASE
https://bugzilla.redhat.com/show_bug.cgi?id=1880721 Bug 1880721 depends on bug 1881808, which changed state.
Bug 1881808 Summary: Review Request: golang-github-protonmail-crypto - Go supplementary cryptography libraries https://bugzilla.redhat.com/show_bug.cgi?id=1881808
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |CURRENTRELEASE
Product: Fedora Version: rawhide Component: Package Review
Package Review package-review@lists.fedoraproject.org has canceled Package Review package-review@lists.fedoraproject.org's request for Robert-André Mauchin 🐧 zebob.m@gmail.com's needinfo: Bug 1880721: Review Request: hydroxide - A third-party, open-source ProtonMail bridge https://bugzilla.redhat.com/show_bug.cgi?id=1880721
--- Comment #5 from Package Review package-review@lists.fedoraproject.org --- This is an automatic action taken by review-stats script.
The ticket reviewer failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we reset the status and the assignee of this ticket.
https://bugzilla.redhat.com/show_bug.cgi?id=1880721
Maxwell G gotmax@e.email changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |2124347
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2124347 [Bug 2124347] Review Request: golang-github-emersion-mbox - Package mbox parses the mbox file format into messages and formats messages into mbox files
https://bugzilla.redhat.com/show_bug.cgi?id=1880721 Bug 1880721 depends on bug 1881798, which changed state.
Bug 1881798 Summary: Review Request: golang-github-emersion-mbox - Package mbox parses the mbox file format into messages and formats messages into mbox files. https://bugzilla.redhat.com/show_bug.cgi?id=1881798
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |DUPLICATE
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com