https://bugzilla.redhat.com/show_bug.cgi?id=1830712
Bug ID: 1830712 Summary: Review Request: kronometer - A simple KDE stopwatch application Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: aperotti@redhat.com QA Contact: extras-qa@fedoraproject.org CC: extras-qa@fedoraproject.org, i@cicku.me, kevin@tigcc.ticalc.org, nobody@fedoraproject.org, package-review@lists.fedoraproject.org, ppisar@redhat.com Depends On: 1117223 (kronometer) Blocks: 656997 (kde-reviews) Target Milestone: --- Classification: Fedora
Spec URL: https://github.com/andreamtp/kronometer/blob/master/kronometer.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/andreamtp/kronometer/fedo...
Kronometer is a stopwatch application. Kronometer is free software and it's released under the GPLv2 license. Fedora Account System Username: andreamtp
I was looking for a stopwatch for KDE and found kronometer was missing in Fedora, so I've packaged. I've already done some packaging for persona use, but this is my rpm for Fedora.
COPR builds of the packages: https://copr.fedorainfracloud.org/coprs/andreamtp/kronometer/
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=656997 [Bug 656997] kde-related package review tracker https://bugzilla.redhat.com/show_bug.cgi?id=1117223 [Bug 1117223] Review Request: kronometer - A simple KDE stopwatch application
https://bugzilla.redhat.com/show_bug.cgi?id=1830712
Raphael Groner projects.rg@smart.ms changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |201449 (FE-DEADREVIEW)
--- Comment #1 from Raphael Groner projects.rg@smart.ms --- *** Bug 1117223 has been marked as a duplicate of this bug. ***
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=1830712
Raphael Groner projects.rg@smart.ms changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |projects.rg@smart.ms Blocks|201449 (FE-DEADREVIEW) |
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=1830712
--- Comment #2 from Raphael Groner projects.rg@smart.ms --- Please use a link to raw spec file to properly get it downloadable. E.g. https://raw.githubusercontent.com/andreamtp/kronometer/master/kronometer.spe...
Release: 0%{?dist}
Please start with value 1, also in %changelog.
https://bugzilla.redhat.com/show_bug.cgi?id=1830712
Raphael Groner projects.rg@smart.ms changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |177841 (FE-NEEDSPONSOR)
--- Comment #3 from Raphael Groner projects.rg@smart.ms --- Please follow the guidelines to get sponsored as a packager. https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=1830712
Andrea Perotti aperotti@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(projects.rg@smart | |.ms)
--- Comment #4 from Andrea Perotti aperotti@redhat.com --- Updated according the comments above:
Spec URL: https://raw.githubusercontent.com/andreamtp/kronometer/master/kronometer.spe... SRPM URL: https://download.copr.fedorainfracloud.org/results/andreamtp/kronometer/fedo...
Kronometer is a stopwatch application. Kronometer is free software and it's released under the GPLv2 license. Fedora Account System Username: andreamtp
I was looking for a stopwatch for KDE and found kronometer was missing in Fedora, so I've packaged. I've already done some packaging for persona use, but this is my rpm for Fedora.
COPR builds of the packages: https://copr.fedorainfracloud.org/coprs/andreamtp/kronometer/
https://bugzilla.redhat.com/show_bug.cgi?id=1830712
Raphael Groner projects.rg@smart.ms changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(projects.rg@smart | |.ms) |
--- Comment #5 from Raphael Groner projects.rg@smart.ms --- As I'm asked, I can't sponsor you because I'm not in the sponsors group. You need to look for another mentor with the relevant responsibilities.
https://bugzilla.redhat.com/show_bug.cgi?id=1830712
--- Comment #6 from Kevin Kofler kevin@tigcc.ticalc.org --- At a first glance, the specfile looks reasonable to me. Just please also write your name in the changelog and not only the e-mail address.
I have sponsored Andrea. Benvenuto! (Welcome!) Please read https://fedoraproject.org/wiki/Join_the_package_collection_maintainers carefully and follow the process.
I am fluent in Italian (it's the language of my citizenship after all), so if you have any questions you have to ask me, feel free to ask them in Italian if it is easier for you. (Though I guess that as a Red Hat employee, you are probably also used to communicating in English.)
Raphael, can you complete the formal review? (You can approve the package now that the contributor is sponsored.)
https://bugzilla.redhat.com/show_bug.cgi?id=1830712
Raphael Groner projects.rg@smart.ms changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |projects.rg@smart.ms Flags| |fedora-review?
--- Comment #7 from Raphael Groner projects.rg@smart.ms --- Kevin, did you run fedora-review?
Well, FAS name seems to be andreamtp as given in the COPR links.
Generally, are you interested in review swap?
https://bugzilla.redhat.com/show_bug.cgi?id=1830712
--- Comment #8 from Andrea Perotti aperotti@redhat.com --- (In reply to Kevin Kofler from comment #6)
At a first glance, the specfile looks reasonable to me. Just please also write your name in the changelog and not only the e-mail address.
Updated according the comments above:
Spec URL: https://raw.githubusercontent.com/andreamtp/kronometer/master/kronometer.spe... SRPM URL: https://download.copr.fedorainfracloud.org/results/andreamtp/kronometer/fedo...
Kronometer is a stopwatch application. Kronometer is free software and it's released under the GPLv2 license. Fedora Account System Username: andreamtp
I was looking for a stopwatch for KDE and found kronometer was missing in Fedora, so I've packaged. I've already done some packaging for persona use, but this is my rpm for Fedora.
COPR builds of the packages: https://copr.fedorainfracloud.org/coprs/andreamtp/kronometer/
I have sponsored Andrea. Benvenuto! [...]
Thank you very much for the sponsorship and for the welcome!
https://bugzilla.redhat.com/show_bug.cgi?id=1830712
--- Comment #9 from Kevin Kofler kevin@tigcc.ticalc.org --- (In reply to Raphael Groner from comment #7)
Kevin, did you run fedora-review?
No, I didn't, I would have posted the output if I did.
To get a first impression of the quality of a specfile, I tend to trust my eyes more than some tool. :-) But of course, if I am doing a complete formal review, I run fedora-review next, before giving the final approval.
Raphael, are you going to run fedora-review, since you took the review?
https://bugzilla.redhat.com/show_bug.cgi?id=1830712
--- Comment #10 from Kevin Kofler kevin@tigcc.ticalc.org --- E.g., what my pedantic eyes catch is the inconsistent alignment here: BuildRequires: desktop-file-utils BuildRequires: libappstream-glib BuildRequires: extra-cmake-modules
BuildRequires: cmake(Qt5Core) >= 5.9.0 … (The first 2 BuildRequires have 1 space after the colon, all the others have 2 spaces.)
That is not something I would fail a review for (because the users of the package won't even notice), but if I were the maintainer of the package, I would have the instant urge to fix this. :-)
https://bugzilla.redhat.com/show_bug.cgi?id=1830712
--- Comment #11 from Andrea Perotti aperotti@redhat.com --- (In reply to Kevin Kofler from comment #10)
E.g., what my pedantic eyes catch is the inconsistent alignment here: BuildRequires: desktop-file-utils BuildRequires: libappstream-glib BuildRequires: extra-cmake-modules
Eheh, fair enough: fixed.
Spec URL: https://raw.githubusercontent.com/andreamtp/kronometer/master/kronometer.spe... SRPM URL: https://download.copr.fedorainfracloud.org/results/andreamtp/kronometer/fedo...
https://bugzilla.redhat.com/show_bug.cgi?id=1830712
--- Comment #12 from Raphael Groner projects.rg@smart.ms ---
Raphael, are you going to run fedora-review, since you took the review?
Raphael, can you complete the formal review? (You can approve the package now that the contributor is sponsored.)
Well, I thought you intent me to do so. Please feel free to approve.
https://bugzilla.redhat.com/show_bug.cgi?id=1830712
--- Comment #13 from Kevin Kofler kevin@tigcc.ticalc.org ---
Well, I thought you intent me to do so.
That was my intention, actually. I was just surprised that you have not posted fedora-review output yet.
https://bugzilla.redhat.com/show_bug.cgi?id=1830712
Raphael Groner projects.rg@smart.ms changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
https://bugzilla.redhat.com/show_bug.cgi?id=1830712
Raphael Groner projects.rg@smart.ms changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW Assignee|projects.rg@smart.ms |nobody@fedoraproject.org Flags|fedora-review? |
--- Comment #14 from Raphael Groner projects.rg@smart.ms --- TBH I fail to find the time to do the official review in near future, sorry.
https://bugzilla.redhat.com/show_bug.cgi?id=1830712
Kevin Kofler kevin@tigcc.ticalc.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |kevin@tigcc.ticalc.org Flags| |fedora-review?
--- Comment #15 from Kevin Kofler kevin@tigcc.ticalc.org --- I'll take the review then, I hope I'll get it done soon. If I take too long, please remind me. :-)
https://bugzilla.redhat.com/show_bug.cgi?id=1830712
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |ppisar@redhat.com
Product: Fedora Version: rawhide Component: Package Review
Kevin Kofler kevin@tigcc.ticalc.org has canceled Package Review package-review@lists.fedoraproject.org's request for Kevin Kofler kevin@tigcc.ticalc.org's needinfo: Bug 1830712: Review Request: kronometer - A simple KDE stopwatch application https://bugzilla.redhat.com/show_bug.cgi?id=1830712
--- Comment #17 from Kevin Kofler kevin@tigcc.ticalc.org --- I am still interested in doing the review, if the submitter is still interested too. I hope to find time this weekend.
https://bugzilla.redhat.com/show_bug.cgi?id=1830712
Kevin Kofler kevin@tigcc.ticalc.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(kevin@tigcc.tical | |c.org) |
--- Comment #17 from Kevin Kofler kevin@tigcc.ticalc.org --- I am still interested in doing the review, if the submitter is still interested too. I hope to find time this weekend.
https://bugzilla.redhat.com/show_bug.cgi?id=1830712
--- Comment #18 from Andrea Perotti aperotti@redhat.com --- (In reply to Kevin Kofler from comment #17)
I am still interested in doing the review, if the submitter is still interested too. I hope to find time this weekend.
Yes please, would be really appreciated.
Spec URL: https://raw.githubusercontent.com/andreamtp/kronometer/master/kronometer.spe...
# dnf copr enable andreamtp/kronometer
<or>
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/andreamtp/kronometer/fedora-...
In COPR can be found repos and builds for F33, F34, F35 and Rawhide
Looking for your feedback!
https://bugzilla.redhat.com/show_bug.cgi?id=1830712
--- Comment #19 from Kevin Kofler kevin@tigcc.ticalc.org --- OK, I'll try to get this finally done this week.
https://bugzilla.redhat.com/show_bug.cgi?id=1830712
--- Comment #20 from Kevin Kofler kevin@tigcc.ticalc.org --- fedora-review output: https://download.copr.fedorainfracloud.org/results/kkofler/kronometer-review...
I still need to go through the manually-checked items, but one thing fedora-review complains about is that you do not have a BuildRequires: gcc-c++ (but are instead implicitly relying on Qt/KDE -devel packages dragging it in transitively). I think adding an explicit BuildRequires: gcc-c++ would be a good idea.
Product: Fedora Version: rawhide Component: Package Review
Kevin Kofler kevin@tigcc.ticalc.org has canceled Package Review package-review@lists.fedoraproject.org's request for Kevin Kofler kevin@tigcc.ticalc.org's needinfo: Bug 1830712: Review Request: kronometer - A simple KDE stopwatch application https://bugzilla.redhat.com/show_bug.cgi?id=1830712
--- Comment #22 from Kevin Kofler kevin@tigcc.ticalc.org --- Seeing how I have somehow managed to let this sit for a whole year again, I guess resetting the flags is the honest thing to do, and I am doing that hereby, sorry.
https://bugzilla.redhat.com/show_bug.cgi?id=1830712
Kevin Kofler kevin@tigcc.ticalc.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|kevin@tigcc.ticalc.org |nobody@fedoraproject.org Flags|fedora-review? | |needinfo?(kevin@tigcc.tical | |c.org) | Status|ASSIGNED |NEW
--- Comment #22 from Kevin Kofler kevin@tigcc.ticalc.org --- Seeing how I have somehow managed to let this sit for a whole year again, I guess resetting the flags is the honest thing to do, and I am doing that hereby, sorry.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com