Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: ode - High performance library for simulating rigid body dynamics

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197641

j.w.r.degoede@hhs.nl changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |hugo@devin.com.br

------- Additional Comments From j.w.r.degoede@hhs.nl 2006-07-05 03:31 EST ------- Hugo,

I've submitted this for review as I'll be the primary maintainer as discussed per mail. Can you review this?

Others,

Notice that ode contains and will use a private copy of the Opcode collision detect library. This has been "discussed" on f-e-l, that is I posted my intention to package ode with this private copy an rational for it and nobody objected (actually no body replied).

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: ode - High performance library for simulating rigid body dynamics

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197641

------- Additional Comments From hugo@devin.com.br 2006-07-05 13:06 EST ------- I can't connect to people.atrpms.net, the host is unreachable (I can't ping or connect to port 80). Is it a problem only with me? (I'll try sometime later too). Once I get the SRPM I'll begin doing the review.

To the others about the opcode collision detection lib, here is the thread: https://www.redhat.com/archives/fedora-extras-list/2006-June/msg01139.html

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: ode - High performance library for simulating rigid body dynamics

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197641

hugo@devin.com.br changed:

What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| |

------- Additional Comments From hugo@devin.com.br 2006-07-05 16:07 EST ------- I've got the SRPM and now I'll do the review.

MUST OK:

* rpmlint returns ok for the ode package. The source does not contain documentation for development files, so rpmlint's warning about no-documentation on ode-devel should be fine. * Package is named according to Packaging Guidelines (following upstream's name too) * Spec file name matches the base package * Package meets Packaging Guidelines * Package is legal and licensed under BSD and LGPL, the license field on spec matches the source license. * License files within the source tarball are packaged as %%doc files. * Spec file is in American English and legible :) * Source package matches the upstream tarball: 7afdb1d434a1e2cc2d701fdf8d1f2fad ode-src-0.6.zip * Package builds fine * All BR listed fine, no unusued BR listed. * Package does not need locale files. * The package contains shared libraries and have ldconfig run in %%post and %%postun. * Package owns all directory it creates, does not own other packages' directories. * No duplicate files in %%files * Permission on packaged files are fine * The %%clean section on the spec file is right * Spec file uses macros consistently * No large documentation files in the package, no need for -doc subpackage. * %%doc files does not affect package runtime. * Development files are under the -devel subpackage. * No pkgconfig files. * Devel package requires the base package using a fully versioned dependency * No .la files in the packages. * No GUI application under the package.

SHOULD OK:

* No scriptlets use * Package build and works fine for i386 and x86_64

I don't see any blockers on this.

APPROVED

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: ode - High performance library for simulating rigid body dynamics

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=197641

j.w.r.degoede@hhs.nl changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution| |NEXTRELEASE

------- Additional Comments From j.w.r.degoede@hhs.nl 2006-07-06 03:02 EST ------- Imported and build.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=197641

Kevin Fenzi kevin@tummy.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+

--- Comment #7 from Kevin Fenzi kevin@tummy.com 2010-04-09 00:46:47 EDT --- cvs done.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=197641

--- Comment #9 from Jon Ciesla limb@jcomserv.net 2011-07-14 19:34:40 EDT --- Git done (by process-git-requests).