https://bugzilla.redhat.com/show_bug.cgi?id=1662550

--- Comment #1 from Robert-André Mauchin zebob.m@gmail.com --- - Add hicolor-icon-theme to Requires to own the icon directories

- Verify the .desktop file

BuildRequires: desktop-file-utils

desktop-file-validate %{buildroot}/%{_datadir}/applications/{name}.desktop

Package Review ==============

Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed

Issues: ======= - Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file.

===== MUST items =====

C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs.

Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GNU Lesser General Public License (v3)", "GNU Lesser General Public License (v3 or later)", "Unknown or generated". 61 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/shadowsocks-qt5/review-shadowsocks- qt5/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in shadowsocks-qt5-debuginfo , shadowsocks-qt5-debugsource [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic: [x]: Rpmlint is run on all installed packages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.

Rpmlint ------- Checking: shadowsocks-qt5-3.0.1-1.fc30.x86_64.rpm shadowsocks-qt5-debuginfo-3.0.1-1.fc30.x86_64.rpm shadowsocks-qt5-debugsource-3.0.1-1.fc30.x86_64.rpm shadowsocks-qt5-3.0.1-1.fc30.src.rpm shadowsocks-qt5.x86_64: W: no-manual-page-for-binary ss-qt5 4 packages and 0 specfiles checked; 0 errors, 1 warnings.

https://bugzilla.redhat.com/show_bug.cgi?id=1662550

--- Comment #3 from Zamir SUN sztsian@gmail.com --- Please post path to SPEC file and SRPM again whenever you fixed some thing.

In your commit

desktop-file-validate %{buildroot}%{_datadir}/applications/{name}.desktop

This caused a build failure. You missed a % before the {name} variable.

https://bugzilla.redhat.com/show_bug.cgi?id=1662550

--- Comment #5 from sensor.wen@gmail.com --- Thanks. fixed.

https://github.com/FZUG/repo/commit/5120066983a6355162a29d18966cc788e9539ad6

https://bugzilla.redhat.com/show_bug.cgi?id=1662550

Mattia Verga mattia.verga@protonmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|POST |NEW Assignee|zebob.m@gmail.com |nobody@fedoraproject.org Flags|fedora-review+ |needinfo?(sensor.wen@gmail. | |com)

--- Comment #7 from Mattia Verga mattia.verga@protonmail.com --- Review stalled