https://bugzilla.redhat.com/show_bug.cgi?id=1888351

Fabian Affolter mail@fabian-affolter.ch changed:

What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: |python-volvooncall - |python-volvooncall - |Communicate with Volco On |Communicate with Volvo On |Call |Call

https://bugzilla.redhat.com/show_bug.cgi?id=1888351

Andy Mender andymenderunix@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+

--- Comment #1 from Andy Mender andymenderunix@gmail.com --- Rpmlint found some forgotten shebangs, please remove them: python3-volvooncall.noarch: E: non-executable-script /usr/lib/python3.9/site-packages/volvooncall/mqtt.py 644 /usr/bin/env python3 python3-volvooncall.noarch: E: non-executable-script /usr/lib/python3.9/site-packages/volvooncall/volvooncall.py 644 /usr/bin/env python3

The rest looks good so you can do it on package import. Full review below:

Package Review ==============

Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed

Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://docs.fedoraproject.org/en-US/packaging-guidelines/

===== MUST items =====

Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 12 files have unknown license. Detailed output of licensecheck in /home/amender/rpmbuild/SPECS/python- volvooncall/python-volvooncall/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local

Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic: [x]: Reviewer should test that the package builds in mock. [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. Review: All fine. Link to the ticket with upstream is in the SPEC file. [x]: Final provides and requires are sane (see attachments). [-]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_use_rpmlint

Installation errors ------------------- INFO: mock.py version 2.6 starting (python version = 3.8.5)... Start: init plugins INFO: selinux enabled Finish: init plugins INFO: Signal handler active Start: run Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled package manager cache Start: cleaning package manager metadata Finish: cleaning package manager metadata INFO: enabled HW Info plugin Mock Version: 2.6 INFO: Mock Version: 2.6 Finish: chroot init INFO: installing package(s): /home/amender/rpmbuild/SPECS/python-volvooncall/python3-volvooncall-0.8.12-1.fc34.noarch.rpm ERROR: Command failed: # /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 34 --setopt=deltarpm=False --allowerasing --disableplugin=local --disableplugin=spacewalk install /home/amender/rpmbuild/SPECS/python-volvooncall/python3-volvooncall-0.8.12-1.fc34.noarch.rpm --setopt=tsflags=nocontexts

Rpmlint ------- Checking: python3-volvooncall-0.8.12-1.fc34.noarch.rpm python-volvooncall-0.8.12-1.fc34.src.rpm python3-volvooncall.noarch: E: non-executable-script /usr/lib/python3.9/site-packages/volvooncall/mqtt.py 644 /usr/bin/env python3 python3-volvooncall.noarch: E: non-executable-script /usr/lib/python3.9/site-packages/volvooncall/volvooncall.py 644 /usr/bin/env python3 python3-volvooncall.noarch: W: no-manual-page-for-binary voc 2 packages and 0 specfiles checked; 2 errors, 1 warnings.

Source checksums ---------------- https://files.pythonhosted.org/packages/source/v/volvooncall/volvooncall-0.8... : CHECKSUM(SHA256) this package : 6744ce4a3a3e0363878ce0150dd5b1995dbee765e6667ad4cae3fbf611883d86 CHECKSUM(SHA256) upstream package : 6744ce4a3a3e0363878ce0150dd5b1995dbee765e6667ad4cae3fbf611883d86

Requires -------- python3-volvooncall (rpmlib, GLIBC filtered): /usr/bin/python3 python(abi) python3.9dist(aiohttp) python3.9dist(certifi) python3.9dist(docopt) python3.9dist(geopy) python3.9dist(hbmqtt) python3.9dist(pyyaml) python3.9dist(setuptools)

Provides -------- python3-volvooncall: python-volvooncall python3-volvooncall python3.9-volvooncall python3.9dist(volvooncall) python3dist(volvooncall)

https://bugzilla.redhat.com/show_bug.cgi?id=1888351

--- Comment #3 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-volvooncall

https://bugzilla.redhat.com/show_bug.cgi?id=1888351

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA

--- Comment #5 from Fedora Update System updates@fedoraproject.org --- FEDORA-2020-c6f8e6033e has been pushed to the Fedora 33 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-c6f8e6033e *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-c6f8e6033e

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

https://bugzilla.redhat.com/show_bug.cgi?id=1888351 Bug 1888351 depends on bug 1888345, which changed state.

Bug 1888345 Summary: Review Request: python-hbmqtt - MQTT client/broker https://bugzilla.redhat.com/show_bug.cgi?id=1888345

What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |WONTFIX

https://bugzilla.redhat.com/show_bug.cgi?id=1888351

Mattia Verga mattia.verga@proton.me changed:

What |Removed |Added ---------------------------------------------------------------------------- Depends On|1888345 |

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1888345 [Bug 1888345] Review Request: python-hbmqtt - MQTT client/broker