Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: openjpeg - JPEG 2000 codec library

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229098

lxtnow@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |lxtnow@gmail.com

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: openjpeg - JPEG 2000 codec library

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229098

------- Additional Comments From lxtnow@gmail.com 2007-02-18 22:02 EST ------- rpmlint ouput error on -devel package:

no-documentation.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: openjpeg - JPEG 2000 codec library

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229098

------- Additional Comments From seg@haxxed.com 2007-02-23 19:10 EST ------- Sorry, I got tied up with other things. Updated package:

http://www.haxxed.com/rpms/secondlife/openjpeg-1.1-2.src.rpm http://www.haxxed.com/rpms/secondlife/openjpeg.spec

* Sat Feb 17 2007 Callum Lerwick seg@haxxed.com 1.1-2 - Move header to a subdirectory. - Fix makefile patch to preserve timestamps during install.

I hate using macros unless there's a really good reason. The package name is very unlikely to change, and on the rare occasion that it might, a search and replace isn't a big deal. So I avoid using %{name}

The no-doc warning on the devel package is ignoreable. The main package has docs. Hmmm, I actually need to go over the docs, README.linux shouldn't be packaged and ChangeLog might be better in the devel package. And where's the license...

I figure the purpose of the makefile patch is self evident, based on the name and by taking a look at it. I put in a comment for the others because otherwise it would not be clear that they're there for the benefit of another package.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: openjpeg - JPEG 2000 codec library

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229098

------- Additional Comments From seg@haxxed.com 2007-03-11 15:53 EST ------- http://www.haxxed.com/rpms/secondlife/openjpeg-1.1.1-1.src.rpm http://www.haxxed.com/rpms/secondlife/openjpeg.spec

* Fri Feb 23 2007 Callum Lerwick seg@haxxed.com 1.1.1-1 - New upstream version, which has the SL patches merged.

I still need to email upstream about including the license.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: openjpeg - JPEG 2000 codec library

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229098

------- Additional Comments From lxtnow@gmail.com 2007-03-12 08:09 EST ------- s/Can/Can't

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: openjpeg - JPEG 2000 codec library

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229098

seg@haxxed.com changed:

What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO| |233946 nThis| |

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: openjpeg - JPEG 2000 codec library

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229098

------- Additional Comments From lxtnow@gmail.com 2007-04-05 21:43 EST ------- Well,

any answers from upstream about license ?

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: openjpeg - JPEG 2000 codec library Alias: openjpeg

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229098

cweyl@alumni.drew.edu changed:

What |Removed |Added ---------------------------------------------------------------------------- Alias| |openjpeg

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: openjpeg - JPEG 2000 codec library Alias: openjpeg

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229098

bugzilla@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Priority|normal |medium

j.w.r.degoede@hhs.nl changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |j.w.r.degoede@hhs.nl

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: openjpeg - JPEG 2000 codec library Alias: openjpeg

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229098

------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-05-14 20:28 EST ------- I will close this bug as NOTABUG if any response from the reporter is gained within one week

http://fedoraproject.org/wiki/Extras/Policy/StalledReviews

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: openjpeg - JPEG 2000 codec library Alias: openjpeg

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229098

seg@haxxed.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED Flag|needinfo?(seg@haxxed.com) |

------- Additional Comments From seg@haxxed.com 2007-05-21 17:29 EST ------- I just submitted a bunch of patches yesterday, they may have been waiting on that. I have a package based on SVN, however the ABI has sort of broken due to a bunch of stuff for Cinema4k being added to the encoder parameter structure. Upstream tried to prevent it, but on Fedora, it still crashes apps with "stack smashing detected". Not sure how to deal with this.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: openjpeg - JPEG 2000 codec library Alias: openjpeg

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229098

kwizart@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |kwizart@gmail.com

------- Additional Comments From kwizart@gmail.com 2007-06-06 16:53 EST ------- Hi! 4 June 2007: Version 1.2 Released

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: openjpeg - JPEG 2000 codec library Alias: openjpeg

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229098

------- Additional Comments From seg@haxxed.com 2007-06-13 20:44 EST ------- My upgrade to F7 went smoothly as usual. (note: sarcasm) I'll upload an updated package shortly.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: openjpeg - JPEG 2000 codec library Alias: openjpeg

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229098

------- Additional Comments From j.w.r.degoede@hhs.nl 2007-06-14 14:27 EST ------- (In reply to comment #21)

• New upstream version, ABI has broken, upstream has bumped soname.

Since this is still under review, and thius not in Fedora, we do not have anything depending on this already in the repo, right? Then this shouldn't be a problem.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: openjpeg - JPEG 2000 codec library Alias: openjpeg

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229098

------- Additional Comments From lxtnow@gmail.com 2007-06-15 04:57 EST ------- OK - Mock : Built on F-7 (x86_64) ? - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License field in spec matches OK - License is GPL OK - License match extras packaging policy licenses allowed OK - License file is included in package OK - Spec in American English OK - Spec is legible. OK - Sources SHOULD match upstream md5sum: 4973c564c96683a921a7f6759906da4e openjpeg_v1_2.tar.gz OK - Package has correct buildroot. OK - extras BuildRequires are not redundant. OK - %build and %install stages are correct and work. OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories that other packages own. OK - Changelog section is correct.

OK - Should function as described. OK - Should package latest version

------------------------------------------- Rpmlint output: ------------------------------------------- OK - silent on both srpm and main/sub package rpm

------------------------------------------- Sub-packages: ------------------------------------------- They need some improvment. according to the scheme of opengjpeg the main package should contain all bin files, that imply to remove -bin subpackage (which not really usefull). And if other packages work with/need-to openjpeg lib for developping work, provide a subpackage named -lib or -n libopenjpeg.

Also Changelog file should be in the main package.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: openjpeg - JPEG 2000 codec library Alias: openjpeg

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229098

tibbs@math.uh.edu changed:

What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163776 | nThis| |

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: openjpeg - JPEG 2000 codec library Alias: openjpeg

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229098

------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-07-03 14:03 EST ------- Again ping?

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: openjpeg - JPEG 2000 codec library Alias: openjpeg

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229098

seg@haxxed.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED Flag|needinfo?(seg@haxxed.com) |

------- Additional Comments From seg@haxxed.com 2007-07-24 15:41 EST ------- Hmmm, I'm trying to get some patches upstreamed. I should probably get a new package out in the mean time.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: openjpeg - JPEG 2000 codec library Alias: openjpeg

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229098

------- Additional Comments From lxtnow@gmail.com 2007-08-14 13:49 EST ------- Okay, All issues above has been fixed.

However, the release tag need to be fix. As a pre-release svn checkout, its should be set like this: 0.%{X}.%{alphatag} So move it to "0.1.%{snapshot}%{?dist}" instead of "2.%{snapshot}%{?dist}".

Also note that as an snapshot version, you should comment above the source0 the svn external link to get the source.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: openjpeg - JPEG 2000 codec library Alias: openjpeg

https://bugzilla.redhat.com/show_bug.cgi?id=229098

opensource@till.name changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |opensource@till.name

------- Additional Comments From opensource@till.name 2007-09-08 03:38 EST ------- (In reply to comment #31)

@Callum About the snapshoot, it is often recommanded to use a bash script to retrieve the sources (and remove CVS or .svn ), so you can have a method to compare

The Guidelines demand a documented way how to create a snapshot tarball: http://fedoraproject.org/wiki/Packaging/SourceURL#head-615f6271efb394ab340a9... And a hint for svn: You can use "svn export" instead of "svn co" to avoid the creation of .svn directories.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: openjpeg - JPEG 2000 codec library Alias: openjpeg

https://bugzilla.redhat.com/show_bug.cgi?id=229098

------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-10-03 05:29 EST ------- Again ping?

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: openjpeg - JPEG 2000 codec library Alias: openjpeg

https://bugzilla.redhat.com/show_bug.cgi?id=229098

kwizart@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO Flag| |needinfo?(seg@haxxed.com)

------- Additional Comments From kwizart@gmail.com 2007-10-14 19:38 EST ------- This package needs cvs to be Requested by the Reporter. See: http://fedoraproject.org/wiki/PackageMaintainers/CVSAdminProcedure

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: openjpeg - JPEG 2000 codec library Alias: openjpeg

https://bugzilla.redhat.com/show_bug.cgi?id=229098

------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-11-02 05:24 EST ------- By the way:

(In reply to comment #29)

http://www.haxxed.com/rpms/secondlife/openjpeg.spec http://www.haxxed.com/rpms/secondlife/openjpeg-1.2-2.20070808svn.fc7.src.rpm

• Thu Aug 09 2007 Callum Lerwick seg@haxxed.com 1.2-2.20070808svn

• Put binaries in main package, move libraries to -libs subpackage.

Rebuild fails at least on ppc and ppc64. http://koji.fedoraproject.org/koji/taskinfo?taskID=224231

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: openjpeg - JPEG 2000 codec library Alias: openjpeg

https://bugzilla.redhat.com/show_bug.cgi?id=229098

mtasaka@ioa.s.u-tokyo.ac.jp changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO Flag| |needinfo?(seg@haxxed.com)

------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-11-16 07:00 EST ------- Again ping, Callum?

If this package is okay, please do CVS procedure ( http://fedoraproject.org/wiki/PackageMaintainers/CVSAdminProcedure )

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: openjpeg - JPEG 2000 codec library Alias: openjpeg

https://bugzilla.redhat.com/show_bug.cgi?id=229098

seg@haxxed.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?

------- Additional Comments From seg@haxxed.com 2007-11-16 23:05 EST ------- New Package CVS Request ======================= Package Name: openjpeg Short Description: JPEG 2000 codec library Owners: seg Branches: F-7 F-8 InitialCC: seg Cvsextras Commits: yes

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: openjpeg - JPEG 2000 codec library Alias: openjpeg

https://bugzilla.redhat.com/show_bug.cgi?id=229098

------- Additional Comments From updates@fedoraproject.org 2007-11-20 12:56 EST ------- openjpeg-1.2-3.20071114svn480.fc7 has been pushed to the Fedora 7 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update openjpeg'

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: openjpeg - JPEG 2000 codec library Alias: openjpeg

https://bugzilla.redhat.com/show_bug.cgi?id=229098

------- Additional Comments From gwirth79@gmail.com 2007-11-25 14:15 EST ------- openjpeg-devel-1.2-3.20071114svn480.fc8 openjpeg.h header file and library do not match. Installed on Fedora 8 system fully updated as of 11/25/2007

Simple program: openjpegtest.c

#include <stdio.h> #include <openjpeg/openjpeg.h> int main( void ) { return 0; }

Compile: gcc -o tmp.out openjpegtest.c -lopenjpeg

Results:

/usr/lib/gcc/i386-redhat-linux/4.1.2/../../../libopenjpeg.so: undefined reference to `floor' /usr/lib/gcc/i386-redhat-linux/4.1.2/../../../libopenjpeg.so: undefined reference to `ceilf' /usr/lib/gcc/i386-redhat-linux/4.1.2/../../../libopenjpeg.so: undefined reference to `floorf' /usr/lib/gcc/i386-redhat-linux/4.1.2/../../../libopenjpeg.so: undefined reference to `lrintf' /usr/lib/gcc/i386-redhat-linux/4.1.2/../../../libopenjpeg.so: undefined reference to `pow' collect2: ld returned 1 exit status

Looks like a math include got left out

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: openjpeg - JPEG 2000 codec library Alias: openjpeg

https://bugzilla.redhat.com/show_bug.cgi?id=229098

------- Additional Comments From seg@haxxed.com 2007-11-25 15:08 EST ------- Yeah, that's a link error. gcc *should* be replacing those functions with inline code on i386, though.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: openjpeg - JPEG 2000 codec library Alias: openjpeg

https://bugzilla.redhat.com/show_bug.cgi?id=229098

updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |ERRATA Fixed In Version| |1.2-3.20071114svn480.fc7

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=229098

Adam Goode adam@spicenitz.org changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |adam@spicenitz.org Flag|fedora-cvs+ |fedora-cvs?

--- Comment #51 from Adam Goode adam@spicenitz.org 2009-09-23 14:02:34 EDT --- Package Change Request ====================== Package Name: openjpeg New Branches: EL-5 Owners: agoode

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=229098

Vincent Danen vdanen@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Alias|openjpeg |