https://bugzilla.redhat.com/show_bug.cgi?id=1654881
Bug ID: 1654881 Summary: Review Request: rsc-pdf - PDF Reader for Go Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: deparker@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://raw.githubusercontent.com/derekparker/rsc-pdf-rpm/v0-0.1/pdf.spec SRPM URL: https://github.com/derekparker/rsc-pdf-rpm/releases/download/v0-0.1/golang-r... Description: PDF reader for Go. Fedora Account System Username: deparker
https://bugzilla.redhat.com/show_bug.cgi?id=1654881
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@gmail.com
--- Comment #1 from Robert-André Mauchin zebob.m@gmail.com --- - %defattr(-,root,root,-): This is not needed
- I don't understand the point of:
%dir %attr(755,root,root) %{gopath}/src/%{goipath} %{gopath}/src/%{goipath}/*.go %{gopath}/src/%{goipath}/pdfpasswd/*.go
All the files should already be specified in devel.file-list and thus do not need to be specified manually.
- Why is there a trailing "toolchain." in the common description?
- Upstream provides releases: https://github.com/rsc/pdf/releases
You should use them:
%global goipath rsc.io/pdf %global forgeurl https://github.com/rsc/pdf Version: 0.1.1
%global common_description %{expand: PDF reader implemented in Go.}
%gometa
Name: %{goname} Release: 1%{?dist}
https://bugzilla.redhat.com/show_bug.cgi?id=1654881
--- Comment #2 from Derek Parker deparker@redhat.com --- Thanks for the review, updated:
SRPM: https://github.com/derekparker/rsc-pdf-rpm/releases/download/v0.1.1-1/golang... SPEC: https://raw.githubusercontent.com/derekparker/rsc-pdf-rpm/v0.1.1-1/pdf.spec
https://bugzilla.redhat.com/show_bug.cgi?id=1654881
Derek Parker deparker@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |jcajka@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1654881
--- Comment #3 from Robert-André Mauchin zebob.m@gmail.com --- - Version-Release info is erroneous in the %changelog entry:
* Wed Nov 28 2018 Derek Parker deparker@redhat.com - 0.1.1-1
- Don't mix tabs and spaces:
Version: 0.1.1
- SPEC file should be named golang-rsc-pdf.spec
https://bugzilla.redhat.com/show_bug.cgi?id=1654881
Jakub Čajka jcajka@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|jcajka@redhat.com |nobody@fedoraproject.org
package-review@lists.fedoraproject.org