Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review request: rubygem-jammit - Industrial Strength Asset Packaging for Rails
https://bugzilla.redhat.com/show_bug.cgi?id=739478
Summary: Review request: rubygem-jammit - Industrial Strength Asset Packaging for Rails Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: unspecified Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: bkabrda@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org Classification: Fedora Story Points: --- Type: ---
SPEC: http://bkabrda.fedorapeople.org/jammit/rubygem-jammit.spec SRPM: http://bkabrda.fedorapeople.org/jammit/rubygem-jammit-0.6.3-1.fc15.src.rpm
Description: Jammit is an industrial strength asset packaging library for Rails, providing both the CSS and JavaScript concatenation and compression that you'd expect, as well as YUI Compressor and Closure Compiler compatibility, ahead-of-time gzipping, built-in JavaScript template support, and optional Data-URI / MHTML image embedding.
Note: This package is a bit tricky. Two tests fail without rubygem-closure-compiler installed, four more tests fail when testing with Rails >= 3. Jammit can however be used even without closure-compiler, so I didn't list it in BR: nor R: sections. The failing tests are already reported (see links in comments in spec file). Also, please note, that you need to install rubygem-yui-compressor (https://bugzilla.redhat.com/show_bug.cgi?id=725768) and you currently need to place yuicompressor-2.4.4.jar under /usr/share/java/ manually to rebuild this package.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=739478
Bohuslav Kabrda bkabrda@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends on| |725768
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=739478
Vít Ondruch vondruch@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |vondruch@redhat.com AssignedTo|nobody@fedoraproject.org |vondruch@redhat.com Flag| |fedora-review?
--- Comment #1 from Vít Ondruch vondruch@redhat.com 2011-09-21 02:13:26 EDT --- Taking this for a review.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=739478
Vít Ondruch vondruch@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=739478
Vít Ondruch vondruch@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |705521
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=739478
James Laska jlaska@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jlaska@redhat.com
--- Comment #2 from James Laska jlaska@redhat.com 2011-10-04 15:38:22 EDT --- (In reply to comment #1)
Taking this for a review.
Any updates?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=739478
James Laska jlaska@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |743402
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=739478
--- Comment #3 from Vít Ondruch vondruch@redhat.com 2011-10-05 02:05:26 EDT --- (In reply to comment #2)
(In reply to comment #1)
Taking this for a review.
Any updates?
Actually this is blocked by review of rhbz#725768 and this is blocked by rhbz#725739 which block everything :/
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=739478
Vít Ondruch vondruch@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|743402 |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=739478
James Laska jlaska@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |743402
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=739478
Mo Morsi mmorsi@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|743402 |
https://bugzilla.redhat.com/show_bug.cgi?id=739478
--- Comment #4 from Bohuslav "Slavek" Kabrda bkabrda@redhat.com --- The yui-compressor dependency has been removed in upstream [1], so it seems that we will be able to proceed, once a new version is released [2]. I will try to look into packaging the new dependencies in the meanwhile.
[1] https://github.com/documentcloud/jammit/commit/28ddf14bc7a33d25734f557594296... [2] https://github.com/documentcloud/jammit/issues/239
https://bugzilla.redhat.com/show_bug.cgi?id=739478 Bug 739478 depends on bug 725768, which changed state.
Bug 725768 Summary: Review Request: rubygem-yui-compressor - JavaScript and CSS minification library https://bugzilla.redhat.com/show_bug.cgi?id=725768
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |NOTABUG
https://bugzilla.redhat.com/show_bug.cgi?id=739478
Vít Ondruch vondruch@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |DEFERRED Last Closed| |2016-10-11 06:22:56
--- Comment #5 from Vít Ondruch vondruch@redhat.com --- I guess you don't mind me closing this review.
https://bugzilla.redhat.com/show_bug.cgi?id=739478
Vít Ondruch vondruch@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |201449 (FE-DEADREVIEW)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=739478
Vít Ondruch vondruch@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |
package-review@lists.fedoraproject.org