Hello friends,
can you please review the SUBJ and let me know what you think about it? Thank you.
https://fedoraproject.org/wiki/User:Lruzicka/QA:Testcase_Remote_logging
On Tue, 2018-05-29 at 19:59 +0200, Lukas Ruzicka wrote:
Hello friends,
can you please review the SUBJ and let me know what you think about it? Thank you.
https://fedoraproject.org/wiki/User:Lruzicka/QA:Testcase_Remote_logging
As the criterion is specific to Server, I'd call it QA:Testcase_Server_remote_logging .
In general the test looks good, thanks! However, looking at the wikitext, you seem to have reproduced the Associated_release_criterion template somehow instead of just...using it. That whole first block should just be:
{{Template:Associated_release_criterion|Beta|remote-logging}}
and that's all it needs.
We should probably run this by Server SIG to verify this is actually how we expect remote logging to work and be set up. I honestly don't recall exactly what our expectations were initially when adding the criterion.
Thanks!
Hello Adam,
I have updated using the template the way you are suggesting and it works as expected. Thanks. Please, do make a review in Server SIG so that I can finalize it and get it ready for real world.
Lukas
On Thu, May 31, 2018 at 6:19 AM, Adam Williamson <adamwill@fedoraproject.org
wrote:
On Tue, 2018-05-29 at 19:59 +0200, Lukas Ruzicka wrote:
Hello friends,
can you please review the SUBJ and let me know what you think about it? Thank you.
https://fedoraproject.org/wiki/User:Lruzicka/QA:Testcase_Remote_logging
As the criterion is specific to Server, I'd call it QA:Testcase_Server_remote_logging .
In general the test looks good, thanks! However, looking at the wikitext, you seem to have reproduced the Associated_release_criterion template somehow instead of just...using it. That whole first block should just be:
{{Template:Associated_release_criterion|Beta|remote-logging}}
and that's all it needs.
We should probably run this by Server SIG to verify this is actually how we expect remote logging to work and be set up. I honestly don't recall exactly what our expectations were initially when adding the criterion.
Thanks!
Adam Williamson Fedora QA Community Monkey IRC: adamw | Twitter: AdamW_Fedora | XMPP: adamw AT happyassassin . net http://www.happyassassin.net _______________________________________________ test mailing list -- test@lists.fedoraproject.org To unsubscribe send an email to test-leave@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/test@lists. fedoraproject.org/message/LX2PTN5OIFMAHM3G7IDCCI3JSZYW56C5/
On Mon, Jun 4, 2018 at 5:43 AM Lukas Ruzicka lruzicka@redhat.com wrote:
Hello Adam,
I have updated using the template the way you are suggesting and it works as expected. Thanks. Please, do make a review in Server SIG so that I can finalize it and get it ready for real world.
For the record, the original criterion was that there must be some way for logging to be sent to a remote log aggregator. We very intentionally didn't name rsyslog, because at the time we were looking at ways for systemd itself to forward its logs (which would include being able to forward along the early boot logs that rsyslog misses).
I haven't followed it terribly closely, but last I heard rsyslog was still the reigning champion in this space, so I think it's *probably* the right way to test. I'd still appreciate if you could forward your proposed test case to the server@lists.fedoraproject.org mailing list so the Server SIG can make a formal decision to accept it.
Thanks!
-
Adam Williamson -
Lukas Ruzicka -
Stephen Gallagher