vdsm-patches November 2011

vdsm-patches@lists.fedorahosted.org

16 participants
335 discussions

Change in vdsm[master]: [WIP] Small objects repository file implementation
by Federico Simoncelli 19 May '14

19 May '14

Federico Simoncelli has uploaded a new change for review. Change subject: [WIP] Small objects repository file implementation ...................................................................... [WIP] Small objects repository file implementation Change-Id: I3003f8652a58c68a966bc37e591c1d1d2308c164 --- M vdsm/storage/fileSD.py M vdsm/storage/hsm.py M vdsm/storage/outOfProcess.py M vdsm/storage/sd.py M vdsm/storage/sp.py M vdsm_cli/vdsClient.py 6 files changed, 83 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/42/242/1 -- To view, visit http://gerrit.ovirt.org/242 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3003f8652a58c68a966bc37e591c1d1d2308c164 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>

2 2

Change in vdsm[master]: Add a chown implementation that looks up uid and gid
by Federico Simoncelli 19 May '14

19 May '14

Federico Simoncelli has uploaded a new change for review. Change subject: Add a chown implementation that looks up uid and gid ...................................................................... Add a chown implementation that looks up uid and gid We already have a case in vdsm (configNetwork) where we need to use a chown function that is capable to convert the owner and group names to uid and gid. Going forward this can be reused for the deployment utilities and to prepare the paths needed by vdsm (eg: /rhev and /var/run/vdsm). Change-Id: Iab6f67ba93a0d9cbac775992623f3bb2ab996555 --- M vdsm/configNetwork.py M vdsm/utils.py 2 files changed, 21 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/87/387/1 -- To view, visit http://gerrit.ovirt.org/387 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iab6f67ba93a0d9cbac775992623f3bb2ab996555 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>

4 6

Change in vdsm[master]: More safe startSpm().
by ewarszaw＠redhat.com 19 May '14

19 May '14

Eduardo has uploaded a new change for review. Change subject: More safe startSpm(). ...................................................................... More safe startSpm(). Change-Id: I1e6b32bdf1dd8dc36f6633306d4edef89d542e31 --- M vdsm/storage/sp.py 1 file changed, 16 insertions(+), 19 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/51/451/1 -- To view, visit http://gerrit.ovirt.org/451 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1e6b32bdf1dd8dc36f6633306d4edef89d542e31 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>

3 4

Change in vdsm[master]: [WIP] Add the base commands to vdsm-tool
by Federico Simoncelli 11 May '14

11 May '14

Federico Simoncelli has uploaded a new change for review. Change subject: [WIP] Add the base commands to vdsm-tool ...................................................................... [WIP] Add the base commands to vdsm-tool Change-Id: Id3f49dc3cbb4dfba86a85ab9348d19684445f40e --- M vdsm-tool/Makefile.am A vdsm-tool/base.py M vdsm.spec.in 3 files changed, 52 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/88/388/1 -- To view, visit http://gerrit.ovirt.org/388 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id3f49dc3cbb4dfba86a85ab9348d19684445f40e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>

2 2

Change in vdsm[master]: [WIP] Add the daemon commands to vdsm-tool
by Federico Simoncelli 11 May '14

11 May '14

Federico Simoncelli has uploaded a new change for review. Change subject: [WIP] Add the daemon commands to vdsm-tool ...................................................................... [WIP] Add the daemon commands to vdsm-tool Change-Id: Ieafb9886f3ffb2433478203186dd94005b2a51e8 --- M vdsm-tool/Makefile.am A vdsm-tool/daemon.py M vdsm.spec.in 3 files changed, 52 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/89/389/1 -- To view, visit http://gerrit.ovirt.org/389 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ieafb9886f3ffb2433478203186dd94005b2a51e8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>

2 2

Change in vdsm[master]: BZ#752470 Related: Don't use SIGTERM in spmprotect.sh
by Federico Simoncelli 11 May '14

11 May '14

Federico Simoncelli has uploaded a new change for review. Change subject: BZ#752470 Related: Don't use SIGTERM in spmprotect.sh ...................................................................... BZ#752470 Related: Don't use SIGTERM in spmprotect.sh Attempting to stop the SPM (SIGUSR1) and using SIGKILL if that fails is already enough. In any case giving vdsm only 2 seconds between SIGTERM and SIGKILL was a too short timeout to hope in a restart. Change-Id: I83e07f966b69e2f8ba803f0d2a5020d90e6029d8 --- M vdsm/storage/protect/spmprotect.sh 1 file changed, 1 insertion(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/65/265/1 -- To view, visit http://gerrit.ovirt.org/265 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I83e07f966b69e2f8ba803f0d2a5020d90e6029d8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>

4 4

[NEW PATCH] Change getChain() to return dictionary with chain itself and its template. (via gerrit-bot)
by Igor Lvovsky 24 May '12

24 May '12

New patch submitted by Igor Lvovsky (ilvovsky(a)redhat.com) You can review this change at: http://gerrit.usersys.redhat.com/692 commit 3a09f874889cb372ee84b04a234f7b653458e26f Author: Igor Lvovsky <ilvovsky(a)redhat.com> Date: Tue Jul 12 15:18:45 2011 +0300 Change getChain() to return dictionary with chain itself and its template. This change will avoid unneeded produceVolume and improve behaviour of different flows. Change-Id: Ife46d592171aedea087e0d6462b735cd7e0d75e0 diff --git a/vdsm/storage/image.py b/vdsm/storage/image.py index 1c70a34..102ea6c 100644 --- a/vdsm/storage/image.py +++ b/vdsm/storage/image.py @@ -104,7 +104,7 @@ class Image: # 1. Remove template's image: Create 'fake' template instead of deleted one # 2. Remove regular image: Remove parent-'fake' template if nobody need it already try: - pvol = self.getTemplate(sdUUID=sdUUID, imgUUID=imgUUID) + pvol = self.getChain(sdUUID, imgUUID)['template'] # 1. If we required to delete template's image that have VMs # based on it, we should create similar 'fake' template instead if pvol: @@ -269,17 +269,16 @@ class Image: return newImgUUID - def __chainSizeCalc(self, sdUUID, imgUUID, volUUID, size): + def __chainSizeCalc(self, sdUUID, imgUUID, size): """ Compute an estimate of the whole chain size using the sum of the actual size of the chain's volumes """ - chain = self.getChain(sdUUID, imgUUID, volUUID) + chainDict = self.getChain(sdUUID, imgUUID) newsize = 0 - template = chain[0].getParentVolume() - if template: - newsize = template.getVolumeSize() - for vol in chain: + if chainDict['template']: + newsize = chainDict['template'].getVolumeSize() + for vol in chainDict['chain']: newsize += vol.getVolumeSize() if newsize > size: newsize = size @@ -301,12 +300,14 @@ class Image: newsize = int(newsize * 1.1) # allocate %10 more for cow metadata return newsize - def getChain(self, sdUUID, imgUUID, volUUID=None): + def getChain(self, sdUUID, imgUUID): """ - Return the chain of volumes of image as a sorted list - (not including a shared base (template) if any) + Return the dictionary with chain of volumes of image as a sorted list + (not including a shared base (template)) and the template if any """ - chain = [] + # 'chain' - chain of volumes of image as a sorted list + # 'template' - shared base (template) if any + chainDict = {'chain':[], 'template':None} # Find all volumes of image volclass = SDF.produce(sdUUID).getVolumeClass() uuidlist = volclass.getImageVolumes(self.repoPath, sdUUID, imgUUID) @@ -316,14 +317,13 @@ class Image: srcVol = volclass(self.repoPath, sdUUID, imgUUID, uuidlist[0]) # For template image include only one volume (template itself) if len(uuidlist) == 1 and srcVol.isShared(): - return [srcVol] + return {'chain':[srcVol], 'template':srcVol} # find the leaf for vol in uuidlist: srcVol = volclass(self.repoPath, sdUUID, imgUUID, vol) if srcVol.isLeaf(): - if not volUUID or volUUID == srcVol.volUUID: - break + break srcVol = None if not srcVol: @@ -332,38 +332,25 @@ class Image: # Build up the sorted (parent->child) chain while not srcVol.isShared(): - chain.insert(0, srcVol) + chainDict['chain'].insert(0, srcVol) if srcVol.getParent() == volume.BLANK_UUID: break srcVol = srcVol.getParentVolume() - self.log.info("sdUUID=%s imgUUID=%s chain=%s ", sdUUID, imgUUID, str(chain)) - return chain + if srcVol.isShared(): + chainDict['template'] = srcVol - def getTemplate(self, sdUUID, imgUUID): - """ - Return template of the image - """ - tmpl = None - # Find all volumes of image (excluding template) - chain = self.getChain(sdUUID, imgUUID) - # check if the chain is build above a template, or it is a standalone - pvol = chain[0].getParentVolume() - if pvol: - tmpl = pvol - elif chain[0].isShared(): - tmpl = chain[0] - - return tmpl + self.log.info("sdUUID=%s imgUUID=%s chainDict=%s ", sdUUID, imgUUID, str(chainDict)) + return chainDict def validate(self, srcSdUUID, dstSdUUID, imgUUID, op=MOVE_OP): """ Validate template on destination domain """ - # Find all volumes of source image - chain = self.getChain(srcSdUUID, imgUUID) - leafVol = chain[-1] srcDom = SDF.produce(srcSdUUID) + # Find all volumes of source image + chainDict = self.getChain(srcSdUUID, imgUUID) + leafVol = chainDict['chain'][-1] # Avoid move template's image if there is a VM based on it (except 'Backup' domain) if op == MOVE_OP and leafVol.isShared() and not srcDom.isBackup(): chList = leafVol.getAllChildrenList(self.repoPath, srcSdUUID, imgUUID, leafVol.volUUID) @@ -371,18 +358,16 @@ class Image: raise se.MoveTemplateImageError(imgUUID) # check if the chain is build above a template, or it is a standalone - pvol = chain[0].getParentVolume() + pvol = chainDict['template'] if pvol: # this is a shared template based chain - if not pvol.isShared(): - raise se.ImageIsNotLegalChain("Base image parent vol %s is not shared" % pvol.volUUID) pimg = pvol.getImage() # pimg == template image try: volclass = SDF.produce(dstSdUUID).getVolumeClass() # Validate that the destination template exists and accessible volclass(self.repoPath, dstSdUUID, pimg, pvol.volUUID) - except se.StorageException, e: - self.log.error("Unexpected error", exc_info=True) - raise se.CouldNotValideTemplateOnTargetDomain("Template %s Destination domain %s: %s" % (pimg, dstSdUUID, str(e))) + except se.StorageException: + self.log.error("Cannot validate template %s on target domain %s", pimg, dstSdUUID, exc_info=True) + raise se.CouldNotValideTemplateOnTargetDomain() def __templateRelink(self, destDom, imgUUID, volUUID): """ @@ -473,20 +458,15 @@ class Image: def _createTargetImage(self, destDom, srcSdUUID, imgUUID): # Before actual data copying we need perform several operation # such as: create all volumes, create fake template if needed, ... - try: - # Find all volumes of source image - srcChain = self.getChain(srcSdUUID, imgUUID) - except se.StorageException: - self.log.error("Unexpected error", exc_info=True) - raise - except Exception, e: - self.log.error("Unexpected error", exc_info=True) - raise se.SourceImageActionError(imgUUID, srcSdUUID, str(e)) + + # Find all volumes of source image + srcChainDict = self.getChain(srcSdUUID, imgUUID) + srcChain = srcChainDict['chain'] fakeTemplate = False pimg = volume.BLANK_UUID # standalone chain # check if the chain is build above a template, or it is a standalone - pvol = srcChain[0].getParentVolume() + pvol = srcChainDict['template'] if pvol: # find out parent volume parameters volParams = pvol.getVolumeParams() @@ -686,11 +666,9 @@ class Image: """ if not self.isLegal(sdUUID, imgUUID): raise se.ImageIsNotLegalChain(imgUUID) - chain = self.getChain(sdUUID, imgUUID) - # check if the chain is build above a template, or it is a standalone - pvol = chain[0].getParentVolume() - if pvol: - if not pvol.isLegal() or pvol.isFake(): + chainDict = self.getChain(sdUUID, imgUUID) + if chainDict['template']: + if not chainDict['template'].isLegal() or chainDict['template'].isFake(): raise se.ImageIsNotLegalChain(imgUUID) def copy(self, sdUUID, vmUUID, srcImgUUID, srcVolUUID, dstImgUUID, dstVolUUID, @@ -735,8 +713,7 @@ class Image: # using the sum of the actual size of the chain's volumes if volParams['volFormat'] != volume.COW_FORMAT or volParams['prealloc'] != volume.SPARSE_VOL: raise se.IncorrectFormat(self) - volParams['apparentsize'] = self.__chainSizeCalc(sdUUID, srcImgUUID, - srcVolUUID, volParams['size']) + volParams['apparentsize'] = self.__chainSizeCalc(sdUUID, srcImgUUID, volParams['size']) # Find out dest volume parameters if preallocate in [volume.PREALLOCATED_VOL, volume.SPARSE_VOL]: diff --git a/vdsm/storage/resourceFactories.py b/vdsm/storage/resourceFactories.py index ce3ec70..07df0f0 100644 --- a/vdsm/storage/resourceFactories.py +++ b/vdsm/storage/resourceFactories.py @@ -106,20 +106,18 @@ class ImageResourceFactory(rm.SimpleResourceFactory): # Get the list of the volumes repoPath = os.path.join(self.storage_repository, dom.getPools()[0]) try: - chain = image.Image(repoPath).getChain(sdUUID=self.sdUUID, imgUUID=resourceName) + chainDict = image.Image(repoPath).getChain(sdUUID=self.sdUUID, imgUUID=resourceName) + chain = chainDict['chain'] except se.ImageDoesNotExistInSD: log.debug("Image %s does not exist in domain %s", resourceName, self.sdUUID) return [] - # check if the chain is build above a template, or it is a standalone - pvol = chain[0].getParentVolume() - if pvol: - template = pvol.volUUID - elif chain[0].isShared(): - # Image of template itself, - # with no other volumes in chain - template = chain[0].volUUID - del chain[:] + # Image of template itself, + # with no other volumes in chain + if chainDict['template']: + template = chainDict['template'].volUUID + if chainDict['template'] in chain: + del chain[:] volUUIDChain = [vol.volUUID for vol in chain] volUUIDChain.sort()

4 5

Change in vdsm[master]: BZ#752470 Related: Out of process getReadDelay
by Federico Simoncelli 07 May '12

07 May '12

Federico Simoncelli has uploaded a new change for review. Change subject: BZ#752470 Related: Out of process getReadDelay ...................................................................... BZ#752470 Related: Out of process getReadDelay To avoid being blocked by a thread in a D state we should determine the read delay using oop also for block devices. Change-Id: I3d2a16bfec60f6197bbea8e31be722c86cce278e --- M vdsm/storage/blockSD.py M vdsm/storage/misc.py 2 files changed, 6 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/64/264/1 -- To view, visit http://gerrit.ovirt.org/264 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3d2a16bfec60f6197bbea8e31be722c86cce278e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>

3 5

Change in vdsm[master]: [WIP] Add the vdsm-tool command
by Federico Simoncelli 06 Mar '12

06 Mar '12

Federico Simoncelli has uploaded a new change for review. Change subject: [WIP] Add the vdsm-tool command ...................................................................... [WIP] Add the vdsm-tool command Change-Id: I15be275cdc18d40c5b4b6e9bc3668d3eb2935624 --- M Makefile.am M configure.ac A vdsm-tool/Makefile.am A vdsm-tool/__init__.py A vdsm-tool/vdsm-tool M vdsm.spec.in 6 files changed, 115 insertions(+), 7 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/95/295/1 -- To view, visit http://gerrit.ovirt.org/295 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I15be275cdc18d40c5b4b6e9bc3668d3eb2935624 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>

3 5

Change in vdsm[master]: [WIP] Move the VDSM common code to the python site lib
by Federico Simoncelli 06 Mar '12

06 Mar '12

Federico Simoncelli has uploaded a new change for review. Change subject: [WIP] Move the VDSM common code to the python site lib ...................................................................... [WIP] Move the VDSM common code to the python site lib Some VDSM code is shared between different components (eg: vdsm and vdsm-cli share vdscli.py) and some modules have a really common name (eg: utils, config) risking to collide with other packages. For these two reasons and for cleanliness some modules are moved to a new location (the standard python site lib) and they can be shipped in a different package. Change-Id: I4baa573532e41f47bbb19a011856c876f851a2b6 --- M configure.ac M vds_bootstrap/vds_bootstrap.py M vdsm.spec.in M vdsm/Makefile.am M vdsm/caps.py M vdsm/clientIF.py M vdsm/config.py M vdsm/configNetwork.py M vdsm/get-conf-item M vdsm/guestIF.py M vdsm/hooks.py M vdsm/kaxmlrpclib.py M vdsm/ksm.py M vdsm/libvirtconnection.py M vdsm/libvirtvm.py M vdsm/netinfo.py M vdsm/set-conf-item M vdsm/storage/blockSD.py M vdsm/storage/blockVolume.py M vdsm/storage/devicemapper.py M vdsm/storage/dispatcher.py M vdsm/storage/fileSD.py M vdsm/storage/fileUtils.py M vdsm/storage/hsm.py M vdsm/storage/image.py M vdsm/storage/iscsi.py M vdsm/storage/lvm.py M vdsm/storage/misc.py M vdsm/storage/multipath.py M vdsm/storage/outOfProcess.py M vdsm/storage/processPool.py M vdsm/storage/resourceFactories.py M vdsm/storage/safelease.py M vdsm/storage/sd.py M vdsm/storage/sdc.py M vdsm/storage/sp.py M vdsm/storage/storage_connection.py M vdsm/storage/storage_mailbox.py M vdsm/storage/task.py M vdsm/storage/taskManager.py M vdsm/storage/volume.py M vdsm/substitute_constants.py M vdsm/supervdsm.py M vdsm/supervdsmServer.py M vdsm/ut/ivdsm.py M vdsm/ut/testGuestChannel.py M vdsm/utils.py M vdsm/vdsm M vdsm/vm.py M vdsm_cli/Makefile.am M vdsm_cli/dumpStorageTable.py M vdsm_cli/vdsClient.py M vdsm_cli/vdscli.py.in M vdsm_hooks/faqemu/before_vm_start.py M vdsm_hooks/vhostmd/after_vm_destroy.py M vdsm_reg/rhevm.py M vdsm_reg/vdsm-reg-setup 57 files changed, 144 insertions(+), 129 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/86/286/1 -- To view, visit http://gerrit.ovirt.org/286 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4baa573532e41f47bbb19a011856c876f851a2b6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>

3 8

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

vdsm-patches November 2011