389-commits October 2018

389-commits@lists.fedoraproject.org

1 participants
28 discussions

[389-ds-base] tag 389-ds-base-1.3.9.0 created (now e68ffaa)
by git repository hosting 31 Oct '18

31 Oct '18

This is an automated email from the git hooks/post-receive script. mreynolds pushed a change to tag 389-ds-base-1.3.9.0 in repository 389-ds-base. at e68ffaa (commit) No new revisions were added by this update. -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[389-ds-base] branch 389-ds-base-1.3.9 created (now e68ffaa)
by git repository hosting 31 Oct '18

31 Oct '18

This is an automated email from the git hooks/post-receive script. mreynolds pushed a change to branch 389-ds-base-1.3.9 in repository 389-ds-base. at e68ffaa Branching 1.3.8 to 1.3.9 This branch includes the following new commits: new e68ffaa Branching 1.3.8 to 1.3.9 The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 1

[389-ds-base] branch master updated (64ef808 -> a7dfa38)
by git repository hosting 31 Oct '18

31 Oct '18

This is an automated email from the git hooks/post-receive script. mreynolds pushed a change to branch master in repository 389-ds-base. from 64ef808 Ticket 49997 RFE: ds-replcheck could validate suffix exists and it's replicated add a7dfa38 Ticket 49995 - Fix issues with internal op logging No new revisions were added by this update. Summary of changes: ldap/servers/slapd/add.c | 8 +++-- ldap/servers/slapd/delete.c | 8 +++-- ldap/servers/slapd/main.c | 20 ++++++------ ldap/servers/slapd/modify.c | 8 +++-- ldap/servers/slapd/modrdn.c | 8 +++-- ldap/servers/slapd/opshared.c | 8 +++-- ldap/servers/slapd/result.c | 28 ++++++++++------ ldap/servers/slapd/slapi-private.h | 4 +-- ldap/servers/slapd/thread_data.c | 65 ++++++++++++-------------------------- ldap/servers/slapd/util.c | 5 ++- 10 files changed, 78 insertions(+), 84 deletions(-) -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[389-ds-base] branch master updated (a06c232 -> 64ef808)
by git repository hosting 30 Oct '18

30 Oct '18

This is an automated email from the git hooks/post-receive script. gparente pushed a change to branch master in repository 389-ds-base. from a06c232 Ticket 49985 - memberof may silently fails to update a member add 64ef808 Ticket 49997 RFE: ds-replcheck could validate suffix exists and it's replicated No new revisions were added by this update. Summary of changes: ldap/admin/src/scripts/ds-replcheck | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[389-ds-base] branch 389-ds-base-1.3.7 updated: Ticket 49967 - entry cache corruption after failed MODRDN
by git repository hosting 29 Oct '18

29 Oct '18

This is an automated email from the git hooks/post-receive script. mreynolds pushed a commit to branch 389-ds-base-1.3.7 in repository 389-ds-base. The following commit(s) were added to refs/heads/389-ds-base-1.3.7 by this push: new 1448415 Ticket 49967 - entry cache corruption after failed MODRDN 1448415 is described below commit 144841524fbe2e968eda176ea95ee793337b890e Author: Thierry Bordaz <tbordaz(a)redhat.com> AuthorDate: Wed Oct 24 15:31:25 2018 +0200 Ticket 49967 - entry cache corruption after failed MODRDN Bug Description: During a MODRDN the DN cache is updated to replace source DN with the target DN (modrdn_rename_entry_update_indexes) If later a failure occurs (for example if BETXN_POSTOP fails) and the txn is aborted, the target DN (for the specific entryID) remains in the DN cache. If the entry is returned in a search, to build the DN there is a lookup of the DN cache with the entryID. It retrieves the target DN rather than the source DN Fix Description: In case of failure of the operation, the entry (from the entryID) need to be cleared from the DN cache https://pagure.io/389-ds-base/issue/49967 Reviewed by: Mark Reynolds Platforms tested: F27 Flag Day: no Doc impact: no (cherry picked from commit ab4af68ef49fcdc5f2f6d0c1f5c7b9a5333b1bee) (cherry picked from commit 0a2cc3bdb266dc9e88900b1851f119157cae2df6) --- ldap/servers/slapd/back-ldbm/ldbm_modrdn.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/ldap/servers/slapd/back-ldbm/ldbm_modrdn.c b/ldap/servers/slapd/back-ldbm/ldbm_modrdn.c index 93fb77d..5304fb9 100644 --- a/ldap/servers/slapd/back-ldbm/ldbm_modrdn.c +++ b/ldap/servers/slapd/back-ldbm/ldbm_modrdn.c @@ -1400,6 +1400,19 @@ common_return: } } } + + if (ec && retval) { + /* if the operation failed, the destination entry does not exist + * but it has been added in dncache during cache_add_tentative + * we need to remove it. Else a retrieval from ep_id can give the wrong DN + */ + struct backdn *bdn = dncache_find_id(&inst->inst_dncache, ec->ep_id); + slapi_log_err(SLAPI_LOG_CACHE, "ldbm_back_modrdn", + "operation failed, the target entry is cleared from dncache (%s)\n", slapi_entry_get_dn(ec->ep_entry)); + CACHE_REMOVE(&inst->inst_dncache, bdn); + CACHE_RETURN(&inst->inst_dncache, &bdn); + } + /* remove the new entry from the cache if the op failed - otherwise, leave it in */ if (ec && inst) { -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[389-ds-base] branch 389-ds-base-1.3.8 updated: Ticket 49967 - entry cache corruption after failed MODRDN
by git repository hosting 29 Oct '18

29 Oct '18

This is an automated email from the git hooks/post-receive script. mreynolds pushed a commit to branch 389-ds-base-1.3.8 in repository 389-ds-base. The following commit(s) were added to refs/heads/389-ds-base-1.3.8 by this push: new 0a2cc3b Ticket 49967 - entry cache corruption after failed MODRDN 0a2cc3b is described below commit 0a2cc3bdb266dc9e88900b1851f119157cae2df6 Author: Thierry Bordaz <tbordaz(a)redhat.com> AuthorDate: Wed Oct 24 15:31:25 2018 +0200 Ticket 49967 - entry cache corruption after failed MODRDN Bug Description: During a MODRDN the DN cache is updated to replace source DN with the target DN (modrdn_rename_entry_update_indexes) If later a failure occurs (for example if BETXN_POSTOP fails) and the txn is aborted, the target DN (for the specific entryID) remains in the DN cache. If the entry is returned in a search, to build the DN there is a lookup of the DN cache with the entryID. It retrieves the target DN rather than the source DN Fix Description: In case of failure of the operation, the entry (from the entryID) need to be cleared from the DN cache https://pagure.io/389-ds-base/issue/49967 Reviewed by: Mark Reynolds Platforms tested: F27 Flag Day: no Doc impact: no (cherry picked from commit ab4af68ef49fcdc5f2f6d0c1f5c7b9a5333b1bee) --- ldap/servers/slapd/back-ldbm/ldbm_modrdn.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/ldap/servers/slapd/back-ldbm/ldbm_modrdn.c b/ldap/servers/slapd/back-ldbm/ldbm_modrdn.c index b9a092c..684b040 100644 --- a/ldap/servers/slapd/back-ldbm/ldbm_modrdn.c +++ b/ldap/servers/slapd/back-ldbm/ldbm_modrdn.c @@ -1400,6 +1400,19 @@ common_return: } } } + + if (ec && retval) { + /* if the operation failed, the destination entry does not exist + * but it has been added in dncache during cache_add_tentative + * we need to remove it. Else a retrieval from ep_id can give the wrong DN + */ + struct backdn *bdn = dncache_find_id(&inst->inst_dncache, ec->ep_id); + slapi_log_err(SLAPI_LOG_CACHE, "ldbm_back_modrdn", + "operation failed, the target entry is cleared from dncache (%s)\n", slapi_entry_get_dn(ec->ep_entry)); + CACHE_REMOVE(&inst->inst_dncache, bdn); + CACHE_RETURN(&inst->inst_dncache, &bdn); + } + /* remove the new entry from the cache if the op failed - otherwise, leave it in */ if (ec && inst) { -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[389-ds-base] branch master updated (ab4af68 -> a06c232)
by git repository hosting 26 Oct '18

26 Oct '18

This is an automated email from the git hooks/post-receive script. tbordaz pushed a change to branch master in repository 389-ds-base. from ab4af68 Ticket 49967 - entry cache corruption after failed MODRDN add a06c232 Ticket 49985 - memberof may silently fails to update a member No new revisions were added by this update. Summary of changes: .../suites/memberof_plugin/regression_test.py | 185 ++++++++++++++++++++- ldap/servers/plugins/memberof/memberof.c | 4 +- 2 files changed, 185 insertions(+), 4 deletions(-) -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[389-ds-base] branch master updated (487ea32 -> ab4af68)
by git repository hosting 25 Oct '18

25 Oct '18

This is an automated email from the git hooks/post-receive script. tbordaz pushed a change to branch master in repository 389-ds-base. from 487ea32 Ticket 49975 - Add missing include file to main.c add ab4af68 Ticket 49967 - entry cache corruption after failed MODRDN No new revisions were added by this update. Summary of changes: .../suites/memberof_plugin/regression_test.py | 160 +++++++++++++++++++++ ldap/servers/slapd/back-ldbm/ldbm_modrdn.c | 13 ++ 2 files changed, 173 insertions(+) -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[389-ds-base] branch master updated: Ticket 49975 - Add missing include file to main.c
by git repository hosting 24 Oct '18

24 Oct '18

This is an automated email from the git hooks/post-receive script. mreynolds pushed a commit to branch master in repository 389-ds-base. The following commit(s) were added to refs/heads/master by this push: new 487ea32 Ticket 49975 - Add missing include file to main.c 487ea32 is described below commit 487ea32c67b7a7f66931d4b9e89a29a3edf0776c Author: Mark Reynolds <mreynolds(a)redhat.com> AuthorDate: Wed Oct 24 15:10:52 2018 -0400 Ticket 49975 - Add missing include file to main.c Description: The first commit for this ticket introduced a compiler warning because it was missing the proper header file. https://pagure.io/389-ds-base/issue/49975 Reviewed by: mreynolds(one line commit rule) --- ldap/servers/slapd/main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ldap/servers/slapd/main.c b/ldap/servers/slapd/main.c index f50b320..d175dcd 100644 --- a/ldap/servers/slapd/main.c +++ b/ldap/servers/slapd/main.c @@ -32,6 +32,7 @@ #include <netinet/in.h> #include <arpa/inet.h> #include <netdb.h> +#include <grp.h> #include <pwd.h> /* getpwnam */ #if !defined(LINUX) && !defined(__FreeBSD__) union semun -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[389-ds-base] branch master updated: Ticket 49814 - skip standard ports for selinux labelling
by git repository hosting 24 Oct '18

24 Oct '18

This is an automated email from the git hooks/post-receive script. mreynolds pushed a commit to branch master in repository 389-ds-base. The following commit(s) were added to refs/heads/master by this push: new 3cb911d Ticket 49814 - skip standard ports for selinux labelling 3cb911d is described below commit 3cb911d59035b06abc88e2b0ea5e069bdb9238bb Author: Mark Reynolds <mreynolds(a)redhat.com> AuthorDate: Wed Oct 24 13:42:46 2018 -0400 Ticket 49814 - skip standard ports for selinux labelling Description: Skip labelling ports that use the the standard port numbers (389, 636). https://pagure.io/389-ds-base/issue/49814 Reviewed by: mreynolds(one line commit rule) --- src/lib389/lib389/utils.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib389/lib389/utils.py b/src/lib389/lib389/utils.py index 68a06e3..8b1609e 100644 --- a/src/lib389/lib389/utils.py +++ b/src/lib389/lib389/utils.py @@ -184,7 +184,7 @@ def selinux_label_port(port, remove_label=False): :raises: ValueError: Error message """ - if not selinux.is_selinux_enabled(): + if not selinux.is_selinux_enabled() or port == 389 or port == 636: return label_set = False -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

389-commits October 2018