Hi all,
We have recently been receiving emails about wrongly formatted fedmsg message coming from copr in stg. Has there been any changes made to the structure of the messages sent in stg?
To give you an idea, this is what we received: Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/moksha/hub/api/consumer.py", line 191, in _work self.consume(message) File "/usr/lib/python2.7/site-packages/fmn/consumer/consumer.py", line 89, in consume self.work(session, raw_msg) File "/usr/lib/python2.7/site-packages/fmn/consumer/consumer.py", line 105, in work msg['msg']['owner'] in self.ignored_copr_owners: KeyError: 'owner'
The message being: {'body': {u'username': u'copr', u'certificate': u'LS0tLS1CRUdJTiBDRVJUSUZJQ0FURS0tLS0tCk1JSUVUakNDQTdlZ0F3SUJBZ0lDQVBZd0RRWUpL\nb1pJaHZjTkFRRUZCUUF3Z2FBeEN6QUpCZ05WQkFZVEFsVlQKTVFzd0NRWURWUVFJRXdKT1F6RVFN\nQTRHQTFVRUJ4TUhVbUZzWldsbmFERVhNQlVHQTFVRUNoTU9SbVZrYjNKaApJRkJ5YjJwbFkzUXhE\nekFOQmdOVkJBc1RCbVpsWkcxelp6RVBNQTBHQTFVRUF4TUdabVZrYlhObk1ROHdEUVlEClZRUXBF\nd1ptWldSdGMyY3hKakFrQmdrcWhraUc5dzBCQ1FFV0YyRmtiV2x1UUdabFpHOXlZWEJ5YjJwbFkz\nUXUKYjNKbk1CNFhEVEUwTURReU16RTBNamsxTVZvWERUSTBNRFF5TURFME1qazFNVm93Z2R3eEN6\nQUpCZ05WQkFZVApBbFZUTVFzd0NRWURWUVFJRXdKT1F6RVFNQTRHQTFVRUJ4TUhVbUZzWldsbmFE\nRVhNQlVHQTFVRUNoTU9SbVZrCmIzSmhJRkJ5YjJwbFkzUXhEekFOQmdOVkJBc1RCbVpsWkcxelp6\nRXRNQ3NHQTFVRUF4TWtZMjl3Y2kxamIzQnkKTFdKbExtTnNiM1ZrTG1abFpHOXlZWEJ5YjJwbFkz\nUXViM0puTVMwd0t3WURWUVFwRXlSamIzQnlMV052Y0hJdApZbVV1WTJ4dmRXUXVabVZrYjNKaGNI\nSnZhbVZqZEM1dmNtY3hKakFrQmdrcWhraUc5dzBCQ1FFV0YyRmtiV2x1ClFHWmxaRzl5WVhCeWIy\ncGxZM1F1YjNKbk1JR2ZNQTBHQ1NxR1NJYjNEUUVCQVFVQUE0R05BRENCaVFLQmdRQ2UKREs5VFQy\nM05BdTZPWTVGMnVVNHpMRW9Ld2k1RnRRTU5jVWV5eDdmOHJxMUZXaUxDWHBjWFhpU2tzUE1XV1NM\nWQo5SHNoa1pvM3ZjMHFSRXVBWDNweWRuM2VFRDA0UExrUmRlaWpvSXA5L0Y2YlZ3MmlLMDdXRmc5\nU2MwNlRsKzhSCld1RHNaeTQ1SVJKYXhCRTlJaHBYL0x2Y2JnQ1cvZmVHVGp5WG1iRHd0UUlEQVFB\nQm80SUJWekNDQVZNd0NRWUQKVlIwVEJBSXdBREF0QmdsZ2hrZ0JodmhDQVEwRUlCWWVSV0Z6ZVMx\nU1UwRWdSMlZ1WlhKaGRHVmtJRU5sY25ScApabWxqWVhSbE1CMEdBMVVkRGdRV0JCUm5lNTg0d3Bs\nWGYrZVE2K25zSTZCbm5BNENaRENCMVFZRFZSMGpCSUhOCk1JSEtnQlJyUUZyNUVnaUpXZWRaNVFY\nMUFoMEtUbjhVQUtHQnBxU0JvekNCb0RFTE1Ba0dBMVVFQmhNQ1ZWTXgKQ3pBSkJnTlZCQWdUQWs1\nRE1SQXdEZ1lEVlFRSEV3ZFNZV3hsYVdkb01SY3dGUVlEVlFRS0V3NUdaV1J2Y21FZwpVSEp2YW1W\namRERVBNQTBHQTFVRUN4TUdabVZrYlhObk1ROHdEUVlEVlFRREV3Wm1aV1J0YzJjeER6QU5CZ05W\nCkJDa1RCbVpsWkcxelp6RW1NQ1FHQ1NxR1NJYjNEUUVKQVJZWFlXUnRhVzVBWm1Wa2IzSmhjSEp2\nYW1WamRDNXYKY21lQ0NRRGpVQjVIVHhjZVJUQVRCZ05WSFNVRUREQUtCZ2dyQmdFRkJRY0RBakFM\nQmdOVkhROEVCQU1DQjRBdwpEUVlKS29aSWh2Y05BUUVGQlFBRGdZRUFVazNlbjBYUXpDQm5IUlh4\nZDhyOHp2ZFAwVURvbEpiUysyTEl3Z3NDClJDMnNkZ1UwNGdFblYxdFpVTjNydEk1SzQ2MnpKT0JQ\nOFhQd3h4eUZMN1lOYmVtWTgyTG52Y1pHdzliMGdxTDMKdHNKbzllSFV5SXBZMG93TlVKdzgzU1Ax\neFJvb3NwVGJRK3BsNm9qdjVPNVpGZ1lBUG1yckRWZ0M4a2gzRlp4Rgp0SWc9Ci0tLS0tRU5EIENF\nUlRJRklDQVRFLS0tLS0K\n', u'i': 3, u'timestamp': 1485209011, u'msg_id':u'2017-dc6af56b-76c4-425d-8b66-f69295b38fe0', u'crypto': u'x509', u'topic': u'org.fedoraproject.prod.copr.build.end',u'signature':u'AJHlFzJnrrTF9XVs6b0KT4U0n3LCVtK/cWbt+hceOeWf/0bvYn6ZMx6dUTBasutGnA8TY998U6H6\nzgBXPM1fyV4WCO+ekuIV7O6dpNedlfpcrnnU1LRGCPWVPSgIw0gg5QDfZ06kQWuQvC17JxokG7Pi\n4vIiW64ifAddRZEILxc=\n', u'msg': {}}, 'topic':u'org.fedoraproject.prod.copr.build.end'}
Does that ring a bell to anyone?
Thanks, Pierre
Yes, untested changes got into production. We are sorry. I am currently working on a fix.
On Tue, Jan 24, 2017 at 11:02 AM, Pierre-Yves Chibon pingou@pingoured.fr wrote:
Hi all,
We have recently been receiving emails about wrongly formatted fedmsg message coming from copr in stg. Has there been any changes made to the structure of the messages sent in stg?
To give you an idea, this is what we received: Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/moksha/hub/api/consumer.py", line 191, in _work self.consume(message) File "/usr/lib/python2.7/site-packages/fmn/consumer/consumer.py", line 89, in consume self.work(session, raw_msg) File "/usr/lib/python2.7/site-packages/fmn/consumer/consumer.py", line 105, in work msg['msg']['owner'] in self.ignored_copr_owners: KeyError: 'owner'
The message being: {'body': {u'username': u'copr', u'certificate': u'LS0tLS1CRUdJTiBDRVJUSUZJQ0FURS0tLS0tCk1JSUVUakNDQTdlZ0F3SUJB Z0lDQVBZd0RRWUpL\nb1pJaHZjTkFRRUZCUUF3Z2FBeEN6Q UpCZ05WQkFZVEFsVlQKTVFzd0NRWURWUVFJRXdKT1F6RVFN\ nQTRHQTFVRUJ4TUhVbUZzWldsbmFERVhNQlVHQTFVRUNoTU9SbVZrYjNKaAp JRkJ5YjJwbFkzUXhE\nekFOQmdOVkJBc1RCbVpsWkcxelp6R VBNQTBHQTFVRUF4TUdabVZrYlhObk1ROHdEUVlEClZRUXBF\ nd1ptWldSdGMyY3hKakFrQmdrcWhraUc5dzBCQ1FFV0YyRmtiV2x1UUdabFp HOXlZWEJ5YjJwbFkz\nUXUKYjNKbk1CNFhEVEUwTURReU16R TBNamsxTVZvWERUSTBNRFF5TURFME1qazFNVm93Z2R3eEN6\ nQUpCZ05WQkFZVApBbFZUTVFzd0NRWURWUVFJRXdKT1F6RVFNQTRHQTFVRUJ 4TUhVbUZzWldsbmFE\nRVhNQlVHQTFVRUNoTU9SbVZrCmIzS mhJRkJ5YjJwbFkzUXhEekFOQmdOVkJBc1RCbVpsWkcxelp6\ nRXRNQ3NHQTFVRUF4TWtZMjl3Y2kxamIzQnkKTFdKbExtTnNiM1ZrTG1abFp HOXlZWEJ5YjJwbFkz\nUXViM0puTVMwd0t3WURWUVFwRXlSa mIzQnlMV052Y0hJdApZbVV1WTJ4dmRXUXVabVZrYjNKaGNI\ nSnZhbVZqZEM1dmNtY3hKakFrQmdrcWhraUc5dzBCQ1FFV0YyRmtiV2x1ClF HWmxaRzl5WVhCeWIy\ncGxZM1F1YjNKbk1JR2ZNQTBHQ1NxR 1NJYjNEUUVCQVFVQUE0R05BRENCaVFLQmdRQ2UKREs5VFQy\ nM05BdTZPWTVGMnVVNHpMRW9Ld2k1RnRRTU5jVWV5eDdmOHJxMUZXaUxDWHB jWFhpU2tzUE1XV1NM\nWQo5SHNoa1pvM3ZjMHFSRXVBWDNwe WRuM2VFRDA0UExrUmRlaWpvSXA5L0Y2YlZ3MmlLMDdXRmc5\ nU2MwNlRsKzhSCld1RHNaeTQ1SVJKYXhCRTlJaHBYL0x2Y2JnQ1cvZmVHVGp 5WG1iRHd0UUlEQVFB\nQm80SUJWekNDQVZNd0NRWUQKVlIwV EJBSXdBREF0QmdsZ2hrZ0JodmhDQVEwRUlCWWVSV0Z6ZVMx\ nU1UwRWdSMlZ1WlhKaGRHVmtJRU5sY25ScApabWxqWVhSbE1CMEdBMVVkRGd RV0JCUm5lNTg0d3Bs\nWGYrZVE2K25zSTZCbm5BNENaRENCM VFZRFZSMGpCSUhOCk1JSEtnQlJyUUZyNUVnaUpXZWRaNVFY\ nMUFoMEtUbjhVQUtHQnBxU0JvekNCb0RFTE1Ba0dBMVVFQmhNQ1ZWTXgKQ3p BSkJnTlZCQWdUQWs1\nRE1SQXdEZ1lEVlFRSEV3ZFNZV3hsY Vdkb01SY3dGUVlEVlFRS0V3NUdaV1J2Y21FZwpVSEp2YW1W\ namRERVBNQTBHQTFVRUN4TUdabVZrYlhObk1ROHdEUVlEVlFRREV3Wm1aV1J 0YzJjeER6QU5CZ05W\nCkJDa1RCbVpsWkcxelp6RW1NQ1FHQ 1NxR1NJYjNEUUVKQVJZWFlXUnRhVzVBWm1Wa2IzSmhjSEp2\ nYW1WamRDNXYKY21lQ0NRRGpVQjVIVHhjZVJUQVRCZ05WSFNVRUREQUtCZ2d yQmdFRkJRY0RBakFM\nQmdOVkhROEVCQU1DQjRBdwpEUVlKS 29aSWh2Y05BUUVGQlFBRGdZRUFVazNlbjBYUXpDQm5IUlh4\ nZDhyOHp2ZFAwVURvbEpiUysyTEl3Z3NDClJDMnNkZ1UwNGdFblYxdFpVTjN ydEk1SzQ2MnpKT0JQ\nOFhQd3h4eUZMN1lOYmVtWTgyTG52Y 1pHdzliMGdxTDMKdHNKbzllSFV5SXBZMG93TlVKdzgzU1Ax\ neFJvb3NwVGJRK3BsNm9qdjVPNVpGZ1lBUG1yckRWZ0M4a2gzRlp4Rgp0SWc 9Ci0tLS0tRU5EIENF\nUlRJRklDQVRFLS0tLS0K\n', u'i': 3, u'timestamp': 1485209011, u'msg_id':u'2017-dc6af56b-76c4-425d-8b66-f69295b38fe0', u'crypto': u'x509', u'topic': u'org.fedoraproject.prod.copr. build.end',u'signature':u'AJHlFzJnrrTF9XVs6b0KT4U0n3LCVtK/cWbt+hceOeWf/ 0bvYn6ZMx6dUTBasutGnA8TY998U6H6\nzgBXPM1fyV4WCO+ ekuIV7O6dpNedlfpcrnnU1LRGCPWVPSgIw0gg5QDfZ06kQWuQvC17JxokG7Pi\n4vIiW64ifAddRZEILxc=\n', u'msg': {}}, 'topic':u'org.fedoraproject.prod.copr.build.end'}
Does that ring a bell to anyone?
Thanks, Pierre _______________________________________________ copr-devel mailing list -- copr-devel@lists.fedorahosted.org To unsubscribe send an email to copr-devel-leave@lists.fedorahosted.org
On Tue, Jan 24, 2017 at 11:30:33AM +0100, Michal Novotny wrote:
Yes, untested changes got into production. We are sorry. I am currently working on a fix.
If that made it up to production, then we'll need to adjust fedmsg_meta to support these messages as well.
fedmsg_meta should work for all our published messages (published and stored on datagrepper).
Pierre
On Tue, Jan 24, 2017 at 11:02 AM, Pierre-Yves Chibon pingou@pingoured.fr wrote:
Hi all, We have recently been receiving emails about wrongly formatted fedmsg message coming from copr in stg. Has there been any changes made to the structure of the messages sent in stg? To give you an idea, this is what we received: Traceback (most recent call last):  File "/usr/lib/python2.7/site-packages/moksha/hub/api/consumer.py", line 191, in _work   self.consume(message)  File "/usr/lib/python2.7/site-packages/fmn/consumer/consumer.py", line 89, in consume   self.work(session, raw_msg)  File "/usr/lib/python2.7/site-packages/fmn/consumer/consumer.py", line 105, in work   msg['msg']['owner'] in self.ignored_copr_owners: KeyError: 'owner' The message being: {'body': {u'username': u'copr', u'certificate': u'LS0tLS1CRUdJTiBDRVJUSUZJQ0FURS0tLS0tCk1JSUVUakNDQTdlZ0F3SUJBZ0lDQVBZd0RRWUpL\nb1pJaHZjTkFRRUZCUUF3Z2FBeEN6QUpCZ05WQkFZVEFsVlQKTVFzd0NRWURWUVFJRXdKT1F6RVFN\nQTRHQTFVRUJ4TUhVbUZzWldsbmFERVhNQlVHQTFVRUNoTU9SbVZrYjNKaApJRkJ5YjJwbFkzUXhE\nekFOQmdOVkJBc1RCbVpsWkcxelp6RVBNQTBHQTFVRUF4TUdabVZrYlhObk1ROHdEUVlEClZRUXBF\nd1ptWldSdGMyY3hKakFrQmdrcWhraUc5dzBCQ1FFV0YyRmtiV2x1UUdabFpHOXlZWEJ5YjJwbFkz\nUXUKYjNKbk1CNFhEVEUwTURReU16RTBNamsxTVZvWERUSTBNRFF5TURFME1qazFNVm93Z2R3eEN6\nQUpCZ05WQkFZVApBbFZUTVFzd0NRWURWUVFJRXdKT1F6RVFNQTRHQTFVRUJ4TUhVbUZzWldsbmFE\nRVhNQlVHQTFVRUNoTU9SbVZrCmIzSmhJRkJ5YjJwbFkzUXhEekFOQmdOVkJBc1RCbVpsWkcxelp6\nRXRNQ3NHQTFVRUF4TWtZMjl3Y2kxamIzQnkKTFdKbExtTnNiM1ZrTG1abFpHOXlZWEJ5YjJwbFkz\nUXViM0puTVMwd0t3WURWUVFwRXlSamIzQnlMV052Y0hJdApZbVV1WTJ4dmRXUXVabVZrYjNKaGNI\nSnZhbVZqZEM1dmNtY3hKakFrQmdrcWhraUc5dzBCQ1FFV0YyRmtiV2x1ClFHWmxaRzl5WVhCeWIy\ncGxZM1F1YjNKbk1JR2ZNQTBHQ1NxR1NJYjNEUUVCQVFVQUE0R05BRENCaVFLQmdRQ2UKREs5VFQy\nM05BdTZPWTVGMnVVNHpMRW9Ld2k1RnRRTU5jVWV5eDdmOHJxMUZXaUxDWHBjWFhpU2tzUE1XV1NM\nWQ> o5SHNoa1pvM3ZjMHFSRXVBWDNweWRuM2VFRDA0UExrUmRlaWpvSXA5L0Y2YlZ3MmlLMDdXRmc5\nU2MwNlRsKzhSCld1RHNaeTQ1SVJKYXhCRTlJaHBYL0x2Y2JnQ1cvZmVHVGp5WG1iRHd0UUlEQVFB\nQm80SUJWekNDQVZNd0NRWUQKVlIwVEJBSXdBREF0QmdsZ2hrZ0JodmhDQVEwRUlCWWVSV0Z6ZVMx\nU1UwRWdSMlZ1WlhKaGRHVmtJRU5sY25ScApabWxqWVhSbE1CMEdBMVVkRGdRV0JCUm5lNTg0d3Bs\nWGYrZVE2K25zSTZCbm5BNENaRENCMVFZRFZSMGpCSUhOCk1JSEtnQlJyUUZyNUVnaUpXZWRaNVFY\nMUFoMEtUbjhVQUtHQnBxU0JvekNCb0RFTE1Ba0dBMVVFQmhNQ1ZWTXgKQ3pBSkJnTlZCQWdUQWs1\nRE1SQXdEZ1lEVlFRSEV3ZFNZV3hsYVdkb01SY3dGUVlEVlFRS0V3NUdaV1J2Y21FZwpVSEp2YW1W\namRERVBNQTBHQTFVRUN4TUdabVZrYlhObk1ROHdEUVlEVlFRREV3Wm1aV1J0YzJjeER6QU5CZ05W\nCkJDa1RCbVpsWkcxelp6RW1NQ1FHQ1NxR1NJYjNEUUVKQVJZWFlXUnRhVzVBWm1Wa2IzSmhjSEp2\nYW1WamRDNXYKY21lQ0NRRGpVQjVIVHhjZVJUQVRCZ05WSFNVRUREQUtCZ2dyQmdFRkJRY0RBakFM\nQmdOVkhROEVCQU1DQjRBdwpEUVlKS29aSWh2Y05BUUVGQlFBRGdZRUFVazNlbjBYUXpDQm5IUlh4\nZDhyOHp2ZFAwVURvbEpiUysyTEl3Z3NDClJDMnNkZ1UwNGdFblYxdFpVTjNydEk1SzQ2MnpKT0JQ\nOFhQd3h4eUZMN1lOYmVtWTgyTG52Y1pHdzliMGdxTDMKdHNKbzllSFV5SXBZMG93TlVKdzgzU1Ax\neFJvb3NwVGJ> RK3BsNm9qdjVPNVpGZ1lBUG1yckRWZ0M4a2gzRlp4Rgp0SWc9Ci0tLS0tRU5EIENF\nUlRJRklDQVRFLS0tLS0K\n', u'i': 3, u'timestamp': 1485209011, u'msg_id':u'2017-dc6af56b-76c4-425d-8b66-f69295b38fe0', u'crypto': u'x509', u'topic': u'org.fedoraproject.prod.copr.build.end',u'signature':u'AJHlFzJnrrTF9XVs6b0KT4U0n3LCVtK/cWbt+hceOeWf/0bvYn6ZMx6dUTBasutGnA8TY998U6H6\nzgBXPM1fyV4WCO+ekuIV7O6dpNedlfpcrnnU1LRGCPWVPSgIw0gg5QDfZ06kQWuQvC17JxokG7Pi\n4vIiW64ifAddRZEILxc=\n', u'msg': {}}, 'topic':u'org.fedoraproject.prod.copr.build.end'} Does that ring a bell to anyone? Thanks, Pierre _______________________________________________ copr-devel mailing list -- copr-devel@lists.fedorahosted.org To unsubscribe send an email to copr-devel-leave@lists.fedorahosted.org
copr-devel mailing list -- copr-devel@lists.fedorahosted.org To unsubscribe send an email to copr-devel-leave@lists.fedorahosted.org
On Tue, Jan 24, 2017 at 11:44 AM, Pierre-Yves Chibon pingou@pingoured.fr wrote:
On Tue, Jan 24, 2017 at 11:30:33AM +0100, Michal Novotny wrote:
Yes, untested changes got into production. We are sorry. I am
currently
working on a fix.
If that made it up to production, then we'll need to adjust fedmsg_meta to support these messages as well.
fedmsg_meta should work for all our published messages (published and stored on datagrepper).
Okay, these messages have all empty body (the "msg" attribute), e.g `build.end`:
{ "source_name": "datanommer", "certificate": "LS0tLS1CRUdJTiBDRVJUSUZJQ0FURS0tLS0tCk1JSUVUakNDQTdlZ0F3SUJBZ0lDQVBZd0RRWUpL\nb1pJaHZjTkFRRUZCUUF3Z2FBeEN6QUpCZ05WQkFZVEFsVlQKTVFzd0NRWURWUVFJRXdKT1F6RVFN\nQTRHQTFVRUJ4TUhVbUZzWldsbmFERVhNQlVHQTFVRUNoTU9SbVZrYjNKaApJRkJ5YjJwbFkzUXhE\nekFOQmdOVkJBc1RCbVpsWkcxelp6RVBNQTBHQTFVRUF4TUdabVZrYlhObk1ROHdEUVlEClZRUXBF\nd1ptWldSdGMyY3hKakFrQmdrcWhraUc5dzBCQ1FFV0YyRmtiV2x1UUdabFpHOXlZWEJ5YjJwbFkz\nUXUKYjNKbk1CNFhEVEUwTURReU16RTBNamsxTVZvWERUSTBNRFF5TURFME1qazFNVm93Z2R3eEN6\nQUpCZ05WQkFZVApBbFZUTVFzd0NRWURWUVFJRXdKT1F6RVFNQTRHQTFVRUJ4TUhVbUZzWldsbmFE\nRVhNQlVHQTFVRUNoTU9SbVZrCmIzSmhJRkJ5YjJwbFkzUXhEekFOQmdOVkJBc1RCbVpsWkcxelp6\nRXRNQ3NHQTFVRUF4TWtZMjl3Y2kxamIzQnkKTFdKbExtTnNiM1ZrTG1abFpHOXlZWEJ5YjJwbFkz\nUXViM0puTVMwd0t3WURWUVFwRXlSamIzQnlMV052Y0hJdApZbVV1WTJ4dmRXUXVabVZrYjNKaGNI\nSnZhbVZqZEM1dmNtY3hKakFrQmdrcWhraUc5dzBCQ1FFV0YyRmtiV2x1ClFHWmxaRzl5WVhCeWIy\ncGxZM1F1YjNKbk1JR2ZNQTBHQ1NxR1NJYjNEUUVCQVFVQUE0R05BRENCaVFLQmdRQ2UKREs5VFQy\nM05BdTZPWTVGMnVVNHpMRW9Ld2k1RnRRTU5jVWV5eDdmOHJxMUZXaUxDWHBjWFhpU2tzUE1XV1NM\nWQo5SHNoa1pvM3ZjMHFSRXVBWDNweWRuM2VFRDA0UExrUmRlaWpvSXA5L0Y2YlZ3MmlLMDdXRmc5\nU2MwNlRsKzhSCld1RHNaeTQ1SVJKYXhCRTlJaHBYL0x2Y2JnQ1cvZmVHVGp5WG1iRHd0UUlEQVFB\nQm80SUJWekNDQVZNd0NRWUQKVlIwVEJBSXdBREF0QmdsZ2hrZ0JodmhDQVEwRUlCWWVSV0Z6ZVMx\nU1UwRWdSMlZ1WlhKaGRHVmtJRU5sY25ScApabWxqWVhSbE1CMEdBMVVkRGdRV0JCUm5lNTg0d3Bs\nWGYrZVE2K25zSTZCbm5BNENaRENCMVFZRFZSMGpCSUhOCk1JSEtnQlJyUUZyNUVnaUpXZWRaNVFY\nMUFoMEtUbjhVQUtHQnBxU0JvekNCb0RFTE1Ba0dBMVVFQmhNQ1ZWTXgKQ3pBSkJnTlZCQWdUQWs1\nRE1SQXdEZ1lEVlFRSEV3ZFNZV3hsYVdkb01SY3dGUVlEVlFRS0V3NUdaV1J2Y21FZwpVSEp2YW1W\namRERVBNQTBHQTFVRUN4TUdabVZrYlhObk1ROHdEUVlEVlFRREV3Wm1aV1J0YzJjeER6QU5CZ05W\nCkJDa1RCbVpsWkcxelp6RW1NQ1FHQ1NxR1NJYjNEUUVKQVJZWFlXUnRhVzVBWm1Wa2IzSmhjSEp2\nYW1WamRDNXYKY21lQ0NRRGpVQjVIVHhjZVJUQVRCZ05WSFNVRUREQUtCZ2dyQmdFRkJRY0RBakFM\nQmdOVkhROEVCQU1DQjRBdwpEUVlKS29aSWh2Y05BUUVGQlFBRGdZRUFVazNlbjBYUXpDQm5IUlh4\nZDhyOHp2ZFAwVURvbEpiUysyTEl3Z3NDClJDMnNkZ1UwNGdFblYxdFpVTjNydEk1SzQ2MnpKT0JQ\nOFhQd3h4eUZMN1lOYmVtWTgyTG52Y1pHdzliMGdxTDMKdHNKbzllSFV5SXBZMG93TlVKdzgzU1Ax\neFJvb3NwVGJRK3BsNm9qdjVPNVpGZ1lBUG1yckRWZ0M4a2gzRlp4Rgp0SWc9Ci0tLS0tRU5EIENF\nUlRJRklDQVRFLS0tLS0K\n", "i": 3, "timestamp": 1485166967.0, "msg_id": "2017-db23086c-2001-496e-a59f-10b92c466ae5", "topic": "org.fedoraproject.prod.copr.build.end", "source_version": "0.6.5", "signature": "HJEOhP93vZFUk3cjIzggxZqIT+IRaLpKF/t21Kn0AcQ9B1VJEe+myerAAJMZfuXppGQqsFyzcPFx\nu+9p7geI5NqNxnN+diUXNlxbXN9/VN0X3vX7U4mbc0/zLyGcbKWIn/pcskbM5qYC2lJHLov0pMwq\nrbq/B0N3CxBL2og0Fj8=\n", "msg": {} }
Does fedmsg_meta need to be adjusted even so? clime
Pierre
On Tue, Jan 24, 2017 at 11:02 AM, Pierre-Yves Chibon <
pingou@pingoured.fr>
wrote:
Hi all, We have recently been receiving emails about wrongly formattedfedmsg
message coming from copr in stg. Has there been any changes made to the structure of the messagessent in
stg? To give you an idea, this is what we received: Traceback (most recent call last): Â File "/usr/lib/python2.7/site-packages/moksha/hub/api/consumer.py",
line 191, in _work   self.consume(message)  File "/usr/lib/python2.7/site-packages/fmn/consumer/consumer.py",
line 89, in consume   self.work(session, raw_msg)  File "/usr/lib/python2.7/site-packages/fmn/consumer/consumer.py",
line 105, in work   msg['msg']['owner'] in self.ignored_copr_owners: KeyError: 'owner' The message being: {'body': {u'username': u'copr', u'certificate': u'LS0tLS1CRUdJTiBDRVJUSUZJQ0FURS0tLS0tCk1JSUVUakNDQTdlZ0F3SUJBZ0lDQVBZd0RRWUpL\nb1pJaHZjTkFRRUZCUUF3Z2FBeEN6Q UpCZ05WQkFZVEFsVlQKTVFzd0NRWURWUVFJRXdKT1F6RVFN\ nQTRHQTFVRUJ4TUhVbUZzWldsbmFERVhNQlVHQTFVRUNoTU9SbVZrYjNKaAp JRkJ5YjJwbFkzUXhE\nekFOQmdOVkJBc1RCbVpsWkcxelp6R VBNQTBHQTFVRUF4TUdabVZrYlhObk1ROHdEUVlEClZRUXBF\ nd1ptWldSdGMyY3hKakFrQmdrcWhraUc5dzBCQ1FFV0YyRmtiV2x1UUdabFp HOXlZWEJ5YjJwbFkz\nUXUKYjNKbk1CNFhEVEUwTURReU16R TBNamsxTVZvWERUSTBNRFF5TURFME1qazFNVm93Z2R3eEN6\ nQUpCZ05WQkFZVApBbFZUTVFzd0NRWURWUVFJRXdKT1F6RVFNQTRHQTFVRUJ 4TUhVbUZzWldsbmFE\nRVhNQlVHQTFVRUNoTU9SbVZrCmIzS mhJRkJ5YjJwbFkzUXhEekFOQmdOVkJBc1RCbVpsWkcxelp6\ nRXRNQ3NHQTFVRUF4TWtZMjl3Y2kxamIzQnkKTFdKbExtTnNiM1ZrTG1abFp HOXlZWEJ5YjJwbFkz\nUXViM0puTVMwd0t3WURWUVFwRXlSa mIzQnlMV052Y0hJdApZbVV1WTJ4dmRXUXVabVZrYjNKaGNI\ nSnZhbVZqZEM1dmNtY3hKakFrQmdrcWhraUc5dzBCQ1FFV0YyRmtiV2x1ClF HWmxaRzl5WVhCeWIy\ncGxZM1F1YjNKbk1JR2ZNQTBHQ1NxR 1NJYjNEUUVCQVFVQUE0R05BRENCaVFLQmdRQ2UKREs5VFQy\ nM05BdTZPWTVGMnVVNHpMRW9Ld2k1RnRRTU5jVWV5eDdmOHJxMUZXaUxDWHBjWFhpU2tzUE1XV1NM\nWQ> o5SHNoa1pvM3ZjMHFSRXVBWDNweWRuM2VFRDA0UExrUmRlaWpvSXA5L0Y2Yl Z3MmlLMDdXRmc5\nU2MwNlRsKzhSCld1RHNaeTQ1SVJKY XhCRTlJaHBYL0x2Y2JnQ1cvZmVHVGp5WG1iRHd0UUlEQVFB\ nQm80SUJWekNDQVZNd0NRWUQKVlIwVEJBSXdBREF0QmdsZ2hrZ0JodmhDQVE wRUlCWWVSV0Z6ZVMx\nU1UwRWdSMlZ1WlhKaGRHVmtJRU5sY 25ScApabWxqWVhSbE1CMEdBMVVkRGdRV0JCUm5lNTg0d3Bs\ nWGYrZVE2K25zSTZCbm5BNENaRENCMVFZRFZSMGpCSUhOCk1JSEtnQlJyUUZ yNUVnaUpXZWRaNVFY\nMUFoMEtUbjhVQUtHQnBxU0JvekNCb 0RFTE1Ba0dBMVVFQmhNQ1ZWTXgKQ3pBSkJnTlZCQWdUQWs1\ nRE1SQXdEZ1lEVlFRSEV3ZFNZV3hsYVdkb01SY3dGUVlEVlFRS0V3NUdaV1J 2Y21FZwpVSEp2YW1W\namRERVBNQTBHQTFVRUN4TUdabVZrY lhObk1ROHdEUVlEVlFRREV3Wm1aV1J0YzJjeER6QU5CZ05W\ nCkJDa1RCbVpsWkcxelp6RW1NQ1FHQ1NxR1NJYjNEUUVKQVJZWFlXUnRhVzV BWm1Wa2IzSmhjSEp2\nYW1WamRDNXYKY21lQ0NRRGpVQjVIV HhjZVJUQVRCZ05WSFNVRUREQUtCZ2dyQmdFRkJRY0RBakFM\ nQmdOVkhROEVCQU1DQjRBdwpEUVlKS29aSWh2Y05BUUVGQlFBRGdZRUFVazN lbjBYUXpDQm5IUlh4\nZDhyOHp2ZFAwVURvbEpiUysyTEl3Z 3NDClJDMnNkZ1UwNGdFblYxdFpVTjNydEk1SzQ2MnpKT0JQ\ nOFhQd3h4eUZMN1lOYmVtWTgyTG52Y1pHdzliMGdxTDMKdHNKbzllSFV5SXB ZMG93TlVKdzgzU1Ax\neFJvb3NwVGJ> RK3BsNm9qdjVPNVpGZ1lBUG1yckRWZ 0M4a2gzRlp4Rgp0SWc9Ci0tLS0tRU5EIENF\nUlRJRklDQVRFLS0tLS0K\n',
u'i': 3, u'timestamp': 1485209011, u'msg_id':u'2017-dc6af56b-76c4-425d-8b66-f69295b38fe0', u'crypto': u'x509', u'topic': u'org.fedoraproject.prod.copr.build.end',u'signature':u'AJHlFzJnrrTF9XVs6b0KT4U0n3LCVtK/cWbt+hceOeWf/ 0bvYn6ZMx6dUTBasutGnA8TY998U6H6\nzgBXPM1fyV4WCO+ ekuIV7O6dpNedlfpcrnnU1LRGCPWVPSgIw0gg5QDfZ06kQWuQvC17JxokG7P i\n4vIiW64ifAddRZEILxc=\n',
u'msg': {}}, 'topic':u'org.fedoraproject.prod.copr.build.end'} Does that ring a bell to anyone? Thanks, Pierre _______________________________________________ copr-devel mailing list -- copr-devel@lists.fedorahosted.org To unsubscribe send an email to copr-devel-leave@lists.fedorahosted.org
copr-devel mailing list -- copr-devel@lists.fedorahosted.org To unsubscribe send an email to copr-devel-leave@lists.fedorahosted.org
copr-devel mailing list -- copr-devel@lists.fedorahosted.org To unsubscribe send an email to copr-devel-leave@lists.fedorahosted.org
Otherwise, in the fix that I am going to apply tomorrow, there will some additional fields for chroot.start and build.start messages.
For chroot.start: - status (int) - version (str)
For build.start: - status (int) - version (str) - chroot (str)
The old fields will be all there with the same type. Only some new fields will be added. I hope that does not represent a problem for fedmsg_meta or anybody. I am aware that an ideal way would be to just leave the old message interface as it was but the code would get very ugly. Of course, I will do it if needed.
clime
On Tue, Jan 24, 2017 at 1:36 PM, Michal Novotny clime@redhat.com wrote:
On Tue, Jan 24, 2017 at 11:44 AM, Pierre-Yves Chibon pingou@pingoured.fr wrote:
On Tue, Jan 24, 2017 at 11:30:33AM +0100, Michal Novotny wrote:
Yes, untested changes got into production. We are sorry. I am
currently
working on a fix.
If that made it up to production, then we'll need to adjust fedmsg_meta to support these messages as well.
fedmsg_meta should work for all our published messages (published and stored on datagrepper).
Okay, these messages have all empty body (the "msg" attribute), e.g `build.end`:
{ "source_name": "datanommer", "certificate": "LS0tLS1CRUdJTiBDRVJUSUZJQ0FURS0tLS0tCk1JSUVUakNDQTdlZ0F3SUJBZ0lDQVBZd0RRWUpL\nb1pJaHZjTkFRRUZCUUF3Z2FBeEN6QUpCZ05WQkFZVEFsVlQKTVFzd0NRWURWUVFJRXdKT1F6RVFN\nQTRHQTFVRUJ4TUhVbUZzWldsbmFERVhNQlVHQTFVRUNoTU9SbVZrYjNKaApJRkJ5YjJwbFkzUXhE\nekFOQmdOVkJBc1RCbVpsWkcxelp6RVBNQTBHQTFVRUF4TUdabVZrYlhObk1ROHdEUVlEClZRUXBF\nd1ptWldSdGMyY3hKakFrQmdrcWhraUc5dzBCQ1FFV0YyRmtiV2x1UUdabFpHOXlZWEJ5YjJwbFkz\nUXUKYjNKbk1CNFhEVEUwTURReU16RTBNamsxTVZvWERUSTBNRFF5TURFME1qazFNVm93Z2R3eEN6\nQUpCZ05WQkFZVApBbFZUTVFzd0NRWURWUVFJRXdKT1F6RVFNQTRHQTFVRUJ4TUhVbUZzWldsbmFE\nRVhNQlVHQTFVRUNoTU9SbVZrCmIzSmhJRkJ5YjJwbFkzUXhEekFOQmdOVkJBc1RCbVpsWkcxelp6\nRXRNQ3NHQTFVRUF4TWtZMjl3Y2kxamIzQnkKTFdKbExtTnNiM1ZrTG1abFpHOXlZWEJ5YjJwbFkz\nUXViM0puTVMwd0t3WURWUVFwRXlSamIzQnlMV052Y0hJdApZbVV1WTJ4dmRXUXVabVZrYjNKaGNI\nSnZhbVZqZEM1dmNtY3hKakFrQmdrcWhraUc5dzBCQ1FFV0YyRmtiV2x1ClFHWmxaRzl5WVhCeWIy\ncGxZM1F1YjNKbk1JR2ZNQTBHQ1NxR1NJYjNEUUVCQVFVQUE0R05BRENCaVFLQmdRQ2UKREs5VFQy\nM05BdTZPWTVGMnVVNHpMRW9Ld2k1RnRRTU5jVWV5eDdmOHJxMUZXaUxDWHBjWFhpU2tzUE1XV1NM\nWQo5SHNoa1pvM3ZjMHFSRXVBWDNweWRuM2VFRDA0UExrUmRlaWpvSXA5L0Y2YlZ3MmlLMDdXRmc5\nU2MwNlRsKzhSCld1RHNaeTQ1SVJKYXhCRTlJaHBYL0x2Y2JnQ1cvZmVHVGp5WG1iRHd0UUlEQVFB\nQm80SUJWekNDQVZNd0NRWUQKVlIwVEJBSXdBREF0QmdsZ2hrZ0JodmhDQVEwRUlCWWVSV0Z6ZVMx\nU1UwRWdSMlZ1WlhKaGRHVmtJRU5sY25ScApabWxqWVhSbE1CMEdBMVVkRGdRV0JCUm5lNTg0d3Bs\nWGYrZVE2K25zSTZCbm5BNENaRENCMVFZRFZSMGpCSUhOCk1JSEtnQlJyUUZyNUVnaUpXZWRaNVFY\nMUFoMEtUbjhVQUtHQnBxU0JvekNCb0RFTE1Ba0dBMVVFQmhNQ1ZWTXgKQ3pBSkJnTlZCQWdUQWs1\nRE1SQXdEZ1lEVlFRSEV3ZFNZV3hsYVdkb01SY3dGUVlEVlFRS0V3NUdaV1J2Y21FZwpVSEp2YW1W\namRERVBNQTBHQTFVRUN4TUdabVZrYlhObk1ROHdEUVlEVlFRREV3Wm1aV1J0YzJjeER6QU5CZ05W\nCkJDa1RCbVpsWkcxelp6RW1NQ1FHQ1NxR1NJYjNEUUVKQVJZWFlXUnRhVzVBWm1Wa2IzSmhjSEp2\nYW1WamRDNXYKY21lQ0NRRGpVQjVIVHhjZVJUQVRCZ05WSFNVRUREQUtCZ2dyQmdFRkJRY0RBakFM\nQmdOVkhROEVCQU1DQjRBdwpEUVlKS29aSWh2Y05BUUVGQlFBRGdZRUFVazNlbjBYUXpDQm5IUlh4\nZDhyOHp2ZFAwVURvbEpiUysyTEl3Z3NDClJDMnNkZ1UwNGdFblYxdFpVTjNydEk1SzQ2MnpKT0JQ\nOFhQd3h4eUZMN1lOYmVtWTgyTG52Y1pHdzliMGdxTDMKdHNKbzllSFV5SXBZMG93TlVKdzgzU1Ax\neFJvb3NwVGJRK3BsNm9qdjVPNVpGZ1lBUG1yckRWZ0M4a2gzRlp4Rgp0SWc9Ci0tLS0tRU5EIENF\nUlRJRklDQVRFLS0tLS0K\n", "i": 3, "timestamp": 1485166967.0, "msg_id": "2017-db23086c-2001-496e-a59f-10b92c466ae5", "topic": "org.fedoraproject.prod.copr.build.end", "source_version": "0.6.5", "signature": "HJEOhP93vZFUk3cjIzggxZqIT+IRaLpKF/t21Kn0AcQ9B1VJEe+myerAAJMZfuXppGQqsFyzcPFx\nu+9p7geI5NqNxnN+diUXNlxbXN9/VN0X3vX7U4mbc0/zLyGcbKWIn/pcskbM5qYC2lJHLov0pMwq\nrbq/B0N3CxBL2og0Fj8=\n", "msg": {} }
Does fedmsg_meta need to be adjusted even so? clime
Pierre
On Tue, Jan 24, 2017 at 11:02 AM, Pierre-Yves Chibon <
pingou@pingoured.fr>
wrote:
Hi all, We have recently been receiving emails about wrongly formattedfedmsg
message coming from copr in stg. Has there been any changes made to the structure of the messagessent in
stg? To give you an idea, this is what we received: Traceback (most recent call last): Â File "/usr/lib/python2.7/site-packages/moksha/hub/api/consumer.py",
line 191, in _work   self.consume(message)  File "/usr/lib/python2.7/site-packages/fmn/consumer/consumer.py",
line 89, in consume   self.work(session, raw_msg)  File "/usr/lib/python2.7/site-packages/fmn/consumer/consumer.py",
line 105, in work   msg['msg']['owner'] in self.ignored_copr_owners: KeyError: 'owner' The message being: {'body': {u'username': u'copr', u'certificate': u'LS0tLS1CRUdJTiBDRVJUSUZJQ0FURS0tLS0tCk1JSUVUakNDQTdlZ0F3SUJBZ0lDQVBZd0RRWUpL\nb1pJaHZjTkFRRUZCUUF3Z2FBeEN6QUpCZ05WQkFZ VEFsVlQKTVFzd0NRWURWUVFJRXdKT1F6RVFN\nQTRHQTFVRUJ4TUhVbUZzWl dsbmFERVhNQlVHQTFVRUNoTU9SbVZrYjNKaApJRkJ5YjJwbFkzUXhE\nekFO QmdOVkJBc1RCbVpsWkcxelp6RVBNQTBHQTFVRUF4TUdabVZrYlhObk1ROHdE UVlEClZRUXBF\nd1ptWldSdGMyY3hKakFrQmdrcWhraUc5dzBCQ1FFV0YyRm tiV2x1UUdabFpHOXlZWEJ5YjJwbFkz\nUXUKYjNKbk1CNFhEVEUwTURReU16 RTBNamsxTVZvWERUSTBNRFF5TURFME1qazFNVm93Z2R3eEN6\nQUpCZ05WQk FZVApBbFZUTVFzd0NRWURWUVFJRXdKT1F6RVFNQTRHQTFVRUJ4TUhVbUZzWl dsbmFE\nRVhNQlVHQTFVRUNoTU9SbVZrCmIzSmhJRkJ5YjJwbFkzUXhEekFO QmdOVkJBc1RCbVpsWkcxelp6\nRXRNQ3NHQTFVRUF4TWtZMjl3Y2kxamIzQn kKTFdKbExtTnNiM1ZrTG1abFpHOXlZWEJ5YjJwbFkz\nUXViM0puTVMwd0t3 WURWUVFwRXlSamIzQnlMV052Y0hJdApZbVV1WTJ4dmRXUXVabVZrYjNKaGNI \nSnZhbVZqZEM1dmNtY3hKakFrQmdrcWhraUc5dzBCQ1FFV0YyRmtiV2x1Cl FHWmxaRzl5WVhCeWIy\ncGxZM1F1YjNKbk1JR2ZNQTBHQ1NxR1NJYjNEUUVC QVFVQUE0R05BRENCaVFLQmdRQ2UKREs5VFQy\nM05BdTZPWTVGMnVVNHpMRW 9Ld2k1RnRRTU5jVWV5eDdmOHJxMUZXaUxDWHBjWFhpU2tzUE1XV1NM\nWQ> o5SHNoa1pvM3ZjMHFSRXVBWDNweWRuM2VFRDA0UExrUmRlaWpvSXA5L0Y2Yl Z3MmlLMDdXRmc5\nU2MwNlRsKzhSCld1RHNaeTQ1SVJKYXhCRTlJaHBYL0x2 Y2JnQ1cvZmVHVGp5WG1iRHd0UUlEQVFB\nQm80SUJWekNDQVZNd0NRWUQKVl IwVEJBSXdBREF0QmdsZ2hrZ0JodmhDQVEwRUlCWWVSV0Z6ZVMx\nU1UwRWdS MlZ1WlhKaGRHVmtJRU5sY25ScApabWxqWVhSbE1CMEdBMVVkRGdRV0JCUm5l NTg0d3Bs\nWGYrZVE2K25zSTZCbm5BNENaRENCMVFZRFZSMGpCSUhOCk1JSE tnQlJyUUZyNUVnaUpXZWRaNVFY\nMUFoMEtUbjhVQUtHQnBxU0JvekNCb0RF TE1Ba0dBMVVFQmhNQ1ZWTXgKQ3pBSkJnTlZCQWdUQWs1\nRE1SQXdEZ1lEVl FRSEV3ZFNZV3hsYVdkb01SY3dGUVlEVlFRS0V3NUdaV1J2Y21FZwpVSEp2YW 1W\namRERVBNQTBHQTFVRUN4TUdabVZrYlhObk1ROHdEUVlEVlFRREV3Wm1a V1J0YzJjeER6QU5CZ05W\nCkJDa1RCbVpsWkcxelp6RW1NQ1FHQ1NxR1NJYj NEUUVKQVJZWFlXUnRhVzVBWm1Wa2IzSmhjSEp2\nYW1WamRDNXYKY21lQ0NR RGpVQjVIVHhjZVJUQVRCZ05WSFNVRUREQUtCZ2dyQmdFRkJRY0RBakFM\nQm dOVkhROEVCQU1DQjRBdwpEUVlKS29aSWh2Y05BUUVGQlFBRGdZRUFVazNlbj BYUXpDQm5IUlh4\nZDhyOHp2ZFAwVURvbEpiUysyTEl3Z3NDClJDMnNkZ1Uw NGdFblYxdFpVTjNydEk1SzQ2MnpKT0JQ\nOFhQd3h4eUZMN1lOYmVtWTgyTG 52Y1pHdzliMGdxTDMKdHNKbzllSFV5SXBZMG93TlVKdzgzU1Ax\neFJvb3NwVGJ> RK3BsNm9qdjVPNVpGZ1lBUG1yckRWZ0M4a2gzRlp4Rgp0SWc9Ci0tLS0tRU5 EIENF\nUlRJRklDQVRFLS0tLS0K\n',
u'i': 3, u'timestamp': 1485209011, u'msg_id':u'2017-dc6af56b-76c4-425d-8b66-f69295b38fe0', u'crypto': u'x509', u'topic': u'org.fedoraproject.prod.copr.build.end',u'signature':u'AJHlFzJnrrTF9XVs6b0KT4U0n3LCVtK/cWbt+hceOeWf/0bvYn6ZMx6dUTBasutGnA8TY998U6H6\ nzgBXPM1fyV4WCO+ekuIV7O6dpNedlfpcrnnU1LRGCPWVPSgIw0gg5QDfZ06 kQWuQvC17JxokG7Pi\n4vIiW64ifAddRZEILxc=\n',
u'msg': {}}, 'topic':u'org.fedoraproject.prod.copr.build.end'} Does that ring a bell to anyone? Thanks, Pierre _______________________________________________ copr-devel mailing list -- copr-devel@lists.fedorahosted.org To unsubscribe send an email to copr-devel-leave@lists.fedorahosted.org
copr-devel mailing list -- copr-devel@lists.fedorahosted.org To unsubscribe send an email to copr-devel-leave@lists.fedorahosted.org
copr-devel mailing list -- copr-devel@lists.fedorahosted.org To unsubscribe send an email to copr-devel-leave@lists.fedorahosted.org
On Tue, Jan 24, 2017 at 03:12:10PM +0100, Michal Novotny wrote:
Otherwise, in the fix that I am going to apply tomorrow, there will some additional fields for chroot.start and build.start messages.
For chroot.start:
- status (int)
- version (str)
For build.start:
- status (int)
- version (str)
- chroot (str)
The old fields will be all there with the same type. Only some new fields will be added. I hope that does not represent a problem for fedmsg_meta or anybody. I am aware that an ideal way would be to just leave the old message interface as it was but the code would get very ugly. Of course, I will do it if needed.
Adding new fields is not a problem for fedmsg_meta as long as it can access the old ones.
We can adjust fedmsg_meta to benefit from the new fields if we want. The way is then to rename the tests TestFoo to LegacyTestFoo (so we keep supporting the old formats) and then add a new TestFoo where the message is of the new format and adjust the processor to support the new format (while still supporting the old one).
For example: https://github.com/fedora-infra/fedmsg_meta_fedora_infrastructure/pull/403
Pierre
On Tue, Jan 24, 2017 at 01:36:59PM +0100, Michal Novotny wrote:
On Tue, Jan 24, 2017 at 11:44 AM, Pierre-Yves Chibon pingou@pingoured.fr wrote:
On Tue, Jan 24, 2017 at 11:30:33AM +0100, Michal Novotny wrote: >Â Â Yes, untested changes got into production. We are sorry. I am currently >Â Â working on a fix. If that made it up to production, then we'll need to adjust fedmsg_meta to support these messages as well. fedmsg_meta should work for all our published messages (published and stored on datagrepper).Okay, these messages have all empty body (the "msg" attribute), e.g `build.end`:
{ "source_name": "datanommer", "i": 3,
...
"timestamp": 1485166967.0, "msg_id": "2017-db23086c-2001-496e-a59f-10b92c466ae5", "topic": "org.fedoraproject.prod.copr.build.end", "source_version": "0.6.5", "signature": "HJEOhP93vZFUk3cjIzggxZqIT+IRaLpKF/t21Kn0AcQ9B1VJEe+myerAAJMZfuXppGQqsFyzcPFx\nu+9p7geI5NqNxnN+diUXNlxbXN9/VN0X3vX7U4mbc0/zLyGcbKWIn/pcskbM5qYC2lJHLov0pMwq\nrbq/B0N3CxBL2og0Fj8=\n", "msg": {} }
Does fedmsg_meta need to be adjusted even so?
Yeah, fedmsg_meta should be able to process all the messages stored in datagrepper, otherwise it breaks datagrepper and a few other apps.
So we'll end up with some not so useful message: "a build ended in copr" but we should add them.
The easiest for this type of changes is to use test-driven-development, add the new message to the test, fill in the expectations and then adjust the processor to handle those cases.
Pierre
On Tue, Jan 24, 2017 at 10:40 PM, Pierre-Yves Chibon pingou@pingoured.fr wrote:
On Tue, Jan 24, 2017 at 01:36:59PM +0100, Michal Novotny wrote:
On Tue, Jan 24, 2017 at 11:44 AM, Pierre-Yves Chibon <
pingou@pingoured.fr>
wrote:
On Tue, Jan 24, 2017 at 11:30:33AM +0100, Michal Novotny wrote: >Â Â Yes, untested changes got into production. We are sorry. I am currently >Â Â working on a fix. If that made it up to production, then we'll need to adjustfedmsg_meta
to support these messages as well. fedmsg_meta should work for all our published messages (publishedand
stored on datagrepper).Okay, these messages have all empty body (the "msg" attribute), e.g `build.end`:
{ "source_name": "datanommer", "i": 3,
...
"timestamp": 1485166967.0, "msg_id": "2017-db23086c-2001-496e-a59f-10b92c466ae5", "topic": "org.fedoraproject.prod.copr.build.end", "source_version": "0.6.5", "signature": "HJEOhP93vZFUk3cjIzggxZqIT+IRaLpKF/t21Kn0AcQ9B1VJEe+
myerAAJMZfuXppGQqsFyzcPFx\nu+9p7geI5NqNxnN+diUXNlxbXN9/ VN0X3vX7U4mbc0/zLyGcbKWIn/pcskbM5qYC2lJHLov0pMwq\nrbq/B0N3CxBL2og0Fj8=\n",
"msg": {} }
Does fedmsg_meta need to be adjusted even so?
Yeah, fedmsg_meta should be able to process all the messages stored in datagrepper, otherwise it breaks datagrepper and a few other apps.
So we'll end up with some not so useful message: "a build ended in copr" but we should add them.
A malformed message (processed with the current fedmsg_meta:
*copr.build.start* https://apps.fedoraproject.org/datagrepper/raw?topic=org.fedoraproject.prod.copr.build.start Automated build of the None copr has been started JSON https://apps.fedoraproject.org/datagrepper/id?id=2017-a8154546-d8eb-401c-9b66-9984572885da&is_raw=true&size=extra-large
fedmsg_meta might already account for the case of missing fields. Looking at the
code, I think this is the case. Let me, please, know what you think.
The easiest for this type of changes is to use test-driven-development, add the new message to the test, fill in the expectations and then adjust the processor to handle those cases.
Pierre _______________________________________________ copr-devel mailing list -- copr-devel@lists.fedorahosted.org To unsubscribe send an email to copr-devel-leave@lists.fedorahosted.org
On Wed, Jan 25, 2017 at 09:05:03AM +0100, Michal Novotny wrote:
On Tue, Jan 24, 2017 at 10:40 PM, Pierre-Yves Chibon pingou@pingoured.fr wrote:
On Tue, Jan 24, 2017 at 01:36:59PM +0100, Michal Novotny wrote: >Â Â On Tue, Jan 24, 2017 at 11:44 AM, Pierre-Yves Chibon <pingou@pingoured.fr> >Â Â wrote: > >Â Â Â On Tue, Jan 24, 2017 at 11:30:33AM +0100, Michal Novotny wrote: >Â Â Â >Ã*Â Ã*Â Yes, untested changes got into production. We are sorry. I am >Â Â Â currently >Â Â Â >Ã*Â Ã*Â working on a fix. > >Â Â Â If that made it up to production, then we'll need to adjust fedmsg_meta >Â Â Â to >Â Â Â support these messages as well. > >Â Â Â fedmsg_meta should work for all our published messages (published and >Â Â Â stored on >Â Â Â datagrepper). > >Â Â Okay, these messages have all empty body (the "msg" attribute), e.g >Â Â `build.end`: > >Â { >Â Â "source_name": "datanommer", >Â Â "i": 3, ... >Â Â "timestamp": 1485166967.0, >Â Â "msg_id": "2017-db23086c-2001-496e-a59f-10b92c466ae5", >Â Â "topic": "org.fedoraproject.prod.copr.build.end", >Â Â "source_version": "0.6.5", >Â Â "signature": "HJEOhP93vZFUk3cjIzggxZqIT+IRaLpKF/t21Kn0AcQ9B1VJEe+myerAAJMZfuXppGQqsFyzcPFx\nu+9p7geI5NqNxnN+diUXNlxbXN9/VN0X3vX7U4mbc0/zLyGcbKWIn/pcskbM5qYC2lJHLov0pMwq\nrbq/B0N3CxBL2og0Fj8=\n", >Â Â "msg": {} >Â } > >Â Â Does fedmsg_meta need to be adjusted even so? Yeah, fedmsg_meta should be able to process all the messages stored in datagrepper, otherwise it breaks datagrepper and a few other apps. So we'll end up with some not so useful message: "a build ended in copr" but we should add them.A malformed message (processed with the current fedmsg_meta:
copr.build.start Automated build of the None copr has been started JSON
fedmsg_meta might already account for the case of missing fields. Looking at the
code, I think this is the case. Let me, please, know what you think.
Well, in the first email on this thread there is an error from fedmsg_meta so there is likely one part of fedmsg_meta that won't like the missing fields.
Pierre
On Wed, Jan 25, 2017 at 9:21 AM, Pierre-Yves Chibon pingou@pingoured.fr wrote:
On Wed, Jan 25, 2017 at 09:05:03AM +0100, Michal Novotny wrote:
On Tue, Jan 24, 2017 at 10:40 PM, Pierre-Yves Chibon <
pingou@pingoured.fr>
wrote:
On Tue, Jan 24, 2017 at 01:36:59PM +0100, Michal Novotny wrote: >Â Â On Tue, Jan 24, 2017 at 11:44 AM, Pierre-Yves Chibon <pingou@pingoured.fr> >Â Â wrote: > >Â Â Â On Tue, Jan 24, 2017 at 11:30:33AM +0100, Michal Novotny wrote: >Â Â Â >Ã*Â Ã*Â Yes, untested changes got into production. Weare
sorry. I am >Â Â Â currently >Â Â Â >Ã*Â Ã*Â working on a fix. > >Â Â Â If that made it up to production, then we'll need toadjust
fedmsg_meta >Â Â Â to >Â Â Â support these messages as well. > >Â Â Â fedmsg_meta should work for all our published messages (published and >Â Â Â stored on >Â Â Â datagrepper). > >Â Â Okay, these messages have all empty body (the "msg"attribute),
e.g >Â Â `build.end`: > >Â { >Â Â "source_name": "datanommer", >Â Â "i": 3, ... >Â Â "timestamp": 1485166967.0, >Â Â "msg_id": "2017-db23086c-2001-496e-a59f-10b92c466ae5", >Â Â "topic": "org.fedoraproject.prod.copr.build.end", >Â Â "source_version": "0.6.5", >Â Â "signature": "HJEOhP93vZFUk3cjIzggxZqIT+IRaLpKF/t21Kn0AcQ9B1VJEe+myerAAJMZfuXppGQqsFyzcPFx\nu+9p7geI5NqNxnN+diUXNlxbXN9/ VN0X3vX7U4mbc0/zLyGcbKWIn/pcskbM5qYC2lJHLov0pMwq\nrbq/B0N3CxBL2og0Fj8=\n",
>Â Â "msg": {} >Â } > >Â Â Does fedmsg_meta need to be adjusted even so? Yeah, fedmsg_meta should be able to process all the messages storedin
datagrepper, otherwise it breaks datagrepper and a few other apps. So we'll end up with some not so useful message: "a build ended incopr"
but we should add them.A malformed message (processed with the current fedmsg_meta:
copr.build.start Automated build of the None copr has been started
JSON
fedmsg_meta might already account for the case of missing fields.
Looking
at the
code, I think this is the case. Let me, please, know what you think.
Well, in the first email on this thread there is an error from fedmsg_meta so there is likely one part of fedmsg_meta that won't like the missing fields.
I proposed this PR in fmn.consumer to fix it:
https://github.com/fedora-infra/fmn.consumer/pull/97/commits/fdfcec49d0197d3...
Pierre _______________________________________________ copr-devel mailing list -- copr-devel@lists.fedorahosted.org To unsubscribe send an email to copr-devel-leave@lists.fedorahosted.org
On Wed, Jan 25, 2017 at 09:48:12AM +0100, Michal Novotny wrote:
On Wed, Jan 25, 2017 at 9:21 AM, Pierre-Yves Chibon pingou@pingoured.fr wrote: Well, in the first email on this thread there is an error from fedmsg_meta so there is likely one part of fedmsg_meta that won't like the missing fields.
I proposed this PR in fmn.consumer to fix it: https://github.com/fedora-infra/fmn.consumer/pull/97/commits/fdfcec49d0197d3...
Thanks :)
Pierre
copr-devel@lists.fedorahosted.org
-
Michal Novotny -
Pierre-Yves Chibon