I'm not sure how widely used asciidoc is around here. Both git and tig use it to build their documentation and have been hit by bug 506953¹. I think this bug may hit many other users of asciidoc as well, making our current packages a bit annoying to use for many projects.
If any other asciidoc users have run into spurious 'unsafe: include file' errors since asciidoc was updated to 8.4.5 (F-11 and devel), your help confirming that the patch I posted to the bug report helps and doesn't hurt would be most welcome. (Even if you haven't hit the 'unsafe: include file' errors, your testing would be great.)
¹ https://bugzilla.redhat.com/506953
Todd Zullinger wrote:
I'm not sure how widely used asciidoc is around here. Both git and tig use it to build their documentation and have been hit by bug 506953¹. I think this bug may hit many other users of asciidoc as well, making our current packages a bit annoying to use for many projects.
If any other asciidoc users have run into spurious 'unsafe: include file' errors since asciidoc was updated to 8.4.5 (F-11 and devel), your help confirming that the patch I posted to the bug report helps and doesn't hurt would be most welcome. (Even if you haven't hit the 'unsafe: include file' errors, your testing would be great.)
guilt hit this, but I just passed the --unsafe option to asciidoc to work around it :)
-Eric
On Wed, Jul 15, 2009 at 6:01 AM, Todd Zullingertmz@pobox.com wrote:
safekeep hit it. I was just starting to diagnose the problem.
Do we really need to carry patches around in multiple individual projects for what is understood to be a problem in our asciidoc packaging? Really? Can't we deal with this in asciidoc packaging? So we aren't running done multiple failure to build reports?
These are the packages which asciidoc's broken safe behavior. potentially impacts on packaging building.
repoquery --whatrequires --archlist=src --repoid=rawhide-source asciidoc
git-cola-0:1.3.8-1.fc12.src tig-0:0.14.1-1.fc11.src gegl-0:0.1.0-1.fc12.src libXi-0:1.2.99-2.20090619.fc12.src guilt-0:0.32-3.fc11.src git-0:1.6.3.3-1.fc12.src safekeep-0:1.0.5-2.fc11.src cogito-0:0.18.2-4.fc11.src sectool-0:0.9.3-1.fc12.src
-jef
On Wed, Jul 15, 2009 at 11:12:19AM -0800, Jeff Spaleta wrote:
These are the packages which asciidoc's broken safe behavior. potentially impacts on packaging building.
repoquery --whatrequires --archlist=src --repoid=rawhide-source asciidoc
git-cola-0:1.3.8-1.fc12.src tig-0:0.14.1-1.fc11.src gegl-0:0.1.0-1.fc12.src libXi-0:1.2.99-2.20090619.fc12.src
libXi is not affected by this issue.
guilt-0:0.32-3.fc11.src git-0:1.6.3.3-1.fc12.src safekeep-0:1.0.5-2.fc11.src cogito-0:0.18.2-4.fc11.src sectool-0:0.9.3-1.fc12.src
Cheers, Peter
On Wed, 2009-07-15 at 10:01 -0400, Todd Zullinger wrote:
I'm not sure how widely used asciidoc is around here. Both git and tig use it to build their documentation and have been hit by bug 506953¹. I think this bug may hit many other users of asciidoc as well, making our current packages a bit annoying to use for many projects.
If any other asciidoc users have run into spurious 'unsafe: include file' errors since asciidoc was updated to 8.4.5 (F-11 and devel), your help confirming that the patch I posted to the bug report helps and doesn't hurt would be most welcome. (Even if you haven't hit the 'unsafe: include file' errors, your testing would be great.)
just apply the --unsafe as default patch I suppose, I'm not sure its actually a useful feature,
Dave.
Dave Airlie wrote:
just apply the --unsafe as default patch I suppose, I'm not sure its actually a useful feature,
I created an 'unsafe' mode by default patch and sent it upstream, as well as noted it in the bug report. I'll go apply for privileges to asciidoc so I can apply this, if no one notices any glaring problems with the changes in the next day or so.
-
David Airlie -
Eric Sandeen -
Jef Spaleta -
Peter Hutterer -
Todd Zullinger