On 11/03/2017 04:59 AM, Hans de Goede wrote:
Hi,
On 01-11-17 20:34, Laura Abbott wrote:
I'm always a bit uneasy about enabling hardware power saving since it rarely seems to be done correctly but as Peter pointed out it's easy to revert if something goes wrong. Having the endorsement of upstream is also good since it means they should be responsive.
Enabling for 4.14 sounds like a good plan. Did you intend for this to end up in stable releases on rebase?
That was my original intention yes. But now that you explicitly ask I guess that we may want to hold off on that and just make the change for rawhide / F28. I will try to get the change committed to the master branch today (otherwise I will do it Monday). I will leave it up to you if you also make the change to the stable releases on rebase.
We ended up putting this in the 4.14 rebase and there were a few issues reported[0][1] on i686 and x86_64 so I've set it back to 0 on all arches in F27 and F26. Hans, do you want to leave in on in Rawhide and see if we can come up with some fixes or should I switch it to 0 there as well?
[0] https://bugzilla.redhat.com/show_bug.cgi?id=1525561 [1] https://bugzilla.redhat.com/show_bug.cgi?id=1525104
Thanks, Jeremy