Ville,
Adding glic fedora list and CC'ing Siddhesh.
Thank you very much for helping with glibc.
In the future please make sure we get a bug filed for every issue so we can discuss the problem before the fix is applied.
While glibc places files into %{_prefix}/lib/locale, I would like to have talked about who should owns those directories that are just expected to exist.
If the answer is "glibc" then I have no problem.
However, we don't own /etc for example, and as the core C library we are the *first* package to add a file into /etc from a bootstrap perspective.
Is there Fedora policy on which directories you don't have to own and can expect?
Cheers, Carlos.
On 01/25/2014 01:51 PM, Ville Skyttä wrote:
commit 111d75b10fe5ed46bcfe24b1a78a620091b75ee5 Author: Ville Skyttä ville.skytta@iki.fi Date: Sat Jan 25 20:52:16 2014 +0200
Own the %{_prefix}/lib/locale dir.glibc.spec | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/glibc.spec b/glibc.spec index d3a3a8d..6a36498 100644 --- a/glibc.spec +++ b/glibc.spec @@ -1573,6 +1573,7 @@ rm -f *.filelist* %ifnarch %{auxarches} %files -f common.filelist common %defattr(-,root,root) +%dir %{_prefix}/lib/locale %attr(0644,root,root) %verify(not md5 size mtime) %{_prefix}/lib/locale/locale-archive.tmpl %attr(0644,root,root) %verify(not md5 size mtime mode) %ghost %config(missingok,noreplace) %{_prefix}/lib/locale/locale-archive %dir %attr(755,root,root) /etc/default @@ -1624,6 +1625,9 @@ rm -f *.filelist* %endif
%changelog +* Sat Jan 25 2014 Ville Skyttä ville.skytta@iki.fi +- Own the %%{_prefix}/lib/locale dir.
- Thu Jan 23 2014 Siddhesh Poyarekar siddhesh@redhat.com - 2.18.90-23
- Sync with upstream master.
On Mon, Jan 27, 2014 at 7:55 PM, Carlos O'Donell carlos@redhat.com wrote:
While glibc places files into %{_prefix}/lib/locale, I would like to have talked about who should owns those directories that are just expected to exist.
If the answer is "glibc" then I have no problem.
To me the answer is clearly glibc (well, more specifically glibc-common) as no other packages in the distro place files to /usr/lib/locale that I'm aware of:
$ repoquery --repoid=rawhide -f "/usr/lib/locale/*" "/usr/lib/locale/*/*" "/usr/lib/locale/*/*/*" glibc-common-0:2.18.90-23.fc21.x86_64
However, we don't own /etc for example, and as the core C library we are the *first* package to add a file into /etc from a bootstrap perspective.
Is there Fedora policy on which directories you don't have to own and can expect?
https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Owner...
Specifically regarding /etc: "Packages must own all directories they put files in, except for any directories owned by the filesystem [...]". $ rpm -qf /etc filesystem-3.2-24.fc21.x86_64
On 01/27/2014 02:15 PM, Ville Skyttä wrote:
On Mon, Jan 27, 2014 at 7:55 PM, Carlos O'Donell carlos@redhat.com wrote:
While glibc places files into %{_prefix}/lib/locale, I would like to have talked about who should owns those directories that are just expected to exist.
If the answer is "glibc" then I have no problem.
To me the answer is clearly glibc (well, more specifically glibc-common) as no other packages in the distro place files to /usr/lib/locale that I'm aware of:
$ repoquery --repoid=rawhide -f "/usr/lib/locale/*" "/usr/lib/locale/*/*" "/usr/lib/locale/*/*/*" glibc-common-0:2.18.90-23.fc21.x86_64
All good arguments.
Would you mind if we had this kind of discussion first before checking in any future patches? This way the rest of the team maintaining glibc can comment?
I would still like a bug for user visible issues such that the Fedora glibc maintainers can have something to refer to for future discussions and or use to generated release notes.
Does that make sense?
However, we don't own /etc for example, and as the core C library we are the *first* package to add a file into /etc from a bootstrap perspective.
Is there Fedora policy on which directories you don't have to own and can expect?
https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Owner...
Specifically regarding /etc: "Packages must own all directories they put files in, except for any directories owned by the filesystem [...]". $ rpm -qf /etc filesystem-3.2-24.fc21.x86_64
Thanks, I just went through the filesystem package and noted that /etc is owned there, so that looks good to me.
Cheers, Carlos.
On Mon, Jan 27, 2014 at 10:04 PM, Carlos O'Donell carlos@redhat.com wrote:
On 01/27/2014 02:15 PM, Ville Skyttä wrote:
On Mon, Jan 27, 2014 at 7:55 PM, Carlos O'Donell carlos@redhat.com wrote:
While glibc places files into %{_prefix}/lib/locale, I would like to have talked about who should owns those directories that are just expected to exist.
If the answer is "glibc" then I have no problem.
To me the answer is clearly glibc (well, more specifically glibc-common) as no other packages in the distro place files to /usr/lib/locale that I'm aware of:
$ repoquery --repoid=rawhide -f "/usr/lib/locale/*" "/usr/lib/locale/*/*" "/usr/lib/locale/*/*/*" glibc-common-0:2.18.90-23.fc21.x86_64
All good arguments.
Would you mind if we had this kind of discussion first before checking in any future patches? This way the rest of the team maintaining glibc can comment?
Yes, I'll keep that in mind for the future.
On 01/27/2014 03:36 PM, Ville Skyttä wrote:
To me the answer is clearly glibc (well, more specifically glibc-common) as no other packages in the distro place files to /usr/lib/locale that I'm aware of:
$ repoquery --repoid=rawhide -f "/usr/lib/locale/*" "/usr/lib/locale/*/*" "/usr/lib/locale/*/*/*" glibc-common-0:2.18.90-23.fc21.x86_64
All good arguments.
Would you mind if we had this kind of discussion first before checking in any future patches? This way the rest of the team maintaining glibc can comment?
Yes, I'll keep that in mind for the future.
Thanks Ville.
Cheers, Carlos.
On Mon, Jan 27, 2014 at 12:55:57PM -0500, Carlos O'Donell wrote:
%changelog +* Sat Jan 25 2014 Ville Skyttä ville.skytta@iki.fi +- Own the %%{_prefix}/lib/locale dir.
Also, the usual policy is to bump the release number on every change. The changelog is also missing the NVR.
Siddhesh
On Wed, Jan 29, 2014 at 6:48 AM, Siddhesh Poyarekar siddhesh@redhat.com wrote:
On Mon, Jan 27, 2014 at 12:55:57PM -0500, Carlos O'Donell wrote:
%changelog +* Sat Jan 25 2014 Ville Skyttä ville.skytta@iki.fi +- Own the %%{_prefix}/lib/locale dir.
Also, the usual policy is to bump the release number on every change. The changelog is also missing the NVR.
Both of those were very much intentional and the latter is the consequence of not doing the former; I don't think this change alone warrants building and pushing glibc updates to rawhide users, it can wait until the next build.
-
Carlos O'Donell -
Siddhesh Poyarekar -
Ville Skyttä