golang February 2022

golang@lists.fedoraproject.org

6 participants
8 discussions

[go-rpm-macros] Issue #36: Renaming BUILDTAGS and LDFLAGS to include GO prefixes
by Link Dupont 20 Jun '22

20 Jun '22

linkdupont reported a new issue against the project: `go-rpm-macros` that you are following: `` In #34 and #35, it was brought up to rename the `BUILDTAGS` variable to `GOBUILDTAGS` in order to be more explicit about the intended use of the variables and to avoid any potential namespace collision with other variables. I looked into what packages are using `BUILDTAGS` today to figure out how much of an impact a rename like this will have. As of this writing, the following packages are using `BUILDTAGS` in some capacity: ``` buildah.spec containernetworking-plugins.spec cri-tools.spec go-compilers.spec golang-github-prometheus-node-exporter.spec golang-github-prometheus.spec grafana.spec hugo.spec moby-engine.spec oci-seccomp-bpf-hook.spec pack.spec podman.spec reg.spec runc.spec skopeo.spec snapd.spec source-to-image.spec stargz-snapshotter.spec syncthing.spec weldr-client.spec ``` And the follow packages use `LDFLAGS`: ``` aerc.spec age.spec butane.spec clash.spec containerd.spec doctl.spec fzf.spec geoipupdate.spec git-lfs.spec golang-github-aliyun-cli.spec golang-github-colinmarc-hdfs-2.spec golang-github-haproxytech-dataplaneapi.spec golang-github-hub.spec golang-github-jsonnet-bundler.spec golang-github-magefile-mage.spec golang-github-prometheus.spec golang-github-rfjakob-gocryptfs.spec golang-github-tdewolff-minify.spec golang-github-theoapp-theo-agent.spec golang-mvdan-editorconfig.spec ignition.spec kiln.spec micro.spec open-policy-agent.spec osbuild-composer.spec rclone.spec reg.spec source-to-image.spec syncthing.spec tinygo.spec vgrep.spec weldr-client.spec ``` I identified these packages by grepping the contents of the [current spec tarball](https://src.fedoraproject.org/repo/rpm-specs-latest.tar.xz). To avoid breaking these packages that are currently using `BUILDTAGS` or `LDFLAGS`, there are two possible approaches I see to safely rename the variables: #### 1. Rebuild everything in a side-tag Patch `go-rpm-macros` to rename `BUILDTAGS` and `LDFLAGS` to `GOBUILDTAGS` and `GOLDFLAGS` respectively. Then patch the above packages and stage them all in a side-tag to update them in one monolithic Bodhi update. #### 2. Support both old and new variables at the same time Patch `go-rpm-macros` to support **both** `BUILDTAGS`/`LDFLAGS` *and* `GOBUILDTAGS`/`GOLDFLAGS` simultaneously. Then patch the above packages over time until everything has been ported over to using `GOBUILDTAGS` and `GOLDFLAGS`, and then drop the old variables from `go-rpm-macros`. I'm not sure how easy either of these approaches will be. They are both moving targets as new packages are constantly getting added. It might just be a constant effort to try and keep on top of all the patches as new packages come along and patches need to be rebased onto their target's changes. `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/issue/36

3 4

[golist] Issue #28: golist fails when new go-1.17 `//go:build` style is used
by Mikel Olasagasti 07 Jun '22

07 Jun '22

mikelo2 reported a new issue against the project: `golist` that you are following: `` golist fails when golang-1.17 new `//go:build` style is used: ``` $ go2rpm https://github.com/google/log4jscanner //go:build comment without // +build comment Traceback (most recent call last): File "/usr/bin/go2rpm", line 8, in <module> sys.exit(main()) File "/usr/lib/python3.10/site-packages/go2rpm/__main__.py", line 598, in main buildrequires = to_list(get_buildrequires(forge, subdir)) File "/usr/lib/python3.10/site-packages/go2rpm/__main__.py", line 442, in get_buildrequires buildrequires = subprocess.check_output( File "/usr/lib64/python3.10/subprocess.py", line 420, in check_output return run(*popenargs, stdout=PIPE, timeout=timeout, check=True, File "/usr/lib64/python3.10/subprocess.py", line 524, in run raise CalledProcessError(retcode, process.args, subprocess.CalledProcessError: Command '['golist', '--imported', '--skip-self', '--package-path', 'github.com/google/log4jscanner']' returned non-zero exit status 1. ``` From go-1.17 release notes: ` The go command now understands //go:build lines and prefers them over // +build lines. The new syntax uses boolean expressions, just like Go, and should be less error-prone. As of this release, the new syntax is fully supported, and all Go files should be updated to have both forms with the same meaning. To aid in migration, gofmt now automatically synchronizes the two forms. For more details on the syntax and migration plan, see https://golang.org/design/draft-gobuild. ` `` To reply, visit the link below or just reply to this email https://pagure.io/golist/issue/28

1 4

[go-rpm-macros] PR #43: [RFC] rpm/macros.d: use linkmode=external
by Luca Boccassi 12 Mar '22

12 Mar '22

bluca opened a new pull-request against the project: `go-rpm-macros` that you are following: `` [RFC] rpm/macros.d: use linkmode=external `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/43

5 21

[Fedocal] Reminder meeting : Go SIG
by jcajka＠fedoraproject.org 27 Feb '22

27 Feb '22

Dear all, You are kindly invited to the meeting: Go SIG on 2022-02-28 from 20:00:00 to 21:00:00 Europe/Prague At fedora-golang(a)libera.chat The meeting will be about: Fedora's Go SIG meeting More information available at: [https://pagure.io/GoSIG/go-sig/](https://pagure.io/GoSIG/go-sig/) Source: https://calendar.fedoraproject.org//meeting/10012/

1 0

Package reviews
by Fabio Alessandro Locati 20 Feb '22

20 Feb '22

Hi everyone, I've packaged a bunch of packages related to Go and I'm looking for someone who is willing to review them. If needed, I can swap reviews as well. Around protobuf: * https://bugzilla.redhat.com/show_bug.cgi?id=2053935 (googleapis) * https://bugzilla.redhat.com/show_bug.cgi?id=2053988 (golang-google-grpc) Gopass (and deps): * https://bugzilla.redhat.com/show_bug.cgi?id=2053960 (golang-github-gokyle-twofactor) * https://bugzilla.redhat.com/show_bug.cgi?id=2053961 (golang-github-gopasspw-pinentry) * https://bugzilla.redhat.com/show_bug.cgi?id=2053962 (golang-github-jsimonetti-pwscheme) * https://bugzilla.redhat.com/show_bug.cgi?id=2053963 (golang-github-martinhoefling-goxkcdpwgen) * https://bugzilla.redhat.com/show_bug.cgi?id=2053964 (golang-github-skip2-qrcode) * https://bugzilla.redhat.com/show_bug.cgi?id=2053965 (golang-github-mitchellh-ps) * https://bugzilla.redhat.com/show_bug.cgi?id=2053966 (golang-github-caspr-io-yamlpath) * https://bugzilla.redhat.com/show_bug.cgi?id=2053968 (golang-github-schollz-closestmatch) * https://bugzilla.redhat.com/show_bug.cgi?id=2053969 (golang-github-gopasspw-gopass) Thanks a lot, Fale -- Fabio Alessandro Locati fale.io

2 2

[go-rpm-macros] PR #44: Stop using deprecated %__global_ldflags macro.
by Maxwell G 16 Feb '22

16 Feb '22

gotmax23 opened a new pull-request against the project: `go-rpm-macros` that you are following: `` Stop using deprecated %__global_ldflags macro. `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/44

2 4

[Fedocal] Reminder meeting : Go SIG
by jcajka＠fedoraproject.org 13 Feb '22

13 Feb '22

Dear all, You are kindly invited to the meeting: Go SIG on 2022-02-14 from 20:00:00 to 21:00:00 Europe/Prague At fedora-golang(a)libera.chat The meeting will be about: Fedora's Go SIG meeting More information available at: [https://pagure.io/GoSIG/go-sig/](https://pagure.io/GoSIG/go-sig/) Source: https://calendar.fedoraproject.org//meeting/10012/

1 0

Need advice for package review
by Mattia Verga 01 Feb '22

01 Feb '22

I have been asked to review 'apptainer' package request [1], which is a package rename of 'singularity' already present in Fedora repositories [2], but I need some advices from experienced Go packagers, as I know very little of Go... Aside from not using any macro in the spec file, it seems that both the new package and the existing one are bundling the Go toolchain and use that for compiling.... I don't think that's allowed, but I'm asking, since 'singularity' already does that and it's available in repos. Thank you Mattia [1] https://bugzilla.redhat.com/show_bug.cgi?id=2034758 [2] https://src.fedoraproject.org/rpms/singularity

2 1

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

golang February 2022