[Bug 1096293] New: `docker start` doesn't fail on started container

List overview All Threads
Download

newer

older

[Bug 1099732] New: go install...

[Bug 1090071] New: `docker start`...

Red Hat Bugzilla

9 May 2014 9 May '14

10:20 a.m.

https://bugzilla.redhat.com/show_bug.cgi?id=1096293

Bug ID: 1096293 Summary: `docker start` doesn't fail on started container Product: Red Hat Enterprise Linux 7 Version: 7.1 Component: docker Assignee: lsm5@redhat.com Reporter: ldoktor@redhat.com QA Contact: virt-bugs@redhat.com CC: admiller@redhat.com, golang@lists.fedoraproject.org, lsm5@redhat.com, mattdm@redhat.com, mgoldman@redhat.com, s@shk.io, vbatts@redhat.com Depends On: 1090071

+++ This bug was initially created as a clone of Bug #1090071 +++

Description of problem: On older (0.9) docker, the `docker start $running_container` failed. The new 0.10.2 version just prints the container name and proceeds.

Version-Release number of selected component (if applicable): docker-0.10.0-8.el7.x86_64 docker-io-0.10.0-2.fc20.x86_64

How reproducible: Always

Steps to Reproduce: 1. docker run -i -t -name test fedora bash 2. docker start test

Actual results: [root@t530 ~]# docker start test test [root@t530 ~]# echo &? 0

Expected results: [root@t530 ~]# docker start test Error: Cannot start container test: The container 429d709bc86c037b09e9f74dfab40aa33dc19bcf3109daf3f5b2fbbd3c6df297 is already running. 2014/04/22 15:29:28 Error: failed to start one or more containers [root@t530 ~]# echo &? 1

--- Additional comment from Lukas Doktor on 2014-05-05 03:38:57 EDT ---

Upstream Docker version 0.10.0, build dc9c28f/0.10.0 has the same issue (silently passes even thought the container was already running)

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1090071 [Bug 1090071] `docker start` doesn't fail on started container

-- You are receiving this mail because: You are on the CC list for the bug.

Show replies by date

Red Hat Bugzilla

12 May 12 May

2:29 p.m.

New subject: [Bug 1096293] `docker start` doesn't fail on started container

https://bugzilla.redhat.com/show_bug.cgi?id=1096293

Chris Evich cevich@redhat.com changed:

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

19 May 19 May

3:34 p.m.

New subject: [Bug 1096293] `docker start` doesn't fail on started container

https://bugzilla.redhat.com/show_bug.cgi?id=1096293

Daniel Walsh dwalsh@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |dwalsh@redhat.com

--- Comment #3 from Daniel Walsh dwalsh@redhat.com --- I don't think this is a bug but a request for enhancement. I don't see any documentation that says this is what docker should do.

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

4:13 p.m.

New subject: [Bug 1096293] `docker start` doesn't fail on started container

https://bugzilla.redhat.com/show_bug.cgi?id=1096293

--- Comment #4 from Chris Evich cevich@redhat.com ---

IMHO, the destinction would be if it could even be a problem to ignore the second 'start'. I could see this as splitting-hairs as well, but in that case it should probably at least be documented behavior somewhere.

I'm not a concurrency/parallel expert, but I'd guess as long as either double-start or double-stop reports an error it's fine. It's asking for trouble if both ignore the double call. In that case I'd call it a bug b/c: The start or stop needn't come from the same interface (i.e. CLI and REST, arriving at the "same" time). In other words, as long as one way (start or stop) ignores doubles, but the other way makes a stink, there are unlikely to be any races possible in customer use/calls.

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

20 May 20 May

6:27 a.m.

New subject: [Bug 1096293] `docker start` doesn't fail on started container

https://bugzilla.redhat.com/show_bug.cgi?id=1096293

--- Comment #5 from Lukas Doktor ldoktor@redhat.com --- The main issue here is inconsistency. Old docker behaved differently, than the current one. It would be nice to choose one way and stick with it.

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

7:43 a.m.

New subject: [Bug 1096293] `docker start` doesn't fail on started container

https://bugzilla.redhat.com/show_bug.cgi?id=1096293

--- Comment #6 from Daniel Walsh dwalsh@redhat.com --- Lukas. I agree I think this one should be fixed. I think docker start should tell you the container is already started.

But since the app is controlled by upstream, we only have the ability to send patches.

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

9:07 a.m.

New subject: [Bug 1096293] `docker start` doesn't fail on started container

https://bugzilla.redhat.com/show_bug.cgi?id=1096293

--- Comment #7 from Chris Evich cevich@redhat.com --- IMHO, the between-versions behavior inconsistency is nearly always a hard-sell, especially for something sooooo new. While having it change like this is frustrating for testing/development, it's somewhat to be expected. We'll have a much easier argument to make for this change if it can be pinned to a nastier problem to expect end-users to workaround. If we can't, then probably best close this and fixup our tests with version-dependant behavior.

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

13 Jun 13 Jun

9:30 a.m.

New subject: [Bug 1096293] `docker start` doesn't fail on started container

https://bugzilla.redhat.com/show_bug.cgi?id=1096293

Lokesh Mandvekar lsm5@redhat.com changed:

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

17 Jun 17 Jun

9:39 a.m.

New subject: [Bug 1096293] `docker start` doesn't fail on started container

https://bugzilla.redhat.com/show_bug.cgi?id=1096293

--- Comment #10 from Chris Evich cevich@redhat.com --- Confirmed fixed in docker-0.11.1-19.el7.x86_64 (or slightly earlier). Multiple starts, just keep printing the container's name for an already running container.

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

1:05 p.m.

New subject: [Bug 1096293] `docker start` doesn't fail on started container

https://bugzilla.redhat.com/show_bug.cgi?id=1096293

Matthew Heon mheon@redhat.com changed:

--- Comment #11 from Matthew Heon mheon@redhat.com --- Given that this change was intentionally made by upstream, we're not going to fix it. There is now documentation in the manpages and Docker web documentation which establishes that this is intended behaviour (included in docker-0.11.1-19.el7). This should clarify that this is not a bug and remove confusion.

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

1:57 p.m.

New subject: [Bug 1096293] `docker start` doesn't fail on started container

https://bugzilla.redhat.com/show_bug.cgi?id=1096293

--- Comment #12 from Chris Evich cevich@redhat.com --- Yep, no need to fix it now and updated documentation is great as well. Docker autotest has also been updated to reflect this behavior, so we're all good now. Thanks!

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

14 Jul 14 Jul

10:44 a.m.

New subject: [Bug 1096293] `docker start` doesn't fail on started container

https://bugzilla.redhat.com/show_bug.cgi?id=1096293

Chris Evich cevich@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |VERIFIED

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

11 Nov 11 Nov

4:09 a.m.

New subject: [Bug 1096293] `docker start` doesn't fail on started container

https://bugzilla.redhat.com/show_bug.cgi?id=1096293

Red Hat Bugzilla Rules Engine rule-engine@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Extras

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

4 Jan 4 Jan

3:53 p.m.

New subject: [Bug 1096293] `docker start` doesn't fail on started container

https://bugzilla.redhat.com/show_bug.cgi?id=1096293

John Skeoch jskeoch@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Assignee|mheon@redhat.com |jrieden@redhat.com

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

26 Mar 26 Mar

6:35 a.m.

New subject: [Bug 1096293] `docker start` doesn't fail on started container

https://bugzilla.redhat.com/show_bug.cgi?id=1096293

Libor Miksik lmiksik@redhat.com changed:

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

29 Jun 29 Jun

8:39 p.m.

New subject: [Bug 1096293] `docker start` doesn't fail on started container

https://bugzilla.redhat.com/show_bug.cgi?id=1096293 Bug 1096293 depends on bug 1090071, which changed state.

Bug 1090071 Summary: `docker start` doesn't fail on started container https://bugzilla.redhat.com/show_bug.cgi?id=1090071

-- You are receiving this mail because: You are on the CC list for the bug.

3230

Age (days ago)

3647

Last active (days ago)

golang@lists.fedoraproject.org

15 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla