https://bugzilla.redhat.com/show_bug.cgi?id=1326890
Bug ID: 1326890 Summary: FTBFS with gcc-go on s390x Product: Fedora Version: 24 Component: golang-googlecode-net Assignee: fpokorny@redhat.com Reporter: dan@danny.cz QA Contact: extras-qa@fedoraproject.org CC: fpokorny@redhat.com, golang@lists.fedoraproject.org, jchaloup@redhat.com, mattdm@redhat.com, vbatts@redhat.com Blocks: 467765 (ZedoraTracker)
Created attachment 1146911 --> https://bugzilla.redhat.com/attachment.cgi?id=1146911&action=edit build.log
Build of golang-googlecode-net fails on s390x that uses gcc-go with tons of errors
... + go test -compiler gccgo -gccgoflags '-O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -march=z9-109 -mtune=z10 ' golang.org/x/net/ipv4 # golang.org/x/net/ipv4 ../../BUILDROOT/golang-googlecode-net-0-0.31.git6acef71.fc24.s390x/usr/share/gocode/src/golang.org/x/net/ipv4/icmp.go:34:2: error: use of undefined type 'sysICMPFilter' sysICMPFilter ^ ../../BUILDROOT/golang-googlecode-net-0-0.31.git6acef71.fc24.s390x/usr/share/gocode/src/golang.org/x/net/ipv4/control_pktinfo.go:19:11: error: reference to undefined name 'sysIP_PKTINFO' m.Type = sysIP_PKTINFO ^ ../../BUILDROOT/golang-googlecode-net-0-0.31.git6acef71.fc24.s390x/usr/share/gocode/src/golang.org/x/net/ipv4/control_pktinfo.go:20:27: error: reference to undefined name 'sysSizeofInetPktinfo' ...
see http://s390.koji.fedoraproject.org/koji/taskinfo?taskID=2183406 for full logs, or attachment for build.log
Version-Release number of selected component (if applicable): golang-googlecode-net-0-0.31.git6acef71.fc24
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=467765 [Bug 467765] Fedora for System z (s390): Bug Tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1326890
--- Comment #1 from Jan Chaloupka jchaloup@redhat.com --- ipv4]$ grep -rn "type sysICMPFilter" zsys_linux_amd64.go:130:type sysICMPFilter struct { icmp_stub.go:11:type sysICMPFilter struct { zsys_linux_arm64.go:132:type sysICMPFilter struct { defs_linux.go:111:type sysICMPFilter C.struct_icmp_filter zsys_linux_mips64le.go:132:type sysICMPFilter struct { zsys_linux_mips64.go:132:type sysICMPFilter struct { zsys_linux_386.go:128:type sysICMPFilter struct { zsys_linux_ppc64le.go:132:type sysICMPFilter struct { zsys_linux_ppc64.go:132:type sysICMPFilter struct { zsys_linux_arm.go:128:type sysICMPFilter struct {
Can't see s390x among supported architectures for this package.
Checking the upstream [1] the support is still missing.
[1] https://github.com/golang/net/tree/master/ipv4
https://bugzilla.redhat.com/show_bug.cgi?id=1326890
--- Comment #2 from Dan Horák dan@danny.cz --- The files are generated with "cgo" if I see correctly, how difficult would be to add the s390x variant? Do we have the tool needed (we even have golang now on s390x)? How about upstream acceptance?
https://bugzilla.redhat.com/show_bug.cgi?id=1326890
--- Comment #3 from Dan Horák dan@danny.cz --- Created attachment 1147705 --> https://bugzilla.redhat.com/attachment.cgi?id=1147705&action=edit add s390x support
something like that should add the missing s390x support, but it fails to build for me, it exceeds my Go foo :-)
https://bugzilla.redhat.com/show_bug.cgi?id=1326890
Jan Chaloupka jchaloup@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
--- Comment #4 from Jan Chaloupka jchaloup@redhat.com --- Thanks for the patch. I will take a look at it.
https://bugzilla.redhat.com/show_bug.cgi?id=1326890
--- Comment #5 from Dan Horák dan@danny.cz --- scratch build with applied http://s390.koji.fedoraproject.org/koji/taskinfo?taskID=2187433
https://bugzilla.redhat.com/show_bug.cgi?id=1326890
--- Comment #6 from Dan Horák dan@danny.cz --- Seems recent upstream already contains s390x support, please make an update in Fedora too.
https://bugzilla.redhat.com/show_bug.cgi?id=1326890
--- Comment #7 from Jan Chaloupka jchaloup@redhat.com --- Still the same issue [1]: "/tmp/go-build546930784/golang.org/x/net/libipv4.a(_go_.o): In function `golang_org_x_net_ipv4.set.pN28_golang_org_x_net_ipv4.rawOpt': /builddir/build/BUILDROOT/golang-googlecode-net-0-0.32.gitbc3663d.fc25.s390x/usr/share/gocode/src/golang.org/x/net/ipv4/control.go:18: multiple definition of `golang_org_x_net_ipv4.set.pN28_golang_org_x_net_ipv4.rawOpt'"
[1] http://s390.koji.fedoraproject.org/koji/taskinfo?taskID=2266793
https://bugzilla.redhat.com/show_bug.cgi?id=1326890
Dan Horák dan@danny.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1349371
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1349371 [Bug 1349371] gcc-go fails to link golang-googlecode-net
golang@lists.fedoraproject.org
-
Red Hat Bugzilla