blowry opened a new pull-request against the project: `go-rpm-macros` that you are following: `` Remove tildes from goname ``
To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/26
ngompa commented on the pull-request: `Remove tildes from goname` that you are following: `` This probably needs to be substituted with another character... ``
To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/26
blowry commented on the pull-request: `Remove tildes from goname` that you are following: `` What character should it be changed to? My use-case for this is sourcehut urls like https://git.sr.ht/~sircmpwn/getopt, so goname will be set to something like "golang-sr-sircmpwn-getopt" instead of "golang-sr-~sircmpwn-getopt". ``
To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/26
ngompa commented on the pull-request: `Remove tildes from goname` that you are following: `` Also, are tildes really invalid in package names? I didn't think they were... ``
To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/26
qulogic commented on the pull-request: `Remove tildes from goname` that you are following: `` Do they trigger the special versioning (even though they're not in the version)? ``
To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/26
ngompa commented on the pull-request: `Remove tildes from goname` that you are following: `` They should not. If it's in the name field, it's like any other character, as far as I know. @pmatilai, @ffesti, or @ignatenkobrain would know for sure, though. ``
To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/26
pmatilai commented on the pull-request: `Remove tildes from goname` that you are following: `` It would've taken anybody like 5s to test whether tilde is allowed in the name or not, certainly much less than speculating about its possible effect on version comparison and whatnot. Tilde, like many other special characters, is not allowed in package name. ``
To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/26
nim commented on the pull-request: `Remove tildes from goname` that you are following: `` ~ should be replaced with "-" then. "-" is safe as intra-name separator. ``
To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/26
blowry commented on the pull-request: `Remove tildes from goname` that you are following: `` That sounds good but then the modules hosted on sourcehut I'm trying to package would have two dashes in a row (golang-sr--sircmpwn-getopt). Is that allowed/a desirable outcome? ``
To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/26
qulogic commented on the pull-request: `Remove tildes from goname` that you are following: `` The split on line 60 should coalesce repeated separators. ``
To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/26
blowry commented on the pull-request: `Remove tildes from goname` that you are following: `` Should be good now ``
To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/26
nim commented on the pull-request: `Remove tildes from goname` that you are following: `` That will work but it’s better to add tilde to the generic forbidden separator cleanup rule:
-- replace various separators rpm does not like with -
``
To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/26
blowry commented on the pull-request: `Remove tildes from goname` that you are following: `` Done ``
To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/26
eclipseo merged a pull-request against the project: `go-rpm-macros` that you are following.
Merged pull-request:
`` Remove tildes from goname ``
golang@lists.fedoraproject.org
-
Benjamin Lowry -
Elliott Sales de Andrade
-
Neal Gompa
-
Nicolas Mailhot
-
Panu Matilainen
-
Robert-André Mauchin