golang February 2014

golang@lists.fedoraproject.org

6 participants
117 discussions

[Bug 1060502] Review Request: golang-github-mitchellh-cli - A library for implementing powerful command-line interfaces in Go
by Red Hat Bugzilla 27 Feb '14

27 Feb '14

https://bugzilla.redhat.com/show_bug.cgi?id=1060502 Lokesh Mandvekar <lsm5(a)redhat.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lsm5(a)redhat.com --- Comment #2 from Lokesh Mandvekar <lsm5(a)redhat.com> --- Hi Jeff, I'm not sure if the noarch for rhel >= 7 would work right now. Last time I checked, stuff was failing for some arch for rhel7 (I think ppc64). So I had noarch only for fedora >= 19. Did 'go test' work for you without specifying GOPATH? IIRC, it failed for me sometime back, and I used this: GOPATH=%{buildroot}/%{gopath} go test %{import_path}/capability (line 45 http://pkgs.fedoraproject.org/cgit/golang-github-syndtr-gocapability.git/tr…) some minor things to consider (no biggie), for upstreams using git I've used 'shortcommit' (http://pkgs.fedoraproject.org/cgit/golang-github-gorilla-context.git/tree/g…) and for those using hg I've used 'shortrev' (http://pkgs.fedoraproject.org/cgit/golang-bitbucket-kardianos-osext.git/tre…). The shortrev and abbrevrev could perhaps be replaced with a single shortcommit here and it could be used in the release tag too. (Again, this is just the current state of existing golang-* packages and _not_ a guideline.). HTH -- You are receiving this mail because: You are on the CC list for the bug.

1 0

[Bug 1060502] Review Request: golang-github-mitchellh-cli - A library for implementing powerful command-line interfaces in Go
by Red Hat Bugzilla 27 Feb '14

27 Feb '14

https://bugzilla.redhat.com/show_bug.cgi?id=1060502 Dan Mashal <dan.mashal(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dan.mashal(a)gmail.com --- Comment #1 from Dan Mashal <dan.mashal(a)gmail.com> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 16 files have unknown license. Detailed output of licensecheck in /home/dan/fedora-review/1060502-golang-github-mitchellh- cli/licensecheck.txt [ ]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/gocode/src(golang- github-gorilla-mux-devel, golang-googlecode-net-devel, golang-googlecode- goprotobuf-devel, golang-github-coreos-go-systemd-devel, golang- googlecode-sqlite-devel, golang-bitbucket-kardianos-osext-devel, golang- github-gorilla-context-devel, golang-github-coreos-go-log-devel, golang- github-kr-pty-devel, golang-github-goraft-raft-devel), /usr/share/gocode (golang-github-gorilla-mux-devel, golang-googlecode-net-devel, golang- googlecode-goprotobuf-devel, golang-github-coreos-go-systemd-devel, golang-googlecode-sqlite-devel, golang-bitbucket-kardianos-osext-devel, golang-github-gorilla-context-devel, golang-github-coreos-go-log-devel, golang-github-kr-pty-devel, golang-github-goraft-raft-devel), /usr/share/gocode/src/github.com(golang-github-gorilla-mux-devel, golang- github-syndtr-gocapability-devel, golang-github-coreos-go-systemd-devel, golang-github-gorilla-context-devel, golang-github-coreos-go-log-devel, golang-github-kr-pty-devel, golang-github-goraft-raft-devel) [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: golang-github-mitchellh-cli-devel-0-0.1.git69f0b65ce53b.fc20.noarch.rpm golang-github-mitchellh-cli-0-0.1.git69f0b65ce53b.fc20.src.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint golang-github-mitchellh-cli-devel 1 packages and 0 specfiles checked; 0 errors, 0 warnings. # echo 'rpmlint-done:' Requires -------- golang-github-mitchellh-cli-devel (rpmlib, GLIBC filtered): golang Provides -------- golang-github-mitchellh-cli-devel: golang(github.com/mitchellh/cli) golang-github-mitchellh-cli-devel Source checksums ---------------- https://github.com/mitchellh/cli/tarball/master/mitchellh-cli-69f0b65.tar.gz : CHECKSUM(SHA256) this package : 469e50e09a5dbf7554ca90376be928c10a2e41c871c61ed5cf0fe31d6d14576b CHECKSUM(SHA256) upstream package : 469e50e09a5dbf7554ca90376be928c10a2e41c871c61ed5cf0fe31d6d14576b Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -b 1060502 Buildroot used: fedora-20-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG -- You are receiving this mail because: You are on the CC list for the bug.

1 0

[Bug 1060500] Review Request: golang-github-miekg-dns - Alternative (more granular) approach to a DNS library
by Red Hat Bugzilla 27 Feb '14

27 Feb '14

https://bugzilla.redhat.com/show_bug.cgi?id=1060500 Dan Mashal <dan.mashal(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dan.mashal(a)gmail.com --- Comment #1 from Dan Mashal <dan.mashal(a)gmail.com> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /home/dan/fedora- review/1060500-golang-github-miekg-dns/diff.txt See: http://fedoraproject.org/wiki/Packaging/SourceURL ===== MUST items ===== Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 33 files have unknown license. Detailed output of licensecheck in /home/dan/fedora-review/1060500-golang-github-miekg- dns/licensecheck.txt [ ]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/gocode/src(golang- github-gorilla-mux-devel, golang-googlecode-net-devel, golang-googlecode- goprotobuf-devel, golang-github-coreos-go-systemd-devel, golang- googlecode-sqlite-devel, golang-bitbucket-kardianos-osext-devel, golang- github-gorilla-context-devel, golang-github-coreos-go-log-devel, golang- github-kr-pty-devel, golang-github-goraft-raft-devel), /usr/share/gocode (golang-github-gorilla-mux-devel, golang-googlecode-net-devel, golang- googlecode-goprotobuf-devel, golang-github-coreos-go-systemd-devel, golang-googlecode-sqlite-devel, golang-bitbucket-kardianos-osext-devel, golang-github-gorilla-context-devel, golang-github-coreos-go-log-devel, golang-github-kr-pty-devel, golang-github-goraft-raft-devel), /usr/share/gocode/src/github.com(golang-github-gorilla-mux-devel, golang- github-syndtr-gocapability-devel, golang-github-coreos-go-systemd-devel, golang-github-gorilla-context-devel, golang-github-coreos-go-log-devel, golang-github-kr-pty-devel, golang-github-goraft-raft-devel) [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: golang-github-miekg-dns-devel-0-0.1.gitdd3549666972.fc20.noarch.rpm golang-github-miekg-dns-0-0.1.gitdd3549666972.fc20.src.rpm golang-github-miekg-dns.src: W: file-size-mismatch miekg-dns-dd35496.tar.gz = 86959, https://github.com/miekg/dns/tarball/master/miekg-dns-dd35496.tar.gz = 89671 2 packages and 0 specfiles checked; 0 errors, 1 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint golang-github-miekg-dns-devel 1 packages and 0 specfiles checked; 0 errors, 0 warnings. # echo 'rpmlint-done:' Requires -------- golang-github-miekg-dns-devel (rpmlib, GLIBC filtered): golang Provides -------- golang-github-miekg-dns-devel: golang(github.com/miekg/dns) golang-github-miekg-dns-devel Source checksums ---------------- https://github.com/miekg/dns/tarball/master/miekg-dns-dd35496.tar.gz : CHECKSUM(SHA256) this package : 65b0514fe8ab288c3cb3bfa0bf6d59ef64dd3eb255945d78371d4e974eb8d50d CHECKSUM(SHA256) upstream package : 8d3e53d83d299f3090eab2bfd321c4c9c9deb2f992f02635ebceecf804d70325 diff -r also reports differences Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -b 1060500 Buildroot used: fedora-20-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG -- You are receiving this mail because: You are on the CC list for the bug.

1 0

[Bug 1060454] Review Request: golang-github-armon-go-metrics - Collect run time and performance metrics in golang software
by Red Hat Bugzilla 27 Feb '14

27 Feb '14

https://bugzilla.redhat.com/show_bug.cgi?id=1060454 Dan Mashal <dan.mashal(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dan.mashal(a)gmail.com --- Comment #1 from Dan Mashal <dan.mashal(a)gmail.com> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /home/dan/fedora- review/1060454-golang-github-armon-go-metrics/diff.txt See: http://fedoraproject.org/wiki/Packaging/SourceURL ===== MUST items ===== Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 14 files have unknown license. Detailed output of licensecheck in /home/dan/fedora-review/1060454-golang-github-armon-go- metrics/licensecheck.txt [ ]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/gocode/src(golang- github-gorilla-mux-devel, golang-googlecode-net-devel, golang-googlecode- goprotobuf-devel, golang-github-coreos-go-systemd-devel, golang- googlecode-sqlite-devel, golang-bitbucket-kardianos-osext-devel, golang- github-gorilla-context-devel, golang-github-coreos-go-log-devel, golang- github-kr-pty-devel, golang-github-goraft-raft-devel), /usr/share/gocode (golang-github-gorilla-mux-devel, golang-googlecode-net-devel, golang- googlecode-goprotobuf-devel, golang-github-coreos-go-systemd-devel, golang-googlecode-sqlite-devel, golang-bitbucket-kardianos-osext-devel, golang-github-gorilla-context-devel, golang-github-coreos-go-log-devel, golang-github-kr-pty-devel, golang-github-goraft-raft-devel), /usr/share/gocode/src/github.com(golang-github-gorilla-mux-devel, golang- github-syndtr-gocapability-devel, golang-github-coreos-go-systemd-devel, golang-github-gorilla-context-devel, golang-github-coreos-go-log-devel, golang-github-kr-pty-devel, golang-github-goraft-raft-devel) [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: golang-github-armon-go-metrics-devel-0-0.1.git8ceaed1d0bc3.fc20.noarch.rpm golang-github-armon-go-metrics-0-0.1.git8ceaed1d0bc3.fc20.src.rpm golang-github-armon-go-metrics.src: W: spelling-error %description -l en_US statsite -> stat site, stat-site, stateside golang-github-armon-go-metrics.src: W: spelling-error %description -l en_US statsd -> stats, stated, stats d golang-github-armon-go-metrics.src: W: file-size-mismatch armon-go-metrics-8ceaed1.tar.gz = 9512, https://github.com/armon/go-metrics/tarball/master/armon-go-metrics-8ceaed1… = 9740 2 packages and 0 specfiles checked; 0 errors, 3 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint golang-github-armon-go-metrics-devel 1 packages and 0 specfiles checked; 0 errors, 0 warnings. # echo 'rpmlint-done:' Requires -------- golang-github-armon-go-metrics-devel (rpmlib, GLIBC filtered): golang Provides -------- golang-github-armon-go-metrics-devel: golang(github.com/armon/go-metrics) golang-github-armon-go-metrics-devel Source checksums ---------------- https://github.com/armon/go-metrics/tarball/master/armon-go-metrics-8ceaed1… : CHECKSUM(SHA256) this package : 004ccc948eb01c9a66a22297c3b1d5fde22783eb77d1738a62250d8d4e6fadae CHECKSUM(SHA256) upstream package : f7937b3f9c4967f205c1fea7e15c7cfd13ed3afe75a642b6aa88509750326071 diff -r also reports differences Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -b 1060454 Buildroot used: fedora-20-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG -- You are receiving this mail because: You are on the CC list for the bug.

1 0

[Bug 1067110] /usr/include/features.h:145:3: error: #warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE" [-Werror=cpp
by Red Hat Bugzilla 25 Feb '14

25 Feb '14

https://bugzilla.redhat.com/show_bug.cgi?id=1067110 Carlos O'Donell <codonell(a)redhat.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(codonell(a)redhat.c | |om) | --- Comment #10 from Carlos O'Donell <codonell(a)redhat.com> --- (In reply to Petr Spacek from comment #9) > (In reply to Frank Ch. Eigler from comment #8) > > Carlos, what is the official rune to make -Werror code build with both old > > and new glibc, which had some reason for _BSD_SOURCE? > > > > NOTABUG seems like an unfortunate way of brushing off build breakage due > > to this glibc change. > > I'm facing the same problem with my package. Carlos, please shed light on > this. The way this is going to work is like this: https://sourceware.org/glibc/wiki/Release/2.20#Packaging_Changes This isn't the way it works yet in Fedora Rawhide, but it will in about 24 hours. See: https://sourceware.org/bugzilla/show_bug.cgi?id=16632 -- You are receiving this mail because: You are on the CC list for the bug.

1 0

[Bug 1067110] /usr/include/features.h:145:3: error: #warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE" [-Werror=cpp
by Red Hat Bugzilla 25 Feb '14

25 Feb '14

https://bugzilla.redhat.com/show_bug.cgi?id=1067110 Petr Spacek <pspacek(a)redhat.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pspacek(a)redhat.com Flags| |needinfo?(codonell(a)redhat.c | |om) --- Comment #9 from Petr Spacek <pspacek(a)redhat.com> --- (In reply to Frank Ch. Eigler from comment #8) > Carlos, what is the official rune to make -Werror code build with both old > and new glibc, which had some reason for _BSD_SOURCE? > > NOTABUG seems like an unfortunate way of brushing off build breakage due > to this glibc change. I'm facing the same problem with my package. Carlos, please shed light on this. -- You are receiving this mail because: You are on the CC list for the bug.

1 0

[Bug 1067110] /usr/include/features.h:145:3: error: #warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE" [-Werror=cpp
by Red Hat Bugzilla 24 Feb '14

24 Feb '14

https://bugzilla.redhat.com/show_bug.cgi?id=1067110 Frank Ch. Eigler <fche(a)redhat.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fche(a)redhat.com --- Comment #8 from Frank Ch. Eigler <fche(a)redhat.com> --- Carlos, what is the official rune to make -Werror code build with both old and new glibc, which had some reason for _BSD_SOURCE? NOTABUG seems like an unfortunate way of brushing off build breakage due to this glibc change. -- You are receiving this mail because: You are on the CC list for the bug.

1 0

[Bug 1059743] New: bad filenames in rpm scriptlets expanded
by Red Hat Bugzilla 23 Feb '14

23 Feb '14

https://bugzilla.redhat.com/show_bug.cgi?id=1059743 Bug ID: 1059743 Summary: bad filenames in rpm scriptlets expanded Product: Fedora Version: 20 Component: docker-io Assignee: lsm5(a)redhat.com Reporter: jorton(a)redhat.com QA Contact: extras-qa(a)fedoraproject.org CC: golang(a)lists.fedoraproject.org, lsm5(a)redhat.com, mattdm(a)redhat.com, mgoldman(a)redhat.com, skottler(a)redhat.com, vbatts(a)redhat.com Description of problem: # rpm -q --scripts docker-io | grep systemctl /usr/bin/systemctl preset /builddir/build/SOURCES/docker.service >/dev/null 2>&1 || : /usr/bin/systemctl --no-reload disable /builddir/build/SOURCES/docker.service > /dev/null 2>&1 || : /usr/bin/systemctl stop /builddir/build/SOURCES/docker.service > /dev/null 2>&1 || : /usr/bin/systemctl daemon-reload >/dev/null 2>&1 || : /usr/bin/systemctl try-restart /builddir/build/SOURCES/docker.service >/dev/null 2>&1 || : Version-Release number of selected component (if applicable): docker-io-0.7.6-4.fc20.x86_64 -- You are receiving this mail because: You are on the CC list for the bug.

1 10

[Bug 1062177] New: docker-io-0.8.0 is available
by Red Hat Bugzilla 23 Feb '14

23 Feb '14

https://bugzilla.redhat.com/show_bug.cgi?id=1062177 Bug ID: 1062177 Summary: docker-io-0.8.0 is available Product: Fedora Version: rawhide Component: docker-io Keywords: FutureFeature, Triaged Assignee: lsm5(a)redhat.com Reporter: upstream-release-monitoring(a)fedoraproject.org QA Contact: extras-qa(a)fedoraproject.org CC: golang(a)lists.fedoraproject.org, lsm5(a)redhat.com, mattdm(a)redhat.com, mgoldman(a)redhat.com, skottler(a)redhat.com, vbatts(a)redhat.com Latest upstream release: 0.8.0 Current version/release in Fedora Rawhide: 0.7.6-4.fc21 URL: https://github.com/dotcloud/docker/releases Please consult the package updates policy before you issue an update to a stable branch: https://fedoraproject.org/wiki/Updates_Policy More information about the service that created this bug can be found at: https://fedoraproject.org/wiki/Upstream_release_monitoring -- You are receiving this mail because: You are on the CC list for the bug.

1 13

[docker-io/epel7] import lsm5's latest docker-io SRPM
by Lokesh Mandvekar 22 Feb '14

22 Feb '14

commit 4e758633cc8d979ccb5120aa07c823391c9ea840 Author: Adam Miller <admiller(a)redhat.com> Date: Thu Feb 20 15:53:41 2014 -0600 import lsm5's latest docker-io SRPM docker-io.spec | 29 ++++++---- docker.sysconfig | 1 - docker.sysvinit | 123 --------------------------------------------- remove-vendored-tar.patch | 109 +++++++++++++++++++++++++++++++++++++++ sources | 2 +- 5 files changed, 127 insertions(+), 137 deletions(-) --- diff --git a/docker-io.spec b/docker-io.spec index 7976363..8b7fbb9 100644 --- a/docker-io.spec +++ b/docker-io.spec @@ -9,30 +9,29 @@ %global debug_package %{nil} %global gopath %{_datadir}/gocode -%global commit cc3a8c8d8ec57e15b7b7316797132d770408ab1a +%global commit a1598d1e1c157388f3b07415729de28f4d205e49 %global shortcommit %(c=%{commit}; echo ${c:0:7}) Name: docker-io -Version: 0.8.0 -Release: 3%{?dist} +Version: 0.8.1 +Release: 1%{?dist} Summary: Automates deployment of containerized applications License: ASL 2.0 Patch0: ignore-btrfs-for-rhel.patch +Patch1: remove-vendored-tar.patch URL: http://www.docker.io # only x86_64 for now: https://github.com/dotcloud/docker/issues/136 ExclusiveArch: x86_64 Source0: https://github.com/dotcloud/docker/archive/v%{version}.tar.gz # though final name for sysconf/sysvinit files is simply 'docker', # having .sysvinit and .sysconfig makes things clear -Source1: docker.sysconfig -Source2: docker.sysvinit -Source3: docker.1 +Source1: docker.1 BuildRequires: gcc BuildRequires: glibc-static -# ensure build uses golang 1.2 and above -# https://github.com/dotcloud/docker/issues/3191 -BuildRequires: golang >= 1.2 +# ensure build uses golang 1.2-7 and above +# http://code.google.com/p/go/source/detail?r=a15f344a9efa35ef168c8feaa92a15a… +BuildRequires: golang >= 1.2-7 BuildRequires: golang(github.com/gorilla/mux) BuildRequires: golang(github.com/kr/pty) BuildRequires: golang(code.google.com/p/go.net/websocket) @@ -82,6 +81,7 @@ rm -rf vendor %if 0%{?rhel} %patch0 -p1 -b ignore-btrfs-for-rhel %endif +%patch1 -p1 -b remove-vendored-tar %build mkdir _build @@ -107,7 +107,7 @@ install -d %{buildroot}%{_libexecdir}/docker install -p -m 755 bundles/%{version}/dynbinary/dockerinit-%{version} %{buildroot}%{_libexecdir}/docker/dockerinit # install manpage install -d %{buildroot}%{_mandir}/man1 -install -p -m 644 %{SOURCE3} %{buildroot}%{_mandir}/man1 +install -p -m 644 %{SOURCE1} %{buildroot}%{_mandir}/man1 # install bash completion install -d %{buildroot}%{_sysconfdir}/bash_completion.d install -p -m 644 contrib/completion/bash/docker %{buildroot}%{_sysconfdir}/bash_completion.d/docker.bash @@ -130,9 +130,9 @@ install -d %{buildroot}%{_unitdir} install -p -m 644 contrib/init/systemd/docker.service %{buildroot}%{_unitdir} %else install -d %{buildroot}%{_sysconfdir}/sysconfig/ -install -p -m 644 %{SOURCE1} %{buildroot}%{_sysconfdir}/sysconfig/docker +install -p -m 644 contrib/init/sysvinit-redhat/docker.sysconfig %{buildroot}%{_sysconfdir}/sysconfig/docker install -d %{buildroot}%{_initddir} -install -p -m 755 %{SOURCE2} %{buildroot}%{_initddir}/docker +install -p -m 755 contrib/init/sysvinit-redhat/docker %{buildroot}%{_initddir}/docker %endif %pre @@ -192,6 +192,11 @@ fi %{_datadir}/vim/vimfiles/syntax/dockerfile.vim %changelog +* Wed Feb 19 2014 Lokesh Mandvekar <lsm5(a)redhat.com> - 0.8.1-1 +- Bug 1066841 - upstream version bump to v0.8.1 +- use sysvinit files from upstream contrib +- BR golang >= 1.2-7 + * Thu Feb 13 2014 Adam Miller <maxamillion(a)fedoraproject.org> - 0.8.0-3 - Remove unneeded sysctl settings in initscript https://github.com/dotcloud/docker/pull/4125 diff --git a/remove-vendored-tar.patch b/remove-vendored-tar.patch new file mode 100644 index 0000000..d180bc2 --- /dev/null +++ b/remove-vendored-tar.patch @@ -0,0 +1,109 @@ +From 093f9f11373c3414abb30b74b1271a80822f2d90 Mon Sep 17 00:00:00 2001 +From: Lokesh Mandvekar <lsm5(a)redhat.com> +Date: Wed, 19 Feb 2014 20:49:50 -0500 +Subject: [PATCH] remove vendored tar + +--- + archive/archive.go | 2 +- + archive/changes.go | 2 +- + archive/diff.go | 2 +- + archive/wrap.go | 2 +- + integration/api_test.go | 2 +- + integration/utils_test.go | 2 +- + utils/tarsum.go | 2 +- + 7 files changed, 7 insertions(+), 7 deletions(-) + +diff --git a/archive/archive.go b/archive/archive.go +index 16c0199..817d37e 100644 +--- a/archive/archive.go ++++ b/archive/archive.go +@@ -2,7 +2,7 @@ package archive + + import ( + "bytes" +- "code.google.com/p/go/src/pkg/archive/tar" ++ "archive/tar" + "compress/bzip2" + "compress/gzip" + "errors" +diff --git a/archive/changes.go b/archive/changes.go +index b46b13b..25406f5 100644 +--- a/archive/changes.go ++++ b/archive/changes.go +@@ -1,7 +1,7 @@ + package archive + + import ( +- "code.google.com/p/go/src/pkg/archive/tar" ++ "archive/tar" + "fmt" + "github.com/dotcloud/docker/utils" + "io" +diff --git a/archive/diff.go b/archive/diff.go +index 6a77839..7bf01f3 100644 +--- a/archive/diff.go ++++ b/archive/diff.go +@@ -1,7 +1,7 @@ + package archive + + import ( +- "code.google.com/p/go/src/pkg/archive/tar" ++ "archive/tar" + "fmt" + "io" + "io/ioutil" +diff --git a/archive/wrap.go b/archive/wrap.go +index 981420b..0abe320 100644 +--- a/archive/wrap.go ++++ b/archive/wrap.go +@@ -2,7 +2,7 @@ package archive + + import ( + "bytes" +- "code.google.com/p/go/src/pkg/archive/tar" ++ "archive/tar" + "io/ioutil" + ) + +diff --git a/integration/api_test.go b/integration/api_test.go +index 5779e6b..e8ef626 100644 +--- a/integration/api_test.go ++++ b/integration/api_test.go +@@ -3,7 +3,7 @@ package docker + import ( + "bufio" + "bytes" +- "code.google.com/p/go/src/pkg/archive/tar" ++ "archive/tar" + "encoding/json" + "fmt" + "github.com/dotcloud/docker" +diff --git a/integration/utils_test.go b/integration/utils_test.go +index 947ace1..59297fa 100644 +--- a/integration/utils_test.go ++++ b/integration/utils_test.go +@@ -2,7 +2,7 @@ package docker + + import ( + "bytes" +- "code.google.com/p/go/src/pkg/archive/tar" ++ "archive/tar" + "fmt" + "io" + "io/ioutil" +diff --git a/utils/tarsum.go b/utils/tarsum.go +index ddeecfb..be8b4db 100644 +--- a/utils/tarsum.go ++++ b/utils/tarsum.go +@@ -2,7 +2,7 @@ package utils + + import ( + "bytes" +- "code.google.com/p/go/src/pkg/archive/tar" ++ "archive/tar" + "compress/gzip" + "crypto/sha256" + "encoding/hex" +-- +1.9.0 + diff --git a/sources b/sources index 4c76ff3..b77c489 100644 --- a/sources +++ b/sources @@ -1 +1 @@ -737aec190c2ad81b00192f858f9ed31b v0.8.0.tar.gz +3e74f5af4a74f3448a1db5763e455eb9 v0.8.1.tar.gz

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

golang February 2014