jexl is now failing in rawhide with an odd failure:
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:2.10.3:aggregate (default-cli) on project commons-jexl: An error has occurred in JavaDocs report generation: [ERROR] Exit code: 1 - /builddir/build/BUILD/commons-jexl-2.1.1-src/src/main/java/org/apache/commons/jexl2/ExpressionImpl.java:35: error: bad HTML entity [ERROR] * Original expression stripped from leading & trailing spaces. [ERROR] ^ [ERROR] /builddir/build/BUILD/commons-jexl-2.1.1-src/src/main/java/org/apache/commons/jexl2/Interpreter.java:888: warning: no @param for node [ERROR] public Object visit(ASTFloatLiteral node, Object data) { [ERROR] ^ [ERROR] /builddir/build/BUILD/commons-jexl-2.1.1-src/src/main/java/org/apache/commons/jexl2/Interpreter.java:888: warning: no @param for data
Something odd change in java land?
http://koji.fedoraproject.org/koji/taskinfo?taskID=9488894
jexl is now failing in rawhide with an odd failure:
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:2.10.3:aggregate (default-cli) on project commons-jexl: An error has occurred in JavaDocs report generation: [ERROR] Exit code: 1 - /builddir/build/BUILD/commons-jexl-2.1.1-src/src/main/java/org/apache/commons/jexl2/ExpressionImpl.java:35: error: bad HTML entity [ERROR] * Original expression stripped from leading & trailing spaces. [ERROR] ^ [ERROR] /builddir/build/BUILD/commons-jexl-2.1.1-src/src/main/java/org/apache/commons/jexl2/Interpreter.java:888: warning: no @param for node [ERROR] public Object visit(ASTFloatLiteral node, Object data) { [ERROR] ^ [ERROR] /builddir/build/BUILD/commons-jexl-2.1.1-src/src/main/java/org/apache/commons/jexl2/Interpreter.java:888: warning: no @param for data
Something odd change in java land?
https://kojipkgs.fedoraproject.org/work/tasks/9440/9489440/build.log
I've run into the same issues. I remember a while ago hearing that the javadoc parser would be getting much stricter but never thought it'd be this strict.
My guess is that the '- removed patch6: disable-doclint-by-default.patch' had something to do with it, but I haven't really checked any further.
http://koji.fedoraproject.org/koji/buildinfo?buildID=628509
Cheers,
Hi,
* Roland Grunberg rgrunber@redhat.com [2015-04-15 13:33]:
jexl is now failing in rawhide with an odd failure:
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:2.10.3:aggregate (default-cli) on project commons-jexl: An error has occurred in JavaDocs report generation: [ERROR] Exit code: 1 - /builddir/build/BUILD/commons-jexl-2.1.1-src/src/main/java/org/apache/commons/jexl2/ExpressionImpl.java:35: error: bad HTML entity [ERROR] * Original expression stripped from leading & trailing spaces. [ERROR] ^ [ERROR] /builddir/build/BUILD/commons-jexl-2.1.1-src/src/main/java/org/apache/commons/jexl2/Interpreter.java:888: warning: no @param for node [ERROR] public Object visit(ASTFloatLiteral node, Object data) { [ERROR] ^ [ERROR] /builddir/build/BUILD/commons-jexl-2.1.1-src/src/main/java/org/apache/commons/jexl2/Interpreter.java:888: warning: no @param for data
Something odd change in java land?
Yes. We removed a patch in Rawhide that was diverging from upstream. Now Fedora's OpenJDK 8 is more like upstream OpenJDK 8 and (proprietary) Oracle Java 8.
My guess is that the '- removed patch6: disable-doclint-by-default.patch' had something to do with it, but I haven't really checked any further.
Yup. This patch was *disabling* doclint. Now it is enabled by default. This makes javadoc much more strict about what is validates as valid javadoc. If your javadoc is invalid for some reason (bad html, unescaped entities, adding comments after @return), then javadoc will now fail.
There's more information about this, including more details about how to turn it off, here: http://blog.joda.org/2014/02/turning-off-doclint-in-jdk-8-javadoc.html
TLDR: You can disable doclint by passing the `-Xdoclint:none` option to javadoc.
Another option is to fix the upstream package to have valid javadocs and contribute the fixes back upstream. They will hit the same issues when they try building using the (proprietary) Oracle Java 8. This will fix it for others too.
I've run into the same issues. I remember a while ago hearing that the javadoc parser would be getting much stricter but never thought it'd be this strict.
Yeah, it's a bit too strict, IMHO. But upstream is unconvinced at this point about it. Fortunately, fixing the javadoc is quite simple, generally. If anyone needs help, I will be happy to do what I can to fix packages.
Thanks, Omair
On 04/15/2015 12:01 PM, Omair Majid wrote:
Hi,
- Roland Grunberg rgrunber@redhat.com [2015-04-15 13:33]:
jexl is now failing in rawhide with an odd failure:
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:2.10.3:aggregate (default-cli) on project commons-jexl: An error has occurred in JavaDocs report generation: [ERROR] Exit code: 1 - /builddir/build/BUILD/commons-jexl-2.1.1-src/src/main/java/org/apache/commons/jexl2/ExpressionImpl.java:35: error: bad HTML entity [ERROR] * Original expression stripped from leading & trailing spaces. [ERROR] ^ [ERROR] /builddir/build/BUILD/commons-jexl-2.1.1-src/src/main/java/org/apache/commons/jexl2/Interpreter.java:888: warning: no @param for node [ERROR] public Object visit(ASTFloatLiteral node, Object data) { [ERROR] ^ [ERROR] /builddir/build/BUILD/commons-jexl-2.1.1-src/src/main/java/org/apache/commons/jexl2/Interpreter.java:888: warning: no @param for data
Something odd change in java land?
Yes. We removed a patch in Rawhide that was diverging from upstream. Now Fedora's OpenJDK 8 is more like upstream OpenJDK 8 and (proprietary) Oracle Java 8.
My guess is that the '- removed patch6: disable-doclint-by-default.patch' had something to do with it, but I haven't really checked any further.
Yup. This patch was *disabling* doclint. Now it is enabled by default. This makes javadoc much more strict about what is validates as valid javadoc. If your javadoc is invalid for some reason (bad html, unescaped entities, adding comments after @return), then javadoc will now fail.
There's more information about this, including more details about how to turn it off, here: http://blog.joda.org/2014/02/turning-off-doclint-in-jdk-8-javadoc.html
TLDR: You can disable doclint by passing the `-Xdoclint:none` option to javadoc.
Another option is to fix the upstream package to have valid javadocs and contribute the fixes back upstream. They will hit the same issues when they try building using the (proprietary) Oracle Java 8. This will fix it for others too.
I've run into the same issues. I remember a while ago hearing that the javadoc parser would be getting much stricter but never thought it'd be this strict.
Yeah, it's a bit too strict, IMHO. But upstream is unconvinced at this point about it. Fortunately, fixing the javadoc is quite simple, generally. If anyone needs help, I will be happy to do what I can to fix packages.
Thanks, Omair
Thanks for the info. I've managed to patch jexl.
On 04/15/2015 08:01 PM, Omair Majid wrote:
Yes. We removed a patch in Rawhide that was diverging from upstream. Now Fedora's OpenJDK 8 is more like upstream OpenJDK 8 and (proprietary) Oracle Java 8.
This change broke quite many packages.
I will workaround this in XMvn by forcing doclint to be skipped in executions of javadoc:aggregate MOJOs.
Packages not built with Maven will have to be fixed manually by either adding -Xdoclint:none or skipping generating javadocs.
On 04/16/2015 08:43 AM, Mikolaj Izdebski wrote:
On 04/15/2015 08:01 PM, Omair Majid wrote:
Yes. We removed a patch in Rawhide that was diverging from upstream. Now Fedora's OpenJDK 8 is more like upstream OpenJDK 8 and (proprietary) Oracle Java 8.
This change broke quite many packages.
I will workaround this in XMvn by forcing doclint to be skipped in executions of javadoc:aggregate MOJOs.
Packages not built with Maven will have to be fixed manually by either adding -Xdoclint:none or skipping generating javadocs.
Or fixing the javadocs in packages?
The patch have been in rpms for pretty long time. I think it really is time to fix the packages...
If you can, feel free to send me some reasonable amount of packages and I will help with fixing
J.
On 16 April 2015 at 07:49, Jiri Vanek jvanek@redhat.com wrote:
On 04/16/2015 08:43 AM, Mikolaj Izdebski wrote:
On 04/15/2015 08:01 PM, Omair Majid wrote:
Yes. We removed a patch in Rawhide that was diverging from upstream. Now Fedora's OpenJDK 8 is more like upstream OpenJDK 8 and (proprietary) Oracle Java 8.
This change broke quite many packages.
I will workaround this in XMvn by forcing doclint to be skipped in executions of javadoc:aggregate MOJOs.
Packages not built with Maven will have to be fixed manually by either adding -Xdoclint:none or skipping generating javadocs.
Or fixing the javadocs in packages?
Unfortunately, the sheer number of javadoc fixes needed in Fedora and the very few resources we have prohibits this approach.
(I for one, certainly don't have time to fix javadoc errors -- thanks Mikolaj for adding workaround in xmvn.)
The patch have been in rpms for pretty long time. I think it really is time to fix the packages...
If you can, feel free to send me some reasonable amount of packages and I will help with fixing
This is probably a good place to start: http://koschei.cloud.fedoraproject.org/groups/java?order_by=state%2Cname
I warn you it is no small task.
J.
-- java-devel mailing list java-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/java-devel
On 04/16/2015 09:16 AM, Mat Booth wrote:
On 16 April 2015 at 07:49, Jiri Vanek <jvanek@redhat.com mailto:jvanek@redhat.com> wrote:
On 04/16/2015 08:43 AM, Mikolaj Izdebski wrote: On 04/15/2015 08:01 PM, Omair Majid wrote: Yes. We removed a patch in Rawhide that was diverging from upstream. Now Fedora's OpenJDK 8 is more like upstream OpenJDK 8 and (proprietary) Oracle Java 8. This change broke quite many packages. I will workaround this in XMvn by forcing doclint to be skipped in executions of javadoc:aggregate MOJOs. Packages not built with Maven will have to be fixed manually by either adding -Xdoclint:none or skipping generating javadocs. Or fixing the javadocs in packages?Unfortunately, the sheer number of javadoc fixes needed in Fedora and the very few resources we have prohibits this approach.
430? Split it among 50 people and you are done :) I think in closes surrounding you ill find at least 10.
(I for one, certainly don't have time to fix javadoc errors -- thanks Mikolaj for adding workaround in xmvn.)
I would discourage from it. It is just another divergence from upstreams. But well. why not...
The patch have been in rpms for pretty long time. I think it really is time to fix the packages... If you can, feel free to send me some reasonable amount of packages and I will help with fixingThis is probably a good place to start: http://koschei.cloud.fedoraproject.org/groups/java?order_by=state%2Cname
I warn you it is no small task.
It need higher then small number of people to fix it.
J. -- java-devel mailing list java-devel@lists.__fedoraproject.org <mailto:java-devel@lists.fedoraproject.org> https://admin.fedoraproject.__org/mailman/listinfo/java-__devel <https://admin.fedoraproject.org/mailman/listinfo/java-devel>-- Mat Booth http://fedoraproject.org/get-fedora
----- Original Message -----
From: "Jiri Vanek" jvanek@redhat.com To: "Mat Booth" fedora@matbooth.co.uk Cc: "Fedora Java Development List" java-devel@lists.fedoraproject.org Sent: Thursday, 16 April, 2015 10:49:48 AM Subject: Re: [fedora-java] Strange new build failures
On 04/16/2015 09:16 AM, Mat Booth wrote:
On 16 April 2015 at 07:49, Jiri Vanek <jvanek@redhat.com mailto:jvanek@redhat.com> wrote:
On 04/16/2015 08:43 AM, Mikolaj Izdebski wrote: On 04/15/2015 08:01 PM, Omair Majid wrote: Yes. We removed a patch in Rawhide that was diverging from upstream. Now Fedora's OpenJDK 8 is more like upstream OpenJDK 8 and (proprietary) Oracle Java 8. This change broke quite many packages. I will workaround this in XMvn by forcing doclint to be skipped in executions of javadoc:aggregate MOJOs. Packages not built with Maven will have to be fixed manually by either adding -Xdoclint:none or skipping generating javadocs. Or fixing the javadocs in packages?Unfortunately, the sheer number of javadoc fixes needed in Fedora and the very few resources we have prohibits this approach.
430? Split it among 50 people and you are done :) I think in closes surrounding you ill find at least 10.
(I for one, certainly don't have time to fix javadoc errors -- thanks Mikolaj for adding workaround in xmvn.)
I would discourage from it. It is just another divergence from upstreams. But well. why not...
The patch have been in rpms for pretty long time. I think it really is time to fix the packages... If you can, feel free to send me some reasonable amount of packages and I will help with fixingThis is probably a good place to start: http://koschei.cloud.fedoraproject.org/groups/java?order_by=state%2Cname
I warn you it is no small task.
It need higher then small number of people to fix it.
Another thing to be considered is the verbosity of javadoc patches. They must be upstreamed aggressively as otherwise rebasing will become a nightmare.
Alexander Kurtakov Red Hat Eclipse team
J. -- java-devel mailing list java-devel@lists.__fedoraproject.org <mailto:java-devel@lists.fedoraproject.org> https://admin.fedoraproject.__org/mailman/listinfo/java-__devel <https://admin.fedoraproject.org/mailman/listinfo/java-devel>-- Mat Booth http://fedoraproject.org/get-fedora
-- java-devel mailing list java-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/java-devel
On 04/16/2015 08:43 AM, Mikolaj Izdebski wrote:
On 04/15/2015 08:01 PM, Omair Majid wrote:
Yes. We removed a patch in Rawhide that was diverging from upstream. Now Fedora's OpenJDK 8 is more like upstream OpenJDK 8 and (proprietary) Oracle Java 8.
This change broke quite many packages.
I will workaround this in XMvn by forcing doclint to be skipped in executions of javadoc:aggregate MOJOs.
The workaround is included in xmvn-2.3.2-7.fc23 https://github.com/mizdebsk/xmvn/commit/a9cde0b
This is quick hotfix to make builds possible, not the final solution. I will try to come up with something better.
java-devel@lists.fedoraproject.org
-
Aleksandar Kurtakov -
Jiri Vanek -
Mat Booth -
Mikolaj Izdebski -
Omair Majid -
Orion Poplawski -
Roland Grunberg