Excerpts from Ankur Sinha's message of Thu May 12 07:10:50 +0200 2011:

On Wed, 2011-05-11 at 15:08 -0600, Orion Poplawski wrote:

...

On 05/11/2011 01:59 PM, Ankur Sinha wrote:

...

Hi folks!

I'm trying to build an RPM package for dcm4che2[1] for the fedora-medical SIG[2]. I've downloaded the latest svn, and followed

the

...

packaging spec from the Packaging:Java[3] page. I'm running into

some

...

errors that I don't know how to get around. This is my first java package. Could someone glance through this and put me on the right

track

...

please? The spec[4] (bare minimum) and the build.log[5] are

provided.

...

The srpm is here[6].

Looks like you need the test images, from here perhaps:

http://www.dcm4che.org/maven2/org/dcm4che/test/dcm4che-test-image/2.6/

Aha! But I can't use the jar straight away, can I? I need to package the test-images up and then proceed with dcm4che2, right?

Yes, that's normally the case. In the (perhaps likely?) scenario where sources for test-image are not that easy to find it's possible to -Dmaven.test.skip=true which will not run tests. You might want to first build whole package without tests and then work on making tests work.

Good luck!

-- Stanislav Ochotnicky sochotnicky@redhat.com Software Engineer - Base Operating Systems Brno

PGP: 7B087241 Red Hat Inc. http://cz.redhat.com

Excerpts from Ankur Sinha's message of Thu May 12 14:07:21 +0200 2011:

On Thu, 2011-05-12 at 10:14 +0200, Stanislav Ochotnicky wrote:

...

Yes, that's normally the case. In the (perhaps likely?) scenario where sources for test-image are not that easy to find it's possible to -Dmaven.test.skip=true which will not run tests. You might want to first build whole package without tests and then work on making tests work.

Good luck!

Hello Stanislav,

Thank you for that :) Sadly though, it appears to not be making a difference. :(

This is the build section that I'm using:

%build mvn-rpmbuild -X -Dmaven.test.skip=true install javadoc:aggregate

It still fails with the same error:

...

The repository system is offline but the artifact org.dcm4che.test:dcm4che-test-image:jar:2.6 is not available in the local repository. DEBUG: at org.apache.maven.project.DefaultProjectDependenciesResolver.resolve(DefaultProjectDependenciesResolver.java:170) DEBUG: at org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.getDependencies(LifecycleDependencyResolver.java:171) DEBUG: ... 22 more DEBUG: Caused by: org.sonatype.aether.resolution.DependencyResolutionException: The repository system is offline but the artifact org.dcm4che.test:dcm4che-test-image:jar:2.6 is not available in the local repository. DEBUG: at org.sonatype.aether.impl.internal.DefaultRepositorySystem.resolveDependencies(DefaultRepositorySystem.java:412) DEBUG: at org.apache.maven.project.DefaultProjectDependenciesResolver.resolve(DefaultProjectDependenciesResolver.java:164) DEBUG: ... 23 more DEBUG: Caused by: org.sonatype.aether.resolution.ArtifactResolutionException: The repository system is offline but the artifact org.dcm4che.test:dcm4che-test-image:jar:2.6 is not available in the local repository. DEBUG: at org.sonatype.aether.impl.internal.DefaultArtifactResolver.resolve(DefaultArtifactResolver.java:541) DEBUG: at org.sonatype.aether.impl.internal.DefaultArtifactResolver.resolveArtifacts(DefaultArtifactResolver.java:220) DEBUG: at org.sonatype.aether.impl.internal.DefaultRepositorySystem.resolveDependencies(DefaultRepositorySystem.java:395) DEBUG: ... 24 more DEBUG: Caused by: org.sonatype.aether.transfer.ArtifactNotFoundException: The repository system is offline but the artifact org.dcm4che.test:dcm4che-test-image:jar:2.6 is not available in the local repository. DEBUG: at org.sonatype.aether.impl.internal.DefaultArtifactResolver.resolve(DefaultArtifactResolver.java:352) DEBUG: ... 26 more DEBUG: [ERROR] DEBUG: [ERROR] DEBUG: [ERROR] For more information about the errors and possible solutions, please read the following articles: DEBUG: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionExcepti... DEBUG: [ERROR] DEBUG: [ERROR] After correcting the problems, you can resume the build with the command DEBUG: [ERROR] mvn <goals> -rf :dcm4che-core DEBUG: RPM build errors: DEBUG: error: Bad exit status from /var/tmp/rpm-tmp.Xkg6An (%build) DEBUG: Bad exit status from /var/tmp/rpm-tmp.Xkg6An (%build)

Any other hints? I haven't been able to find the sources of the test-image. I'm still looking, but it's unlikely that I'll be able to locate them.

Ah, sorry. I should have mentioned you'll have to rip out depdendencies from pom.xml files for this to work. Files dcm4che-core/pom.xml and dcm4che-imageio/pom.xml contain mentions of dcm4che-test-image. This is just a test dependency but unfortunately Maven doesn't realize that it doesn't need test dependencies when tests are not run (huh right?).

So in short remove these parts from pom.xml: <dependency> <groupId>org.dcm4che.test</groupId> <artifactId>dcm4che-test-image</artifactId> <version>2.6</version> <scope>test</scope> </dependency>

FYI you can also stop-by at #fedora-java channel on Freenode. There should be someone there to help you out most of the time.

-- Stanislav Ochotnicky sochotnicky@redhat.com Software Engineer - Base Operating Systems Brno

PGP: 7B087241 Red Hat Inc. http://cz.redhat.com

Excerpts from Orion Poplawski's message of Thu May 12 16:08:26 +0200 2011:

On 05/12/2011 02:14 AM, Stanislav Ochotnicky wrote:

...

Excerpts from Ankur Sinha's message of Thu May 12 07:10:50 +0200 2011:

...

On Wed, 2011-05-11 at 15:08 -0600, Orion Poplawski wrote:

...

On 05/11/2011 01:59 PM, Ankur Sinha wrote:

...

Hi folks!

I'm trying to build an RPM package for dcm4che2[1] for the fedora-medical SIG[2]. I've downloaded the latest svn, and followed

the

...

packaging spec from the Packaging:Java[3] page. I'm running into

some

...

errors that I don't know how to get around. This is my first java package. Could someone glance through this and put me on the right

track

...

please? The spec[4] (bare minimum) and the build.log[5] are

provided.

...

The srpm is here[6].

Looks like you need the test images, from here perhaps:

http://www.dcm4che.org/maven2/org/dcm4che/test/dcm4che-test-image/2.6/

Aha! But I can't use the jar straight away, can I? I need to package the test-images up and then proceed with dcm4che2, right?

Yes, that's normally the case. In the (perhaps likely?) scenario where sources for test-image are not that easy to find it's possible to -Dmaven.test.skip=true which will not run tests. You might want to first build whole package without tests and then work on making tests work.

dcm4che-test-image-2.6.jar just contains a bunch of test image data. I see no reason that it couldn't be included as part of the dcm4che2 package. I don't know how to point maven to it tough.

org/dcm4chee/imagetest directory contains 2 Java class files. It's hard to tell it they are actually being run, but I guess they are. One way to fix all of this (and probably best in long term) is to ask upstream to do a source release of test data/package.

As for pointing maven to arbitrary directory..not easy. Only way to do it with our maven right now is to create proper directory structure within .m2/ directory. That is: .m2/groupid1/groupid2/../artifactid/artifactid-version.{pom,jar}

-- Stanislav Ochotnicky sochotnicky@redhat.com Software Engineer - Base Operating Systems Brno

PGP: 7B087241 Red Hat Inc. http://cz.redhat.com

Excerpts from Ankur Sinha's message of Fri May 27 15:07:00 +0200 2011:

On Thu, 2011-05-12 at 16:19 +0200, Stanislav Ochotnicky wrote:

...

org/dcm4chee/imagetest directory contains 2 Java class files. It's hard to tell it they are actually being run, but I guess they are. One way to fix all of this (and probably best in long term) is to ask upstream to do a source release of test data/package.

As for pointing maven to arbitrary directory..not easy. Only way to do it with our maven right now is to create proper directory structure within .m2/ directory. That is: .m2/groupid1/groupid2/../artifactid/artifactid-version.{pom,jar}

Hello,

I managed to build dcm4che-test. That dependency problem is over. Now I'm stuck with another one:

This is what mock says:

...

DEBUG: [ERROR] Failed to execute goal on project dcm4che-imageio: Could not resolve dependencies for project dcm4che:dcm4che-imageio:jar:2.0.25: The repository system is offline but the artifact com.sun.media:jai_imageio:jar:1.1 is not available in the local repository. -> [Help 1] DEBUG: org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal on project dcm4che-imageio: Could not resolve dependencies for project dcm4che:dcm4che-imageio:jar:2.0.25: The repository system is offline but the artifact com.sun.media:jai_imageio:jar:1.1 is not available in the local repository.

I've created a local depmap file etc. and tried it (Thanks Stanislav for guiding me over the IRC), but it's still giving me this error.

My spec[1], depmap[2] and build.logs[3] are at my fedorapeople.org space. Could you please have a look at tell me where I'm mucking up?

Your depmap is still not correct, your JPP artifactid is: <artifactId>jai_imageio-1.2</artifactId>

but it should be: <artifactId>jai_imageio</artifactId>

Cheers and keep fighting! :-)

On 09:02:55 AM Saturday, May 28, 2011 Ankur Sinha wrote:

On Fri, 2011-05-27 at 13:25 +0200, Stanislav Ochotnicky wrote:

...

Your depmap is still not correct, your JPP artifactid is: <artifactId>jai_imageio-1.2</artifactId>

but it should be: <artifactId>jai_imageio</artifactId>

Cheers and keep fighting! :-)

Hi Stanislay,

I've tried this as well. I still get the same error. I've updated the files on my fedora people space. The new depmap, the current spec and the build.log from mock are all here[1]. I'm sure it's something tiny that I'm missing out on :/

Look for "XML document structures must start and end within the same entity." in the log. Your depmap file is not a valid xml file.

Alex

Thanks, Ankur

[1]http://ankursinha.fedorapeople.org/dcm4che/

-- java-devel mailing list java-devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/java-devel

On Sat, 2011-05-28 at 12:50 +0530, Ankur Sinha wrote:

On Sat, 2011-05-28 at 09:03 +0300, Alexander Kurtakov wrote:

...

Look for "XML document structures must start and end within the same entity." in the log. Your depmap file is not a valid xml file.

Alex

Thanks Alex! I ran xmllint and corrected the file.

All the components are building properly. There's something wrong with the javadoc generation though. It says:

...

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:2.8:aggregate (default-cli) on project dcm4che: An error has occurred in JavaDocs report generation: [ERROR] Exit code: 1 - /builddir/build/BUILD/dcm4che-2.0.25/dcm4che-core/src/main/java/org/dcm4che2/data/Tag.java:1474: warning: unmappable character for encoding ANSI_X3.4-1968 [ERROR] /** (0018,1153) VR=IS, VM=1 Exposure in ??As */ [ERROR] ^ [ERROR] /builddir/build/BUILD/dcm4che-2.0.25/dcm4che-core/src/main/java/org/dcm4che2/data/Tag.java:1474: warning: unmappable character for encoding ANSI_X3.4-1968

There was a warning earlier:

...

[WARNING] File encoding has not been set, using platform encoding ANSI_X3.4-1968, i.e. build is platform dependent!

How would I set the encoding? What should it be set to?

Thanks! Regards, Ankur

Hello,

I managed to solve this one (I think)

The solution was to add:

<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>

<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>

to the properties section of the pom.xml file.

More info on it on these links:

http://wiki.wsmoak.net/cgi-bin/wiki.pl?action=browse&diff=3&id=Maven...

http://docs.codehaus.org/display/MAVENUSER/POM+Element+for+Source+File +Encoding

http://jira.codehaus.org/browse/MNG-2216

Thanks! Regards, Ankur

Excerpts from Guido Grazioli's message of Mon May 30 11:54:57 +0200 2011:

2011/5/30 Ankur Sinha sanjay.ankur@gmail.com:

...

The solution was to add:

...

<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>

<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>

to the properties section of the pom.xml file.

could that be a candidate for inclusion in settings.xml or MAVEN_OPTS?

Good idea I believe, gonna look into it.

Excerpts from Alexander Kurtakov's message of Mon May 30 18:38:49 +0200 2011:

On 07:36:38 PM Monday, May 30, 2011 Stanislav Ochotnicky wrote:

...

Excerpts from Guido Grazioli's message of Mon May 30 11:54:57 +0200 2011:

...

2011/5/30 Ankur Sinha sanjay.ankur@gmail.com:

...

The solution was to add:

...

<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>

<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncod ing>

to the properties section of the pom.xml file.

could that be a candidate for inclusion in settings.xml or MAVEN_OPTS?

Good idea I believe, gonna look into it.

I don't think this is good idea at all because AFAIK this will override whatever is set in the pom even thus breaking projects that have set everything correctly. Feel free to prove me wrong on this.

While I admit that we should probably not touch sourceEncoding, outputEncoding should always be UTF-8 in Fedora.

2011/5/31 Alexander Kurtakov:

On 11:05:38 AM Tuesday, May 31, 2011 Stanislav Ochotnicky wrote:

...

Excerpts from Alexander Kurtakov's message of Mon May 30 18:38:49 +0200

...

I don't think this is good idea at all because AFAIK this will override whatever is set in the pom even thus breaking projects that have set everything correctly. Feel free to prove me wrong on this.

While I admit that we should probably not touch sourceEncoding, outputEncoding should always be UTF-8 in Fedora.

Yup, I agree here. I would even say that we need to ask upstream to make it

Actually overriding the settings in the pom file is a bit brute: if i understood corretly this setting applies to filtered text resources, and having an xml config file with <?xml version="1.0" encoding="iso8859-1"?> would be allowed: changing the output encoding to UTF-8 could break things; what i had in mind was adding an inactive profile in settings.xml, to be activated in the mvn command line when needed.

Cheers