Nifty script.
A drawback is that we're calling copy-platform multiple times for multiple-feature projects like Mylyn and the calls after the first one all say "file exists" for the mkdir and ln -s calls.
It should be fairly easy to change the copy-platform script to only generate the necessary directories and links if they don't already exist, shouldn't it?
* Mat Booth fedora@matbooth.co.uk [2008-03-31 17:20]:
Nifty script.
Thanks.
A drawback is that we're calling copy-platform multiple times for multiple-feature projects like Mylyn and the calls after the first one all say "file exists" for the mkdir and ln -s calls.
It should be fairly easy to change the copy-platform script to only generate the necessary directories and links if they don't already exist, shouldn't it?
Yes. I didn't want to mess with copy-platform since I wanted to get this script into a build of the SDK. If you -- or anyone else -- has a few minutes to make this modification, I'd appreciate any patches.
Andrew
On Tue, Apr 1, 2008 at 3:29 AM, Andrew Overholt overholt@redhat.com wrote:
Yes. I didn't want to mess with copy-platform since I wanted to get this script into a build of the SDK. If you -- or anyone else -- has a few minutes to make this modification, I'd appreciate any patches.
Andrew
Sure thing, see attached. This patch changes "eclipse-copy-platform.sh" and "eclipse.spec" from the Rawhide eclipse package. I hope that's ok.
Regards, Mat
Hi Mat,
On Thu, 2008-04-03 at 01:14 +0100, Mat Booth wrote:
On Tue, Apr 1, 2008 at 3:29 AM, Andrew Overholt overholt@redhat.com wrote:
Yes. I didn't want to mess with copy-platform since I wanted to get this script into a build of the SDK. If you -- or anyone else -- has a few minutes to make this modification, I'd appreciate any patches.
Andrew
Sure thing, see attached. This patch changes "eclipse-copy-platform.sh" and "eclipse.spec" from the Rawhide eclipse package. I hope that's ok.
Awesome, thanks!
My only nit is this:
-sed -e's/^(.*)$/\1 \1/' -e's,^,ln -s $eclipse/,' >> copy-platform +sed -e's/^(.*)$/\1/' -e's,^(.*),[ ! -e \1 ] && ln -s $eclipse/\1 \1,' >> copy-platform
I don't think you need the first sed command, do you? Would removing it still accomplish the same thing? Like this:
sed -e's,^(.*),[ ! -e \1 ] && ln -s $eclipse/\1 \1,'
Did you want to just commit this? If you request commit on the eclipse module in the account system, I'll grant it.
Thanks again,
Andrew
java-devel@lists.fedoraproject.org