I get wanting to keep the critical repo in another location, but there is no reason why we can't use pagure to front for pull requests and just mirror the git repo from https://infrastructure.fedoraproject.org/cgit/ansible.git/.
i.e. ansible.git would still be source of truth, but we would get PR workflow etc.
Dusty
On 07/12/2017 01:16 PM, Dusty Mabe wrote:
I get wanting to keep the critical repo in another location, but there is no reason why we can't use pagure to front for pull requests and just mirror the git repo from https://infrastructure.fedoraproject.org/cgit/ansible.git/.
yes there is. We need to have bi-directional mirroring or at least some convention of which one to push to.
We had some thoughts about that, but we havent gotten anything set yet.
i.e. ansible.git would still be source of truth, but we would get PR workflow etc.
yes, that would be lovely, but we need to figure out details.
ie, say I push something to the repo directly and at the same time someone merges a PR on the pagure end... now how do you sync the two repos?
I suppose we could use the pagure one always unless pagure was down...
kevin
On 07/12/2017 03:35 PM, Kevin Fenzi wrote:
On 07/12/2017 01:16 PM, Dusty Mabe wrote:
I get wanting to keep the critical repo in another location, but there is no reason why we can't use pagure to front for pull requests and just mirror the git repo from https://infrastructure.fedoraproject.org/cgit/ansible.git/.
yes there is. We need to have bi-directional mirroring or at least some convention of which one to push to.
I think one way mirroring would be good enough. Basically the pagure repo would be readonly for the master branch and would be a one way mirror of what is in ansible git repo. No one would ever 'merge' in the pagure repo.
The admin users would have two remotes on their local git repos. Workflow would be:
user1: open PR to pagureinfra user2: review in web interface user2: comment in web interface LGTM user2: git pull pagureinfra/PR1234 user2: git merge pagureinfra/PR1234 into master user2: git push ansiblegit master pagure: automatically sees commit is in master - closes pull request
I know this type of workflow works for github (i.e. the automatically closing the pull request when it detects the commit made it into master). I've done this with Github and dist-git before [1]
WDYT?
On Wed, 2017-07-12 at 15:44 -0400, Dusty Mabe wrote:
I know this type of workflow works for github (i.e. the automatically closing the pull request when it detects the commit made it into master). I've done this with Github and dist-git before [1]
There is an issue with Pagure detecting merged pull requests:
On Wed, Jul 12, 2017, at 09:44 PM, Dusty Mabe wrote:
On 07/12/2017 03:35 PM, Kevin Fenzi wrote:
On 07/12/2017 01:16 PM, Dusty Mabe wrote:
I get wanting to keep the critical repo in another location, but there is no reason why we can't use pagure to front for pull requests and just mirror the git repo from https://infrastructure.fedoraproject.org/cgit/ansible.git/.
yes there is. We need to have bi-directional mirroring or at least some convention of which one to push to.
I think one way mirroring would be good enough. Basically the pagure repo would be readonly for the master branch and would be a one way mirror of what is in ansible git repo. No one would ever 'merge' in the pagure repo.
The admin users would have two remotes on their local git repos. Workflow would be:
user1: open PR to pagureinfra user2: review in web interface user2: comment in web interface LGTM user2: git pull pagureinfra/PR1234
I believe this line ^^ is more complex in Pagure. It seems you have to actually add remotes for the fork in order to get to the PRs.
https://docs.pagure.org/pagure/usage/pull_requests.html#working-with-pull-re...
regards,
bex
user2: git merge pagureinfra/PR1234 into master user2: git push ansiblegit master pagure: automatically sees commit is in master - closes pull request
I know this type of workflow works for github (i.e. the automatically closing the pull request when it detects the commit made it into master). I've done this with Github and dist-git before [1]
WDYT?
[1] https://github.com/dustymabe/fedpkg-kompose _______________________________________________ infrastructure mailing list -- infrastructure@lists.fedoraproject.org To unsubscribe send an email to infrastructure-leave@lists.fedoraproject.org
On Fri, Jul 14, 2017 at 01:48:16AM +0200, Brian Exelbierd wrote:
On Wed, Jul 12, 2017, at 09:44 PM, Dusty Mabe wrote:
On 07/12/2017 03:35 PM, Kevin Fenzi wrote:
On 07/12/2017 01:16 PM, Dusty Mabe wrote:
I get wanting to keep the critical repo in another location, but there is no reason why we can't use pagure to front for pull requests and just mirror the git repo from https://infrastructure.fedoraproject.org/cgit/ansible.git/.
yes there is. We need to have bi-directional mirroring or at least some convention of which one to push to.
I think one way mirroring would be good enough. Basically the pagure repo would be readonly for the master branch and would be a one way mirror of what is in ansible git repo. No one would ever 'merge' in the pagure repo.
The admin users would have two remotes on their local git repos. Workflow would be:
user1: open PR to pagureinfra user2: review in web interface user2: comment in web interface LGTM user2: git pull pagureinfra/PR1234
I believe this line ^^ is more complex in Pagure. It seems you have to actually add remotes for the fork in order to get to the PRs.
From 3.0 it can be done in the same way github does it, there will be a refs/pull/<id> allowing to fetch the PR locally.
Pierre
infrastructure@lists.fedoraproject.org
-
Brian Exelbierd -
Dusty Mabe -
Kevin Fenzi -
Pierre-Yves Chibon -
Randy Barlow