Thanks to janeznemanic, I have a commit ready for the ansible repo that should replace all the old $foo and ${foo} variables with new style ansible/jinja2 {{ foo }} style. ;)
Anyone around to +1 it? :)
It's rather large, so it's in /tmp/ansible-variables.patch on lockbox01.
kevin
Since Ansible is push-based, this shouldn't actually cause any noticeable change unless/until the playbooks are run, so +1 here.
-Ricky
On 01/01/2014 01:39 PM, Kevin Fenzi wrote:
Thanks to janeznemanic, I have a commit ready for the ansible repo that should replace all the old $foo and ${foo} variables with new style ansible/jinja2 {{ foo }} style. ;)
Anyone around to +1 it? :)
It's rather large, so it's in /tmp/ansible-variables.patch on lockbox01.
kevin
infrastructure mailing list infrastructure@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/infrastructure
On Wed, 01 Jan 2014 14:15:42 -0500 Ricky Elrod codeblock@elrod.me wrote:
Since Ansible is push-based, this shouldn't actually cause any noticeable change unless/until the playbooks are run, so +1 here.
Yep. Pushed. :)
Thanks,
kevin
After pushing this I went ahead and did some more cleanup:
1. I went through and ran 'ansible-playbook --syntax-check' on all the host and group playbooks and fixed all the depreciation warnings that were left and also cleaned up any errors that prevented it from finishing.
2. I then went and ran 'ansible-playbook --check --diff' on them all and fixed up some more issues. A few cases where we needed to run things always (even in check) because we use the variables, missing or wrong paths, syntax issues that werent caught by check, etc.
There's a few hosts that aren't up/running:
fedocal.dev logstash-dev
Should we nuke these?
Anyhow, next steps next week will be to run them and make sure everything is in sync, then get it so everything is 100% idempotent. :)
kevin
Le mercredi 01 janvier 2014 à 19:22 -0700, Kevin Fenzi a écrit :
After pushing this I went ahead and did some more cleanup:
- I went through and ran 'ansible-playbook --syntax-check' on all the
host and group playbooks and fixed all the depreciation warnings that were left and also cleaned up any errors that prevented it from finishing.
So maybe that's the right time to add a git commit hook that check this and block commit if that's not the case ?
On Fri, 03 Jan 2014 12:12:54 +0100 Michael Scherer misc@zarb.org wrote:
Le mercredi 01 janvier 2014 à 19:22 -0700, Kevin Fenzi a écrit :
After pushing this I went ahead and did some more cleanup:
- I went through and ran 'ansible-playbook --syntax-check' on all
the host and group playbooks and fixed all the depreciation warnings that were left and also cleaned up any errors that prevented it from finishing.
So maybe that's the right time to add a git commit hook that check this and block commit if that's not the case ?
Yeah, that would be nice. ;)
--syntax-check only works on playbooks, so the hook would have to look for /playbooks/ and then only pass the yml files into ansible-playbook --syntax-check.
It's also a pretty simple check at this point, but at least it would catch depreciated syntax being re-added.
kevin
An interesting post:
https://raymii.org/s/tutorials/Ansible_-_Playbook_Testing.html
This handles tests by making a dummy inventory with just localhost in it (which is never contacted)
Perhaps we could adjust this setup to work for us.
kevin
infrastructure@lists.fedoraproject.org
-
Kevin Fenzi -
Michael Scherer -
Ricky Elrod