Good Morning Everyone,
Kevin recently saw that pkgs02 is sending emails on commits again. I have been a first-hand witness of this myself as well.
I'd like to apply the following PR manually and reload apache/restart pagure-logcom. It should help figuring out why it's behaving this way.
The corresponding PR is at: https://pagure.io/pagure/pull-request/3907
Thanks, Pierre
I reviewed the code and +1 On Fri, 12 Oct 2018 at 09:33, Pierre-Yves Chibon pingou@pingoured.fr wrote:
Good Morning Everyone,
Kevin recently saw that pkgs02 is sending emails on commits again. I have been a first-hand witness of this myself as well.
I'd like to apply the following PR manually and reload apache/restart pagure-logcom. It should help figuring out why it's behaving this way.
The corresponding PR is at: https://pagure.io/pagure/pull-request/3907
Thanks, Pierre _______________________________________________ infrastructure mailing list -- infrastructure@lists.fedoraproject.org To unsubscribe send an email to infrastructure-leave@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedorapro...
Good Morning,
While applying this FBR, I think I found the root cause for the emailing on commits in dist-git, here is, I suspect this is the patch needed to fix this:
"""" From 1b661f2c5f217470111aa91fb502b21255f9fa37 Mon Sep 17 00:00:00 2001 From: Pierre-Yves Chibon pingou@pingoured.fr Date: Mon, 15 Oct 2018 15:18:55 +0200 Subject: [PATCH] Turn off emailing on watchcommits on the main app and the git hooks
Signed-off-by: Pierre-Yves Chibon pingou@pingoured.fr --- roles/distgit/pagure/templates/pagure.cfg | 1 - roles/distgit/pagure/templates/pagure_shared.cfg | 1 + 2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/roles/distgit/pagure/templates/pagure.cfg b/roles/distgit/pagure/templates/pagure.cfg index 19a2aee4c..8a8ab5adf 100644 --- a/roles/distgit/pagure/templates/pagure.cfg +++ b/roles/distgit/pagure/templates/pagure.cfg @@ -213,7 +213,6 @@ LOGGING = { ENABLE_UI_NEW_PROJECTS = False ALLOWED_PREFIX = ['rpms', 'modules', 'container', 'tests'] EXCLUDE_GROUP_INDEX = ['packager'] -EMAIL_ON_WATCHCOMMITS = False PRIVATE_PROJECTS = False FEDMSG_NOTIFICATIONS = True PR_TARGET_MATCHING_BRANCH = True diff --git a/roles/distgit/pagure/templates/pagure_shared.cfg b/roles/distgit/pagure/templates/pagure_shared.cfg index faca9925f..8d58d57e6 100644 --- a/roles/distgit/pagure/templates/pagure_shared.cfg +++ b/roles/distgit/pagure/templates/pagure_shared.cfg @@ -53,6 +53,7 @@ ENABLE_GROUP_MNGT = False DEPLOY_KEY = False LOCAL_SSH_KEY = False ALLOW_DELETE_BRANCH = False +EMAIL_ON_WATCHCOMMITS = False
DISABLED_PLUGINS = ['IRC', 'Pagure tickets', 'Read the Doc', 'Fedmsg']
+1
----- Original Message -----
Good Morning,
While applying this FBR, I think I found the root cause for the emailing on commits in dist-git, here is, I suspect this is the patch needed to fix this:
"""" From 1b661f2c5f217470111aa91fb502b21255f9fa37 Mon Sep 17 00:00:00 2001 From: Pierre-Yves Chibon pingou@pingoured.fr Date: Mon, 15 Oct 2018 15:18:55 +0200 Subject: [PATCH] Turn off emailing on watchcommits on the main app and the git hooks
Signed-off-by: Pierre-Yves Chibon pingou@pingoured.fr
roles/distgit/pagure/templates/pagure.cfg | 1 - roles/distgit/pagure/templates/pagure_shared.cfg | 1 + 2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/roles/distgit/pagure/templates/pagure.cfg b/roles/distgit/pagure/templates/pagure.cfg index 19a2aee4c..8a8ab5adf 100644 --- a/roles/distgit/pagure/templates/pagure.cfg +++ b/roles/distgit/pagure/templates/pagure.cfg @@ -213,7 +213,6 @@ LOGGING = { ENABLE_UI_NEW_PROJECTS = False ALLOWED_PREFIX = ['rpms', 'modules', 'container', 'tests'] EXCLUDE_GROUP_INDEX = ['packager'] -EMAIL_ON_WATCHCOMMITS = False PRIVATE_PROJECTS = False FEDMSG_NOTIFICATIONS = True PR_TARGET_MATCHING_BRANCH = True diff --git a/roles/distgit/pagure/templates/pagure_shared.cfg b/roles/distgit/pagure/templates/pagure_shared.cfg index faca9925f..8d58d57e6 100644 --- a/roles/distgit/pagure/templates/pagure_shared.cfg +++ b/roles/distgit/pagure/templates/pagure_shared.cfg @@ -53,6 +53,7 @@ ENABLE_GROUP_MNGT = False DEPLOY_KEY = False LOCAL_SSH_KEY = False ALLOW_DELETE_BRANCH = False +EMAIL_ON_WATCHCOMMITS = False
DISABLED_PLUGINS = ['IRC', 'Pagure tickets', 'Read the Doc', 'Fedmsg']
-- 2.14.4 """"
Thoughts about applying this?
Thanks, Pierre
infrastructure mailing list -- infrastructure@lists.fedoraproject.org To unsubscribe send an email to infrastructure-leave@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedorapro...
infrastructure@lists.fedoraproject.org