Hey, I'm currently testing a solution for the problem where one can prevent CVS commit mail from going out by pressing ctrl-c during the commit.
To do this, I built a version of CVS with signal handling disabled and made a wrapper script for cvs server that traps SIGINT and some other things.
I'd appreciate if people can test and try to abuse/break this setup :-), so I have a test repo setup. To test this, you need to be in sysadmin-test:
1. Prepend your ~/.ssh/authorized_keys file on publictest10.fedoraproject.org with:
command="/home/fedora/ricky/test.sh",no-port-forwarding,no-X11-forwarding,no-agent-forwarding,no-pty
(make sure not to accidentally lock yourself out with this)
2. Checkout the test module with: cvs -d :ext:username@publictest10.fedoraproject.org/home/fedora/ricky/repo co test
3. Try to make a commit without it getting logged in /home/fedora/ricky/repo/CVSROOT/commitlog
Feel free to try clever/evil things to test this out.
Thanks, Ricky
On 2009-04-23 04:30:25 PM, Ricky Zhou wrote:
I'd appreciate if people can test and try to abuse/break this setup :-), so I have a test repo setup. To test this, you need to be in sysadmin-test:
- Prepend your ~/.ssh/authorized_keys file on
publictest10.fedoraproject.org with:
command="/home/fedora/ricky/test.sh",no-port-forwarding,no-X11-forwarding,no-agent-forwarding,no-pty
(make sure not to accidentally lock yourself out with this)
- Checkout the test module with:
cvs -d :ext:username@publictest10.fedoraproject.org/home/fedora/ricky/repo co test
- Try to make a commit without it getting logged in
/home/fedora/ricky/repo/CVSROOT/commitlog
Feel free to try clever/evil things to test this out.
Update: Now it's slightly easier for some people to test this out.
If you are in the packager group and you are not in any of sysadmin-main, sysadmin-test, sysadmin-noc, then you do not need to take any special action, you can just:
cvs -d :ext:username@publictest10.fedoraproject.org/home/fedora/ricky/repo co test
and test ctrl-cing commits. If you are in one of the three groups listed, you'll still have to follow the instructions to restrict your SSH command.
Thanks, and please test! Ricky
On Thu, 30 Apr 2009, Ricky Zhou wrote:
On 2009-04-23 04:30:25 PM, Ricky Zhou wrote:
I'd appreciate if people can test and try to abuse/break this setup :-), so I have a test repo setup. To test this, you need to be in sysadmin-test:
- Prepend your ~/.ssh/authorized_keys file on
publictest10.fedoraproject.org with:
command="/home/fedora/ricky/test.sh",no-port-forwarding,no-X11-forwarding,no-agent-forwarding,no-pty
(make sure not to accidentally lock yourself out with this)
- Checkout the test module with:
cvs -d :ext:username@publictest10.fedoraproject.org/home/fedora/ricky/repo co test
- Try to make a commit without it getting logged in
/home/fedora/ricky/repo/CVSROOT/commitlog
Feel free to try clever/evil things to test this out.
Update: Now it's slightly easier for some people to test this out.
If you are in the packager group and you are not in any of sysadmin-main, sysadmin-test, sysadmin-noc, then you do not need to take any special action, you can just:
cvs -d :ext:username@publictest10.fedoraproject.org/home/fedora/ricky/repo co test
and test ctrl-cing commits. If you are in one of the three groups listed, you'll still have to follow the instructions to restrict your SSH command.
I was able to write the file and commit, I did ctl+c out of it after it hit the "Sleeping for 5 seconds bit" and my commit went through. I'm not quite sure what the intended behavior is, perhaps we should enable emails? Maybe you already did?
-Mike
On 2009-04-30 04:43:14 PM, Mike McGrath wrote:
I was able to write the file and commit, I did ctl+c out of it after it hit the "Sleeping for 5 seconds bit" and my commit went through. I'm not quite sure what the intended behavior is, perhaps we should enable emails? Maybe you already did?
Sorry, my mistake. I made it log to /home/fedora/ricky/repo/CVSROOT/commitlog and I forgot to chgrp the file so that people in packager had write access to it. Could somebody in packager test this out now?
Thanks, Ricky
On 05/01/2009 05:09 AM, Ricky Zhou wrote:
On 2009-04-30 04:43:14 PM, Mike McGrath wrote:
I was able to write the file and commit, I did ctl+c out of it after it hit the "Sleeping for 5 seconds bit" and my commit went through. I'm not quite sure what the intended behavior is, perhaps we should enable emails? Maybe you already did?
Sorry, my mistake. I made it log to /home/fedora/ricky/repo/CVSROOT/commitlog and I forgot to chgrp the file so that people in packager had write access to it. Could somebody in packager test this out now?
Did anyone test this out yet? If not, please post to fedora-devel list.
Rahul
On Wed, 6 May 2009, Rahul Sundaram wrote:
On 05/01/2009 05:09 AM, Ricky Zhou wrote:
On 2009-04-30 04:43:14 PM, Mike McGrath wrote:
I was able to write the file and commit, I did ctl+c out of it after it hit the "Sleeping for 5 seconds bit" and my commit went through. I'm not quite sure what the intended behavior is, perhaps we should enable emails? Maybe you already did?
Sorry, my mistake. I made it log to /home/fedora/ricky/repo/CVSROOT/commitlog and I forgot to chgrp the file so that people in packager had write access to it. Could somebody in packager test this out now?
Did anyone test this out yet? If not, please post to fedora-devel list.
I did a few times, I wasn't able to commit without log but I did wedge it once requiring manual intervention.
-Mike
infrastructure@lists.fedoraproject.org
-
Mike McGrath -
Rahul Sundaram -
Ricky Zhou